This is an automated email from the ASF dual-hosted git repository.

colegreer pushed a commit to branch 3.6-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git


The following commit(s) were added to refs/heads/3.6-dev by this push:
     new 0b8b7ec4c5 Temporary fix to failing JDK8 test (#2529)
0b8b7ec4c5 is described below

commit 0b8b7ec4c5b57095f16464565e86c8f00c1f274f
Author: Ryan Tan <65996005+r...@users.noreply.github.com>
AuthorDate: Mon Mar 25 15:17:36 2024 -0700

    Temporary fix to failing JDK8 test (#2529)
    
    A new SelectStep test is failing in JDK8 tests due to a difference in 
hashing between Java 8 and 11. In Java 8, the hash used to identify the 
traverser to be removed from the no-op barrier is recomputed at removal, and 
can't find a match due to other traversal branches having added vertices to the 
bulkset, thus changing its potential hash value. Java 11 simply uses the hash 
field stored at creation instead of recomputing it which avoids this problem.
    
    This additional barrier step is a temporary fix that helps the query wait 
until all the vertices have been added to the bulkset before adding traversals 
to the no-op barrier so that hashing stays consistent.
---
 .../org/apache/tinkerpop/gremlin/test/features/map/Select.feature       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/Select.feature
 
b/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/Select.feature
index b2f8ef8dc5..6229fa1935 100644
--- 
a/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/Select.feature
+++ 
b/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/Select.feature
@@ -906,7 +906,7 @@ Feature: Step - select()
     Given the modern graph
     And the traversal of
       """
-      g.V().as("label").aggregate(local,"x").select("x").select("label")
+      
g.V().as("label").aggregate(local,"x").barrier().select("x").select("label")
       """
     When iterated to list
     Then the result should be unordered

Reply via email to