makes the StringBuilder final
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/f6ecbff6 Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/f6ecbff6 Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/f6ecbff6 Branch: refs/heads/tp33 Commit: f6ecbff6e036bb246efed3b2db5664a154b14442 Parents: 7485ae8 Author: Otavio Santana <otaviopolianasant...@gmail.com> Authored: Wed Aug 22 09:19:20 2018 -0300 Committer: Otavio Santana <otaviopolianasant...@gmail.com> Committed: Wed Aug 22 10:04:49 2018 -0300 ---------------------------------------------------------------------- .../gremlin/jsr223/AbstractGremlinScriptEngineFactory.java | 2 +- .../gremlin/process/traversal/dsl/GremlinDslProcessor.java | 2 +- .../process/traversal/util/DefaultTraversalMetrics.java | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/f6ecbff6/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/AbstractGremlinScriptEngineFactory.java ---------------------------------------------------------------------- diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/AbstractGremlinScriptEngineFactory.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/AbstractGremlinScriptEngineFactory.java index e54b8cc..69f4f73 100644 --- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/AbstractGremlinScriptEngineFactory.java +++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/AbstractGremlinScriptEngineFactory.java @@ -107,7 +107,7 @@ public abstract class AbstractGremlinScriptEngineFactory implements GremlinScrip */ @Override public String getProgram(final String... statements) { - StringBuilder program = new StringBuilder(); + final StringBuilder program = new StringBuilder(); for (String statement : statements) { program.append(statement).append(System.lineSeparator()); http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/f6ecbff6/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessor.java ---------------------------------------------------------------------- diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessor.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessor.java index e5fd37a..b86a9b8 100644 --- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessor.java +++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessor.java @@ -429,7 +429,7 @@ public class GremlinDslProcessor extends AbstractProcessor { private void addMethodBody(final MethodSpec.Builder methodToAdd, final ExecutableElement templateMethod, final String startBody, final String endBody, final Object... statementArgs) { final List<? extends VariableElement> parameters = templateMethod.getParameters(); - StringBuilder body = new StringBuilder(startBody); + final StringBuilder body = new StringBuilder(startBody); final int numberOfParams = parameters.size(); for (int ix = 0; ix < numberOfParams; ix++) { http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/f6ecbff6/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java ---------------------------------------------------------------------- diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java index e155ab6..2a1b036 100644 --- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java +++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java @@ -109,14 +109,14 @@ public final class DefaultTraversalMetrics implements TraversalMetrics, Serializ private void appendMetrics(final Collection<? extends Metrics> metrics, final StringBuilder sb, final int indent) { // Append each StepMetric's row. indexToLabelMap values are ordered by index. for (Metrics m : metrics) { - StringBuilder rowName = new StringBuilder(m.getName()); + final StringBuilder metricName = new StringBuilder(m.getName()); // Handle indentation for (int ii = 0; ii < indent; ii++) { - rowName.insert(0, " "); + metricName.insert(0, " "); } // Abbreviate if necessary - rowName = new StringBuilder(StringUtils.abbreviate(rowName.toString(), 50)); + final StringBuilder rowName = new StringBuilder(StringUtils.abbreviate(metricName.toString(), 50)); // Grab the values final Long itemCount = m.getCount(ELEMENT_COUNT_ID); @@ -187,7 +187,7 @@ public final class DefaultTraversalMetrics implements TraversalMetrics, Serializ private static String padLeft(final String text, final int amountToPad) { // not sure why this method needed to exist. stupid string format stuff and commons utilities wouldn't // work for some reason in the context this method was used above. - StringBuilder newText = new StringBuilder(text); + final StringBuilder newText = new StringBuilder(text); for (int ix = 0; ix < amountToPad; ix++) { newText.insert(0, " "); }