[GitHub] [tinkerpop] spmallette commented on issue #1075: Docker gremlin-server test script
spmallette commented on issue #1075: Docker gremlin-server test script URL: https://github.com/apache/tinkerpop/pull/1075#issuecomment-503992176 VOTE +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1075: Docker gremlin-server test script
spmallette commented on issue #1075: Docker gremlin-server test script URL: https://github.com/apache/tinkerpop/pull/1075#issuecomment-501686223 Can't think of a reasonable way to sort out the "copied" files I alluded to above, at least not without re-working how the Maven build works. At this stage, it's probably better that we simply have this docker capability than re-working the maven stuff. Also, I don't see much change happening to these files anymore so perhaps it's not a big deal (certainly not as big as the amount of copy/paste we had before the maven refactoring to unify testing across GLVs. Added some comments to remind us that changes to the test configuration in gremlin-server will need to be replicated to docker. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1075: Docker gremlin-server test script
spmallette commented on issue #1075: Docker gremlin-server test script URL: https://github.com/apache/tinkerpop/pull/1075#issuecomment-501237677 rebased on `tp34` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1075: Docker gremlin-server test script
spmallette commented on issue #1075: Docker gremlin-server test script URL: https://github.com/apache/tinkerpop/pull/1075#issuecomment-481362889 This works nicely for me. Was able to start up Gremlin Server with the above command and then run c# tests out of the debugger in Rider. Looking at the file changes on this PR, it looks like a fair bit of copy/paste of our existing config files to `docker/` - is that right? or are there substantive changes in those new files? if not substantive and they are just copies, can we figure out how to single source them somehow so that we don't have to remember to update both places when we have a change? i put a fair bit of effort into trying to unify the `gremlin-server-integration*.yaml` test files - would be nice to just have a single set to work with that drives all tests if we can. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1075: Docker gremlin-server test script
spmallette commented on issue #1075: Docker gremlin-server test script URL: https://github.com/apache/tinkerpop/pull/1075#issuecomment-480822506 Came back to this to try it out. When I go to start it with: `docker/gremlin-server.sh` i get: ```text $ docker/gremlin-server.sh Using Gremlin Server latest Sending build context to Docker daemon 770.3MB Step 1/9 : FROM tinkerpop/gremlin-server:latest ---> 826f5bf53d48 Step 2/9 : RUN mkdir -p /opt ---> Running in 0c0fd5c03b8a ---> 95a2a636f89a Removing intermediate container 0c0fd5c03b8a Step 3/9 : WORKDIR /opt ---> 53b5ad93b0e4 Removing intermediate container 0d1c3c5bd364 Step 4/9 : COPY gremlin-server/src/test /opt/test/ ---> 429d70b20698 Removing intermediate container 8e558f9d322a Step 5/9 : COPY docker/gremlin-server/docker-entrypoint.sh docker/gremlin-server/*.yaml /opt/ ---> 43f453f4fbe9 Removing intermediate container 57df79bfb216 Step 6/9 : RUN chmod 755 /opt/docker-entrypoint.sh ---> Running in 31395a09f130 chmod: /opt/docker-entrypoint.sh: Operation not permitted The command '/bin/sh -c chmod 755 /opt/docker-entrypoint.sh' returned a non-zero code: 1 Unable to find image 'tinkerpop:gremlin-server-test-1554728236' locally docker: Error response from daemon: repository tinkerpop not found: does not exist or no pull access. See 'docker run --help'. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1075: Docker gremlin-server test script
spmallette commented on issue #1075: Docker gremlin-server test script URL: https://github.com/apache/tinkerpop/pull/1075#issuecomment-469229630 > it seems that all failing tests started with g.V(1). So, it looks like either the ids are different or the data type for the ids is wrong. i tried to figure this problem out a little bit last week, but couldn't. it's interesting that id based tests are causing trouble. note that `generate-all.groovy` does do some weird stuff around the id manager: https://github.com/apache/tinkerpop/blob/2e84dfb3ac24f87f682f7c6d2898f07433d9818f/gremlin-server/src/test/scripts/generate-all.groovy#L44 is it possible that this isn't being initialize properly through docker? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
