[GitHub] jorgebay commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python
jorgebay commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python URL: https://github.com/apache/tinkerpop/pull/1060#discussion_r256306608 ## File path: gremlin-python/src/main/jython/gremlin_python/structure/io/graphsonV3d0.py ## @@ -513,17 +548,83 @@ class Int64IO(_NumberIO): graphson_type = "g:Int64" graphson_base_type = "Int64" +@classmethod +def dictify(cls, n, writer): +# if we exceed Java long range then we need a BigInteger Review comment: Shouldn't we throw in case we exceed the range of a int64? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jorgebay commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python
jorgebay commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python URL: https://github.com/apache/tinkerpop/pull/1060#issuecomment-463122813 It's looking good, I have a doubt: would addition of `ByteIO` and others represent a breaking change for Python users? I mean the expected type was x and now is y. cc @aboudreault This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch download-page updated: use bootstrap form
This is an automated email from the ASF dual-hosted git repository. rdale pushed a commit to branch download-page in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/download-page by this push: new 07ea8fe use bootstrap form 07ea8fe is described below commit 07ea8fe37057e8bc7a93f7b150f900e0ad6f49c7 Author: Robert Dale AuthorDate: Wed Feb 13 05:50:39 2019 -0500 use bootstrap form --- docs/site/home/downloads.html | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/site/home/downloads.html b/docs/site/home/downloads.html index 152b290..63e808e 100644 --- a/docs/site/home/downloads.html +++ b/docs/site/home/downloads.html @@ -83,7 +83,9 @@ limitations under the License. Archived Releases - + + + 3.3.4 (15-Oct-2018) 3.3.3 (8-May-2018) 3.3.2 (2-Apr-2018) @@ -113,6 +115,8 @@ limitations under the License. 3.0.1-incubating (2-Sep-2015) 3.0.0-incubating (9-Jul-2015) + +
[GitHub] robertdale commented on issue #1059: Improve download page
robertdale commented on issue #1059: Improve download page URL: https://github.com/apache/tinkerpop/pull/1059#issuecomment-463153417 I pushed a fix. Looks like there is no 'bootstrap-select' class. I changed it to use the standard bootstrap form/select - https://getbootstrap.com/docs/3.3/css/#forms-controls This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aboudreault commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python
aboudreault commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python URL: https://github.com/apache/tinkerpop/pull/1060#issuecomment-463179895 It is. But not sure if we can do otherwise if we want to add this serializer. Stephen, is the server really rejecting the data if we send a gx:Int32 in the range of the Byte possible values? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] spmallette commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python
spmallette commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python URL: https://github.com/apache/tinkerpop/pull/1060#discussion_r256380289 ## File path: gremlin-python/src/main/jython/gremlin_python/structure/io/graphsonV3d0.py ## @@ -513,17 +548,83 @@ class Int64IO(_NumberIO): graphson_type = "g:Int64" graphson_base_type = "Int64" +@classmethod +def dictify(cls, n, writer): +# if we exceed Java long range then we need a BigInteger Review comment: in python `long` is not limited to 64 bits so i thought it would be a better translation to magically convert to `BigInteger` so that java could consume it. not good? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] spmallette commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python
spmallette commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python URL: https://github.com/apache/tinkerpop/pull/1060#issuecomment-463189263 The server won't reject `g:Int32` if it's a byte size value but it won't interpret it as a java `Byte`. This change just allows python to interpret/send the type. I'm not sure what is a breaking change here though. Right now, if Gremlin Server sends a `gx;Byte` python can't deserialize it and gremlin-python has no way to send a single `gx:Byte`. isn't this an additive feature? I suppose that maybe BigInteger might produce different behavior that could be considered breaking. Currently, `gx:BigInteger` coming from Gremlin Server won't be deserialized and I imagine results in error and if python has a number outside of 64bit size and sends it as `g:Long` it will fail to deserialize on Gremlin Server. So, behavior of numbers is a little different because they remove error conditions, but isn't that ok? or am i not thinking about something correctly? (entirely possibly that i am actually as i might be misunderstanding how python is handling some of this stuff given my middling knowledge of the language) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aboudreault commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python
aboudreault commented on a change in pull request #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python URL: https://github.com/apache/tinkerpop/pull/1060#discussion_r256417177 ## File path: gremlin-python/src/main/jython/gremlin_python/structure/io/graphsonV3d0.py ## @@ -513,17 +548,83 @@ class Int64IO(_NumberIO): graphson_type = "g:Int64" graphson_base_type = "Int64" +@classmethod +def dictify(cls, n, writer): +# if we exceed Java long range then we need a BigInteger Review comment: That is correct. Note that this serializer function is used by the BigIntegerIO as well. So otherwise.. we would have no way to write a `gx:BigInteger`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aboudreault commented on issue #1060: TINKERPOP-1435 GraphSON extended module support for gremlin-python
aboudreault commented on issue #1060: TINKERPOP-1435 GraphSON extended module
support for gremlin-python
URL: https://github.com/apache/tinkerpop/pull/1060#issuecomment-463220534
oh, right.. at the moment the user will get back a non-deserialized
`{''@type': 'gx:Byte', '@value': 42}`. I had in mind that the `int` would be
returned as is.
I think we are good Stephen.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[tinkerpop] branch tp33 updated (095cfb6 -> bb67885)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch tp33 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 095cfb6 Removed unecessary build steps in dotnet and js CTR add bb67885 Use clean plugin to kill .NET directories generated during builds No new revisions were added by this update. Summary of changes: gremlin-dotnet/pom.xml | 20 gremlin-python/pom.xml | 1 - pom.xml| 5 + 3 files changed, 25 insertions(+), 1 deletion(-)
[tinkerpop] branch master updated: Use clean plugin to kill .NET directories generated during builds
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/master by this push: new bb67885 Use clean plugin to kill .NET directories generated during builds new 4af04a3 Merge branch 'tp33' bb67885 is described below commit bb678853886a82e3c0575f2b51dd418e35191eb6 Author: Stephen Mallette AuthorDate: Wed Feb 13 11:19:26 2019 -0500 Use clean plugin to kill .NET directories generated during builds The specific directory being removed typically causes problems for docker builds CTR --- gremlin-dotnet/pom.xml | 20 gremlin-python/pom.xml | 1 - pom.xml| 5 + 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/gremlin-dotnet/pom.xml b/gremlin-dotnet/pom.xml index 176e957..bb2d932 100644 --- a/gremlin-dotnet/pom.xml +++ b/gremlin-dotnet/pom.xml @@ -35,6 +35,26 @@ limitations under the License. +org.apache.maven.plugins +maven-clean-plugin + + + +clean + + + + + + + +src/obj +false + + + + + org.eobjects.build dotnet-maven-plugin true diff --git a/gremlin-python/pom.xml b/gremlin-python/pom.xml index 786c54d..18275d0 100644 --- a/gremlin-python/pom.xml +++ b/gremlin-python/pom.xml @@ -86,7 +86,6 @@ limitations under the License. org.apache.maven.plugins maven-clean-plugin -3.0.0 diff --git a/pom.xml b/pom.xml index e8daf98..cd31588 100644 --- a/pom.xml +++ b/pom.xml @@ -601,6 +601,11 @@ limitations under the License. maven-antrun-plugin 1.8 + +org.apache.maven.plugins +maven-clean-plugin +3.1.0 +
[tinkerpop] branch tp33 updated (bb67885 -> 29a9a7b)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch tp33 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from bb67885 Use clean plugin to kill .NET directories generated during builds add 29a9a7b Added retry to some tests that were timer based No new revisions were added by this update. Summary of changes: .../gremlin/server/GremlinDriverIntegrateTest.java | 30 +- 1 file changed, 24 insertions(+), 6 deletions(-)
[tinkerpop] branch master updated: Added retry to some tests that were timer based
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/master by this push:
new 29a9a7b Added retry to some tests that were timer based
new b10d96f Merge branch 'tp33'
29a9a7b is described below
commit 29a9a7b85f96ff089ede5de74a81aa3600bc4746
Author: Stephen Mallette
AuthorDate: Wed Feb 13 22:02:39 2019 -0500
Added retry to some tests that were timer based
These tests failed in docker from time to time. This change should reduce
the chance of that happening. CTR
---
.../gremlin/server/GremlinDriverIntegrateTest.java | 30 +-
1 file changed, 24 insertions(+), 6 deletions(-)
diff --git
a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
index b281e0a..45295d5 100644
---
a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
+++
b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
@@ -330,9 +330,18 @@ public class GremlinDriverIntegrateTest extends
AbstractGremlinServerIntegration
startServer();
// default reconnect time is 1 second so wait some extra time to be
sure it has time to try to bring it
-// back to life
-TimeUnit.SECONDS.sleep(3);
-assertEquals(2, client.submit("1+1").all().join().get(0).getInt());
+// back to life. usually this passes on the first attempt, but docker
is sometimes slow and we get failures
+// waiting for Gremlin Server to pop back up
+for (int ix = 3; ix < 13; ix++) {
+TimeUnit.SECONDS.sleep(ix);
+try {
+final int result =
client.submit("1+1").all().join().get(0).getInt();
+assertEquals(2, result);
+break;
+} catch (Exception ignored) {
+logger.warn("Attempt {} failed on
shouldEventuallySucceedOnSameServerWithDefault", ix);
+}
+}
cluster.close();
}
@@ -355,9 +364,18 @@ public class GremlinDriverIntegrateTest extends
AbstractGremlinServerIntegration
startServer();
// default reconnect time is 1 second so wait some extra time to be
sure it has time to try to bring it
-// back to life
-TimeUnit.SECONDS.sleep(3);
-assertEquals(2, client.submit("1+1").all().join().get(0).getInt());
+// back to life. usually this passes on the first attempt, but docker
is sometimes slow and we get failures
+// waiting for Gremlin Server to pop back up
+for (int ix = 3; ix < 13; ix++) {
+TimeUnit.SECONDS.sleep(ix);
+try {
+final int result =
client.submit("1+1").all().join().get(0).getInt();
+assertEquals(2, result);
+break;
+} catch (Exception ignored) {
+logger.warn("Attempt {} failed on
shouldEventuallySucceedOnSameServerWithScript", ix);
+}
+}
cluster.close();
}
