[jira] [Commented] (TOMEE-2478) extractWars configuration value does invalid extraction
[ https://issues.apache.org/jira/browse/TOMEE-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788284#comment-16788284 ] Romain Manni-Bucau commented on TOMEE-2478: --- I suspect this feature was not properly done for both additionnal webapps and current project. Feel free to add a test and do a pr to fix it. > extractWars configuration value does invalid extraction > --- > > Key: TOMEE-2478 > URL: https://issues.apache.org/jira/browse/TOMEE-2478 > Project: TomEE > Issue Type: Bug > Components: TomEE Maven Plugin >Affects Versions: 7.1.0, 8.0.0-M2 >Reporter: James Smith >Priority: Major > Attachments: tomee-fat-jar.zip, tomee-fat-jar.zip > > > I run my TomEE as a fat JAR, and I like to keep the distribution as lean as I > can achieve. I recently noticed while taking advantage of the *extractWars* > configuration value, which instead of leaving *ROOT.war* and *ROOT/* for > instance, it removes the archive and leaving only the directory. > > Unfortunately, the exploded WAR that results from this variable is > *ROOT.war/*, I only noticed this when I was testing Microprofile config > injection in one of my JAX-RS resources. I have attached a very lean example. > Please run it and modify *extractWars* to notice how the config value is not > being injected when the directory is *ROOT.war/*. > > A fix to the issue will most likely be found > [here|https://github.com/apache/tomee/blob/master/maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TOMEE-2478) extractWars configuration value does invalid extraction
[ https://issues.apache.org/jira/browse/TOMEE-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788231#comment-16788231 ] James Smith commented on TOMEE-2478: [~romain.manni-bucau], could you possibly check this out? I'm not sure if anyone is using this configuration value, or has noticed the issue. Appreciate it! :) > extractWars configuration value does invalid extraction > --- > > Key: TOMEE-2478 > URL: https://issues.apache.org/jira/browse/TOMEE-2478 > Project: TomEE > Issue Type: Bug > Components: TomEE Maven Plugin >Affects Versions: 7.1.0, 8.0.0-M2 >Reporter: James Smith >Priority: Major > Attachments: tomee-fat-jar.zip, tomee-fat-jar.zip > > > I run my TomEE as a fat JAR, and I like to keep the distribution as lean as I > can achieve. I recently noticed while taking advantage of the *extractWars* > configuration value, which instead of leaving *ROOT.war* and *ROOT/* for > instance, it removes the archive and leaving only the directory. > > Unfortunately, the exploded WAR that results from this variable is > *ROOT.war/*, I only noticed this when I was testing Microprofile config > injection in one of my JAX-RS resources. I have attached a very lean example. > Please run it and modify *extractWars* to notice how the config value is not > being injected when the directory is *ROOT.war/*. > > A fix to the issue will most likely be found > [here|https://github.com/apache/tomee/blob/master/maven/tomee-maven-plugin/src/main/java/org/apache/openejb/maven/plugin/AbstractTomEEMojo.java]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
