[trafficserver] branch master updated (fb1b3a1b92 -> e97a83ef64)
This is an automated email from the ASF dual-hosted git repository. cmcfarlen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git from fb1b3a1b92 Cmake presets (#10457) add e97a83ef64 Fix cmake autooptions (#10456) No new revisions were added by this update. Summary of changes: CMakeLists.txt| 6 -- cmake/AutoOptionHelpers.cmake | 10 +++--- 2 files changed, 7 insertions(+), 9 deletions(-)
[trafficserver] branch master updated (5737f77e9c -> fb1b3a1b92)
This is an automated email from the ASF dual-hosted git repository. cmcfarlen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git from 5737f77e9c This fixes CID 1518257 (#10404) add fb1b3a1b92 Cmake presets (#10457) No new revisions were added by this update. Summary of changes: .gitignore| 2 + CMakePresets.json | 112 ++ 2 files changed, 114 insertions(+) create mode 100644 CMakePresets.json
[trafficserver] branch master updated: This fixes CID 1518257 (#10404)
This is an automated email from the ASF dual-hosted git repository. mochen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git The following commit(s) were added to refs/heads/master by this push: new 5737f77e9c This fixes CID 1518257 (#10404) 5737f77e9c is described below commit 5737f77e9c978cca0109f414e9ab1a31506116ce Author: Mo Chen AuthorDate: Mon Sep 18 17:39:09 2023 -0500 This fixes CID 1518257 (#10404) * Initialize _fd to a dummy value. --- iocore/net/AsyncSignalEventIO.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iocore/net/AsyncSignalEventIO.h b/iocore/net/AsyncSignalEventIO.h index 4786df30dc..515b0c1933 100644 --- a/iocore/net/AsyncSignalEventIO.h +++ b/iocore/net/AsyncSignalEventIO.h @@ -35,5 +35,5 @@ public: void process_event(int flags) override; private: - int _fd; + int _fd = -1; };
[trafficserver] branch master updated (f75cee4311 -> a3f807d298)
This is an automated email from the ASF dual-hosted git repository. masaori pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git from f75cee4311 adding a pristine option for strategies (#10410) add a3f807d298 CID 1518583: Unchecked return value (#10394) No new revisions were added by this update. Summary of changes: plugins/experimental/cache_fill/cache_fill.cc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)
[trafficserver] branch master updated (f1a5f6186a -> f75cee4311)
This is an automated email from the ASF dual-hosted git repository. eze pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git from f1a5f6186a Make Cripts buildable on Fedora 39 (#10453) add f75cee4311 adding a pristine option for strategies (#10410) No new revisions were added by this update. Summary of changes: configs/strategies.schema.json | 4 proxy/ParentSelection.h | 1 + proxy/http/HttpTransact.cc | 10 -- proxy/http/remap/NextHopConsistentHash.cc| 10 ++ proxy/http/remap/NextHopSelectionStrategy.cc | 4 proxy/http/remap/NextHopSelectionStrategy.h | 1 + 6 files changed, 28 insertions(+), 2 deletions(-)
[trafficserver] branch master updated (b99a387b93 -> f1a5f6186a)
This is an automated email from the ASF dual-hosted git repository. maskit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git from b99a387b93 Fix potential resource leak in ja3_fingerprint plugin. (#10411) add f1a5f6186a Make Cripts buildable on Fedora 39 (#10453) No new revisions were added by this update. Summary of changes: include/cripts/Files.hpp | 2 +- include/cripts/Matcher.hpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
[trafficserver] branch master updated: Fix potential resource leak in ja3_fingerprint plugin. (#10411)
This is an automated email from the ASF dual-hosted git repository. wkaras pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git The following commit(s) were added to refs/heads/master by this push: new b99a387b93 Fix potential resource leak in ja3_fingerprint plugin. (#10411) b99a387b93 is described below commit b99a387b9393e087e7acf1ef5feecac9d7b00eef Author: Walt Karas AuthorDate: Mon Sep 18 18:21:16 2023 -0400 Fix potential resource leak in ja3_fingerprint plugin. (#10411) Coverity issue CID 1508991 --- plugins/ja3_fingerprint/ja3_fingerprint.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/ja3_fingerprint/ja3_fingerprint.cc b/plugins/ja3_fingerprint/ja3_fingerprint.cc index 79859abde5..6e0e8245c9 100644 --- a/plugins/ja3_fingerprint/ja3_fingerprint.cc +++ b/plugins/ja3_fingerprint/ja3_fingerprint.cc @@ -496,7 +496,7 @@ TSReturnCode TSRemapNewInstance(int argc, char *argv[], void **ih, char * /* errbuf ATS_UNUSED */, int /* errbuf_size ATS_UNUSED */) { TSDebug(PLUGIN_NAME, "New instance for client matching %s to %s", argv[0], argv[1]); - ja3_remap_info *pri = new ja3_remap_info; + std::unique_ptr pri{new ja3_remap_info}; // Parse parameters if (!read_config_option(argc - 1, const_cast(argv + 1), pri->raw, pri->log)) { @@ -511,10 +511,10 @@ TSRemapNewInstance(int argc, char *argv[], void **ih, char * /* errbuf ATS_UNUSE // Create continuation pri->handler = TSContCreate(req_hdr_ja3_handler, nullptr); - TSContDataSet(pri->handler, pri); + TSContDataSet(pri->handler, pri.get()); // Pass to other remap plugin functions - *ih = static_cast(pri); + *ih = static_cast(pri.release()); return TS_SUCCESS; }
[trafficserver] branch master updated (4c8f8cee4b -> d4a8f2f329)
This is an automated email from the ASF dual-hosted git repository. zwoop pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git from 4c8f8cee4b Relax some of the build deps (#10458) add d4a8f2f329 Promotes slice plugin to stable (#10444) No new revisions were added by this update. Summary of changes: plugins/CMakeLists.txt | 1 + plugins/Makefile.am| 2 +- plugins/experimental/CMakeLists.txt| 1 - plugins/experimental/slice/Makefile.inc| 72 -- plugins/{experimental => }/slice/CMakeLists.txt| 0 plugins/{experimental => }/slice/Config.cc | 0 plugins/{experimental => }/slice/Config.h | 0 plugins/{experimental => }/slice/ContentRange.cc | 0 plugins/{experimental => }/slice/ContentRange.h| 0 plugins/{experimental => }/slice/Data.h| 0 plugins/{experimental => }/slice/HttpHeader.cc | 0 plugins/{experimental => }/slice/HttpHeader.h | 0 plugins/slice/Makefile.inc | 72 ++ plugins/{experimental => }/slice/Makefile.tsxs | 0 plugins/{experimental => }/slice/README.md | 0 plugins/{experimental => }/slice/Range.cc | 0 plugins/{experimental => }/slice/Range.h | 0 plugins/{experimental => }/slice/Stage.h | 0 plugins/{experimental => }/slice/client.cc | 0 plugins/{experimental => }/slice/client.h | 0 plugins/{experimental => }/slice/intercept.cc | 0 plugins/{experimental => }/slice/intercept.h | 0 plugins/{experimental => }/slice/prefetch.cc | 0 plugins/{experimental => }/slice/prefetch.h| 0 plugins/{experimental => }/slice/response.cc | 0 plugins/{experimental => }/slice/response.h| 0 plugins/{experimental => }/slice/server.cc | 0 plugins/{experimental => }/slice/server.h | 0 plugins/{experimental => }/slice/slice.cc | 0 plugins/{experimental => }/slice/slice.h | 0 plugins/{experimental => }/slice/slice_test.cc | 0 plugins/{experimental => }/slice/transfer.cc | 0 plugins/{experimental => }/slice/transfer.h| 0 .../slice/unit-tests/CMakeLists.txt| 0 .../slice/unit-tests/slice_test.cc | 0 .../slice/unit-tests/test_config.cc| 0 .../slice/unit-tests/test_content_range.cc | 0 .../slice/unit-tests/test_range.cc | 0 plugins/{experimental => }/slice/util.cc | 0 plugins/{experimental => }/slice/util.h| 0 40 files changed, 74 insertions(+), 74 deletions(-) delete mode 100644 plugins/experimental/slice/Makefile.inc rename plugins/{experimental => }/slice/CMakeLists.txt (100%) rename plugins/{experimental => }/slice/Config.cc (100%) rename plugins/{experimental => }/slice/Config.h (100%) rename plugins/{experimental => }/slice/ContentRange.cc (100%) rename plugins/{experimental => }/slice/ContentRange.h (100%) rename plugins/{experimental => }/slice/Data.h (100%) rename plugins/{experimental => }/slice/HttpHeader.cc (100%) rename plugins/{experimental => }/slice/HttpHeader.h (100%) create mode 100644 plugins/slice/Makefile.inc rename plugins/{experimental => }/slice/Makefile.tsxs (100%) rename plugins/{experimental => }/slice/README.md (100%) rename plugins/{experimental => }/slice/Range.cc (100%) rename plugins/{experimental => }/slice/Range.h (100%) rename plugins/{experimental => }/slice/Stage.h (100%) rename plugins/{experimental => }/slice/client.cc (100%) rename plugins/{experimental => }/slice/client.h (100%) rename plugins/{experimental => }/slice/intercept.cc (100%) rename plugins/{experimental => }/slice/intercept.h (100%) rename plugins/{experimental => }/slice/prefetch.cc (100%) rename plugins/{experimental => }/slice/prefetch.h (100%) rename plugins/{experimental => }/slice/response.cc (100%) rename plugins/{experimental => }/slice/response.h (100%) rename plugins/{experimental => }/slice/server.cc (100%) rename plugins/{experimental => }/slice/server.h (100%) rename plugins/{experimental => }/slice/slice.cc (100%) rename plugins/{experimental => }/slice/slice.h (100%) rename plugins/{experimental => }/slice/slice_test.cc (100%) rename plugins/{experimental => }/slice/transfer.cc (100%) rename plugins/{experimental => }/slice/transfer.h (100%) rename plugins/{experimental => }/slice/unit-tests/CMakeLists.txt (100%) rename plugins/{experimental => }/slice/unit-tests/slice_test.cc (100%) rename plugins/{experimental => }/slice/unit-tests/test_config.cc (100%) rename plugins/{experimental => }/slice/unit-tests/test_content_range.cc (100%) rename plugins/{experimental => }/slice/unit-tests/test_range.cc (100%) rename plugins/{experimental => }/slice/util.cc (100%) rename plugins/{experimental => }/slice/util.h (100%)
[trafficserver] branch master updated (ecd22b94e8 -> 4c8f8cee4b)
This is an automated email from the ASF dual-hosted git repository. zwoop pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git from ecd22b94e8 [Fuzzing] linker (#10449) add 4c8f8cee4b Relax some of the build deps (#10458) No new revisions were added by this update. Summary of changes: include/cripts/Connections.hpp | 1 - include/cripts/Context.hpp | 1 - include/cripts/Crypto.hpp | 2 -- include/cripts/Epilogue.hpp| 1 - include/cripts/Error.hpp | 2 -- include/cripts/Headers.hpp | 2 +- include/cripts/Instance.hpp| 1 - include/cripts/Matcher.hpp | 2 -- include/cripts/Plugins.hpp | 2 -- include/cripts/Time.hpp| 2 -- include/cripts/UUID.hpp| 2 -- include/cripts/Urls.hpp| 2 -- src/cripts/Instance.cc | 5 - 13 files changed, 5 insertions(+), 20 deletions(-)
[trafficserver] branch allow-plain updated (3de3260bba -> 1be584aa52)
This is an automated email from the ASF dual-hosted git repository. shinrich pushed a change to branch allow-plain in repository https://gitbox.apache.org/repos/asf/trafficserver.git from 3de3260bba Fix conflicting contants add 1be584aa52 Address Maskit's comments No new revisions were added by this update. Summary of changes: iocore/net/SSLNextProtocolAccept.cc | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-)
[trafficserver] branch master updated: [Fuzzing] linker (#10449)
This is an automated email from the ASF dual-hosted git repository. kichan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git The following commit(s) were added to refs/heads/master by this push: new ecd22b94e8 [Fuzzing] linker (#10449) ecd22b94e8 is described below commit ecd22b94e8feed2d1edc8292b789937a9f4521cc Author: Arjun <36335769+0x...@users.noreply.github.com> AuthorDate: Mon Sep 18 22:18:24 2023 +0530 [Fuzzing] linker (#10449) Signed-off-by: Arjun Singh --- tests/fuzzing/CMakeLists.txt | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/tests/fuzzing/CMakeLists.txt b/tests/fuzzing/CMakeLists.txt index 9e688a4a2f..4ee7873dde 100644 --- a/tests/fuzzing/CMakeLists.txt +++ b/tests/fuzzing/CMakeLists.txt @@ -31,14 +31,24 @@ add_executable(fuzz_yamlcpp fuzz_yamlcpp.cc) target_link_libraries(fuzz_esi PRIVATE esi-common esicore) -target_link_libraries(fuzz_hpack PRIVATE ts::http2 ts::hdrs ts::tsapi) -target_link_libraries(fuzz_http PRIVATE ts::hdrs ts::tsapi) +target_link_libraries(fuzz_hpack PRIVATE records tscore hdrs inkevent) +target_link_libraries(fuzz_http PRIVATE ts::hdrs ts::tscore ts::inkevent) target_link_libraries(fuzz_json PRIVATE libswoc yaml-cpp ts::jsonrpc_protocol) target_link_libraries(fuzz_proxy_protocol PRIVATE inknet inkevent ts::tscore yaml-cpp libswoc) -target_link_libraries(fuzz_rec_http PRIVATE ts::records ts::tsapi) +target_link_libraries(fuzz_rec_http PRIVATE records tscore libswoc) target_link_libraries(fuzz_yamlcpp PRIVATE yaml-cpp) +target_sources(fuzz_hpack PRIVATE +${CMAKE_SOURCE_DIR}/proxy/http2/HTTP2.cc +${CMAKE_SOURCE_DIR}/proxy/http2/Http2Frame.cc +${CMAKE_SOURCE_DIR}/proxy/http2/HPACK.cc +) +target_include_directories(fuzz_hpack PRIVATE +${CMAKE_SOURCE_DIR}/proxy/http2 +${PROXY_INCLUDE_DIRS} +${CMAKE_SOURCE_DIR}/iocore/utils +) target_include_directories(fuzz_json PRIVATE ${CMAKE_SOURCE_DIR}/mgmt ${CMAKE_SOURCE_DIR}/mgmt/rpc
[trafficserver] branch master updated: Use PRIu64 for stream id (#10446)
This is an automated email from the ASF dual-hosted git repository. maskit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git The following commit(s) were added to refs/heads/master by this push: new 3857bb9936 Use PRIu64 for stream id (#10446) 3857bb9936 is described below commit 3857bb99369c533e150baf29b2867a5d0b10d9cf Author: Masakazu Kitajo AuthorDate: Tue Sep 19 00:27:22 2023 +0900 Use PRIu64 for stream id (#10446) --- proxy/http3/Http3App.cc | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/proxy/http3/Http3App.cc b/proxy/http3/Http3App.cc index 4a8d5c14dc..aadd7ed8f5 100644 --- a/proxy/http3/Http3App.cc +++ b/proxy/http3/Http3App.cc @@ -221,13 +221,13 @@ Http3App::_handle_uni_stream_on_read_ready(int /* event */, VIO *vio) } else if (this->_control_stream_id != adapter->stream().id()) { error = std::make_unique(Http3ErrorClass::CONNECTION, Http3ErrorCode::H3_STREAM_CREATION_ERROR, "Only one control stream per peer is permitted"); - Debug("http3", "CONTROL stream [%lu] error: %hu, %s", this->_control_stream_id, error->get_code(), error->msg); + Debug("http3", "CONTROL stream [%" PRIu64 "] error: %hu, %s", this->_control_stream_id, error->get_code(), error->msg); break; } uint64_t nread = 0; error = this->_control_stream_dispatcher.on_read_ready(adapter->stream().id(), type, *vio->get_reader(), nread); if (error && error->cls != Http3ErrorClass::UNDEFINED) { - Debug("http3", "CONTROL stream [%lu] error: %hu, %s", this->_control_stream_id, error->get_code(), error->msg); + Debug("http3", "CONTROL stream [%" PRIu64 "] error: %hu, %s", this->_control_stream_id, error->get_code(), error->msg); } // The sender MUST NOT close the control stream, and the receiver MUST NOT request that the sender close the control stream. // If either control stream is closed at any point, this MUST be treated as a connection error of type @@ -237,7 +237,7 @@ Http3App::_handle_uni_stream_on_read_ready(int /* event */, VIO *vio) case Http3StreamType::PUSH: { error = std::make_unique(Http3ErrorClass::CONNECTION, Http3ErrorCode::H3_STREAM_CREATION_ERROR, "Only servers can push"); -Debug("http3", "PUSH stream [%lu] error: %hu, %s", adapter->stream().id(), error->get_code(), error->msg); +Debug("http3", "PUSH stream [%" PRIu64 "] error: %hu, %s", adapter->stream().id(), error->get_code(), error->msg); // if a server receives a client-initiated push stream, this MUST be treated as a connection error of type // H3_STREAM_CREATION_ERROR break; @@ -252,7 +252,7 @@ Http3App::_handle_uni_stream_on_read_ready(int /* event */, VIO *vio) // processing. If reading is aborted, the recipient SHOULD use the H3_STREAM_CREATION_ERROR error code or a reserved error code // (Section 8.1). The recipient MUST NOT consider unknown stream types to be a connection error of any kind. error = std::make_unique(Http3ErrorClass::STREAM, Http3ErrorCode::H3_STREAM_CREATION_ERROR, "Stream type unkown"); -Debug("http3", "UNKNOWN stream [%lu] error: %hu, %s", adapter->stream().id(), error->get_code(), error->msg); +Debug("http3", "UNKNOWN stream [%" PRIu64 "] error: %hu, %s", adapter->stream().id(), error->get_code(), error->msg); break; } default: