[GitHub] [incubator-tvm] FrozenGene commented on issue #4281: [RUTNIME] Support C++ RPC
FrozenGene commented on issue #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#issuecomment-552219131 @tqchen Have resolved LOG(ERROR) -> LOG(FATAL) and gnulib issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] FrozenGene commented on issue #4281: [RUTNIME] Support C++ RPC
FrozenGene commented on issue #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#issuecomment-552174191 @tqchen @weberlo I should resolve all the comments. Please review again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] FrozenGene commented on issue #4281: [RUTNIME] Support C++ RPC
FrozenGene commented on issue #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#issuecomment-552068563 > split then check creates additional data structures such as vector and string(additional data structures), which can be avoided as you can simply do istringstream to parse the ints (check the bits) and avoid creation of additional containers @tqchen When I implement completely, I find using system api `inet_pton` is a better solution, we could add ipv6 check too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] FrozenGene commented on issue #4281: [RUTNIME] Support C++ RPC
FrozenGene commented on issue #4281: [RUTNIME] Support C++ RPC URL: https://github.com/apache/incubator-tvm/pull/4281#issuecomment-551969728 @tqchen Wish I have solved many comments. I also replace SelectHelper into PoolHelper. Remained: Ideally, we should just use std::istringstream to do the validation(to reduce memory complexity). Given that this is a util function, we would like to apply such higher standard -> Split internally is used istringstream to do things in fact, need to make sure the meaning. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
