[GitHub] [incubator-tvm] cchung100m commented on a change in pull request #4891: [TEST][FLAKY] topi/tests/python/test_topi_sort.py::test_argsort

2020-02-21 Thread GitBox 
cchung100m commented on a change in pull request #4891: [TEST][FLAKY] 
topi/tests/python/test_topi_sort.py::test_argsort
URL: https://github.com/apache/incubator-tvm/pull/4891#discussion_r382654644
 
 

 ##
 File path: topi/tests/python/test_topi_sort.py
 ##
 @@ -27,6 +27,12 @@ def verify_argsort(axis, is_ascend):
 data_dtype = "float32"
 data = tvm.placeholder(dshape, name="data", dtype=data_dtype)
 np_data = np.random.uniform(size=dshape).astype(data_dtype)
 
 Review comment:
   Apology for the misunderstanding. I update that part you mentioned and the 
test results as shown below:
   
   ```
   >>> perm = np.arange(dshape[0] * dshape[1], dtype=data_dtype)
   >>> np.random.shuffle(perm)
   >>> np_data = perm.reshape(dshape)
   >>> np_data
   array([[22., 23., 10., 18., 12.],
  [16., 20.,  6., 21.,  1.],
  [24.,  7.,  4., 15., 13.],
  [14.,  5.,  8., 19., 11.],
  [ 9.,  3.,  0.,  2., 17.]], dtype=float32)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] cchung100m commented on a change in pull request #4891: [TEST][FLAKY] topi/tests/python/test_topi_sort.py::test_argsort

2020-02-20 Thread GitBox 
cchung100m commented on a change in pull request #4891: [TEST][FLAKY] 
topi/tests/python/test_topi_sort.py::test_argsort
URL: https://github.com/apache/incubator-tvm/pull/4891#discussion_r381996637
 
 

 ##
 File path: topi/tests/python/test_topi_sort.py
 ##
 @@ -27,6 +27,12 @@ def verify_argsort(axis, is_ascend):
 data_dtype = "float32"
 data = tvm.placeholder(dshape, name="data", dtype=data_dtype)
 np_data = np.random.uniform(size=dshape).astype(data_dtype)
 
 Review comment:
   I think `np_data` is needed by the following lines, like L32 and L37, but 
please correct me if I’m wrong on that


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] cchung100m commented on a change in pull request #4891: [TEST][FLAKY] topi/tests/python/test_topi_sort.py::test_argsort

2020-02-17 Thread GitBox 
cchung100m commented on a change in pull request #4891: [TEST][FLAKY] 
topi/tests/python/test_topi_sort.py::test_argsort
URL: https://github.com/apache/incubator-tvm/pull/4891#discussion_r380464642
 
 

 ##
 File path: topi/tests/python/test_topi_sort.py
 ##
 @@ -27,6 +27,12 @@ def verify_argsort(axis, is_ascend):
 data_dtype = "float32"
 data = tvm.placeholder(dshape, name="data", dtype=data_dtype)
 np_data = np.random.uniform(size=dshape).astype(data_dtype)
 
 Review comment:
   Do you mean the output `nd.array` of `numpy.random.uniform`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services