[GitHub] [incubator-tvm] cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth

2019-11-15 Thread GitBox 
cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: 
DepthToSpace, SpaceToDepth
URL: https://github.com/apache/incubator-tvm/pull/4271#issuecomment-554387021
 
 
   Hi @jroesch @soiferj @zhiics 
   
   I would appreciate that if you can review/manage this PR, thank you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth

2019-11-15 Thread GitBox 
cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: 
DepthToSpace, SpaceToDepth
URL: https://github.com/apache/incubator-tvm/pull/4271#issuecomment-554385357
 
 
   @jwfromm 
   
   It is my pleasure to work with you on this PR and I do learn a lot, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth

2019-11-10 Thread GitBox 
cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: 
DepthToSpace, SpaceToDepth
URL: https://github.com/apache/incubator-tvm/pull/4271#issuecomment-552173389
 
 
   Hi @jwfromm 
   
   Thanks for the prompt reply.
   
   I agree that we can use the `onnxruntime` to test onnx model, therefore, I 
add the helper function `get_onnxruntime_output` to test `SpaceToDepth`.  The 
code is tested successfully with `onnxruntime 0.5.0` in my localhost and it 
would be great if we can add the onnxruntime in CI pipeline.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth

2019-11-08 Thread GitBox 
cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: 
DepthToSpace, SpaceToDepth
URL: https://github.com/apache/incubator-tvm/pull/4271#issuecomment-552075617
 
 
   Hi @jwfromm 
   
   Thanks for the suggestion and I had changed the code of testing loop.
   
   However, I encounter an issue when running `test_space_to_depth()` and I 
would appreciate that if you can help me to solve this issue.
   
   many thanks,
   
   ```
   ONNX FATAL: Don't know how to translate op SpaceToDepth
   
/Users/root/tvm/venv/lib/python3.7/site-packages/caffe2/python/onnx/backend.py:698:
 UserWarning: This version of onnx-caffe2 targets ONNX operator set version 9, 
but the model we are trying to import uses version 10.  We will try to import 
it anyway, but if the model uses operators which had BC-breaking changes in the 
intervening versions, import will fail.
   Traceback (most recent call last):
   
 File "/Users/root/tvm/tests/python/frontend/onnx/test_forward.py", line 
1784, in 
   test_space_to_depth()
   
 File "/Users/root/tvm/tests/python/frontend/onnx/test_forward.py", line 
221, in test_space_to_depth
 warnings.warn("This version of onnx-caffe2 targets ONNX operator set 
version {}, but the model we are trying to import uses version {}.  We will try 
to import it anyway, but if the model uses operators which had BC-breaking 
changes in the intervening versions, import will 
fail.".format(cls._known_opset_version, imp.version))
   verify_space_to_depth((1, 1, 4, 6), (1, 4, 2, 3), 2)
   
 File "/Users/root/tvm/tests/python/frontend/onnx/test_forward.py", line 
212, in verify_space_to_depth
   onnx_out = get_caffe2_output(model, x, 'int32')
   
 File "/Users/root/tvm/tests/python/frontend/onnx/test_forward.py", line 
82, in get_caffe2_output
   prepared_backend = caffe2.python.onnx.backend.prepare(model)
   
 File 
"/Users/root/tvm/venv/lib/python3.7/site-packages/caffe2/python/onnx/backend.py",
 line 712, in prepare
   init_net, predict_net = cls._onnx_model_to_caffe2_net(model, device, 
opset_version, False)
   
 File 
"/Users/root/tvm/venv/lib/python3.7/site-packages/caffe2/python/onnx/backend.py",
 line 910, in _onnx_model_to_caffe2_net
   raise RuntimeError('ONNX conversion failed')
   
   RuntimeError: ONNX conversion failed
   
   Process finished with exit code 1
   
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services