[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6335: [BYOC][ETHOSN] Add support for quantized convolution

[GitBox]

comaniac commented on a change in pull request #6335:
URL: https://github.com/apache/incubator-tvm/pull/6335#discussion_r478610698



##
File path: src/relay/backend/contrib/ethosn/codegen.cc
##
@@ -50,6 +50,16 @@ bool IsEthosnOp(const Call& call, const std::string& 
op_name) {
   }
 }
 
+bool IsEthosnFunc(const Call& call, const std::string& op_name) {

Review comment:
   No idea... Let's leave them here for now.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6335: [BYOC][ETHOSN] Add support for quantized convolution

[GitBox]

comaniac commented on a change in pull request #6335:
URL: https://github.com/apache/incubator-tvm/pull/6335#discussion_r477513822



##
File path: src/relay/backend/contrib/ethosn/codegen.cc
##
@@ -50,6 +50,16 @@ bool IsEthosnOp(const Call& call, const std::string& 
op_name) {
   }
 }
 
+bool IsEthosnFunc(const Call& call, const std::string& op_name) {

Review comment:
   It seems to me that this function is not just for checking if a call is 
for an Ethos-N composite function. Maybe we should move it to a common place, 
so does IsEthosnOp.

##
File path: tests/python/contrib/test_ethosn/infrastructure.py
##
@@ -160,6 +162,26 @@ def inference_result(checksum, outputs):
 return False
 
 
+def generate_trials(space, r_factor=3):

Review comment:
   This function is not being used.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org