[GitHub] [incubator-tvm] gussmith23 commented on pull request #5812: Bring Your Own Datatypes

[GitBox]

gussmith23 commented on pull request #5812:
URL: https://github.com/apache/incubator-tvm/pull/5812#issuecomment-700066089


   thanks to everyone involved!! so cool to see this work finally integrated
   into TVM :)
   
   On Sat, Sep 26, 2020, 3:49 PM ziheng  wrote:
   
   > Merged #5812  into
   > master.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   >
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] gussmith23 commented on pull request #5812: Bring Your Own Datatypes

[GitBox]

gussmith23 commented on pull request #5812:
URL: https://github.com/apache/incubator-tvm/pull/5812#issuecomment-693753838


   @tqchen Thanks for the response! Here are a few responses:
   - *Minimum example*: We will resurrect the old dummy custom datatype (that's 
just `float32` under the hood)!
   - *Universal*: It sounds like the easiest path would be to remove the 
Universal dependency altogether, due to the licensing issue. I hadn't thought 
about that, but it makes total sense. 
 + Sure, we will consider keeping the Universal codepaths as optional 
codepaths under a feature flag.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] gussmith23 commented on pull request #5812: Bring Your Own Datatypes

[GitBox]

gussmith23 commented on pull request #5812:
URL: https://github.com/apache/incubator-tvm/pull/5812#issuecomment-693709717


   Bumping on this @jroesch @tqchen @tmoreau89 @junrushao1994 @zhiics 
@hogepodge @ZihengJiang



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] gussmith23 commented on pull request #5812: Bring Your Own Datatypes

[GitBox]

gussmith23 commented on pull request #5812:
URL: https://github.com/apache/incubator-tvm/pull/5812#issuecomment-688535104


   This PR is up for review. Thanks so much to @hypercubestart for doing the 
legwork to get it up!
   
   ccing people who might be able to help in reviewing: @jroesch @tqchen 
@tmoreau89 @junrushao1994 @zhiics @hogepodge @ZihengJiang 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] gussmith23 commented on pull request #5812: Bring Your Own Datatypes

[GitBox]

gussmith23 commented on pull request #5812:
URL: https://github.com/apache/incubator-tvm/pull/5812#issuecomment-681159395


   Thanks all, will do!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] gussmith23 commented on pull request #5812: Bring Your Own Datatypes

[GitBox]

gussmith23 commented on pull request #5812:
URL: https://github.com/apache/incubator-tvm/pull/5812#issuecomment-677769793


   @slyubomirsky I heard from Zach that you have been looking into how 
documentation is done in modern TVM. I need to document the datatypes 
framework, which is distributed across multiple files, and I'm trying to decide 
on a central place to keep the documentation. I'm wondering if anything you've 
learned recently would be relevant here?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] gussmith23 commented on pull request #5812: Bring Your Own Datatypes

[GitBox]

gussmith23 commented on pull request #5812:
URL: https://github.com/apache/incubator-tvm/pull/5812#issuecomment-666479892


   @tqchen looking for your input on testing (or feel free to point us to 
someone else who could advise us!)
   
   @hypercubestart is working on making the BYODT tests more thorough. 
Yesterday we had a discussion about whether it's better to test entire networks 
(i.e. run resnet with posits, run resnet with floats, compare the results) or 
test operator-by-operator, or both. Do you have an opinion?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] gussmith23 commented on pull request #5812: Bring Your Own Datatypes

[GitBox]

gussmith23 commented on pull request #5812:
URL: https://github.com/apache/incubator-tvm/pull/5812#issuecomment-666398623


   Thanks, Theo! We'll be making heavy use of posits to test the framework, so
   we'll be sure to use the right configurations.
   
   Gus
   
   On Thu, Jul 30, 2020, 3:39 AM Theodore Omtzigt 
   wrote:
   
   > @gussmith23  the posit standard is moving
   > towards posit<8,2>, posit<16,2>, posit<32,2>, posit<64,2> specifically to
   > make conversions better, faster, cheaper.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   >
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org