[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #4289: [RUNTIME][REFACTOR] Use object protocol to support runtime::Module
junrushao1994 commented on a change in pull request #4289: [RUNTIME][REFACTOR] Use object protocol to support runtime::Module URL: https://github.com/apache/incubator-tvm/pull/4289#discussion_r344525003 ## File path: src/runtime/micro/tcl_socket.h ## @@ -18,7 +18,6 @@ */ /*! - * Copyright (c) 2019 by Contributors Review comment: What happened to this line... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #4289: [RUNTIME][REFACTOR] Use object protocol to support runtime::Module
junrushao1994 commented on a change in pull request #4289: [RUNTIME][REFACTOR] Use object protocol to support runtime::Module URL: https://github.com/apache/incubator-tvm/pull/4289#discussion_r344524435 ## File path: include/tvm/runtime/module.h ## @@ -71,7 +70,11 @@ class Module { * \note Cyclic dependency is not allowed among modules, * An error will be thrown when cyclic dependency is detected. */ - TVM_DLL void Import(Module other); Review comment: Do we intentionally remove the TVM_DLL here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services