[GitHub] [incubator-tvm] masahi edited a comment on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
masahi edited a comment on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604681188 See https://discuss.tvm.ai/t/discuss-adding-a-pytorch-frontend/5026 for a RFC on adding the PyTorch frontend. Yes, discussion with respect to ONNX is common when adding a new frontend, and the PyTorch RFC above gave some reasons adding the PyTorch frontend could be justified. You want to have similar story for Chainer, more specific than "Chainer users would benefit" or "attracting more users". Note that unlike other frameworks, Chainer doesn't even have a well defined IR we can translate from. You need to start by developing some kind of tracing mechanism. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] masahi edited a comment on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
masahi edited a comment on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604681188 See https://discuss.tvm.ai/t/discuss-adding-a-pytorch-frontend/5026 for a RFC on adding the PyTorch frontend. Yes, discussion with respect to ONNX is common when adding a new frontend, and the PyTorch RFC above gave some reasons adding the PyTorch frontend could be justified. You want to have similar story for Chainer, more specific than "Chainer users would benefit" or "attracting more users" or This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] masahi edited a comment on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
masahi edited a comment on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604095365 You should first send a RFC on why you want to add this frontend. I don't think it is a good idea for the following reasons: * Chainer is now in maintenance mode * We already have ONNX and PyTorch frontend. Existing Chainer users are being encouraged to switch to PyTorch, so they can use either frontend * Additional frontend brings more development and maintenance burden (including reviews), and makes CI even slower This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
