[GitHub] [incubator-tvm] tqchen commented on pull request #5600: [TOPI] Improve CUDA softmax scheduling

2020-06-05 Thread GitBox 


tqchen commented on pull request #5600:
URL: https://github.com/apache/incubator-tvm/pull/5600#issuecomment-639560545


   cc @icemelon9 it might be useful to revisit the softmax strategy.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5600: [TOPI] Improve CUDA softmax scheduling

2020-06-03 Thread GitBox 


tqchen commented on pull request #5600:
URL: https://github.com/apache/incubator-tvm/pull/5600#issuecomment-638261177


   @t-vi can you elaborate?
   
   @wpan11nv please also followup. One thing that get missed during review is 
that we should move the nvptx related intrinsics into codegen_nvptx.cc instead.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5600: [TOPI] Improve CUDA softmax scheduling

2020-05-26 Thread GitBox 


tqchen commented on pull request #5600:
URL: https://github.com/apache/incubator-tvm/pull/5600#issuecomment-633648673


   THanks @wpan11nv , @roastduck @Shawn-Inspur ! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5600: [TOPI] Improve CUDA softmax scheduling

2020-05-23 Thread GitBox 


tqchen commented on pull request #5600:
URL: https://github.com/apache/incubator-tvm/pull/5600#issuecomment-633078719


   @Shawn-Inspur please followup and 
https://tvm.apache.org/docs/contribute/code_review.html#approve-and-request-changes-explicitly



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5600: [TOPI] Improve CUDA softmax scheduling

2020-05-18 Thread GitBox 


tqchen commented on pull request #5600:
URL: https://github.com/apache/incubator-tvm/pull/5600#issuecomment-630282939


   @icemelon9 @Hzfengsy @Shawn-Inspur  please also take a look



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org