[GitHub] [incubator-tvm] u99127 commented on a change in pull request #5648: µtvm debug improvements

2020-05-26 Thread GitBox 


u99127 commented on a change in pull request #5648:
URL: https://github.com/apache/incubator-tvm/pull/5648#discussion_r430249638



##
File path: src/runtime/micro/host_driven/utvm_runtime.c
##
@@ -101,7 +101,7 @@ void UTVMMain() {
 
 // We use a dummy function to signal execution is finished for device
 // backends which require breakpoints.
-void __attribute__((noinline)) UTVMDone() { utvm_done = 1; }
+void __attribute__((noinline,noreturn)) UTVMDone() { utvm_done = 1; for (;;) ; 
}

Review comment:
   fair enough, lgtm.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] u99127 commented on a change in pull request #5648: µtvm debug improvements

2020-05-22 Thread GitBox 


u99127 commented on a change in pull request #5648:
URL: https://github.com/apache/incubator-tvm/pull/5648#discussion_r429357376



##
File path: src/runtime/micro/host_driven/utvm_runtime.c
##
@@ -101,7 +101,7 @@ void UTVMMain() {
 
 // We use a dummy function to signal execution is finished for device
 // backends which require breakpoints.
-void __attribute__((noinline)) UTVMDone() { utvm_done = 1; }
+void __attribute__((noinline,noreturn)) UTVMDone() { utvm_done = 1; for (;;) ; 
}

Review comment:
   Would we want this to trap ever in which case a __builtin_trap might be 
a trick to play ? 
   
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org