[GitHub] [incubator-tvm] zhiics commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule
zhiics commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557640620 @u99127 I see, thank you. You can find the "button" like this: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/approving-a-pull-request-with-required-reviews This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule
zhiics commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557628079 @u99127 Thanks. Cloud you please explicitly approve if everything looks good to you? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule
zhiics commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557194665 yes. Currently, this is an example that provides a demo to tell people how we can write minimal DSO and JSON style runtime. I think it makes sense to put them under `apps` as then they will show up on the `tvm.ai` website. Or production ready codegen/runtime, we will put it under `src/runtime/contrib` as @tqchen mentioned above. These examples are real code that can be compiled and executed. We will likely add DNNL later on when we update the other PR (#4258). And that one will be under `src/runtime/contrib`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule
zhiics commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-554683974 @tqchen I made a gtest for the simple example JSON runtime. Hopefully, this is good now. Please take a look when you have time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule
zhiics commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-553143166 yes, we don't need to call this as a runtime now. It actually just use DSOModule and CSourceModule. I think @comaniac was asking should we add this example (DSO style external library) first and then move to implement the customized runtime you are mentioning. Never mind, we can work on the customized runtime and update the PR. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
