[GitHub] [incubator-tvm] zhiics commented on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config

2020-05-28 Thread GitBox 


zhiics commented on issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-635745547


   Sounds like a good plan.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] zhiics commented on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config

2020-05-28 Thread GitBox 


zhiics commented on issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-635742328


   One potential problem is that it may break downstream deployment.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] zhiics commented on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config

2020-05-28 Thread GitBox 


zhiics commented on issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-635674079


   I realize we may also want to remove `relay.build_config` and directly use 
PassContext to keep it consistent to tir, but it may invoke a lot of changes. 
@tqchen thoughts? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-tvm] zhiics commented on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config

2020-05-22 Thread GitBox 


zhiics commented on issue #5650:
URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-632751624


   @tqchen Thanks for reminding. I will take a stab next week. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org