[GitHub] [tvm] Hzfengsy commented on pull request #9315: [TensorIR][Tutorial] Blitz course
Hzfengsy commented on pull request #9315: URL: https://github.com/apache/tvm/pull/9315#issuecomment-952546817 All comments are addressed. Let's merge it quickly if there is no more comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on pull request #9315: [TensorIR][Tutorial] Blitz course
Hzfengsy commented on pull request #9315: URL: https://github.com/apache/tvm/pull/9315#issuecomment-950107335 I totally agree with @quic-sanirudh. `T` would be much easier when we do round-trips. And we may move towards it. The only concern is that `T` is a alias of `tir`, which makes no sense without `from tvm.script import tir as T`. So I guess we may print `from tvm.script import tir as T` at the start of script if we want to use `T` (or any other alias different from `tir`) as default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on pull request #9315: [TensorIR][Tutorial] Blitz course
Hzfengsy commented on pull request #9315: URL: https://github.com/apache/tvm/pull/9315#issuecomment-948598593 Updated (together with the demo link). PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on pull request #9315: [TensorIR][Tutorial] Blitz course
Hzfengsy commented on pull request #9315: URL: https://github.com/apache/tvm/pull/9315#issuecomment-947634473 Thanks @areusch @jroesch. I totally agree that more introductory context is helpful. I'm working on it. However, it is the first tutorial of TensorIR for the very beginning users (not for TVM experts). So I won't explain too much technical details in this tutorial (e.g. what's the difference between TE and TensorIR). More developing docs and tutorials are on the way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
