[GitHub] [tvm] echuraev commented on pull request #13868: [OpenCL] Implement save/load pre-compiled programs
echuraev commented on PR #13868: URL: https://github.com/apache/tvm/pull/13868#issuecomment-1413616618 @tqchen could you please review this PR once again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tvm] echuraev commented on pull request #13868: [OpenCL] Implement save/load pre-compiled programs
echuraev commented on PR #13868: URL: https://github.com/apache/tvm/pull/13868#issuecomment-1411804399 @srkreddy1238 Thank you for your review! The idea of caching data looks promising, but I agree with @elvin-n that the TVM should provide only API for serializing objects to binary format but shouldn't work with file system. So user application should be responsible for writing/reading this serialized blob to/from disk. Do you think that caching mechanism should be implemented in this PR? I would prefer to see such implementation in separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tvm] echuraev commented on pull request #13868: [OpenCL] Implement save/load pre-compiled programs
echuraev commented on PR #13868: URL: https://github.com/apache/tvm/pull/13868#issuecomment-1408798038 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tvm] echuraev commented on pull request #13868: [OpenCL] Implement save/load pre-compiled programs
echuraev commented on PR #13868: URL: https://github.com/apache/tvm/pull/13868#issuecomment-1408250085 cc: @tqchen, @csullivan, @srkreddy1238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
