[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-12-06 Thread GitBox 


junrushao1994 commented on pull request #9599:
URL: https://github.com/apache/tvm/pull/9599#issuecomment-987508357


   @leandron Thanks! Submitted a follow-up PR #9662


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-12-03 Thread GitBox 


junrushao1994 commented on pull request #9599:
URL: https://github.com/apache/tvm/pull/9599#issuecomment-985907705


   Would you guys mind if I take over and implement my proposed approach to 
avoid creating dummy objects that lead to messy warnings?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-12-03 Thread GitBox 


junrushao1994 commented on pull request #9599:
URL: https://github.com/apache/tvm/pull/9599#issuecomment-985824643


   @u99127 Yep those warnings are annoying and that’s exactly we need to avoid. 
With my proposal (avoid creating dummy Target objects), these warnings won’t 
pop up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-12-01 Thread GitBox 


junrushao1994 commented on pull request #9599:
URL: https://github.com/apache/tvm/pull/9599#issuecomment-984093437


   Hey what do you think of my proposal? It could completely avoid creating 
dummy targets in TVMC and preserve the warning message :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-11-29 Thread GitBox 


junrushao1994 commented on pull request #9599:
URL: https://github.com/apache/tvm/pull/9599#issuecomment-981978677


   Aha I got it now. Thanks @leandron for the explanation!
   
   The problem could go away if we do not create dummy `Target`s in TVMC if 
users don't specify them explicitly, and to make this happen, we could improve 
the implementation of the API `ListTargetKindOptions`:
   
   
https://github.com/apache/tvm/blob/f32042f98b1948d7be468969d705acc44b9b1cbe/src/target/target_kind.cc#L52-L58
   
   Right now it takes a TargetKind object and returns its `key2vtype_` member. 
And to construct a `TargetKind` object, TVMC has to create dummy Targets and 
then extract its `kind` field.
   
   
https://github.com/apache/tvm/blob/515fc88e71c8df94ed7bd6eae42103f34ac1f570/python/tvm/driver/tvmc/target.py#L56
   
   Alternatively, it's possible to avoid doing so by wrapping it with a method 
that takes a string:
   
   ```C++
   Map ListTargetKindOptions(const String& target_kind_name) {
 return 
TargetKindRegEntry::ListTargetKindOptions(TargetKind::Get(target_kind_name));
   }
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-11-28 Thread GitBox 


junrushao1994 commented on pull request #9599:
URL: https://github.com/apache/tvm/pull/9599#issuecomment-981189740


   Thank you @leandron for the explanation!
   
   > Sure, if you see the example I provide in the initial message, it is 
expected that some machines won’t have a Rocm and/or cuda version - they are 
optional dependencies anyway.
   > For those machines, the user will always see those warning messages, even 
when, for example, they would only want to target CPU with LLVM. This is what I 
meant by it being overly verbose, from the user point of view.
   
   Yeah I agree. Those dependencies like cuda or rocm are optional, and 
creating cuda/rocm targets probably means cross-compilation - in this case, not 
giving specific arch version looks like a bit fishy :-) And I agree that likely 
users just want to generate code for CPU with LLVM.
   
   I'm 100% supportive of improve warning messages for TVMC and the overall TVM 
stack, and probably I don't have all the context, so might ask some really dumb 
questions - Why do these warning messages pop up even if users are not doing 
anything wrong? Is that because does `tvmc --version` constructs some dummy 
targets?
   
   Thanks a lot!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #9599: Adjust warnings from target_kind.cc messages to debug level

2021-11-27 Thread GitBox 


junrushao1994 commented on pull request #9599:
URL: https://github.com/apache/tvm/pull/9599#issuecomment-980778920


   Thanks @leandron for bringing it up! The error message is only supposed to 
appear when user doesn’t supply arch information, and it could not be detected 
in our local environment- which means either the local environment is not set 
up properly, or it’s cross compilation without a clear target arch. Either case 
looks suspicious, and thus we think it’s necessary to provide error message 
explicitly.
   
   Would you like to elaborate when the warning looks unnecessarily verbose? Is 
it in the CI environment?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org