[GitHub] [tvm] masahi edited a comment on pull request #9375: [PyTorch] [Frontend] Add support for 'aten::new_zeros' & 'aten::copy_'

2021-10-26 Thread GitBox 


masahi edited a comment on pull request #9375:
URL: https://github.com/apache/tvm/pull/9375#issuecomment-952485326


   I've tried `index_put` approach before, it is available before PT 1.9. See 
the discussion in 
https://github.com/apache/tvm/pull/7231#issuecomment-756693366. My impression 
back then is that ONNX's approach also doesn't cover 100% of cases. Our PT 
frontend already supports converting `index_put`, so you can try for your model.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tvm] masahi edited a comment on pull request #9375: [PyTorch] [Frontend] Add support for 'aten::new_zeros' & 'aten::copy_'

2021-10-26 Thread GitBox 


masahi edited a comment on pull request #9375:
URL: https://github.com/apache/tvm/pull/9375#issuecomment-952273980


   Please add tests.
   
   Also, we need to discuss `aten::copy_`. There have been many requests to 
support this op and attempts to support it.
   https://github.com/apache/tvm/pull/6472
   https://github.com/apache/tvm/pull/6049
   https://github.com/apache/tvm/pull/7231
   https://github.com/apache/tvm/pull/7513
   
   `aten::copy_` is used purely for in-place mutation purpose, which we don't 
support at all. The naive conversion might work for some cases, but since we 
cannot support 100% of use cases correctly, so far we've decided not to support 
it. Have you verified that the output from `bart-base` is correct after 
converting to TVM?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org