date:20170823

[GitHub] incubator-weex issue #640: * [android] Update DrawableLoader

2017-08-23 Thread weex-bot

Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/640
  




  

  
  Fails

  
  
  :no_entry_sign:
  This PR modify SDK code. Please add/modify corresponding 
testcases. If it is ok, please comment about it. Or put '@notdanger' in you 
commit message.

  




  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  

  :warning:
  This PR should update related documents as well. 

  

  :warning:
  Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/adapter/IDrawableLoader.java without 
metion it in commit message. You'd better add '@notdanger' in your commit log. 


  





  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #640: * [android] Update DrawableLoader

2017-08-23 Thread YorkShen

GitHub user YorkShen opened a pull request:

https://github.com/apache/incubator-weex/pull/640

* [android] Update DrawableLoader



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YorkShen/incubator-weex 
android-feature-drawableLoader

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/640.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #640


commit 72cc65f7e7c43c53716c53009f9a96005a10a65c
Author: YorkShen 
Date:   2017-08-23T09:45:41Z

* [android] Update DrawableLoader

(cherry picked from commit 8e0701f)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[2/2] incubator-weex git commit: Merge remote-tracking branch 'upstream/pr634' into apache-0.16-dev

2017-08-23 Thread misakuo

Merge remote-tracking branch 'upstream/pr634' into apache-0.16-dev


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/61abcdc3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/61abcdc3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/61abcdc3

Branch: refs/heads/0.16-dev
Commit: 61abcdc375b2b386880e29ceaea1f4c866d18d0f
Parents: 365332e 837f033
Author: misakuo 
Authored: Thu Aug 24 10:28:13 2017 +0800
Committer: misakuo 
Committed: Thu Aug 24 10:28:13 2017 +0800

--
 .../main/java/com/taobao/weex/WXSDKInstance.java   | 17 +++--
 1 file changed, 15 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/61abcdc3/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
--

[GitHub] incubator-weex pull request #634: * [android] show alert in debug mode when ...

2017-08-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/634


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #631: * [android] fix crash caused by invalid po...

2017-08-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/631


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[2/2] incubator-weex git commit: Merge remote-tracking branch 'upstream/pr631' into apache-0.16-dev

2017-08-23 Thread misakuo

Merge remote-tracking branch 'upstream/pr631' into apache-0.16-dev


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/365332e9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/365332e9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/365332e9

Branch: refs/heads/0.16-dev
Commit: 365332e9728f17703ea0a0f1a59a9fe4b16fd42a
Parents: bade862 c05cfcb
Author: misakuo 
Authored: Thu Aug 24 10:27:42 2017 +0800
Committer: misakuo 
Committed: Thu Aug 24 10:27:42 2017 +0800

--
 .../main/java/com/taobao/weex/dom/action/TraceableAction.java   | 1 +
 .../com/taobao/weex/ui/component/list/BasicListComponent.java   | 5 +
 2 files changed, 6 insertions(+)
--

[1/2] incubator-weex git commit: * [android] show alert in debug mode when pageName not be set

2017-08-23 Thread misakuo

Repository: incubator-weex
Updated Branches:
  refs/heads/0.16-dev 365332e97 -> 61abcdc37


* [android] show alert in debug mode when pageName not be set


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/837f033c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/837f033c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/837f033c

Branch: refs/heads/0.16-dev
Commit: 837f033c6898f484efa77bb9c4271e90a5868c7c
Parents: 41ce0f6
Author: misakuo 
Authored: Wed Aug 23 11:46:45 2017 +0800
Committer: misakuo 
Committed: Wed Aug 23 11:46:45 2017 +0800

--
 .../main/java/com/taobao/weex/WXSDKInstance.java   | 17 +++--
 1 file changed, 15 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/837f033c/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
--
diff --git a/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java 
b/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
index 1c2877a..de68c64 100644
--- a/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
+++ b/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
@@ -18,6 +18,7 @@
  */
 package com.taobao.weex;
 
+import android.app.AlertDialog;
 import android.content.Context;
 import android.content.Intent;
 import android.content.IntentFilter;
@@ -398,8 +399,18 @@ public class WXSDKInstance implements 
IWXActivityStateListener,DomContext, View.
*/
   public void render(String pageName, String template, Map 
options, String jsonInitData, WXRenderStrategy flag) {
 if(WXEnvironment.isApkDebugable() && 
WXPerformance.DEFAULT.equals(pageName)){
-   WXLogUtils.e("Please set your pageName or your js bundle url !!!");
-   return;
+  WXLogUtils.e("WXSDKInstance", "Please set your pageName or your js 
bundle url !!!");
+
+  if (getUIContext() != null) {
+new AlertDialog.Builder(getUIContext())
+.setTitle("Error: Missing pageName")
+.setMessage("We highly recommend you to set pageName. Call" +
+"\nWXSDKInstance#render(String pageName, String template, 
Map options, String jsonInitData, WXRenderStrategy flag)\n" +
+"to fix it.")
+.show();
+  }
+
+  return;
 }
 renderInternal(pageName,template,options,jsonInitData,flag);
   }
@@ -423,6 +434,8 @@ public class WXSDKInstance implements 
IWXActivityStateListener,DomContext, View.
   return;
 }
 
+WXLogUtils.d("WXSDKInstance", "Start render page: " + pageName);
+
 if (WXTracing.isAvailable()) {
   WXTracing.TraceEvent traceEvent = WXTracing.newEvent("executeBundleJS", 
mInstanceId, -1);
   traceEvent.traceId = mExecJSTraceId;

[1/2] incubator-weex git commit: * [android] fix crash caused by invalid position

2017-08-23 Thread misakuo

Repository: incubator-weex
Updated Branches:
  refs/heads/0.16-dev bade86257 -> 365332e97


* [android] fix crash caused by invalid position


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/c05cfcb8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/c05cfcb8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/c05cfcb8

Branch: refs/heads/0.16-dev
Commit: c05cfcb84e8d57139e51895a76cd5d880a407f61
Parents: 6b782f6
Author: misakuo 
Authored: Tue Aug 22 15:29:35 2017 +0800
Committer: misakuo 
Committed: Tue Aug 22 15:29:35 2017 +0800

--
 .../main/java/com/taobao/weex/dom/action/TraceableAction.java   | 1 +
 .../com/taobao/weex/ui/component/list/BasicListComponent.java   | 5 +
 2 files changed, 6 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/c05cfcb8/android/sdk/src/main/java/com/taobao/weex/dom/action/TraceableAction.java
--
diff --git 
a/android/sdk/src/main/java/com/taobao/weex/dom/action/TraceableAction.java 
b/android/sdk/src/main/java/com/taobao/weex/dom/action/TraceableAction.java
index 5bd2689..c4cc59a 100644
--- a/android/sdk/src/main/java/com/taobao/weex/dom/action/TraceableAction.java
+++ b/android/sdk/src/main/java/com/taobao/weex/dom/action/TraceableAction.java
@@ -67,6 +67,7 @@ public class TraceableAction {
   mBeginEvent.name = type;
   mBeginEvent.payload = payload;
   mBeginEvent.parseJsonTime = Stopwatch.nanosToMillis(mParseJsonNanos);
+  mBeginEvent.tname = "JSThread";
   mBeginEvent.submit();
 }
   }

http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/c05cfcb8/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
--
diff --git 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
index c7c0bb6..7833cbf 100644
--- 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
+++ 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
@@ -520,6 +520,11 @@ public abstract class BasicListComponent

[2/2] incubator-weex git commit: Merge remote-tracking branch 'upstream/pr627' into apache-0.16-dev

2017-08-23 Thread misakuo

Merge remote-tracking branch 'upstream/pr627' into apache-0.16-dev


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/bade8625
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/bade8625
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/bade8625

Branch: refs/heads/0.16-dev
Commit: bade862570aa755df2ef3a6a57e291644d6166fb
Parents: 849ed3e 5e339e3
Author: misakuo 
Authored: Thu Aug 24 10:27:10 2017 +0800
Committer: misakuo 
Committed: Thu Aug 24 10:27:10 2017 +0800

--
 .../java/com/taobao/weex/ui/component/AbstractEditComponent.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
--

[GitHub] incubator-weex pull request #627: * [android] fix wrong setting font size

2017-08-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/627


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[1/2] incubator-weex git commit: * [android] fix wrong setting font size

2017-08-23 Thread misakuo

Repository: incubator-weex
Updated Branches:
  refs/heads/0.16-dev 849ed3eb7 -> bade86257


* [android] fix wrong setting font size


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/5e339e35
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/5e339e35
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/5e339e35

Branch: refs/heads/0.16-dev
Commit: 5e339e35f323756c6d2cf4a1145731085149c16f
Parents: 6b782f6
Author: misakuo 
Authored: Tue Aug 22 11:21:15 2017 +0800
Committer: misakuo 
Committed: Tue Aug 22 11:21:15 2017 +0800

--
 .../java/com/taobao/weex/ui/component/AbstractEditComponent.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/5e339e35/android/sdk/src/main/java/com/taobao/weex/ui/component/AbstractEditComponent.java
--
diff --git 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/AbstractEditComponent.java
 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/AbstractEditComponent.java
index 179b179..a8d1963 100644
--- 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/AbstractEditComponent.java
+++ 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/AbstractEditComponent.java
@@ -456,7 +456,9 @@ public abstract class AbstractEditComponent extends 
WXComponent {
   @WXComponentProp(name = Constants.Name.FONT_SIZE)
   public void setFontSize(String fontSize) {
 if (getHostView() != null && fontSize != null ) {
-  getHostView().setTextSize(TypedValue.COMPLEX_UNIT_PX, 
WXStyle.getFontSize(getDomObject().getStyles(),getInstance().getInstanceViewPortWidth()));
+  Map map = new HashMap<>(1);
+  map.put(Constants.Name.FONT_SIZE, fontSize);
+  getHostView().setTextSize(TypedValue.COMPLEX_UNIT_PX, 
WXStyle.getFontSize(map, getInstance().getInstanceViewPortWidth()));
 }
   }

[GitHub] incubator-weex issue #639: Fix typo in involved

2017-08-23 Thread misakuo

Github user misakuo commented on the issue:

https://github.com/apache/incubator-weex/pull/639
  
Thanks for your contribution


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

incubator-weex git commit: Fix typo in involved

2017-08-23 Thread misakuo

Repository: incubator-weex
Updated Branches:
  refs/heads/dev a7f8c310a -> 9eda7b7e4


Fix typo in involved

Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/9eda7b7e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/9eda7b7e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/9eda7b7e

Branch: refs/heads/dev
Commit: 9eda7b7e454faf10f541bd3877e8dcd80345cc03
Parents: a7f8c31
Author: Adam Altman 
Authored: Wed Aug 23 13:33:26 2017 -0500
Committer: GitHub 
Committed: Wed Aug 23 13:33:26 2017 -0500

--
 doc/themes/weex/languages/en.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/9eda7b7e/doc/themes/weex/languages/en.yml
--
diff --git a/doc/themes/weex/languages/en.yml b/doc/themes/weex/languages/en.yml
index 12cec69..f0e5270 100644
--- a/doc/themes/weex/languages/en.yml
+++ b/doc/themes/weex/languages/en.yml
@@ -90,7 +90,7 @@ menu:
   download: Download
   resources: Resources
   tools: Tools
-  invovled: Get Invovled
+  invovled: Get Involved
   advanced: Advanced
   github: GitHub
   legacy: Old Syntax Doc

[GitHub] incubator-weex pull request #639: Fix typo in involved

2017-08-23 Thread adamaltman

GitHub user adamaltman opened a pull request:

https://github.com/apache/incubator-weex/pull/639

Fix typo in involved

Fix a small typo.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adamaltman/incubator-weex patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/639.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #639


commit 9eda7b7e454faf10f541bd3877e8dcd80345cc03
Author: Adam Altman 
Date:   2017-08-23T18:33:26Z

Fix typo in involved




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #638: [jsfm] release weex-js-framework@0.21.11

2017-08-23 Thread weex-bot

Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/638
  




  

  
  Fails

  
  
  :no_entry_sign:
  Code file html5/test/case/complex/component-append-tree.output.js 
does not have the copyright header.

  

  :no_entry_sign:
  Code file html5/test/case/complex/component-append-tree.source.js 
does not have the copyright header.

  




  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  

  :warning:
  These new JS files do not have Flow enabled: 
html5/test/case/complex/component-append-tree.output.js, 
html5/test/case/complex/component-append-tree.source.js

  

  :warning:
  This PR should update related documents as well. 

  





  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #638: [jsfm] release weex-js-framework@0.21.11

2017-08-23 Thread Hanks10100

GitHub user Hanks10100 opened a pull request:

https://github.com/apache/incubator-weex/pull/638

[jsfm] release weex-js-framework@0.21.11

## Change log

+ [rax] Upgrade `weex-rax-framework` to *0.4.11*.
+ [rax] Support to use js service in Rax DSL.
+ [legacy] Fix the unknown differ depth bug in legacy .we framework.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Hanks10100/incubator-weex jsfm-feature-0.21

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #638


commit 4accea5ed865a6accb4ffcf297cb20724892e201
Author: Hanks 
Date:   2017-08-16T14:51:07Z

* [jsfm] upgrade weex-rax-framework to v0.4.10

commit faca5562b8f595e0f95693f35757b6d04ae71b9f
Author: Hanks 
Date:   2017-08-17T04:37:13Z

* [jsfm] release v0.21.10

commit 296ac477922814c800ad42aa208ed895e1b12d4b
Author: Hanks 
Date:   2017-08-23T07:33:15Z

+ [test] add test case for using append tree in child components

commit f7a1805ce0c889a221cb43fd42b530da09ccd67f
Author: Hanks 
Date:   2017-08-23T07:35:48Z

* [jsfm] fix the unknown depth in the differ of legacy framework

commit a1136da36d4947523b1ac7f29ad43baaf374a051
Author: Hanks 
Date:   2017-08-23T07:37:48Z

* [jsfm] upgrade weex-rax-framework to v0.4.11

commit 90fac505195151f19e2afc4e5f283a4391ddd3de
Author: Hanks 
Date:   2017-08-23T07:59:04Z

* [jsfm] release v0.21.11




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #637: 0.16 dev fix 1px scroll load more offset

2017-08-23 Thread weex-bot

Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/637
  





  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  

  :warning:
  This PR modify SDK code without add/modify testcases.

  

  :warning:
  This PR should update related documents as well. 

  





  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #637: 0.16 dev fix 1px scroll load more offset

2017-08-23 Thread gubaojian

GitHub user gubaojian opened a pull request:

https://github.com/apache/incubator-weex/pull/637

0.16 dev fix 1px scroll load more offset

1.fix 1px fallback background
2.scroll offset handler
3.default load more offset 0, can load more

@notdanger

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gubaojian/incubator-weex 
0.16-dev-fix-1px-scroll

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/637.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #637


commit d8273ab2a80ee5e0b1ecf901856d450b6c740636
Author: codefurture 
Date:   2017-08-23T05:55:51Z

Merge pull request #1 from apache/0.16-dev

sync from weex 0.16 dev

commit 67c3dafd9223e2a657b66fd8a24f5bd126c9c28d
Author: jianbai.gbj 
Date:   2017-08-23T08:12:28Z

fix 1px and scroll

commit d921e009e81ccdea6abd39f1c96b08ca8d0f1e9e
Author: jianbai.gbj 
Date:   2017-08-23T08:19:20Z

load more offset bug fix




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

incubator-weex git commit: * [android] Refactor the code of resize attr on image.

2017-08-23 Thread kyork

Repository: incubator-weex
Updated Branches:
  refs/heads/0.16-dev 4025b5b36 -> 849ed3eb7


* [android] Refactor the code of resize attr on image.

The "resize" attribute on image doesn't depend on ImageView.setScaleType any 
longer, BitmapShader can do all the work.

* [android] Update WXImage


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/849ed3eb
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/849ed3eb
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/849ed3eb

Branch: refs/heads/0.16-dev
Commit: 849ed3eb76fc5cf64065d5f8834cc5be3fa4f20c
Parents: 4025b5b
Author: YorkShen 
Authored: Tue Aug 22 11:37:04 2017 +0800
Committer: YorkShen 
Committed: Wed Aug 23 16:06:36 2017 +0800

--
 .../commons/adapter/FrescoImageComponent.java   |  2 +-
 .../com/taobao/weex/ui/component/WXImage.java   | 75 ++--
 .../com/taobao/weex/ui/view/WXImageView.java| 16 -
 .../com/taobao/weex/utils/ImageDrawable.java| 17 ++---
 4 files changed, 56 insertions(+), 54 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/849ed3eb/android/commons/src/main/java/com/alibaba/weex/commons/adapter/FrescoImageComponent.java
--
diff --git 
a/android/commons/src/main/java/com/alibaba/weex/commons/adapter/FrescoImageComponent.java
 
b/android/commons/src/main/java/com/alibaba/weex/commons/adapter/FrescoImageComponent.java
index 109302f..8573e8a 100644
--- 
a/android/commons/src/main/java/com/alibaba/weex/commons/adapter/FrescoImageComponent.java
+++ 
b/android/commons/src/main/java/com/alibaba/weex/commons/adapter/FrescoImageComponent.java
@@ -38,7 +38,7 @@ public class FrescoImageComponent extends WXImage {
   @Override
   protected ImageView initComponentHostView(@NonNull Context context) {
 FrescoImageView view = new FrescoImageView(context);
-view.setScaleType(ImageView.ScaleType.FIT_XY);
+view.setScaleType(WXImage.DEFAULT_SCALE_TYPE);
 
 return view;
   }

http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/849ed3eb/android/sdk/src/main/java/com/taobao/weex/ui/component/WXImage.java
--
diff --git 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXImage.java 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXImage.java
index db58d99..8fda814 100644
--- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXImage.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXImage.java
@@ -31,7 +31,6 @@ import android.support.v4.content.ContextCompat;
 import android.text.TextUtils;
 import android.widget.ImageView;
 import android.widget.ImageView.ScaleType;
-
 import com.taobao.weex.WXEnvironment;
 import com.taobao.weex.WXSDKInstance;
 import com.taobao.weex.adapter.IWXImgLoaderAdapter;
@@ -51,12 +50,11 @@ import com.taobao.weex.ui.view.border.BorderDrawable;
 import com.taobao.weex.utils.ImageDrawable;
 import com.taobao.weex.utils.ImgURIUtil;
 import com.taobao.weex.utils.SingleFunctionParser;
-import com.taobao.weex.utils.WXViewToImageUtil;
 import com.taobao.weex.utils.WXDomUtils;
 import com.taobao.weex.utils.WXLogUtils;
 import com.taobao.weex.utils.WXUtils;
+import com.taobao.weex.utils.WXViewToImageUtil;
 import com.taobao.weex.utils.WXViewUtils;
-
 import java.lang.reflect.InvocationTargetException;
 import java.util.Arrays;
 import java.util.HashMap;
@@ -71,6 +69,7 @@ public class WXImage extends WXComponent {
 
   public static final String SUCCEED = "success";
   public static final String ERRORDESC = "errorDesc";
+  public final static ScaleType DEFAULT_SCALE_TYPE = ScaleType.FIT_XY;
 
   private String mSrc;
   private int mBlurRadius;
@@ -102,7 +101,7 @@ public class WXImage extends WXComponent {
   @Override
   protected ImageView initComponentHostView(@NonNull Context context) {
 WXImageView view = new WXImageView(context);
-view.setScaleType(ScaleType.FIT_XY);
+view.setScaleType(DEFAULT_SCALE_TYPE);
 if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) {
   view.setCropToPadding(true);
 }
@@ -153,32 +152,23 @@ public class WXImage extends WXComponent {
 
   @WXComponentProp(name = Constants.Name.RESIZE_MODE)
   public void setResizeMode(String resizeMode) {
-(getHostView()).setScaleType(getResizeMode(resizeMode));
-  }
-
-  private ScaleType getResizeMode(String resizeMode) {
-ScaleType scaleType = ScaleType.FIT_XY;
-if (TextUtils.isEmpty(resizeMode)) {
-  return scaleType;
-}
-
-switch (resizeMode) {
-  case "cover":
-scaleType = ScaleType.CENTER_CROP;
-break;
-  case "contain":
-scaleType =

[GitHub] incubator-weex pull request #628: * [android] Refactor the code of resize at...

2017-08-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/628


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #636: Weexjsc multiprocess

2017-08-23 Thread yuhun-alibaba

GitHub user yuhun-alibaba opened a pull request:

https://github.com/apache/incubator-weex/pull/636

Weexjsc multiprocess

* [android] add for jsc multi process architecture, will run normal on jsc 
sigle process architecture
 1. if jsc process exception and crash will report and record relevant 
crash log on /cache/jsserver_crash/***info.log
 2. if jsc process exception and crash will reinit framework and record 
reinit result
 3. if jsc process exception and crash will restart it and reload 
current Weex page
 4. use UT upload jsc process exception and crash log
 5. if jsc process exception and crash will notify playground reload 
MainActivity

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yuhun-alibaba/incubator-weex 0.16-dev

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/636.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #636


commit 9dd199aeb18e967338d0b2a1e4a4070cb59e826e
Author: å¾¡é 
Date:   2017-08-22T15:11:14Z

 * [android] add for jsc multi process architecture, will run normal on jsc 
sigle process architecture
 1. if jsc process exception and crash will report and record relevant 
crash log on /cache/jsserver_crash/***info.log
 2. if jsc process exception and crash will reinit framework and record 
reinit result
 3. if jsc process exception and crash will restart it and reload current 
Weex page
 4. use UT upload jsc process exception and crash log
 5. if jsc process exception and crash will notify playground reload 
MainActivity

commit 048661b7289f6fb4ff7394f33f3af6670b7d3bc2
Author: å¾¡é 
Date:   2017-08-23T04:57:18Z

* [android] update libweexjsc.so, jsc will run on a process alone




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #635: * [android] fix NPE on reading bundle data size

2017-08-23 Thread weex-bot

Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/635
  




  

  
  Fails

  
  
  :no_entry_sign:
  This PR modify SDK code. Please add/modify corresponding 
testcases. If it is ok, please comment about it. Or put '@notdanger' in you 
commit message.

  




  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  

  :warning:
  This PR should update related documents as well. 

  





  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

incubator-weex git commit: * [android] fix NPE on reading bundle data size

2017-08-23 Thread misakuo

Repository: incubator-weex
Updated Branches:
  refs/heads/0.16-dev 41ce0f6c4 -> 4025b5b36


* [android] fix NPE on reading bundle data size


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/4025b5b3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/4025b5b3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/4025b5b3

Branch: refs/heads/0.16-dev
Commit: 4025b5b36b13fbf35cd16dc1acf45ad7180f5f2c
Parents: 41ce0f6
Author: misakuo 
Authored: Wed Aug 23 15:33:32 2017 +0800
Committer: misakuo 
Committed: Wed Aug 23 15:33:32 2017 +0800

--
 android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/4025b5b3/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
--
diff --git a/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java 
b/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
index 1c2877a..73c32ee 100644
--- a/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
+++ b/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
@@ -1564,7 +1564,9 @@ public class WXSDKInstance implements 
IWXActivityStateListener,DomContext, View.
 event.tname = "Network";
 event.ph = "E";
 event.extParams = new HashMap<>();
-event.extParams.put("BundleSize", response.originalData.length);
+if (response != null && response.originalData != null) {
+  event.extParams.put("BundleSize", response.originalData.length);
+}
 event.submit();
   }

[GitHub] incubator-weex pull request #635: * [android] fix NPE on reading bundle data...

2017-08-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/635


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #635: * [android] fix NPE on reading bundle data...

2017-08-23 Thread misakuo

GitHub user misakuo opened a pull request:

https://github.com/apache/incubator-weex/pull/635

* [android] fix NPE on reading bundle data size

as title

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/misakuo/incubator-weex 
android-bugfix-tracing-npe

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/635.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #635


commit 4025b5b36b13fbf35cd16dc1acf45ad7180f5f2c
Author: misakuo 
Date:   2017-08-23T07:33:32Z

* [android] fix NPE on reading bundle data size




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #640: * [android] Update DrawableLoader

[GitHub] incubator-weex pull request #640: * [android] Update DrawableLoader

[2/2] incubator-weex git commit: Merge remote-tracking branch 'upstream/pr634' into apache-0.16-dev

[GitHub] incubator-weex pull request #634: * [android] show alert in debug mode when ...

[GitHub] incubator-weex pull request #631: * [android] fix crash caused by invalid po...

[2/2] incubator-weex git commit: Merge remote-tracking branch 'upstream/pr631' into apache-0.16-dev

[1/2] incubator-weex git commit: * [android] show alert in debug mode when pageName not be set

[1/2] incubator-weex git commit: * [android] fix crash caused by invalid position

[2/2] incubator-weex git commit: Merge remote-tracking branch 'upstream/pr627' into apache-0.16-dev

[GitHub] incubator-weex pull request #627: * [android] fix wrong setting font size

[1/2] incubator-weex git commit: * [android] fix wrong setting font size

[GitHub] incubator-weex issue #639: Fix typo in involved

incubator-weex git commit: Fix typo in involved

[GitHub] incubator-weex pull request #639: Fix typo in involved

[GitHub] incubator-weex issue #638: [jsfm] release weex-js-framework@0.21.11

[GitHub] incubator-weex pull request #638: [jsfm] release weex-js-framework@0.21.11

[GitHub] incubator-weex issue #637: 0.16 dev fix 1px scroll load more offset

[GitHub] incubator-weex pull request #637: 0.16 dev fix 1px scroll load more offset

incubator-weex git commit: * [android] Refactor the code of resize attr on image.

[GitHub] incubator-weex pull request #628: * [android] Refactor the code of resize at...

[GitHub] incubator-weex pull request #636: Weexjsc multiprocess

[GitHub] incubator-weex issue #635: * [android] fix NPE on reading bundle data size

incubator-weex git commit: * [android] fix NPE on reading bundle data size

[GitHub] incubator-weex pull request #635: * [android] fix NPE on reading bundle data...

[GitHub] incubator-weex pull request #635: * [android] fix NPE on reading bundle data...

25 matches

Site Navigation

Mail list logo

Footer information