[GitHub] incubator-weex pull request #662: * [android] fix the memory leak caused by ...

2017-08-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/662


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #662: * [android] fix the memory leak caused by Broadca...

2017-08-28 Thread weex-bot 
Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/662
  





  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  

  :warning:
  This PR should update related documents as well. 

  




  

  
  Messages

  
  
  :book:
  According to the blame info, we recommended @luics , @zshshr to 
be the reviewers.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

incubator-weex git commit: * [android] fix the memory leak caused by BroadcastReceiver

2017-08-28 Thread misakuo 
Repository: incubator-weex
Updated Branches:
  refs/heads/0.16-dev 9684dcd75 -> 87c06c5f1


* [android] fix the memory leak caused by BroadcastReceiver


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/87c06c5f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/87c06c5f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/87c06c5f

Branch: refs/heads/0.16-dev
Commit: 87c06c5f1fd208745c53f725ede50bd573618c89
Parents: 9684dcd
Author: misakuo 
Authored: Tue Aug 29 13:44:37 2017 +0800
Committer: misakuo 
Committed: Tue Aug 29 13:44:37 2017 +0800

--
 .../com/taobao/weex/ui/component/WXText.java| 25 +---
 .../taobao/weex/ui/component/WXVContainer.java  |  6 +
 2 files changed, 23 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/87c06c5f/android/sdk/src/main/java/com/taobao/weex/ui/component/WXText.java
--
diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXText.java 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXText.java
index 59e81fb..aad2bf4 100644
--- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXText.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXText.java
@@ -27,6 +27,7 @@ import android.support.v4.content.LocalBroadcastManager;
 import android.text.Layout;
 import android.view.ViewGroup;
 
+import com.taobao.weex.WXEnvironment;
 import com.taobao.weex.WXSDKInstance;
 import com.taobao.weex.annotation.Component;
 import com.taobao.weex.common.Constants;
@@ -162,16 +163,23 @@ public class WXText extends WXComponent {
   @Override
   public void destroy() {
 super.destroy();
-if (getContext() != null && mTypefaceObserver != null) {
-  
LocalBroadcastManager.getInstance(getContext()).unregisterReceiver(mTypefaceObserver);
+if (WXEnvironment.getApplication() != null && mTypefaceObserver != null) {
+  WXLogUtils.d("WXText", "Unregister the typeface observer");
+  
LocalBroadcastManager.getInstance(WXEnvironment.getApplication()).unregisterReceiver(mTypefaceObserver);
+  mTypefaceObserver = null;
 }
   }
 
   private void registerTypefaceObserver(String desiredFontFamily) {
-if (getContext() == null) {
-  WXLogUtils.w("WXText", "Content is null on register typeface observer");
+if (WXEnvironment.getApplication() == null) {
+  WXLogUtils.w("WXText", "ApplicationContent is null on register typeface 
observer");
+  return;
 }
 mFontFamily = desiredFontFamily;
+if (mTypefaceObserver != null) {
+  return;
+}
+
 mTypefaceObserver = new BroadcastReceiver() {
   @Override
   public void onReceive(Context context, Intent intent) {
@@ -181,20 +189,21 @@ public class WXText extends WXComponent {
 }
 
 FontDO fontDO = TypefaceUtil.getFontDO(fontFamily);
-if (fontDO != null && fontDO.getTypeface() != null) {
-  Layout layout = getHostView().getTextLayout();
+if (fontDO != null && fontDO.getTypeface() != null && getHostView() != 
null) {
+  WXTextView hostView = getHostView();
+  Layout layout = hostView.getTextLayout();
   if (layout != null) {
 layout.getPaint().setTypeface(fontDO.getTypeface());
 WXLogUtils.d("WXText", "Apply font family " + fontFamily + " to 
paint");
   } else {
 WXLogUtils.w("WXText", "Layout not created");
   }
-  getHostView().invalidate();
+  hostView.invalidate();
 }
 WXLogUtils.d("WXText", "Font family " + fontFamily + " is available");
   }
 };
 
-
LocalBroadcastManager.getInstance(getContext()).registerReceiver(mTypefaceObserver,
 new IntentFilter(TypefaceUtil.ACTION_TYPE_FACE_AVAILABLE));
+
LocalBroadcastManager.getInstance(WXEnvironment.getApplication()).registerReceiver(mTypefaceObserver,
 new IntentFilter(TypefaceUtil.ACTION_TYPE_FACE_AVAILABLE));
   }
 }

http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/87c06c5f/android/sdk/src/main/java/com/taobao/weex/ui/component/WXVContainer.java
--
diff --git 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXVContainer.java 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXVContainer.java
index 871b18a..f769c2a 100644
--- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXVContainer.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXVContainer.java
@@ -19,6 +19,7 @@
 package com.taobao.weex.ui.component;
 
 import android.content.Intent;
+import android.support.annotation.Nullable;
 import

[GitHub] incubator-weex pull request #662: * [android] fix the memory leak caused by ...

2017-08-28 Thread misakuo 
GitHub user misakuo opened a pull request:

https://github.com/apache/incubator-weex/pull/662

* [android] fix the memory leak caused by BroadcastReceiver



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/misakuo/incubator-weex 
android-bugfix-text-memory-leaked

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/662.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #662


commit 87c06c5f1fd208745c53f725ede50bd573618c89
Author: misakuo 
Date:   2017-08-29T05:44:37Z

* [android] fix the memory leak caused by BroadcastReceiver




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #661: + [ios] distinguish the global pretender a...

2017-08-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/661


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[2/3] incubator-weex git commit: + [ios] add description @notdanger

2017-08-28 Thread acton393 
+ [ios] add description @notdanger


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/09fc591b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/09fc591b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/09fc591b

Branch: refs/heads/0.16-dev
Commit: 09fc591b5963a0b15511ffab2fe95fee69142637
Parents: e939607
Author: 齐山 
Authored: Tue Aug 29 13:13:48 2017 +0800
Committer: 齐山 
Committed: Tue Aug 29 13:13:48 2017 +0800

--
 ios/sdk/WeexSDK/Sources/Module/WXPrerenderManager.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/09fc591b/ios/sdk/WeexSDK/Sources/Module/WXPrerenderManager.m
--
diff --git a/ios/sdk/WeexSDK/Sources/Module/WXPrerenderManager.m 
b/ios/sdk/WeexSDK/Sources/Module/WXPrerenderManager.m
index 07f26a6..d7d51bd 100644
--- a/ios/sdk/WeexSDK/Sources/Module/WXPrerenderManager.m
+++ b/ios/sdk/WeexSDK/Sources/Module/WXPrerenderManager.m
@@ -41,7 +41,7 @@ static NSString *const MSG_PRERENDER_SUCCESS = @"success";
 @property (nonatomic, assign) WXState state;
 @property (nonatomic, strong) NSDate *beginDate;
 @property (nonatomic) long long cacheTime;
-@property (nonatomic) BOOL isCache;  // if set cache , cachetime is no use
+@property (nonatomic) BOOL isCache;  // if set cache , the cachetime is no use.
 
 @end
 @implementation WXPrerenderTask

[3/3] incubator-weex git commit: Merge branch '0.16-dev' of https://github.com/kfeagle/incubator-weex into wip-us-0.16-dev

2017-08-28 Thread acton393 
Merge branch '0.16-dev' of https://github.com/kfeagle/incubator-weex into 
wip-us-0.16-dev


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/9684dcd7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/9684dcd7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/9684dcd7

Branch: refs/heads/0.16-dev
Commit: 9684dcd75c22f98a9a9ccea209149956e0d227f7
Parents: 88ae8eb 09fc591
Author: acton393 
Authored: Tue Aug 29 13:26:45 2017 +0800
Committer: acton393 
Committed: Tue Aug 29 13:26:45 2017 +0800

--
 .../Sources/Controller/WXBaseViewController.m   |  4 +-
 ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m   |  4 +-
 .../WeexSDK/Sources/Module/WXPrerenderManager.h | 15 +
 .../WeexSDK/Sources/Module/WXPrerenderManager.m | 62 
 4 files changed, 71 insertions(+), 14 deletions(-)
--

[1/3] incubator-weex git commit: + [ios] distinguish the global pretender and user pretender

2017-08-28 Thread acton393 
Repository: incubator-weex
Updated Branches:
  refs/heads/0.16-dev 88ae8eb96 -> 9684dcd75


+ [ios] distinguish the global pretender and user pretender


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/e939607a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/e939607a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/e939607a

Branch: refs/heads/0.16-dev
Commit: e939607a98d8ffcdc7af7e747a753350003aa8d1
Parents: 364a40c
Author: 齐山 
Authored: Tue Aug 29 13:09:43 2017 +0800
Committer: 齐山 
Committed: Tue Aug 29 13:09:43 2017 +0800

--
 .../Sources/Controller/WXBaseViewController.m   |  4 +-
 ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m   |  4 +-
 .../WeexSDK/Sources/Module/WXPrerenderManager.h | 15 +
 .../WeexSDK/Sources/Module/WXPrerenderManager.m | 62 
 4 files changed, 71 insertions(+), 14 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/e939607a/ios/sdk/WeexSDK/Sources/Controller/WXBaseViewController.m
--
diff --git a/ios/sdk/WeexSDK/Sources/Controller/WXBaseViewController.m 
b/ios/sdk/WeexSDK/Sources/Controller/WXBaseViewController.m
index 1c90b1e..c49d4a8 100644
--- a/ios/sdk/WeexSDK/Sources/Controller/WXBaseViewController.m
+++ b/ios/sdk/WeexSDK/Sources/Controller/WXBaseViewController.m
@@ -120,7 +120,7 @@
 }
 
 [_instance destroyInstance];
-if([WXPrerenderManager isTaskExist:[self.sourceURL absoluteString]]){
+if([WXPrerenderManager isTaskReady:[self.sourceURL absoluteString]]){
 _instance = [WXPrerenderManager 
instanceFromUrl:self.sourceURL.absoluteString];
 }
 
@@ -154,7 +154,7 @@
 [weakSelf _updateInstanceState:WeexInstanceAppear];
 };
 
-if([WXPrerenderManager isTaskExist:[self.sourceURL absoluteString]]){
+if([WXPrerenderManager isTaskReady:[self.sourceURL absoluteString]]){
 WX_MONITOR_INSTANCE_PERF_START(WXPTJSDownload, _instance);
 WX_MONITOR_INSTANCE_PERF_END(WXPTJSDownload, _instance);
 WX_MONITOR_INSTANCE_PERF_START(WXPTFirstScreenRender, _instance);

http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/e939607a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
--
diff --git a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m 
b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
index 0a6fe11..2e13dbb 100644
--- a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
+++ b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
@@ -349,7 +349,6 @@ typedef enum : NSUInteger {
 {
 NSString *url = @"";
 if([WXPrerenderManager isTaskExist:[self.scriptURL absoluteString]]) {
-[WXPrerenderManager removePrerenderTaskforUrl:[self.scriptURL 
absoluteString]];
 url = [self.scriptURL absoluteString];
 }
 if (!self.instanceId) {
@@ -357,6 +356,7 @@ typedef enum : NSUInteger {
 return;
 }
 
+[WXPrerenderManager removePrerenderTaskforUrl:[self.scriptURL 
absoluteString]];
 [WXPrerenderManager destroyTask:self.instanceId];
 
 [[WXSDKManager bridgeMgr] destroyInstance:self.instanceId];
@@ -373,7 +373,7 @@ typedef enum : NSUInteger {
 });
 });
 if(url.length > 0){
-[WXPrerenderManager addTask:url instanceId:@"" callback:nil];
+[WXPrerenderManager addGlobalTask:url callback:nil];
 }
 }
 

http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/e939607a/ios/sdk/WeexSDK/Sources/Module/WXPrerenderManager.h
--
diff --git a/ios/sdk/WeexSDK/Sources/Module/WXPrerenderManager.h 
b/ios/sdk/WeexSDK/Sources/Module/WXPrerenderManager.h
index c763b57..62e83e9 100644
--- a/ios/sdk/WeexSDK/Sources/Module/WXPrerenderManager.h
+++ b/ios/sdk/WeexSDK/Sources/Module/WXPrerenderManager.h
@@ -39,12 +39,27 @@
 + (void) addTask:(NSString *) url instanceId:(NSString *)instanceId 
callback:(WXModuleCallback)callback;
 
 /**
+ *  @abstract add prerender task
+ *
+ *  @param url The prerender url string
+ *
+ *  @param callback  the module method callback
+ *
+ **/
++ (void) addGlobalTask:(NSString *) url callback:(WXModuleCallback)callback;
+
+/**
  *  @abstract Returns true if url is exist in task .
  *
  **/
 + (BOOL) isTaskExist:(NSString *)url;
 
 /**
+ *  @abstract Returns true if task ready.
+ *
+ **/
++ (BOOL)isTaskReady:(NSString *)url;
+/**
  *  @abstract Returns key from url .
  *
  **/

http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/e939607a/ios/sdk/WeexSDK/Sources/Module/WXPrerenderManager.m
--
diff --git

[GitHub] incubator-weex issue #661: + [ios] distinguish the global pretender and user...

2017-08-28 Thread weex-bot 
Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/661
  





  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  

  :warning:
  This PR modify SDK code without add/modify testcases.

  

  :warning:
  This PR should update related documents as well. 

  




  

  
  Messages

  
  
  :book:
  According to the blame info, we recommended @boboning , @cxfeng1 
to be the reviewers.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #661: 0.16 dev

2017-08-28 Thread kfeagle 
GitHub user kfeagle opened a pull request:

https://github.com/apache/incubator-weex/pull/661

0.16 dev

+ [ios] distinguish the global pretender and user pretender

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kfeagle/incubator-weex 0.16-dev

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/661.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #661


commit e939607a98d8ffcdc7af7e747a753350003aa8d1
Author: 齐山 
Date:   2017-08-29T05:09:43Z

+ [ios] distinguish the global pretender and user pretender

commit 09fc591b5963a0b15511ffab2fe95fee69142637
Author: 齐山 
Date:   2017-08-29T05:13:48Z

+ [ios] add description @notdanger




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #660: * [android] fix the IndexOutOfBoundsExcept...

2017-08-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/660


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #660: * [android] fix the IndexOutOfBoundsException

2017-08-28 Thread weex-bot 
Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/660
  





  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  

  :warning:
  This PR should update related documents as well. 

  




  

  
  Messages

  
  
  :book:
  According to the blame info, we recommended @undefined to be the 
reviewers.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

incubator-weex git commit: * [android] fix the IndexOutOfBoundsException

2017-08-28 Thread misakuo 
Repository: incubator-weex
Updated Branches:
  refs/heads/0.16-dev 68a3fb2e1 -> 88ae8eb96


* [android] fix the IndexOutOfBoundsException


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/88ae8eb9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/88ae8eb9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/88ae8eb9

Branch: refs/heads/0.16-dev
Commit: 88ae8eb9648a4d1217048aaa6d9419dd93bff24f
Parents: 68a3fb2
Author: misakuo 
Authored: Tue Aug 29 13:08:58 2017 +0800
Committer: misakuo 
Committed: Tue Aug 29 13:08:58 2017 +0800

--
 .../ui/component/list/BasicListComponent.java   | 21 +++-
 1 file changed, 7 insertions(+), 14 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/88ae8eb9/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
--
diff --git 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
index 7559991..66eb75b 100644
--- 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
+++ 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
@@ -1349,15 +1349,11 @@ public abstract class BasicListComponent

[GitHub] incubator-weex pull request #660: * [android] fix the IndexOutOfBoundsExcept...

2017-08-28 Thread misakuo 
GitHub user misakuo opened a pull request:

https://github.com/apache/incubator-weex/pull/660

* [android] fix the IndexOutOfBoundsException



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/misakuo/incubator-weex 
android-bugfix-list-onscroll

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/660.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #660


commit 88ae8eb9648a4d1217048aaa6d9419dd93bff24f
Author: misakuo 
Date:   2017-08-29T05:08:58Z

* [android] fix the IndexOutOfBoundsException




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #267: 修复iOS SDK添�� 系统返回手势的bug

2017-08-28 Thread zwwill 
Github user zwwill commented on the issue:

https://github.com/apache/incubator-weex/pull/267
  
问题好像还没解决，现有版本问题依然存在


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #659: * [android] fix NPE on findFirstVisibleIte...

2017-08-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/659


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

incubator-weex git commit: * [android] fix NPE on findFirstVisibleItemPosition

2017-08-28 Thread misakuo 
Repository: incubator-weex
Updated Branches:
  refs/heads/0.16-dev 05c3fc337 -> 68a3fb2e1


* [android] fix NPE on findFirstVisibleItemPosition


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/68a3fb2e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/68a3fb2e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/68a3fb2e

Branch: refs/heads/0.16-dev
Commit: 68a3fb2e1ae2e7f7e2aab1a8d2c60a0ae6693e74
Parents: 05c3fc3
Author: misakuo 
Authored: Mon Aug 28 21:58:42 2017 +0800
Committer: misakuo 
Committed: Mon Aug 28 21:58:42 2017 +0800

--
 .../ui/component/list/BasicListComponent.java   | 29 ++--
 1 file changed, 27 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/68a3fb2e/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
--
diff --git 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
index bd65c1f..7559991 100644
--- 
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
+++ 
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
@@ -1350,6 +1350,19 @@ public abstract class BasicListComponent

[GitHub] incubator-weex pull request #659: * [android] fix NPE on findFirstVisibleIte...

2017-08-28 Thread misakuo 
GitHub user misakuo opened a pull request:

https://github.com/apache/incubator-weex/pull/659

* [android] fix NPE on findFirstVisibleItemPosition

as the title, no testcase needed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/misakuo/incubator-weex 
android-bugfix-list-onscroll

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #659


commit 68a3fb2e1ae2e7f7e2aab1a8d2c60a0ae6693e74
Author: misakuo 
Date:   2017-08-28T13:58:42Z

* [android] fix NPE on findFirstVisibleItemPosition




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #655: fix NP crash, reload crash when context nu...

2017-08-28 Thread yuhun-alibaba 
Github user yuhun-alibaba closed the pull request at:

https://github.com/apache/incubator-weex/pull/655


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #658: * [test] update tc for stable

2017-08-28 Thread weex-bot 
Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/658
  





  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  





  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #658: * [test] update tc for stable

2017-08-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/658


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[1/2] incubator-weex git commit: * [test] update tc for stable

2017-08-28 Thread acton393 
Repository: incubator-weex
Updated Branches:
  refs/heads/0.16-dev 781296f44 -> 05c3fc337


* [test] update tc for stable


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/23fd3bf0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/23fd3bf0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/23fd3bf0

Branch: refs/heads/0.16-dev
Commit: 23fd3bf04ec896057e259e0041645ae0db9181fd
Parents: 6f15eb0
Author: gurisxie <279483...@qq.com>
Authored: Mon Aug 28 15:45:15 2017 +0800
Committer: gurisxie <279483...@qq.com>
Committed: Mon Aug 28 15:45:15 2017 +0800

--
 test/pages/attributes/dom-operation.vue | 33 +++
 test/pages/components/image-onload.vue  | 65 +
 test/pages/components/list-scroll.vue   | 33 +++
 test/pages/components/scroller-scroll.vue   | 31 +++
 test/pages/components/slider-infinite.vue   | 54 +++
 test/pages/dom-operation.vue| 33 ---
 test/pages/image-onload.vue | 31 ---
 test/pages/index.vue| 30 --
 test/pages/list-scroll.vue  | 33 ---
 test/pages/scroller-scroll.vue  | 31 ---
 test/pages/slider-infinite.vue  | 54 ---
 test/scripts/attributes/compositing.test.js |  5 +-
 test/scripts/attributes/dom.test.js | 98 
 test/scripts/components/a-src.test.js   |  2 +-
 test/scripts/components/iconfont.test.js|  2 +-
 test/scripts/components/image-onload.test.js| 32 ++-
 test/scripts/components/input-event.test.js |  2 +-
 test/scripts/components/recycler.test.js| 20 +++-
 test/scripts/components/refresh-loading.test.js | 12 +--
 test/scripts/components/scroll-event.test.js|  6 +-
 test/scripts/components/slider-infinite.test.js |  2 +-
 test/scripts/components/switch-event.test.js|  2 +-
 test/scripts/components/video-property.test.js  |  2 +-
 test/scripts/components/web-event.test.js   |  2 +-
 test/scripts/dom.test.js| 98 
 .../scripts/modules/animation-translate.test.js |  5 +-
 test/scripts/modules/clipboard-event.test.js|  5 +-
 test/scripts/modules/gesture-longpress.test.js  |  5 +-
 test/scripts/modules/modal-event.test.js|  5 +-
 test/scripts/modules/picker-event.test.js   |  5 +-
 30 files changed, 371 insertions(+), 367 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/23fd3bf0/test/pages/attributes/dom-operation.vue
--
diff --git a/test/pages/attributes/dom-operation.vue 
b/test/pages/attributes/dom-operation.vue
new file mode 100644
index 000..334803d
--- /dev/null
+++ b/test/pages/attributes/dom-operation.vue
@@ -0,0 +1,33 @@
+
+
+item
+
+repeat item:{{item}}
+
+display
+display
+{{text}}
+
+
+
+module.exports = {
+data:function(){
+return {
+display:false,
+repeat_items:[1,2,3,4,5],
+text:"display"
+}
+},
+methods:{
+  onclick:function(){
+this.display=true;
+this.repeat_items.push(6);
+  },
+  onclick2:function(){
+this.display = false;
+this.repeat_items.pop();
+this.text = "finished"
+  }
+}
+}
+
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/23fd3bf0/test/pages/components/image-onload.vue
--
diff --git a/test/pages/components/image-onload.vue 
b/test/pages/components/image-onload.vue
new file mode 100644
index 000..2509c0e
--- /dev/null
+++ b/test/pages/components/image-onload.vue
@@ -0,0 +1,65 @@
+
+  
+
+  
+https://gw.alicdn.com/tps/TB1bEMYKXaLaXXX-360-388.png; 
@load="onload">
+https://cn.vuejs.org/images/logo.png1; 
@load="onloadFailed">
+  
+  
+{{size}}
+{{download}}
+  
+
+
+  
+测试点：
+  * 
+
+测试方式：
+  * 
+  * 
+  
+
+  
+
+
+  module.exports = {
+data : {
+  size:"-1,-1",
+  download:'success'
+},
+components: {
+  "wxc-desc":require('../include/wxc-desc.vue'),
+  panel: require('../include/panel.vue'),
+  button: require('../include/button.vue'),
+},
+methods : {
+  onload : function(e) {
+nativeLog(JSON.stringify(e))
+this.size = e.size.naturalWidth + ',' + e.size.naturalHeight;
+  },
+  onloadFailed:function(e) {
+if

[2/2] incubator-weex git commit: Merge branch '0.16-dev' of https://github.com/gurisxie/incubator-weex into wip-us-0.16-dev

2017-08-28 Thread acton393 
Merge branch '0.16-dev' of https://github.com/gurisxie/incubator-weex into 
wip-us-0.16-dev


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/05c3fc33
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/05c3fc33
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/05c3fc33

Branch: refs/heads/0.16-dev
Commit: 05c3fc337ca19e9ca23b2b423f29d3ffa7605489
Parents: 781296f 23fd3bf
Author: acton393 
Authored: Mon Aug 28 16:27:58 2017 +0800
Committer: acton393 
Committed: Mon Aug 28 16:27:58 2017 +0800

--
 test/pages/attributes/dom-operation.vue | 33 +++
 test/pages/components/image-onload.vue  | 65 +
 test/pages/components/list-scroll.vue   | 33 +++
 test/pages/components/scroller-scroll.vue   | 31 +++
 test/pages/components/slider-infinite.vue   | 54 +++
 test/pages/dom-operation.vue| 33 ---
 test/pages/image-onload.vue | 31 ---
 test/pages/index.vue| 30 --
 test/pages/list-scroll.vue  | 33 ---
 test/pages/scroller-scroll.vue  | 31 ---
 test/pages/slider-infinite.vue  | 54 ---
 test/scripts/attributes/compositing.test.js |  5 +-
 test/scripts/attributes/dom.test.js | 98 
 test/scripts/components/a-src.test.js   |  2 +-
 test/scripts/components/iconfont.test.js|  2 +-
 test/scripts/components/image-onload.test.js| 32 ++-
 test/scripts/components/input-event.test.js |  2 +-
 test/scripts/components/recycler.test.js| 20 +++-
 test/scripts/components/refresh-loading.test.js | 12 +--
 test/scripts/components/scroll-event.test.js|  6 +-
 test/scripts/components/slider-infinite.test.js |  2 +-
 test/scripts/components/switch-event.test.js|  2 +-
 test/scripts/components/video-property.test.js  |  2 +-
 test/scripts/components/web-event.test.js   |  2 +-
 test/scripts/dom.test.js| 98 
 .../scripts/modules/animation-translate.test.js |  5 +-
 test/scripts/modules/clipboard-event.test.js|  5 +-
 test/scripts/modules/gesture-longpress.test.js  |  5 +-
 test/scripts/modules/modal-event.test.js|  5 +-
 test/scripts/modules/picker-event.test.js   |  5 +-
 30 files changed, 371 insertions(+), 367 deletions(-)
--

[GitHub] incubator-weex pull request #658: * [test] update tc for stable

2017-08-28 Thread gurisxie 
GitHub user gurisxie opened a pull request:

https://github.com/apache/incubator-weex/pull/658

* [test] update tc for stable

* [test] update tc for stable

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gurisxie/incubator-weex 0.16-dev

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/658.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #658


commit 23fd3bf04ec896057e259e0041645ae0db9181fd
Author: gurisxie <279483...@qq.com>
Date:   2017-08-28T07:45:15Z

* [test] update tc for stable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

incubator-weex git commit: * [ios] fix _styles access crash

2017-08-28 Thread acton393 
Repository: incubator-weex
Updated Branches:
  refs/heads/0.16-dev 6f15eb0f4 -> 781296f44


* [ios] fix _styles access crash


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/781296f4
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/781296f4
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/781296f4

Branch: refs/heads/0.16-dev
Commit: 781296f44c1ab4cfdd4cd0bd287fa9b9b2c3b9af
Parents: 6f15eb0
Author: acton393 
Authored: Mon Aug 28 15:54:24 2017 +0800
Committer: acton393 
Committed: Mon Aug 28 15:54:24 2017 +0800

--
 ios/sdk/WeexSDK/Sources/Model/WXComponent.m | 12 
 1 file changed, 4 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/781296f4/ios/sdk/WeexSDK/Sources/Model/WXComponent.m
--
diff --git a/ios/sdk/WeexSDK/Sources/Model/WXComponent.m 
b/ios/sdk/WeexSDK/Sources/Model/WXComponent.m
index c2424c0..81f8178 100644
--- a/ios/sdk/WeexSDK/Sources/Model/WXComponent.m
+++ b/ios/sdk/WeexSDK/Sources/Model/WXComponent.m
@@ -447,9 +447,7 @@
 _transition = [WXTransition new];
 }
 [_transition _handleTransitionWithStyles:styles withTarget:self];
-}
-else
-{
+} else {
 styles = [self parseStyles:styles];
 [self _updateCSSNodeStyles:styles];
 }
@@ -463,7 +461,7 @@
 - (BOOL)_isPropertyTransitionStyles:(NSDictionary *)styles
 {
 BOOL yesOrNo = false;
-NSString *property = _styles[kWXTransitionProperty];
+NSString *property = self.styles[kWXTransitionProperty];
 if (property) {
 if (([property containsString:@"width"]&[@"width"])
 ||([property containsString:@"height"]&[@"height"])
@@ -483,7 +481,7 @@
 - (BOOL)_isPropertyAnimationStyles:(NSDictionary *)styles
 {
 BOOL yesOrNo = false;
-NSString *property = _styles[kWXTransitionProperty];
+NSString *property = self.styles[kWXTransitionProperty];
 if (property) {
 if (([property 
containsString:@"backgroundColor"]&[@"backgroundColor"])
 ||([property containsString:@"transform"]&[@"transform"])
@@ -527,9 +525,7 @@
 WXAssertMainThread();
 if (![self _isPropertyAnimationStyles:styles]) {
 [self _updateViewStyles:styles];
-}
-else
-{
+} else {
 [self _transitionUpdateViewProperty:styles];
 }