[GitHub] incubator-weex issue #717: * [html5] add custom jsonp callback name support

[orifake]

Github user orifake commented on the issue:

https://github.com/apache/incubator-weex/pull/717
  
Is there anyone can review this pr?


---

[GitHub] incubator-weex pull request #737: * [html5] update start command for develop

[erha19]

GitHub user erha19 opened a pull request:

https://github.com/apache/incubator-weex/pull/737

* [html5] update start  command for develop

Update start  command for develop。

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/erha19/incubator-weex dev

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/737.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #737


commit ab9ef1b24f65fd7f8edb858556d103f5e08634eb
Author: erha19 
Date:   2017-09-22T09:03:33Z

* [html5] update start  command for develop




---

[GitHub] incubator-weex pull request #471: [example] Modify the countdown example

[Hanks10100]

Github user Hanks10100 closed the pull request at:

https://github.com/apache/incubator-weex/pull/471


---

[GitHub] incubator-weex pull request #529: * [ios] upgrade csslayout to yoga

[acton393]

Github user acton393 closed the pull request at:

https://github.com/apache/incubator-weex/pull/529


---

[GitHub] incubator-weex issue #476: [android] Upgrade css-layout to yoga library

[gurisxie]

Github user gurisxie commented on the issue:

https://github.com/apache/incubator-weex/pull/476
  
weex will not use yoga,so close this pr .thanks @sospartan 


---

[GitHub] incubator-weex pull request #666: * [doc] fix typo

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/666


---

[3/3] incubator-weex git commit: Merge branch 'dev' of https://github.com/hyj223/incubator-weex into dev

[gurisxie]

Merge branch 'dev' of https://github.com/hyj223/incubator-weex into dev


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/f3beb7d8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/f3beb7d8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/f3beb7d8

Branch: refs/heads/dev
Commit: f3beb7d868e1fd24963fa439f724bd1969369d95
Parents: 23cc3ea a6f44ad
Author: gurisxie <279483...@qq.com>
Authored: Fri Sep 22 16:03:02 2017 +0800
Committer: gurisxie <279483...@qq.com>
Committed: Fri Sep 22 16:03:02 2017 +0800

--
 html5/render/vue/components/input.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--

[GitHub] incubator-weex pull request #615: [doc] fix iOS build command

[wispy316]

Github user wispy316 closed the pull request at:

https://github.com/apache/incubator-weex/pull/615


---

[GitHub] incubator-weex pull request #476: [android] Upgrade css-layout to yoga libra...

[sospartan]

Github user sospartan closed the pull request at:

https://github.com/apache/incubator-weex/pull/476


---

[GitHub] incubator-weex pull request #521: if render pageName setting Incorrect .in d...

[atomtong]

Github user atomtong closed the pull request at:

https://github.com/apache/incubator-weex/pull/521


---

[GitHub] incubator-weex pull request #690: * [test] else test shell code format

[atomtong]

Github user atomtong closed the pull request at:

https://github.com/apache/incubator-weex/pull/690


---

incubator-weex git commit: * [doc] add message about animation callback

[gurisxie]

Repository: incubator-weex
Updated Branches:
  refs/heads/dev eeaa5e0bd -> 23cc3eaf1


* [doc] add message about animation callback


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/23cc3eaf
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/23cc3eaf
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/23cc3eaf

Branch: refs/heads/dev
Commit: 23cc3eaf1f26f65816b66d6cd2f49c3568da5b5f
Parents: eeaa5e0
Author: doumafang 
Authored: Fri Sep 22 14:12:14 2017 +0800
Committer: doumafang 
Committed: Fri Sep 22 14:12:14 2017 +0800

--
 doc/source/cn/references/modules/animation.md | 5 +++--
 doc/source/references/modules/animation.md| 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/23cc3eaf/doc/source/cn/references/modules/animation.md
--
diff --git a/doc/source/cn/references/modules/animation.md 
b/doc/source/cn/references/modules/animation.md
index 8d188fc..c4381f1 100644
--- a/doc/source/cn/references/modules/animation.md
+++ b/doc/source/cn/references/modules/animation.md
@@ -19,6 +19,7 @@ version: 2.1
 * `options {Object}`：描述动画过程的对象。
   * `options.duration {number}`：指定动画的持续时间 
(单位是毫秒)，默认值是 `0`，表示没有动画效果。
   * `options.delay 
{number}`：指定请求动画操作到执行动画之间的时间间隔 
(单位是毫秒)，默认值是 
`0`，表示没有延迟，在请求后立即执行动画。
+  * `options.needLayout 
{boolean}`：节点动画执行时是否产生布局动画即LayoutAnimation，默认值是false。
   * `options.timingFunction 
{string}`：描述动画执行的速度曲线，用于使动画变化更为平滑。默认值是
 `linear`，表示动画从开始到结束都拥有同æ 
·çš„速度。下表列出了所有合法的属性：
 
 | 属性名| 描述
   |
@@ -50,8 +51,7 @@ version: 2.1
 | `rotate`/`rotateX` v0.14+ /`rotateY` v0.14+ | 指定元素
将被旋转的角度，单位是度 | number | 无 |
 | `perspective` v0.16+ | 观察者
距离z=0平面的距离，在Android 4.1及以上有效 | number | 正无穷
 
-* `callback {Function}`：动画执行完毕之后的回调
-* 
`needLayout（boolean）`：节点动画执行时是否产生布局动画即LayoutAnimation
+* `callback 
{Function}`：动画执行完毕之后的回调函数。**注意，在0.16.0+版本后，iOS上可以获取animation是否执行成功的信息，callback中的`result`参数会有两种，分别是是`Success`与`Fail`，Android暂不支持。**
 
 ## Example
 
@@ -78,6 +78,7 @@ version: 2.1
   },
   duration: 800, //ms
   timingFunction: 'ease',
+  needLayout:false,
   delay: 0 //ms
 }, function () {
   modal.toast({ message: 'animation finished.' })

http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/23cc3eaf/doc/source/references/modules/animation.md
--
diff --git a/doc/source/references/modules/animation.md 
b/doc/source/references/modules/animation.md
index a2f5175..870afb1 100644
--- a/doc/source/references/modules/animation.md
+++ b/doc/source/references/modules/animation.md
@@ -26,6 +26,7 @@ Smooth and meaningful animation is very effective for 
enhancing the user experie
 **position:** Transition options.
 - `duration` (number): Specifies the number of milliseconds of animation 
execution, the default value is `0`, means that no animation will occur.
 - `delay` (number): Specifies the amount of milliseconds to wait between a 
change being requested to a property that is to be transitioned and the start 
of the transition effect. The default value is `0`.   
+-  `needLayout`(boolean)：Whether or not the layout animation occurs when 
animation is executed，default value is `false`
 - `timingFunction` (string): Used to describe how the intermediate values of 
the styles being affected by a transition effect are calculated, default value 
is `linear`, the allowed attributes are listed in the following table:
 
 | name   | description  |
@@ -56,11 +57,9 @@ properties of `transform`:
 | perspective v0.16+ | The distance between 
the z=0 plane and the user in order to give to the 3D-positioned element some 
perspective. Supported for Android 4.1 and above. | number | positive infinity
 | scale/scaleX/scaleY | Stretch or shrink the element.   | 
number   | none  |
 
--  `callback`(function): Callback which is 

[GitHub] incubator-weex pull request #736: * [doc] add message about animation callba...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/736


---

[GitHub] incubator-weex issue #666: * [doc] fix typo

[gurisxie]

Github user gurisxie commented on the issue:

https://github.com/apache/incubator-weex/pull/666
  
@acton393 please have a review


---

[GitHub] incubator-weex pull request #736: * [doc] add message about animation callba...

[gurisxie]

Github user gurisxie commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/736#discussion_r140419198
  
--- Diff: doc/source/cn/references/modules/animation.md ---
@@ -50,8 +51,7 @@ version: 2.1
 | `rotate`/`rotateX` v0.14+ /`rotateY` 
v0.14+ | 指定元素
将被旋转的角度，单位是度 | number | 无 |
 | `perspective` v0.16+ | 观察者
距离z=0平面的距离，在Android 4.1及以上有效 | number | 正无穷
 
-* `callback {Function}`：动画执行完毕之后的回调
-* 
`needLayout（boolean）`：节点动画执行时是否产生布局动画即LayoutAnimation
+* `callback 
{Function}`：动画执行完毕之后的回调函数。**注意，在0.16.0+版本后，iOS上可以获取animation是否执行成功的信息，callback中的`result`参数会有两种，分别是是`Success`与`Fail`，Android暂不支持。**
--- End diff --

please add supported version @doumafang 


---

[GitHub] incubator-weex pull request #736: * [doc] add message about animation callba...

[gurisxie]

Github user gurisxie commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/736#discussion_r140419230
  
--- Diff: doc/source/cn/references/modules/animation.md ---
@@ -19,6 +19,7 @@ version: 2.1
 * `options {Object}`：描述动画过程的对象。
   * `options.duration {number}`：指定动画的持续时间 
(单位是毫秒)，默认值是 `0`，表示没有动画效果。
   * `options.delay 
{number}`：指定请求动画操作到执行动画之间的时间间隔 
(单位是毫秒)，默认值是 
`0`，表示没有延迟，在请求后立即执行动画。
+  * `options.needLayout 
{boolean}`：节点动画执行时是否产生布局动画即LayoutAnimation，默认值是false。
--- End diff --

please add supported version


---

[GitHub] incubator-weex issue #736: * [doc] add message about animation callback

[weex-bot]

Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/736
  





  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  




  

  
  Messages

  
  
  :book:
  According to the blame info, we recommended @DoranYun , @YorkShen 
to be the reviewers.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---

[GitHub] incubator-weex pull request #736: * [doc] add message about animation callba...

[doumafang]

GitHub user doumafang opened a pull request:

https://github.com/apache/incubator-weex/pull/736

* [doc] add message about animation callback

animationModule doc add callback message and fix some bug with doc

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/doumafang/incubator-weex dev

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/736.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #736


commit 23cc3eaf1f26f65816b66d6cd2f49c3568da5b5f
Author: doumafang 
Date:   2017-09-22T06:12:14Z

* [doc] add message about animation callback




---

[GitHub] incubator-weex pull request #735: * [ios] fix pr bug about filter crash

[gurisxie]

Github user gurisxie commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/735#discussion_r140417809
  
--- Diff: ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.m ---
@@ -436,11 +436,11 @@ - (void)handleStyleOnMainThread:(NSDictionary*)styles 
forComponent:(WXComponent
 NSMutableDictionary *normalStyles = [NSMutableDictionary new];
 NSMutableArray *resetStyles = [NSMutableArray new];
 [self filterStyles:styles normalStyles:normalStyles 
resetStyles:resetStyles];
-[component _updateStylesOnMainThread:[normalStyles copy] 
resetStyles:resetStyles];
+[component _updateStylesOnMainThread:normalStyles 
resetStyles:resetStyles];
 [component readyToRender];
 
 WXPerformBlockOnComponentThread(^{
-[component _updateStylesOnComponentThread:[normalStyles copy] 
resetStyles:resetStyles isUpdateStyles:isUpdateStyles];
+[component _updateStylesOnComponentThread:normalStyles 
resetStyles:resetStyles isUpdateStyles:isUpdateStyles];
--- End diff --

why not use copy? @doumafang 


---

[GitHub] incubator-weex issue #735: * [ios] fix pr bug about filter crash

[weex-bot]

Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/735
  





  

  
  Warnings

  
  
  :warning:
  

  No Changelog changes!
  

  

  :warning:
  

  This PR should update related documents as well. 
  

  





  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---