incubator-weex git commit: * [iOS] fix multithread crash about mutable array in scroller component

[acton393]

Repository: incubator-weex
Updated Branches:
  refs/heads/master 7c5ef1c68 -> 9c9ae8846


* [iOS] fix multithread crash about mutable array in scroller component


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/9c9ae884
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/9c9ae884
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/9c9ae884

Branch: refs/heads/master
Commit: 9c9ae884659682882ba2803906a0116556377859
Parents: 7c5ef1c
Author: acton393 
Authored: Thu Mar 8 15:27:44 2018 +0800
Committer: acton393 
Committed: Thu Mar 8 15:28:34 2018 +0800

--
 ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.m | 11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/9c9ae884/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.m
--
diff --git a/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.m 
b/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.m
index 4ebaec5..ede9de3 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.m
+++ b/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.m
@@ -28,6 +28,7 @@
 #import "WXRefreshComponent.h"
 #import "WXConfigCenterProtocol.h"
 #import "WXSDKEngine.h"
+#import "WXThreadSafeMutableArray.h"
 
 @interface WXScrollerComponnetView:UIScrollView
 @end
@@ -50,7 +51,7 @@
 @interface WXScrollerComponent()
 
 @property (nonatomic, strong) NSMutableArray *  stickyArray;
-@property (nonatomic, strong) NSMutableArray *  listenerArray;
+@property (nonatomic, strong) WXThreadSafeMutableArray * listenerArray;
 @property (nonatomic, weak) WXRefreshComponent *refreshComponent;
 @property (nonatomic, weak) WXLoadingComponent *loadingComponent;
 
@@ -118,7 +119,7 @@ WX_EXPORT_METHOD(@selector(resetLoadmore))
 if (self) {
 
 _stickyArray = [NSMutableArray array];
-_listenerArray = [NSMutableArray array];
+_listenerArray = [WXThreadSafeMutableArray array];
 _scrollEvent = NO;
 _scrollStartEvent = NO;
 _scrollEndEvent = NO;
@@ -382,7 +383,8 @@ WX_EXPORT_METHOD(@selector(resetLoadmore))
 - (void)addScrollToListener:(WXComponent *)target
 {
 BOOL has = NO;
-for (WXScrollToTarget *targetData in self.listenerArray) {
+WXThreadSafeMutableArray *listenerArray = [self.listenerArray copy];
+for (WXScrollToTarget *targetData in listenerArray) {
 if (targetData.target == target) {
 has = YES;
 break;
@@ -400,7 +402,8 @@ WX_EXPORT_METHOD(@selector(resetLoadmore))
 {
 if (_shouldRemoveScrollerListener) {
 WXScrollToTarget *targetData = nil;
-for (WXScrollToTarget *targetDataTemp in self.listenerArray) {
+WXThreadSafeMutableArray *listenerArray = [self.listenerArray copy];
+for (WXScrollToTarget *targetDataTemp in listenerArray) {
 if (targetDataTemp.target == target) {
 targetData = targetDataTemp;
 break;

[GitHub] incubator-weex issue #1051: [WEEX-241][iOS] add WXVideoComponent "poster" at...

[acton393]

Github user acton393 commented on the issue:

https://github.com/apache/incubator-weex/pull/1051
  
@xuyouyang  It look good to me and it will be accepted, thank you.
 It would be better if Android player can support poster attributes.


---

[3/3] incubator-weex-site git commit: add application (#89)

[hanks]

add application (#89)


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-weex-site/commit/c941b0d7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/tree/c941b0d7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/diff/c941b0d7

Branch: refs/heads/master
Commit: c941b0d765ddf124b81b6b5747b45bd1c7abe243
Parents: 89dc99e 4e95a78
Author: Hanks 
Authored: Thu Mar 8 14:08:24 2018 +0800
Committer: Hanks 
Committed: Thu Mar 8 14:08:24 2018 +0800

--
 source/_data/users.yml | 5 +
 1 file changed, 5 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex-site/blob/c941b0d7/source/_data/users.yml
--

[2/3] incubator-weex-site git commit: Update users.yml

[hanks]

Update users.yml

use shorter name "飞呀"

Project: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-weex-site/commit/4e95a78e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/tree/4e95a78e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/diff/4e95a78e

Branch: refs/heads/master
Commit: 4e95a78e08b03a7632d222cd4d1ca9bf0d3f359d
Parents: ebbef64
Author: Isaac Ho <84022...@qq.com>
Authored: Wed Mar 7 16:00:58 2018 +0800
Committer: GitHub 
Committed: Wed Mar 7 16:00:58 2018 +0800

--
 source/_data/users.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex-site/blob/4e95a78e/source/_data/users.yml
--
diff --git a/source/_data/users.yml b/source/_data/users.yml
index 8bc0a89..3fd7109 100644
--- a/source/_data/users.yml
+++ b/source/_data/users.yml
@@ -139,7 +139,7 @@ cschool:
   iOS: 'https://app.cschool.cc/download/download.html'
   android: 'https://app.cschool.cc/download/download.html'
 flya:
-  name: '飞呀-国际机票比价'
+  name: '飞呀'
   icon: 
'https://is3-ssl.mzstatic.com/image/thumb/Purple128/v4/2a/0f/69/2a0f69df-c1a4-0358-559c-1c9b52e417ae/AppIcon-1x_U007emarketing-sRGB-85-220-4.png/230x0w.jpg'
   iOS: 'https://itunes.apple.com/cn/app/id1301943383?mt=8'
   android: 'http://app.hicloud.com/app/C100145677'

[1/3] incubator-weex-site git commit: add application

[hanks]

Repository: incubator-weex-site
Updated Branches:
  refs/heads/master 89dc99e08 -> c941b0d76


add application

application use weex

Project: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-weex-site/commit/ebbef64c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/tree/ebbef64c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/diff/ebbef64c

Branch: refs/heads/master
Commit: ebbef64c1448dceb4cb037120eb165d1def93e2b
Parents: 72ea27d
Author: Isaac Ho <84022...@qq.com>
Authored: Fri Mar 2 17:35:18 2018 +0800
Committer: GitHub 
Committed: Fri Mar 2 17:35:18 2018 +0800

--
 source/_data/users.yml | 5 +
 1 file changed, 5 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex-site/blob/ebbef64c/source/_data/users.yml
--
diff --git a/source/_data/users.yml b/source/_data/users.yml
index 93e9914..8bc0a89 100644
--- a/source/_data/users.yml
+++ b/source/_data/users.yml
@@ -138,3 +138,8 @@ cschool:
   icon: 'https://app.cschool.cc/download/imgs/512.png'
   iOS: 'https://app.cschool.cc/download/download.html'
   android: 'https://app.cschool.cc/download/download.html'
+flya:
+  name: '飞呀-国际机票比价'
+  icon: 
'https://is3-ssl.mzstatic.com/image/thumb/Purple128/v4/2a/0f/69/2a0f69df-c1a4-0358-559c-1c9b52e417ae/AppIcon-1x_U007emarketing-sRGB-85-220-4.png/230x0w.jpg'
+  iOS: 'https://itunes.apple.com/cn/app/id1301943383?mt=8'
+  android: 'http://app.hicloud.com/app/C100145677'

[GitHub] incubator-weex pull request #1049: [WEEX-230][android] Weex Input Value Filt...

[gubaojian]

Github user gubaojian closed the pull request at:

https://github.com/apache/incubator-weex/pull/1049


---

[GitHub] incubator-weex pull request #1049: [WEEX-230][android] Weex Input Value Filt...

[gubaojian]

GitHub user gubaojian reopened a pull request:

https://github.com/apache/incubator-weex/pull/1049

[WEEX-230][android] Weex Input Value Filter By Diff Update

[WEEX-230][android] Weex Input Value Filter By Diff Update


http://rax.alibaba-inc.com/playground/08c38f41-49a9-4484-868e-8cd2da21c5cc

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gubaojian/incubator-weex 
release-0.18-input-filter-by-diff

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1049.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1049


commit a16bb9f3ade31feaeb28e8076f94d5b363f7bbda
Author: jianbai.gbj 
Date:   2018-03-06T09:01:00Z

[WEEX-230][android] Weex Input Value Filter By Diff Update




---

[GitHub] incubator-weex pull request #1049: [WEEX-230][android] Weex Input Value Filt...

[gubaojian]

Github user gubaojian closed the pull request at:

https://github.com/apache/incubator-weex/pull/1049


---

[GitHub] incubator-weex pull request #1049: [WEEX-230][android] Weex Input Value Filt...

[gubaojian]

GitHub user gubaojian reopened a pull request:

https://github.com/apache/incubator-weex/pull/1049

[WEEX-230][android] Weex Input Value Filter By Diff Update

[WEEX-230][android] Weex Input Value Filter By Diff Update


http://rax.alibaba-inc.com/playground/08c38f41-49a9-4484-868e-8cd2da21c5cc

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gubaojian/incubator-weex 
release-0.18-input-filter-by-diff

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1049.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1049


commit a16bb9f3ade31feaeb28e8076f94d5b363f7bbda
Author: jianbai.gbj 
Date:   2018-03-06T09:01:00Z

[WEEX-230][android] Weex Input Value Filter By Diff Update




---

[GitHub] incubator-weex issue #1055: [android] support resize Image in FrescoImageAda...

[weex-bot]

Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/1055
  






  

  
  Messages

  
  
  :book:
  has no jsfm file changed.

  

  :book:
  jsfm test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---

[GitHub] incubator-weex pull request #1055: [android] support resize Image in FrescoI...

[xiaoqi951109]

GitHub user xiaoqi951109 opened a pull request:

https://github.com/apache/incubator-weex/pull/1055

[android] support resize Image in FrescoImageAdapter

the default ImageAdapter Supported By Picasso, so a ImgUri with Base64 is 
not supported ,but resize in Image is not useful in FrescoImageAdapter , so i 
support it

First of all, thank you for your contribution! 

Please makes sure that these checkboxes are checked before submitting your 
PR, thank you!



CheckList:

**if** *isBugFix* **:**

  * [ ] Make sure that you add at least one unit test for the bug which you 
had fixed.

**elif** *isNewFeature* **:**

  * [ ] Update API docs for the component.
  * [ ] Update/Add demo to demonstrate new feature.
  * [ ] Update test scripts for the feature.
  * [ ] Add unit tests for the feature.






You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xiaoqi951109/incubator-weex resize_in_Fresco

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1055.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1055


commit 200677fa010d09fe2ea15951c230e3e62e4c304e
Author: xiaoqi951109 <269015753@...>
Date:   2018-03-08T03:18:58Z

[android] support resize Image in FrescoImageAdapter

the default ImageAdapter Supported By Picasso, so a ImgUri with Base64 is 
not supported ,but resize in Image is not useful in FrescoImageAdapter , so i 
support it




---

[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

[xuyouyang]

Github user xuyouyang commented on the issue:

https://github.com/apache/incubator-weex/pull/1051
  
OK. Thank you very much! @acton393 


---

[GitHub] incubator-weex pull request #1051: + [iOS] add WXVideoComponent "poster" att...

[xuyouyang]

Github user xuyouyang commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1051#discussion_r173046770
  
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m ---
@@ -85,6 +89,13 @@ - (id)init
 }
 
 [self addSubview:_playerViewController.view];
+
+_posterImageView = [[UIImageView alloc] init];
--- End diff --

good ideal! I will modify this later.


---

[GitHub] incubator-weex pull request #1054: [android]fix stream res.ok is undefined w...

[marekchen]

GitHub user marekchen reopened a pull request:

https://github.com/apache/incubator-weex/pull/1054

[android]fix stream res.ok is undefined when request has exception

CheckList:

**if** *isBugFix* **:**

  * [x] Make sure that you add at least one unit test for the bug which you 
had fixed.

**elif** *isNewFeature* **:**

  * [ ] Update API docs for the component.
  * [ ] Update/Add demo to demonstrate new feature.
  * [ ] Update test scripts for the feature.
  * [ ] Add unit tests for the feature.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/marekchen/incubator-weex patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1054.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1054


commit b3d3d628c837a07bcf688405294e30ff725ecfa5
Author: marekchen 
Date:   2018-03-07T14:09:35Z

Update WXStreamModule.java




---

[GitHub] incubator-weex pull request #1054: [android]fix stream res.ok is undefined w...

[marekchen]

Github user marekchen closed the pull request at:

https://github.com/apache/incubator-weex/pull/1054


---

[GitHub] incubator-weex issue #1054: [android]fix stream res.ok is undefined when req...

[weex-bot]

Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/1054
  






  

  
  Messages

  
  
  :book:
  has no jsfm file changed.

  

  :book:
  jsfm test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---

[GitHub] incubator-weex pull request #1054: [android]fix stream res.ok is undefined w...

[marekchen]

GitHub user marekchen opened a pull request:

https://github.com/apache/incubator-weex/pull/1054

[android]fix stream res.ok is undefined when request has exception

CheckList:

**if** *isBugFix* **:**

  * [x] Make sure that you add at least one unit test for the bug which you 
had fixed.

**elif** *isNewFeature* **:**

  * [ ] Update API docs for the component.
  * [ ] Update/Add demo to demonstrate new feature.
  * [ ] Update test scripts for the feature.
  * [ ] Add unit tests for the feature.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/marekchen/incubator-weex patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1054.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1054


commit b3d3d628c837a07bcf688405294e30ff725ecfa5
Author: marekchen 
Date:   2018-03-07T14:09:35Z

Update WXStreamModule.java




---

[GitHub] incubator-weex pull request #939: fix stream res.ok is undefined when reques...

[marekchen]

Github user marekchen closed the pull request at:

https://github.com/apache/incubator-weex/pull/939


---

[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

[tw93]

Github user tw93 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1047#discussion_r172837062
  
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -104,6 +142,10 @@ - (void)updateAttributes:(NSDictionary *)attributes
 if (attributes[@"src"]) {
 self.url = attributes[@"src"];
 }
+
+if (attributes[@"source"]) {
--- End diff --

 done!


---

[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

[acton393]

Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1047#discussion_r172835622
  
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -104,6 +142,10 @@ - (void)updateAttributes:(NSDictionary *)attributes
 if (attributes[@"src"]) {
 self.url = attributes[@"src"];
 }
+
+if (attributes[@"source"]) {
--- End diff --

maybe we should update the initSource when update attributes,
as the view can be unloaded during the screen scroll, so the viewDidLoad 
method can called again with initSource


---

[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

[acton393]

Github user acton393 commented on the issue:

https://github.com/apache/incubator-weex/pull/1051
  
@xuyouyang   as the [development 
process](http://weex.apache.org/development-process.html) shows, we need create 
a jira issue in apache, and format your pull request title and commit log.

   I have created a jira issue for this feature, and the issue id is 
WEEX-241, the issue address is https://issues.apache.org/jira/browse/WEEX-241

what you need to do next is to update the title as the following format 
 `[WEEX-jiraId][iOS/Android] summary`

thanks


---

[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

[tw93]

Github user tw93 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1047#discussion_r172833325
  
--- Diff: ios/sdk/WeexSDK/Sources/Module/WXWebViewModule.m ---
@@ -27,6 +27,7 @@ @implementation WXWebViewModule
 @synthesize weexInstance;
--- End diff --

Thinks @acton393 , I have modified it


---

[GitHub] incubator-weex pull request #1051: + [iOS] add WXVideoComponent "poster" att...

[acton393]

Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1051#discussion_r172831893
  
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m ---
@@ -85,6 +89,13 @@ - (id)init
 }
 
 [self addSubview:_playerViewController.view];
+
+_posterImageView = [[UIImageView alloc] init];
--- End diff --

How about lazy load when front-end developer specify the poster attributes


---

[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

[acton393]

Github user acton393 commented on the issue:

https://github.com/apache/incubator-weex/pull/1051
  
@xuyouyang  I got it and find the w3c rules about it : 
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video

thanks, we can make it more standard by add more attributes and styles, 
what about Android?


---

[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

[acton393]

Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1047#discussion_r172826404
  
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -69,6 +71,11 @@ - (instancetype)initWithRef:(NSString *)ref 
type:(NSString *)type styles:(NSDict
 {
 if (self = [super initWithRef:ref type:type styles:styles 
attributes:attributes events:events weexInstance:weexInstance]) {
 self.url = attributes[@"src"];
+
+if(attributes[@"source"]){
+self.source = attributes[@"source"];
--- End diff --

the init method is executed in background thread named component method and 
 `self.source` will call [self setSource:""], 
the method for `setSource` called view operation which is only for main 
thread.

A better way is that define another member for source to save the variable 
during  this initialization,  and call  self.source in component hook lifeCycle 
like  `viewDidLoad`.



---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

[marekchen]

GitHub user marekchen reopened a pull request:

https://github.com/apache/incubator-weex/pull/1053

[android]fix input bug

英文不好就用中文描述了：
1.当在created中设置input的value值为“1”，然后删
除“1”，这时不会触发input事件
2.当输入“1”后，还是不能触发input事件，因
为value值和输入值相同时，不触发input事件
重现代码如下：
``` html

  

  oninput: {{idCard}}
  onchange: {{idCard}}



  

  input type = text


  
  click

  



  .input {
font-size: 60px;
height: 80px;
width: 750px;
  }
  .button {
font-size: 36;
width: 200px;
height: 200px;
color: #41B883;
text-align: center;
padding-top: 10;
padding-bottom: 10;
border-width: 2;
border-style: solid;
margin-right: 20;
border-color: rgb(162, 217, 192);
background-color: rgba(162, 217, 192, 0.2);
  }



  module.exports = {
data: function () {
  return {
idCard:'',
  };
},
methods: {
  clickbutton: function () {
var that=this;
var modal = weex.requireModule('modal')
modal.toast({
message:"text:"+that.idCard,
duration: 0.3
})
  },
  oninput: function(event){
this.idCard = event.value;
console.log('oninput', event.value);
  },
  onchange: function (event) {
this.idCard = event.value;
console.log('onchange', event.value);
  },
},
created(){
  this.idCard = "1"
}
  };

```

CheckList:

**if** *isBugFix* **:**

  * [x] Make sure that you add at least one unit test for the bug which you 
had fixed.

**elif** *isNewFeature* **:**

  * [ ] Update API docs for the component.
  * [ ] Update/Add demo to demonstrate new feature.
  * [ ] Update test scripts for the feature.
  * [ ] Add unit tests for the feature.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/marekchen/incubator-weex master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1053.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1053


commit ef9584f7c0a6246f75cd4fb6aef624537b0c038a
Author: marekchen 
Date:   2018-03-07T11:41:12Z

Update AbstractEditComponent.java




---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

[marekchen]

Github user marekchen closed the pull request at:

https://github.com/apache/incubator-weex/pull/1053


---

[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

[acton393]

Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1047#discussion_r172825375
  
--- Diff: ios/sdk/WeexSDK/Sources/Module/WXWebViewModule.m ---
@@ -27,6 +27,7 @@ @implementation WXWebViewModule
 @synthesize weexInstance;
--- End diff --

webViewModule  method is  deprecated  gradually as we support component 
method, the same expose way as module method
see more details: 
http://weex.apache.org/guide/extend-ios.html#component-method

Maybe it will be better if use component method


---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

[marekchen]

Github user marekchen closed the pull request at:

https://github.com/apache/incubator-weex/pull/1053


---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

[marekchen]

GitHub user marekchen reopened a pull request:

https://github.com/apache/incubator-weex/pull/1053

[android]fix input bug

英文不好就用中文描述了：
1.当在created中设置input的value值为“1”，然后删
除“1”，这时不会触发input事件
2.当输入“1”后，还是不能触发input事件，因
为value值和输入值相同时，不触发input事件
重现代码如下：
``` html

  

  oninput: {{idCard}}
  onchange: {{idCard}}



  

  input type = text


  
  click

  



  .input {
font-size: 60px;
height: 80px;
width: 750px;
  }
  .button {
font-size: 36;
width: 200px;
height: 200px;
color: #41B883;
text-align: center;
padding-top: 10;
padding-bottom: 10;
border-width: 2;
border-style: solid;
margin-right: 20;
border-color: rgb(162, 217, 192);
background-color: rgba(162, 217, 192, 0.2);
  }



  module.exports = {
data: function () {
  return {
idCard:'',
  };
},
methods: {
  clickbutton: function () {
var that=this;
var modal = weex.requireModule('modal')
modal.toast({
message:"text:"+that.idCard,
duration: 0.3
})
  },
  oninput: function(event){
this.idCard = event.value;
console.log('oninput', event.value);
  },
  onchange: function (event) {
this.idCard = event.value;
console.log('onchange', event.value);
  },
},
created(){
  this.idCard = "1"
}
  };

```

CheckList:

**if** *isBugFix* **:**

  * [x] Make sure that you add at least one unit test for the bug which you 
had fixed.

**elif** *isNewFeature* **:**

  * [ ] Update API docs for the component.
  * [ ] Update/Add demo to demonstrate new feature.
  * [ ] Update test scripts for the feature.
  * [ ] Add unit tests for the feature.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/marekchen/incubator-weex master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1053.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1053


commit ef9584f7c0a6246f75cd4fb6aef624537b0c038a
Author: marekchen 
Date:   2018-03-07T11:41:12Z

Update AbstractEditComponent.java




---

[GitHub] incubator-weex issue #1053: [android]fix input bug

[weex-bot]

Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/1053
  





  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  




  

  
  Messages

  
  
  :book:
  danger test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

[marekchen]

GitHub user marekchen opened a pull request:

https://github.com/apache/incubator-weex/pull/1053

[android]fix input bug

英文不好就用中文描述了：
1.当在created中设置input的value值为“1”，然后删
除“1”，这时不会触发input事件
2.当输入“1”后，还是不能触发input事件，因
为value值和输入值相同时，不触发input事件
重现代码如下：
``` html

  

  oninput: {{idCard}}
  onchange: {{idCard}}



  

  input type = text


  
  click

  



  .input {
font-size: 60px;
height: 80px;
width: 750px;
  }
  .button {
font-size: 36;
width: 200px;
height: 200px;
color: #41B883;
text-align: center;
padding-top: 10;
padding-bottom: 10;
border-width: 2;
border-style: solid;
margin-right: 20;
border-color: rgb(162, 217, 192);
background-color: rgba(162, 217, 192, 0.2);
  }



  module.exports = {
data: function () {
  return {
idCard:'',
  };
},
methods: {
  clickbutton: function () {
var that=this;
var modal = weex.requireModule('modal')
modal.toast({
message:"text:"+that.idCard,
duration: 0.3
})
  },
  oninput: function(event){
this.idCard = event.value;
console.log('oninput', event.value);
  },
  onchange: function (event) {
this.idCard = event.value;
console.log('onchange', event.value);
  },
},
created(){
  this.idCard = "1"
}
  };

```

CheckList:

**if** *isBugFix* **:**

  * [x] Make sure that you add at least one unit test for the bug which you 
had fixed.

**elif** *isNewFeature* **:**

  * [ ] Update API docs for the component.
  * [ ] Update/Add demo to demonstrate new feature.
  * [ ] Update test scripts for the feature.
  * [ ] Add unit tests for the feature.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/marekchen/incubator-weex master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1053.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1053


commit ef9584f7c0a6246f75cd4fb6aef624537b0c038a
Author: marekchen 
Date:   2018-03-07T11:41:12Z

Update AbstractEditComponent.java




---

[GitHub] incubator-weex issue #1048: [android]fix input bug

[marekchen]

Github user marekchen commented on the issue:

https://github.com/apache/incubator-weex/pull/1048
  
can't reopen this pr


---

[GitHub] incubator-weex pull request #1048: fix input bug

[marekchen]

Github user marekchen closed the pull request at:

https://github.com/apache/incubator-weex/pull/1048


---

[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

[tw93]

Github user tw93 closed the pull request at:

https://github.com/apache/incubator-weex/pull/1047


---

[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

[tw93]

GitHub user tw93 reopened a pull request:

https://github.com/apache/incubator-weex/pull/1047

[WEEX-233][iOS] More enhanced about  component

First of all, thank you for your contribution! 

Please makes sure that these checkboxes are checked before submitting your 
PR, thank you!



CheckList:

*isNewFeature* **:**

  * [ ] Update API docs for the component.
  * [ ] Update/Add demo to demonstrate new feature.
  * [ ] Update test scripts for the feature.
  * [ ] Add unit tests for the feature.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tw93/incubator-weex ios-feature-enhanced-web

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1047.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1047


commit a052c9f934899b8a0f83ee3d5ff2ba5dc3b13c60
Author: Tw93 
Date:   2018-02-27T10:47:26Z

+ [ios] more enhanced about web

commit e33353a794ed56033305d40692d876fdc58736f9
Author: Tw93 
Date:   2018-03-01T09:07:42Z

+ [ios] change to postmessage

commit 900426be26bf5ec08d32304d003f691932f61180
Author: Tw93 
Date:   2018-03-05T11:39:28Z

+ [ios] Code Style Guidelines

commit db1c20e4c1a543db060ece68c7715b42384de594
Author: 侑夕 
Date:   2018-03-07T11:26:39Z

+ [ios] according to the W3C specification




---