[GitHub] incubator-weex issue #1168: [WEEX-355][android] recycle-list adapter for wee...

[weex-bot]

Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/1168
  




  

  
  Fails

  
  
  :no_entry_sign:
  Code file 
weex_core/Source/android/jniprebuild/jniheader/ContentBoxMeasurement_jni.h does 
not have the copyright header.

  

  :no_entry_sign:
  Code file 
weex_core/Source/android/jniprebuild/jniheader/WXBridge_jni.h does not have the 
copyright header.

  

  :no_entry_sign:
  Code file 
weex_core/Source/android/jniprebuild/jniheader/NativeRenderObjectUtils_jni.h 
does not have the copyright header.

  




  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  

  :warning:
  Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/ui/component/list/template/TemplateViewHolder.java
 without metion it in commit message. You'd better add '@notdanger' in your 
commit log. 

  

  :warning:
  Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/ui/component/list/template/PositionRef.java
 without metion it in commit message. You'd better add '@notdanger' in your 
commit log. 

  

  :warning:
  Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/dom/WXAttr.java without metion it in 
commit message. You'd better add '@notdanger' in your commit log. 

  

  :warning:
  Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/ui/component/binding/Layouts.java 
without metion it in commit message. You'd better add '@notdanger' in your 
commit log. 

  

  :warning:
  Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/dom/WXEvent.java without metion it in 
commit message. You'd better add '@notdanger' in your commit log. 

  

  :warning:
  Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/ui/component/list/template/WXRecyclerTemplateList.java
 without metion it in commit message. You'd better add '@notdanger' in your 
commit log. 

  

  :warning:
  Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java without 
metion it in commit message. You'd better add '@notdanger' in your commit log. 


  




  

  
  Messages

  
  
  :book:
  danger test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---

[GitHub] incubator-weex pull request #1168: [WEEX-355][android] recycle-list adapter ...

[gubaojian]

GitHub user gubaojian opened a pull request:

https://github.com/apache/incubator-weex/pull/1168

[WEEX-355][android] recycle-list adapter for weex-core new architecture

[WEEX-355][android] recycle-list adapter for weex-core new architecture

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gubaojian/incubator-weex 
release-0.19-weex-core-adapter-recycle-list

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1168


commit 388e4e6d3b6bc735a68e1c6e3c20e976a6052382
Author: jianbai.gbj 
Date:   2018-05-07T12:54:22Z

[WEEX-355][android] recycle-list adapter for weex-core new architecture




---

[GitHub] incubator-weex pull request #1167: [WEEX-354] [iOS] WXAnalyzer check instanc...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/1167


---

incubator-weex git commit: [WEEX-354] [iOS] WXAnalyzer check instance.scriptURL==nil close #1167

[acton393]

Repository: incubator-weex
Updated Branches:
  refs/heads/master 792ac344e -> 0d2681fcd


[WEEX-354] [iOS] WXAnalyzer check instance.scriptURL==nil
close #1167


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/0d2681fc
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/0d2681fc
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/0d2681fc

Branch: refs/heads/master
Commit: 0d2681fcd3abef46db2dad5c935a9bee609cc68b
Parents: 792ac34
Author: zhongcang 
Authored: Fri May 11 13:02:50 2018 +0800
Committer: acton393 
Committed: Fri May 11 14:55:57 2018 +0800

--
 ios/sdk/WeexSDK/Sources/Monitor/WXAnalyzerCenter.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/0d2681fc/ios/sdk/WeexSDK/Sources/Monitor/WXAnalyzerCenter.m
--
diff --git a/ios/sdk/WeexSDK/Sources/Monitor/WXAnalyzerCenter.m 
b/ios/sdk/WeexSDK/Sources/Monitor/WXAnalyzerCenter.m
index 643b620..8ab9259 100644
--- a/ios/sdk/WeexSDK/Sources/Monitor/WXAnalyzerCenter.m
+++ b/ios/sdk/WeexSDK/Sources/Monitor/WXAnalyzerCenter.m
@@ -171,7 +171,7 @@
 
 NSMutableDictionary *wrapDic = [data mutableCopy];
 [wrapDic setObject:instance.instanceId forKey:@"instanceId"];
-[wrapDic setObject:[instance.scriptURL absoluteString] forKey:@"url"];
+[wrapDic setObject:[instance.scriptURL absoluteString]?:@"unSetscriptURL" 
forKey:@"url"];
 [wrapDic setValue:GROUP_ANALYZER forKey:@"group"];
 [wrapDic setValue:module forKey:@"module"];
 [wrapDic setValue:type forKey:@"type"];