[GitHub] incubator-weex issue #1177: [Weex-365][iOS] Try to resolve multithread crash...

2018-05-15 Thread weex-bot 
Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/1177
  






  

  
  Messages

  
  
  :book:
  has no jsfm file changed.

  

  :book:
  jsfm test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---

[GitHub] incubator-weex pull request #1177: [Weex-365][iOS] Try to resolve multithrea...

2018-05-15 Thread caixiaomin 
GitHub user caixiaomin opened a pull request:

https://github.com/apache/incubator-weex/pull/1177

[Weex-365][iOS] Try to resolve multithread crash during view unloading

Crash Stack as below:

Incident Identifier: 0F2F4E0D-6210-4A3C-A70C-8B39ED855116
CrashReporter Key: TODO
Hardware Model: iPhone9,1
Process: xxx[1053]
Path: 
/var/containers/Bundle/Application/6AE86C35-88AE-4972-AE17-55CF03B02D85/xxx.app/xxx
Identifier: 0F2F4E0D-6210-4A3C-A70C-8B39ED855116
Version: 7.8.2
Code Type: ARM-64
Parent Process: ??? [1]

Date/Time: 2018-05-13 11:08:22 +
OS Version: iPhone OS 11.3.1 (15E302)
Report Version: 104

Exception Type: SIGTRAP
Exception Codes: #0 at 0x18cae95e0
Triggered by Thread: 0

Thread 0 Crashed:
0 UIKit 0x00018cae95e0 -[UIView(UIKitManual) release] :196 (in UIKit)
1 UIKit 0x00018cf4eed0 __UIViewWasRemovedFromSuperview :152 (in UIKit)
2 UIKit 0x00018cb2de58 -[UIView(Hierarchy) removeFromSuperview] :492 
(in UIKit)
3 xxx 0x000106088ad4 -[WXComponent(ViewManagement) 
_unloadViewWithReusing:] WXComponent+ViewManagement.mm:337 (in xxx)
4 xxx 0x0001060b5bc0 _28-[WXComponentManager unload]_block_invoke 
WXComponentManager.mm:0 (in xxx)
5 libdispatch.dylib 0x000182838b24 _dispatch_call_block_and_release :24 
(in libdispatch.dylib)
6 libdispatch.dylib 0x000182838ae4 _dispatch_client_callout :16 (in 
libdispatch.dylib)
7 libdispatch.dylib 0x0001828456e0 
_dispatch_main_queue_callback_4CF$VARIANT$mp :1012 (in libdispatch.dylib)
8 CoreFoundation 0x000182eef070 
__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ :12 (in CoreFoundation)
9 CoreFoundation 0x000182eecbc8 __CFRunLoopRun :2272 (in CoreFoundation)
10 CoreFoundation 0x000182e0cda8 _CFRunLoopRunSpecific :552 (in 
CoreFoundation)
11 GraphicsServices 0x000184def020 _GSEventRunModal :100 (in 
GraphicsServices)
12 UIKit 0x00018cded78c _UIApplicationMain :236 (in UIKit)
13 xxx 0x000104ce8dfc TBMainEntry TBMainEntry.m:74 (in xxx)
14 xxx 0x0001065501fc main main.m:17 (in xxx)
15 libdyld.dylib 0x00018289dfc0 _start :4 (in libdyld.dylib)

Binary Images:
0x000102ef - 0x000106637fff xxx arm64 
/var/containers/Bundle/Application/6AE86C35-88AE-4972-AE17-55CF03B02D85/xxx.app/xxx
0x000182837000 - 0x00018289cfff libdispatch.dylib arm64 
<42fe29ae709d39d9bc00f31af92baaf1> /usr/lib/system/libdispatch.dylib
0x00018289d000 - 0x0001828b7fff libdyld.dylib arm64 
/usr/lib/system/libdyld.dylib
0x000182e01000 - 0x000183197fff CoreFoundation arm64 
/System/Library/Frameworks/CoreFoundation.framework/CoreFoundation
0x000184de4000 - 0x000184df7fff GraphicsServices arm64 
<85072ece665a3a86807f153e85476fed> 
/System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices
0x00018cad - 0x00018db4efff UIKit arm64 
/System/Library/Frameworks/UIKit.framework/UIKit

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/caixiaomin/incubator-weex 
removeFromSuperviewFix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1177


commit 9e9c4e1db0c15fb871b868be5c76fc63f71cd0e5
Author: maike(麦客) 
Date:   2018-05-15T11:41:45Z

[Weex-365][iOS] Try to resolve multithread crash during view unloading




---

[GitHub] incubator-weex issue #1158: [jsfm] Support sending stylesheets and class nam...

2018-05-15 Thread MountainHill 
Github user MountainHill commented on the issue:

https://github.com/apache/incubator-weex/pull/1158
  
@Hanks10100 其实是目前我碰到一个问题动态设置style
现在只能先定义好style中要设置的属性
```
:style="{color:item.color}"
```

无
法动态设置style，如styleA设置颜色,styleB设置的颜色和字体


---

[GitHub] incubator-weex pull request #1169: * [Android] Add exception info when there...

2018-05-15 Thread YorkShen 
Github user YorkShen closed the pull request at:

https://github.com/apache/incubator-weex/pull/1169


---

[GitHub] incubator-weex pull request #1173: [WEEX-361][Core] max width

2018-05-15 Thread YorkShen 
Github user YorkShen closed the pull request at:

https://github.com/apache/incubator-weex/pull/1173


---

[GitHub] incubator-weex pull request #1170: * [Android] Update gradle wrapper.

2018-05-15 Thread YorkShen 
Github user YorkShen closed the pull request at:

https://github.com/apache/incubator-weex/pull/1170


---

[GitHub] incubator-weex pull request #1176: [WEEX-364][iOS] support swift build

2018-05-15 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/1176


---

incubator-weex git commit: [WEEX-364][iOS] support swift build * [iOS] head newlayout node.h

2018-05-15 Thread acton393 
Repository: incubator-weex
Updated Branches:
  refs/heads/master 71af7585d -> 947767b4c


[WEEX-364][iOS] support swift build
* [iOS] head newlayout node.h

* [iOS] fix compile error
close #1176


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/947767b4
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/947767b4
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/947767b4

Branch: refs/heads/master
Commit: 947767b4c5b1cc5e23d4ad6262f6789c1b5b04d6
Parents: 71af758
Author: zouming.zm 
Authored: Tue May 15 12:02:03 2018 +0800
Committer: acton393 
Committed: Tue May 15 15:55:12 2018 +0800

--
 WeexSDK.podspec | 3 +++
 ios/sdk/WeexSDK.xcodeproj/project.pbxproj   | 2 +-
 ios/sdk/WeexSDK/Sources/Layout/WXCoreStyle.h| 2 +-
 ios/sdk/WeexSDK/Sources/Layout/WXScrollerComponent+Layout.h | 4 
 4 files changed, 9 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/947767b4/WeexSDK.podspec
--
diff --git a/WeexSDK.podspec b/WeexSDK.podspec
index 53f0a17..5fe38ea 100644
--- a/WeexSDK.podspec
+++ b/WeexSDK.podspec
@@ -36,6 +36,9 @@ Pod::Spec.new do |s|
 
 #  s.xcconfig = { "GCC_PREPROCESSOR_DEFINITIONS" => '$(inherited) DEBUG=1' }
 
+  s.private_header_files = 
'ios/sdk/WeexSDK/Sources/Component/RecycleList/WXJSASTParser.h',
+   
'ios/sdk/WeexSDK/Sources/Layout/WXScrollerComponent+Layout.h'
+
   s.xcconfig = { "OTHER_LINK_FLAG" => '$(inherited) -ObjC'}
 
   s.frameworks = 
'CoreMedia','MediaPlayer','AVFoundation','AVKit','JavaScriptCore', 'GLKit', 
'OpenGLES', 'CoreText', 'QuartzCore', 'CoreGraphics'

http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/947767b4/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
--
diff --git a/ios/sdk/WeexSDK.xcodeproj/project.pbxproj 
b/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
index 04f689b..d5be6cc 100644
--- a/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
+++ b/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
@@ -508,7 +508,7 @@
DCA445C71EFA57F300D0CFA8 /* Layout.h in Headers */ = {isa = 
PBXBuildFile; fileRef = 59D3CA3F1CF9ED57008835DC /* Layout.h */; settings = 
{ATTRIBUTES = (Public, ); }; };
DCA445C91EFA58CE00D0CFA8 /* native-bundle-main.js in Resources 
*/ = {isa = PBXBuildFile; fileRef = DCF0CD9D1EAF3A6B0062CA8F /* 
native-bundle-main.js */; };
DCA445CA1EFA58CE00D0CFA8 /* wx_load_er...@3x.png in Resources 
*/ = {isa = PBXBuildFile; fileRef = 59AC02501D2A7E6E00355112 /* 
wx_load_er...@3x.png */; };
-   DCA445CB1EFA590600D0CFA8 /* WXComponent+Layout.h in Headers */ 
= {isa = PBXBuildFile; fileRef = 744BEA571D0520F300452B5D /* 
WXComponent+Layout.h */; };
+   DCA445CB1EFA590600D0CFA8 /* WXComponent+Layout.h in Headers */ 
= {isa = PBXBuildFile; fileRef = 744BEA571D0520F300452B5D /* 
WXComponent+Layout.h */; settings = {ATTRIBUTES = (Public, ); }; };
DCA445CC1EFA592800D0CFA8 /* WXResourceLoader.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 742AD7381DF98C8B007DC46C /* WXResourceLoader.h 
*/; settings = {ATTRIBUTES = (Public, ); }; };
DCA445CD1EFA592E00D0CFA8 /* WXComponent+Events.h in Headers */ 
= {isa = PBXBuildFile; fileRef = 7408C48C1CFB345D000BCCD0 /* 
WXComponent+Events.h */; };
DCA445CE1EFA593500D0CFA8 /* WXComponent+BoxShadow.h in Headers 
*/ = {isa = PBXBuildFile; fileRef = C4E375361E5FCBD3009B2D9C /* 
WXComponent+BoxShadow.h */; };

http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/947767b4/ios/sdk/WeexSDK/Sources/Layout/WXCoreStyle.h
--
diff --git a/ios/sdk/WeexSDK/Sources/Layout/WXCoreStyle.h 
b/ios/sdk/WeexSDK/Sources/Layout/WXCoreStyle.h
index bc7dd06..4289792 100644
--- a/ios/sdk/WeexSDK/Sources/Layout/WXCoreStyle.h
+++ b/ios/sdk/WeexSDK/Sources/Layout/WXCoreStyle.h
@@ -117,7 +117,7 @@ namespace WeexCore {
 }
 
 inline bool isNAN() {
-  return isnan(mTop) || isnan(mBottom) || isnan(mLeft) || isnan(mRight);
+return std::isnan(mTop) || std::isnan(mBottom) || std::isnan(mLeft) || 
std::isnan(mRight);
 }
 
 inline void reset() {

http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/947767b4/ios/sdk/WeexSDK/Sources/Layout/WXScrollerComponent+Layout.h
--
diff --git a/ios/sdk/WeexSDK/Sources/Layout/WXScrollerComponent+Layout.h 
b/ios/sdk/WeexSDK/Sources/Layout/WXScrollerComponent+Layout.h
index c9b633f..9af5170

[GitHub] incubator-weex issue #1176: [WEEX-364][iOS] support swift build

2018-05-15 Thread weex-bot 
Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/1176
  






  

  
  Messages

  
  
  :book:
  has no android file changed.

  

  :book:
  android test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---

[GitHub] incubator-weex pull request #1176: [WEEX-364][iOS] support swift build

2018-05-15 Thread lucky-chen 
GitHub user lucky-chen opened a pull request:

https://github.com/apache/incubator-weex/pull/1176

[WEEX-364][iOS] support swift build

fix c++/OC/swift  build issue

1. add  define ```_cplusplus```   with c++.h
2. use ```std::isnan``` to replace `isnan`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lucky-chen/incubator-weex ios_support_swift

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1176


commit 4708a9413e4c8f589528a6c123dc9f7031009e21
Author: zouming.zm 
Date:   2018-05-15T04:02:03Z

hide some prop in .h file

* [iOS] head newlayout node.h

* [iOS] fix compile error




---