[GitHub] incubator-weex issue #1365: [WEEX-528][iOS] fix textaera set padding-right i...
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1365 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS ---
[GitHub] incubator-weex issue #1364: [WEEX-504][iOS] set :active，placeho...
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1364 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS ---
[GitHub] incubator-weex pull request #1365: [WEEX-528][iOS] fix textaera set padding-...
GitHub user VIceguest opened a pull request: https://github.com/apache/incubator-weex/pull/1365 [WEEX-528][iOS] fix textaera set padding-right invalid http://dotwe.org/vue/7c839c2484f247095e27f0276acaabc8 placeholderå¨è®¾ç½®padding-rightæ¶æ¾ç¤ºä¹å¼å¸¸ You can merge this pull request into a Git repository by running: $ git pull https://github.com/VIceguest/incubator-weex 0.18.0-hotfix-textarea-padding-right Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1365.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1365 commit ce111effe2704bfc3406229d11b74621a34025db Author: jiangbin Date: 2018-07-24T05:51:09Z [WEEX-528][iOS] fix textaera set padding-right invalid ---
[GitHub] incubator-weex pull request #1364: [WEEX-504][iOS] set :active，...
GitHub user VIceguest opened a pull request: https://github.com/apache/incubator-weex/pull/1364 [WEEX-504][iOS] set :activeï¼placeholder display when activ⦠textarea 设置 :active伪类ï¼placeholderä¸æ¶å¤±ï¼ä¸å½åæåå å æ¾ç¤º demoåèhttp://dotwe.org/vue/c45ae83c092e7ca988ffc6952077d10a You can merge this pull request into a Git repository by running: $ git pull https://github.com/VIceguest/incubator-weex 0.18.0-hotfix-textarea-placeholder Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1364.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1364 commit 344557be8efacf3661b734315b2dc59e164d1e16 Author: jiangbin Date: 2018-07-24T05:48:36Z [WEEX-504][iOS] set :activeï¼placeholder display when active regardless of have text ---
[GitHub] incubator-weex issue #1363: [weex-529] [Android] Allow register custom gestu...
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1363 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS ---
[GitHub] incubator-weex pull request #1363: [weex-529] [Android] Allow register custo...
GitHub user Rowandjj opened a pull request: https://github.com/apache/incubator-weex/pull/1363 [weex-529] [Android] Allow register custom gesture listeners https://issues.apache.org/jira/browse/WEEX-529 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rowandjj/incubator-weex android-feature-gesture-v2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1363.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1363 commit c735686ab29b44d40bf827a60a1eb72ae42b254d Author: chuyi Date: 2018-07-23T06:20:13Z [WEEX-529] android WXGesture class allow add custom gesture listener ---
[GitHub] incubator-weex pull request #1362: [weex-529] [Android] Allow register custo...
Github user Rowandjj closed the pull request at: https://github.com/apache/incubator-weex/pull/1362 ---
[GitHub] incubator-weex pull request #1328: [WEEX-504][iOS] set :active，...
Github user VIceguest closed the pull request at: https://github.com/apache/incubator-weex/pull/1328 ---
[GitHub] incubator-weex pull request #1355: [WEEX-528][iOS] fix textaera set padding-...
Github user VIceguest closed the pull request at: https://github.com/apache/incubator-weex/pull/1355 ---
[GitHub] incubator-weex issue #1362: [weex-529] [Android] Allow register custom gestu...
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1362 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS ---
[GitHub] incubator-weex pull request #1362: [weex-529] [Android] Allow register custo...
GitHub user Rowandjj opened a pull request: https://github.com/apache/incubator-weex/pull/1362 [weex-529] [Android] Allow register custom gesture listeners https://issues.apache.org/jira/browse/WEEX-529 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rowandjj/incubator-weex android-feature-gesture Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1362 commit c735686ab29b44d40bf827a60a1eb72ae42b254d Author: chuyi Date: 2018-07-23T06:20:13Z [WEEX-529] android WXGesture class allow add custom gesture listener commit 82bb8965b5f310accc9376c02d32e6cd93889b55 Author: miomin Date: 2018-07-23T07:30:42Z * [android] Update libweexcore.so ---
[GitHub] incubator-weex issue #1361: * [WEEX-534][Android] Add JS Error Log in Graphi...
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1361 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS ---
[GitHub] incubator-weex pull request #1361: * [WEEX-534][Android] Add JS Error Log in...
GitHub user YorkShen opened a pull request: https://github.com/apache/incubator-weex/pull/1361 * [WEEX-534][Android] Add JS Error Log in GraphicActionAddElement https://issues.apache.org/jira/projects/WEEX/issues/WEEX-534 You can merge this pull request into a Git repository by running: $ git pull https://github.com/YorkShen/incubator-weex android_addElementException Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1361.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1361 commit 40e105cc7b2acec16d9ee72cb85a305b57191f6a Author: YorkShen Date: 2018-07-23T14:32:19Z * [Android] Add JS Error Log in GraphicActionAddElement Set component.view.ContentDescription to ref if there is no contentDescription. ---
incubator-weex git commit: [WEEX-527][Android] Sandbox support to debug
Repository: incubator-weex
Updated Branches:
refs/heads/master 291e48b3e -> a120d35e9
[WEEX-527][Android] Sandbox support to debug
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/a120d35e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/a120d35e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/a120d35e
Branch: refs/heads/master
Commit: a120d35e9f5dd5bf7448d5e729997bdfcebac973
Parents: 291e48b
Author: miomin
Authored: Fri Jul 20 17:32:34 2018 +0800
Committer: YorkShen
Committed: Mon Jul 23 20:27:54 2018 +0800
--
.../src/main/java/com/taobao/weex/WXEnvironment.java| 4 ++--
.../java/com/taobao/weex/bridge/WXBridgeManager.java| 12 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/a120d35e/android/sdk/src/main/java/com/taobao/weex/WXEnvironment.java
--
diff --git a/android/sdk/src/main/java/com/taobao/weex/WXEnvironment.java
b/android/sdk/src/main/java/com/taobao/weex/WXEnvironment.java
index 86d70c4..cdb3aeb 100644
--- a/android/sdk/src/main/java/com/taobao/weex/WXEnvironment.java
+++ b/android/sdk/src/main/java/com/taobao/weex/WXEnvironment.java
@@ -79,7 +79,7 @@ public class WXEnvironment {
* Debug model
*/
public static boolean sDebugMode = false;
- public static final boolean sForceEnableDevTool = false;
+ public static final boolean sForceEnableDevTool = true;
public static String sDebugWsUrl = "";
public static boolean sDebugServerConnectable = false;
public static boolean sRemoteDebugMode = false;
@@ -255,7 +255,7 @@ public class WXEnvironment {
*/
e.printStackTrace();
}
-return false;
+return true;
}
public static boolean isPerf() {
http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/a120d35e/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
--
diff --git
a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
index 02ae49c..c0bf2c5 100644
--- a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
+++ b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
@@ -224,7 +224,7 @@ public class WXBridgeManager implements Callback,
BactchExecutor {
setJSFrameworkInit(false);
WXModuleManager.resetAllModuleState();
String jsf = "";
-if (!isSandBoxContext || WXEnvironment.sDebugServerConnectable) {
+if (!isSandBoxContext) {
jsf = WXFileUtils.loadAsset("main.js",
WXEnvironment.getApplication());
} else {
jsf = WXFileUtils.loadAsset("weex-main-jsfm.js",
WXEnvironment.getApplication());
@@ -240,7 +240,7 @@ public class WXBridgeManager implements Callback,
BactchExecutor {
setJSFrameworkInit(false);
WXModuleManager.resetAllModuleState();
String jsf = "";
-if (!isSandBoxContext || WXEnvironment.sDebugServerConnectable) {
+if (!isSandBoxContext) {
jsf = WXFileUtils.loadAsset("main.js",
WXEnvironment.getApplication());
} else {
jsf = WXFileUtils.loadAsset("weex-main-jsfm.js",
WXEnvironment.getApplication());
@@ -1291,12 +1291,12 @@ public class WXBridgeManager implements Callback,
BactchExecutor {
// if { "framework": "Vue" } or { "framework": "Rax" } will use
invokeCreateInstanceContext
// others will use invokeExecJS
-if (!isSandBoxContext || WXEnvironment.sDebugServerConnectable) {
+if (!isSandBoxContext) {
invokeExecJS(instance.getInstanceId(), null, METHOD_CREATE_INSTANCE,
args, false);
return;
}
if (type == BundType.Vue || type == BundType.Rax) {
- invokeCreateInstanceContext(instance.getInstanceId(), null,
METHOD_CREATE_INSTANCE, args, false);
+ invokeCreateInstanceContext(instance.getInstanceId(), null,
"createInstanceContext", args, false);
return;
} else {
invokeExecJS(instance.getInstanceId(), null, METHOD_CREATE_INSTANCE,
args, false);
@@ -1315,7 +1315,7 @@ public class WXBridgeManager implements Callback,
BactchExecutor {
}
public WXJSObject optionObjConvert(boolean useSandBox, BundType type,
WXJSObject opt) {
-if (!useSandBox || type == BundType.Others ||
WXEnvironment.sDebugServerConnectable) {
+if (!useSandBox || type == BundType.Others) {
return opt;
}
try {
@@ -1604,7 +1604,7 @@ public class WXBridgeManager implements Callback,
BactchExecutor {
// if
[GitHub] incubator-weex issue #1360: * [WEEX-533][Android] Fix animation memory leak
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1360 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS ---
incubator-weex git commit: * [Android] Fix animation memory leak
Repository: incubator-weex
Updated Branches:
refs/heads/master 41038abc5 -> 291e48b3e
* [Android] Fix animation memory leak
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/291e48b3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/291e48b3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/291e48b3
Branch: refs/heads/master
Commit: 291e48b3e304305f5d71c2df484f952101450249
Parents: 41038ab
Author: YorkShen
Authored: Mon Jul 23 20:18:56 2018 +0800
Committer: YorkShen
Committed: Mon Jul 23 20:18:56 2018 +0800
--
android/sdk/src/main/java/com/taobao/weex/WXSDKEngine.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/291e48b3/android/sdk/src/main/java/com/taobao/weex/WXSDKEngine.java
--
diff --git a/android/sdk/src/main/java/com/taobao/weex/WXSDKEngine.java
b/android/sdk/src/main/java/com/taobao/weex/WXSDKEngine.java
index b7f7df6..c8c4d78 100644
--- a/android/sdk/src/main/java/com/taobao/weex/WXSDKEngine.java
+++ b/android/sdk/src/main/java/com/taobao/weex/WXSDKEngine.java
@@ -327,7 +327,7 @@ public class WXSDKEngine implements Serializable {
registerModule("modal", WXModalUIModule.class, false);
registerModule("instanceWrap", WXInstanceWrap.class, false);
- registerModule("animation", WXAnimationModule.class, true);
+ registerModule("animation", WXAnimationModule.class, false);
registerModule("webview", WXWebViewModule.class, true);
registerModule("navigator", WXNavigatorModule.class);
registerModule("stream", WXStreamModule.class);
[GitHub] incubator-weex pull request #1360: * [WEEX-533][Android] Fix animation memor...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex/pull/1360 ---
[GitHub] incubator-weex pull request #1360: * [WEEX-533][Android] Fix animation memor...
GitHub user YorkShen opened a pull request: https://github.com/apache/incubator-weex/pull/1360 * [WEEX-533][Android] Fix animation memory leak https://issues.apache.org/jira/browse/WEEX-533 You can merge this pull request into a Git repository by running: $ git pull https://github.com/YorkShen/incubator-weex bugfix_animation_memoryleak Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1360.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1360 commit 291e48b3e304305f5d71c2df484f952101450249 Author: YorkShen Date: 2018-07-23T12:18:56Z * [Android] Fix animation memory leak ---
[GitHub] incubator-weex pull request #1359: [WEEX-532][Android] Fix Iconfont issue
Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex/pull/1359 ---
incubator-weex git commit: * [android] Fix Iconfont issue
Repository: incubator-weex
Updated Branches:
refs/heads/master 907315429 -> 41038abc5
* [android] Fix Iconfont issue
http://rax.alibaba-inc.com/playground/28149825-d0c2-490a-b048-17832cf31886
This closes #1359
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/41038abc
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/41038abc
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/41038abc
Branch: refs/heads/master
Commit: 41038abc572d17af4e51f05f148ba8647aaa148f
Parents: 9073154
Author: YorkShen
Authored: Mon Jul 23 18:01:43 2018 +0800
Committer: YorkShen
Committed: Mon Jul 23 20:03:36 2018 +0800
--
android/sdk/src/main/java/com/taobao/weex/utils/FontDO.java | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/41038abc/android/sdk/src/main/java/com/taobao/weex/utils/FontDO.java
--
diff --git a/android/sdk/src/main/java/com/taobao/weex/utils/FontDO.java
b/android/sdk/src/main/java/com/taobao/weex/utils/FontDO.java
index ca81fa8..cc5d23f 100644
--- a/android/sdk/src/main/java/com/taobao/weex/utils/FontDO.java
+++ b/android/sdk/src/main/java/com/taobao/weex/utils/FontDO.java
@@ -100,7 +100,12 @@ public class FontDO {
String base64Data = data[1];
if (!TextUtils.isEmpty(base64Data)) {
String md5 = WXFileUtils.md5(base64Data);
-File tmpFile = new File(new
File(WXEnvironment.getApplication().getCacheDir(), "font-family"), md5);
+File cacheDir = new
File(WXEnvironment.getApplication().getCacheDir(),
+"font-family");
+if (!cacheDir.exists()) {
+ cacheDir.mkdirs();
+}
+File tmpFile = new File(cacheDir, md5);
if(!tmpFile.exists()){
tmpFile.createNewFile();
WXFileUtils.saveFile(tmpFile.getPath(),
Base64.decode(base64Data, Base64.DEFAULT), WXEnvironment.getApplication());
@@ -118,7 +123,7 @@ public class FontDO {
mState = STATE_INIT;
} catch (Exception e) {
mType = STATE_INVALID;
-WXLogUtils.e("TypefaceUtil", "URI.create(mUrl) failed mUrl: " + mUrl);
+WXLogUtils.e("TypefaceUtil", "URI.create(mUrl) failed mUrl: " + mUrl+
"\n"+ WXLogUtils.getStackTrace(e));
}
} else {
mUrl = src;
[GitHub] incubator-weex pull request #1357: [WEEX-524][iOS] Try to fix a crash operat...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex/pull/1357 ---
[1/2] incubator-weex git commit: Try to fix a crash operating mutable array in multi-thread
Repository: incubator-weex
Updated Branches:
refs/heads/master e36eec286 -> 907315429
Try to fix a crash operating mutable array in multi-thread
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/1172a3b6
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/1172a3b6
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/1172a3b6
Branch: refs/heads/master
Commit: 1172a3b62269b80f909ad17a2b07cbfe2300d7dd
Parents: e36eec2
Author: xuyouyang
Authored: Mon Jul 23 12:06:42 2018 +0800
Committer: xuyouyang
Committed: Mon Jul 23 12:06:42 2018 +0800
--
.../WeexSDK/Sources/Bridge/WXBridgeContext.m| 67 +++-
1 file changed, 37 insertions(+), 30 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/1172a3b6/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
--
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
index 6fab4ab..cfb0e7b 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
@@ -422,12 +422,13 @@ _Pragma("clang diagnostic pop") \
- (WXSDKInstance *)topInstance
{
-if (self.insStack.count > 0) {
-WXSDKInstance *topInstance = [WXSDKManager
instanceForID:[self.insStack firstObject]];
-return topInstance;
-}
-
-return nil;
+ WXSDKInstance *topInstance = nil;
+ @synchronized(self) {
+ if (self.insStack.count > 0) {
+ topInstance = [WXSDKManager
instanceForID:[self.insStack firstObject]];
+ }
+ }
+return topInstance;
}
- (NSMutableDictionary *)sendQueue
@@ -493,14 +494,16 @@ _Pragma("clang diagnostic pop") \
{
WXAssertBridgeThread();
WXAssertParam(instanceIdString);
-
-if (![self.insStack containsObject:instanceIdString]) {
-if ([options[@"RENDER_IN_ORDER"] boolValue]) {
-[self.insStack addObject:instanceIdString];
-} else {
-[self.insStack insertObject:instanceIdString atIndex:0];
-}
-}
+
+ @synchronized(self) {
+ if (![self.insStack containsObject:instanceIdString]) {
+ if ([options[@"RENDER_IN_ORDER"] boolValue]) {
+ [self.insStack addObject:instanceIdString];
+ } else {
+ [self.insStack insertObject:instanceIdString
atIndex:0];
+ }
+ }
+ }
//create a sendQueue bind to the current instance
NSMutableArray *sendQueue = [NSMutableArray array];
@@ -658,9 +661,11 @@ _Pragma("clang diagnostic pop") \
WXAssertParam(instance);
//remove instance from stack
-if([self.insStack containsObject:instance]){
-[self.insStack removeObject:instance];
-}
+ @synchronized(self) {
+ if([self.insStack containsObject:instance]){
+ [self.insStack removeObject:instance];
+ }
+ }
if(_jsBridge && [_jsBridge respondsToSelector:@selector(removeTimers:)]){
[_jsBridge removeTimers:instance];
@@ -896,19 +901,21 @@ _Pragma("clang diagnostic pop") \
BOOL hasTask = NO;
NSMutableArray *tasks = [NSMutableArray array];
NSString *execIns = nil;
-
-for (NSString *instance in self.insStack) {
-NSMutableArray *sendQueue = self.sendQueue[instance];
-if(sendQueue.count > 0){
-hasTask = YES;
-for(WXCallJSMethod *method in sendQueue){
-[tasks addObject:[method callJSTask]];
-}
-[sendQueue removeAllObjects];
-execIns = instance;
-break;
-}
-}
+
+ @synchronized(self) {
+ for (NSString *instance in self.insStack) {
+ NSMutableArray *sendQueue = self.sendQueue[instance];
+ if(sendQueue.count > 0){
+ hasTask = YES;
+ for(WXCallJSMethod *method in sendQueue){
+ [tasks addObject:[method callJSTask]];
+ }
+ [sendQueue removeAllObjects];
+ execIns = instance;
+ break;
+ }
+ }
+ }
if ([tasks count] > 0 && execIns) {
WXSDKInstance * execInstance = [WXSDKManager instanceForID:execIns];
[2/2] incubator-weex git commit: Try to fix a crash operating mutable array in multi-thread
Try to fix a crash operating mutable array in multi-thread
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/90731542
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/90731542
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/90731542
Branch: refs/heads/master
Commit: 907315429de7183bd64e39627f5c65e61b24d2f4
Parents: 1172a3b
Author: xuyouyang
Authored: Mon Jul 23 14:19:48 2018 +0800
Committer: xuyouyang
Committed: Mon Jul 23 14:19:48 2018 +0800
--
ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/90731542/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
--
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
index cfb0e7b..cbc7354 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
@@ -65,7 +65,7 @@ _Pragma("clang diagnostic pop") \
//store the methods which will be executed from native to js
@property (nonatomic, strong) NSMutableDictionary *sendQueue;
//the instance stack
-@property (nonatomic, strong) WXThreadSafeMutableArray*insStack;
+@property (nonatomic, strong) NSMutableArray*insStack;
//identify if the JSFramework has been loaded
@property (nonatomic) BOOL frameworkLoadFinished;
//store some methods temporarily before JSFramework is loaded
@@ -415,7 +415,7 @@ _Pragma("clang diagnostic pop") \
{
if (_insStack) return _insStack;
-_insStack = [WXThreadSafeMutableArray array];
+_insStack = [NSMutableArray array];
return _insStack;
}
@@ -662,9 +662,7 @@ _Pragma("clang diagnostic pop") \
//remove instance from stack
@synchronized(self) {
- if([self.insStack containsObject:instance]){
- [self.insStack removeObject:instance];
- }
+ [self.insStack removeObject:instance];
}
if(_jsBridge && [_jsBridge respondsToSelector:@selector(removeTimers:)]){
[GitHub] incubator-weex issue #1359: [WEEX-532][Android] Fix Iconfont issue
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1359 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS ---
[GitHub] incubator-weex pull request #1359: [WEEX-532][Android] Fix Iconfont issue
GitHub user YorkShen opened a pull request: https://github.com/apache/incubator-weex/pull/1359 [WEEX-532][Android] Fix Iconfont issue https://issues.apache.org/jira/browse/WEEX-532 You can merge this pull request into a Git repository by running: $ git pull https://github.com/YorkShen/incubator-weex android_iconfont Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1359.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1359 commit 8e47317e84f79e11f7ec588836109f8590efd568 Author: YorkShen Date: 2018-07-23T10:01:43Z * [android] Fix Iconfont issue http://rax.alibaba-inc.com/playground/28149825-d0c2-490a-b048-17832cf31886 ---
[GitHub] incubator-weex issue #1358: [WEEX-461][jsfm] Remove useless trace function i...
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1358 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS ---
[GitHub] incubator-weex pull request #1358: [WEEX-461][jsfm] Remove useless trace fun...
GitHub user Hanks10100 opened a pull request: https://github.com/apache/incubator-weex/pull/1358 [WEEX-461][jsfm] Remove useless trace function in js framework Stop tracking the DSL type in js framework. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Hanks10100/incubator-weex jsfm-feature-notrace Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1358.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1358 commit 0b2657c1061b8751b66ac2105a9685edc18eefb3 Author: Hanks Date: 2018-07-23T08:06:38Z [WEEX-461][jsfm] remove useless trace function in js framework ---
