[GitHub] cxfeng1 closed pull request #1757: [iOS] Fix deadlock if WXSDKInstance is released in lock area of thread safe diction…
cxfeng1 closed pull request #1757: [iOS] Fix deadlock if WXSDKInstance is
released in lock area of thread safe diction…
URL: https://github.com/apache/incubator-weex/pull/1757
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
index 0a75f5f16c..7c9529f8ff 100644
--- a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
+++ b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
@@ -80,7 +80,6 @@ @implementation WXSDKInstance
BOOL _debugJS;
id _instanceJavaScriptContext; // sandbox javaScript
context
CGFloat _defaultPixelScaleFactor;
-BOOL _bReleaseInstanceInMainThread;
BOOL _defaultDataRender;
}
@@ -120,7 +119,6 @@ - (instancetype)init
_apmInstance = [[WXApmForInstance alloc] init];
_defaultPixelScaleFactor = CGFLOAT_MIN;
-_bReleaseInstanceInMainThread = YES;
_defaultDataRender = NO;
[self addObservers];
@@ -445,9 +443,6 @@ - (BOOL)_handleConfigCenter
BOOL useJSCApiForCreateInstance = [[configCenter
configForKey:@"iOS_weex_ext_config.useJSCApiForCreateInstance"
defaultValue:@(YES) isDefault:NULL] boolValue];
[WXUtility setUseJSCApiForCreateInstance:useJSCApiForCreateInstance];
-
-//Reading config from orange for Release instance in Main Thread or not
-_bReleaseInstanceInMainThread = [[configCenter
configForKey:@"iOS_weex_ext_config.releaseInstanceInMainThread"
defaultValue:@(YES) isDefault:nil] boolValue];
BOOL shoudMultiContext = NO;
shoudMultiContext = [[configCenter
configForKey:@"iOS_weex_ext_config.createInstanceUsingMutliContext"
defaultValue:@(YES) isDefault:NULL] boolValue];
@@ -666,13 +661,9 @@ - (void)destroyInstance
[WXCoreBridge closePage:instanceId];
// Reading config from orange for Release instance in Main Thread or
not, for Bug #15172691 +{
-if (!_bReleaseInstanceInMainThread) {
+dispatch_async(dispatch_get_main_queue(), ^{
[WXSDKManager removeInstanceforID:instanceId];
-} else {
-dispatch_async(dispatch_get_main_queue(), ^{
-[WXSDKManager removeInstanceforID:instanceId];
-});
-}
+});
//+}
});
diff --git a/ios/sdk/WeexSDK/Sources/Utility/WXThreadSafeMutableDictionary.m
b/ios/sdk/WeexSDK/Sources/Utility/WXThreadSafeMutableDictionary.m
index 3c32292269..6f31fb990e 100644
--- a/ios/sdk/WeexSDK/Sources/Utility/WXThreadSafeMutableDictionary.m
+++ b/ios/sdk/WeexSDK/Sources/Utility/WXThreadSafeMutableDictionary.m
@@ -145,24 +145,30 @@ - (NSEnumerator *)keyEnumerator
- (void)setObject:(id)anObject forKey:(id)aKey
{
+id originalObject = nil; // make sure that object is not released in lock
@try {
pthread_mutex_lock(&_safeThreadDictionaryMutex);
+originalObject = [_dict objectForKey:aKey];
[_dict setObject:anObject forKey:aKey];
}
@finally {
pthread_mutex_unlock(&_safeThreadDictionaryMutex);
}
+originalObject = nil;
}
- (void)setObject:(id)anObject forKeyedSubscript:(id )key
{
+id originalObject = nil; // make sure that object is not released in lock
@try {
pthread_mutex_lock(&_safeThreadDictionaryMutex);
+originalObject = [_dict objectForKey:key];
[_dict setObject:anObject forKeyedSubscript:key];
}
@finally {
pthread_mutex_unlock(&_safeThreadDictionaryMutex);
}
+originalObject = nil;
}
- (NSArray *)allKeys
@@ -189,24 +195,32 @@ - (NSArray *)allValues
- (void)removeObjectForKey:(id)aKey
{
+id originalObject = nil; // make sure that object is not released in lock
@try {
pthread_mutex_lock(&_safeThreadDictionaryMutex);
-[_dict removeObjectForKey:aKey];
+originalObject = [_dict objectForKey:aKey];
+if (originalObject) {
+[_dict removeObjectForKey:aKey];
+}
}
@finally {
pthread_mutex_unlock(&_safeThreadDictionaryMutex);
}
+originalObject = nil;
}
- (void)removeAllObjects
{
+NSArray* allValues = nil; // make sure that objects are not released in
lock
@try {
pthread_mutex_lock(&_safeThreadDictionaryMutex);
+allValues = [_dict allValues];
[_dict removeAllObjects];
}
@finally {
pthread_mutex_unlock(&_safeThreadDictionaryMutex);
}
+allValues = nil;
}
- (id)copy
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the
[GitHub] wqyfavor opened a new pull request #1757: [iOS] Fix deadlock if WXSDKInstance is released in lock area of thread safe diction…
wqyfavor opened a new pull request #1757: [iOS] Fix deadlock if WXSDKInstance is released in lock area of thread safe diction… URL: https://github.com/apache/incubator-weex/pull/1757 …ary. First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Yhspehy edited a comment on issue #1728: render eroor: border in
Yhspehy edited a comment on issue #1728: render eroor: border in URL: https://github.com/apache/incubator-weex/issues/1728#issuecomment-438504639 @Hanks10100 i mean using border in scroller rather than div This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-weex] branch master updated: [iOS] fix renderWithUrl on data_render (#1756)
This is an automated email from the ASF dual-hosted git repository.
cxfeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git
The following commit(s) were added to refs/heads/master by this push:
new b920c01 [iOS] fix renderWithUrl on data_render (#1756)
b920c01 is described below
commit b920c0188cdf66303074f5fb3105cab3db682d24
Author: jianhan-he <41508406+jianhan...@users.noreply.github.com>
AuthorDate: Wed Nov 14 14:26:14 2018 +0800
[iOS] fix renderWithUrl on data_render (#1756)
---
ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
index 8cf079e..0a75f5f 100644
--- a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
+++ b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
@@ -235,9 +235,7 @@ typedef enum : NSUInteger {
WXLogError(@"Url must be passed if you use renderWithURL");
return;
}
-if ([url.absoluteString hasSuffix:WEEX_LITE_URL_SUFFIX]) {
-_defaultDataRender = YES;
-}
+
_scriptURL = url;
[self _checkPageName];
[self.apmInstance startRecord:self.instanceId];
@@ -278,7 +276,7 @@ typedef enum : NSUInteger {
}
if (_isRendered) {
-[WXExceptionUtils commitCriticalExceptionRT:self.instanceId
errCode:[NSString stringWithFormat:@"%d", WX_ERR_RENDER_TWICE]
function:@"_renderWithOpcode:" exception:[NSString stringWithFormat:@"instance
is rendered twice"] extParams:nil];
+[WXExceptionUtils commitCriticalExceptionRT:self.instanceId
errCode:[NSString stringWithFormat:@"%d", WX_ERR_RENDER_TWICE]
function:@"_renderWithData:" exception:[NSString stringWithFormat:@"instance is
rendered twice"] extParams:nil];
return;
}
@@ -336,9 +334,9 @@ typedef enum : NSUInteger {
return;
}
-[WXTracingManager startTracingWithInstanceId:self.instanceId ref:nil
className:nil name:WXTExecJS phase:WXTracingBegin
functionName:@"renderWithOpcode" options:@{@"threadName":WXTMainThread}];
+[WXTracingManager startTracingWithInstanceId:self.instanceId ref:nil
className:nil name:WXTExecJS phase:WXTracingBegin
functionName:@"_renderWithData" options:@{@"threadName":WXTMainThread}];
[[WXSDKManager bridgeMgr] createInstance:self.instanceId contents:contents
options:dictionary data:_jsData];
-[WXTracingManager startTracingWithInstanceId:self.instanceId ref:nil
className:nil name:WXTExecJS phase:WXTracingEnd
functionName:@"renderWithOpcode" options:@{@"threadName":WXTMainThread}];
+[WXTracingManager startTracingWithInstanceId:self.instanceId ref:nil
className:nil name:WXTExecJS phase:WXTracingEnd functionName:@"_renderWithData"
options:@{@"threadName":WXTMainThread}];
// WX_MONITOR_PERF_SET(WXPTBundleSize, [data length], self);
_isRendered = YES;
@@ -484,6 +482,11 @@ typedef enum : NSUInteger {
if (!newOptions[bundleUrlOptionKey]) {
newOptions[bundleUrlOptionKey] = url.absoluteString;
}
+
+if ([url.absoluteString hasSuffix:WEEX_LITE_URL_SUFFIX]) {
+newOptions[@"WLASM_RENDER"] = @(YES);
+}
+
// compatible with some wrong type, remove this hopefully in the future.
if ([newOptions[bundleUrlOptionKey] isKindOfClass:[NSURL class]]) {
WXLogWarning(@"Error type in options with key:bundleUrl, should be of
type NSString, not NSURL!");
@@ -542,7 +545,7 @@ typedef enum : NSUInteger {
return;
}
-if (strongSelf.dataRender) {
+if (([options[@"DATA_RENDER"] boolValue] &&
[options[@"RENDER_WITH_BINARY"] boolValue]) || [options[@"WLASM_RENDER"]
boolValue]) {
[strongSelf _renderWithData:data];
return;
}
@@ -779,7 +782,7 @@ typedef enum : NSUInteger {
- (BOOL)dataRender
{
-if ([_options[@"WLASM_RENDER"] boolValue]) {
+if ([_options[@"DATA_RENDER"] boolValue] || [_options[@"WLASM_RENDER"]
boolValue]) {
return YES;
}
return _defaultDataRender;
[GitHub] cxfeng1 closed pull request #1756: [iOS] fix renderWithUrl on data_render
cxfeng1 closed pull request #1756: [iOS] fix renderWithUrl on data_render
URL: https://github.com/apache/incubator-weex/pull/1756
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
index 8cf079e158..0a75f5f16c 100644
--- a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
+++ b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
@@ -235,9 +235,7 @@ - (void)renderWithURL:(NSURL *)url options:(NSDictionary
*)options data:(id)data
WXLogError(@"Url must be passed if you use renderWithURL");
return;
}
-if ([url.absoluteString hasSuffix:WEEX_LITE_URL_SUFFIX]) {
-_defaultDataRender = YES;
-}
+
_scriptURL = url;
[self _checkPageName];
[self.apmInstance startRecord:self.instanceId];
@@ -278,7 +276,7 @@ - (void)_renderWithData:(NSData *)contents
}
if (_isRendered) {
-[WXExceptionUtils commitCriticalExceptionRT:self.instanceId
errCode:[NSString stringWithFormat:@"%d", WX_ERR_RENDER_TWICE]
function:@"_renderWithOpcode:" exception:[NSString stringWithFormat:@"instance
is rendered twice"] extParams:nil];
+[WXExceptionUtils commitCriticalExceptionRT:self.instanceId
errCode:[NSString stringWithFormat:@"%d", WX_ERR_RENDER_TWICE]
function:@"_renderWithData:" exception:[NSString stringWithFormat:@"instance is
rendered twice"] extParams:nil];
return;
}
@@ -336,9 +334,9 @@ - (void)_renderWithData:(NSData *)contents
return;
}
-[WXTracingManager startTracingWithInstanceId:self.instanceId ref:nil
className:nil name:WXTExecJS phase:WXTracingBegin
functionName:@"renderWithOpcode" options:@{@"threadName":WXTMainThread}];
+[WXTracingManager startTracingWithInstanceId:self.instanceId ref:nil
className:nil name:WXTExecJS phase:WXTracingBegin
functionName:@"_renderWithData" options:@{@"threadName":WXTMainThread}];
[[WXSDKManager bridgeMgr] createInstance:self.instanceId contents:contents
options:dictionary data:_jsData];
-[WXTracingManager startTracingWithInstanceId:self.instanceId ref:nil
className:nil name:WXTExecJS phase:WXTracingEnd
functionName:@"renderWithOpcode" options:@{@"threadName":WXTMainThread}];
+[WXTracingManager startTracingWithInstanceId:self.instanceId ref:nil
className:nil name:WXTExecJS phase:WXTracingEnd functionName:@"_renderWithData"
options:@{@"threadName":WXTMainThread}];
// WX_MONITOR_PERF_SET(WXPTBundleSize, [data length], self);
_isRendered = YES;
@@ -484,6 +482,11 @@ - (void)_renderWithRequest:(WXResourceRequest *)request
options:(NSDictionary *)
if (!newOptions[bundleUrlOptionKey]) {
newOptions[bundleUrlOptionKey] = url.absoluteString;
}
+
+if ([url.absoluteString hasSuffix:WEEX_LITE_URL_SUFFIX]) {
+newOptions[@"WLASM_RENDER"] = @(YES);
+}
+
// compatible with some wrong type, remove this hopefully in the future.
if ([newOptions[bundleUrlOptionKey] isKindOfClass:[NSURL class]]) {
WXLogWarning(@"Error type in options with key:bundleUrl, should be of
type NSString, not NSURL!");
@@ -542,7 +545,7 @@ - (void)_renderWithRequest:(WXResourceRequest *)request
options:(NSDictionary *)
return;
}
-if (strongSelf.dataRender) {
+if (([options[@"DATA_RENDER"] boolValue] &&
[options[@"RENDER_WITH_BINARY"] boolValue]) || [options[@"WLASM_RENDER"]
boolValue]) {
[strongSelf _renderWithData:data];
return;
}
@@ -779,7 +782,7 @@ - (CGFloat)pixelScaleFactor
- (BOOL)dataRender
{
-if ([_options[@"WLASM_RENDER"] boolValue]) {
+if ([_options[@"DATA_RENDER"] boolValue] || [_options[@"WLASM_RENDER"]
boolValue]) {
return YES;
}
return _defaultDataRender;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] weex-bot edited a comment on issue #1756: [iOS] fix renderWithUrl on data_render
weex-bot edited a comment on issue #1756: [iOS] fix renderWithUrl on data_render URL: https://github.com/apache/incubator-weex/pull/1756#issuecomment-438552221 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1756: [iOS] fix renderWithUrl on data_render
weex-bot edited a comment on issue #1756: [iOS] fix renderWithUrl on data_render URL: https://github.com/apache/incubator-weex/pull/1756#issuecomment-438552221 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1756: [iOS] fix renderWithUrl on data_render
weex-bot commented on issue #1756: [iOS] fix renderWithUrl on data_render URL: https://github.com/apache/incubator-weex/pull/1756#issuecomment-438552221 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jianhan-he opened a new pull request #1756: [iOS] fix renderWithUrl on data_render
jianhan-he opened a new pull request #1756: [iOS] fix renderWithUrl on data_render URL: https://github.com/apache/incubator-weex/pull/1756 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl"
weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl"
weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl"
weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Fails :no_entry_sign: Code file weex_core/Source/android/jniprebuild/jniheader/NativeRenderObjectUtils_jni.h does not have the copyright header. Warnings :warning: No Changelog changes! :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java without metion it in commit message. You'd better add '@notdanger' in your commit log. Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1755: [Discussion] Move android build file to root
Hanks10100 commented on issue #1755: [Discussion] Move android build file to root URL: https://github.com/apache/incubator-weex/issues/1755#issuecomment-438516520 Thanks for your advice, but I don't think it's a good idea. Weex is a mixed technology, it contains both Android, iOS, and front-end projects, not just Android. The source codes of them are located in different folders, which is `android`, `ios`, `runtime`, and `weex_core`, they also wrote in different languages. I think it's a good idea to manage them separately, the root path should be reserved for readme, license, build scripts, and other platform-independent files. For those IDEs, I think we can do more configure things to make them easy to use. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 closed pull request #1753: [Release] Added missing Apache license
Hanks10100 closed pull request #1753: [Release] Added missing Apache license
URL: https://github.com/apache/incubator-weex/pull/1753
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/android/sdk/build.gradle b/android/sdk/build.gradle
index 3665675bba..85a6674f5b 100755
--- a/android/sdk/build.gradle
+++ b/android/sdk/build.gradle
@@ -1,3 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:2.3.3'
diff --git a/android/sdk/gradle.properties b/android/sdk/gradle.properties
index 08b9d65cdf..c621f8c509 100755
--- a/android/sdk/gradle.properties
+++ b/android/sdk/gradle.properties
@@ -1,3 +1,22 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
# Project-wide Gradle settings.
# IDE (e.g. Android Studio) users:
diff --git a/android/sdk/proguard-rules.pro b/android/sdk/proguard-rules.pro
index 73247bc730..957227f8c9 100755
--- a/android/sdk/proguard-rules.pro
+++ b/android/sdk/proguard-rules.pro
@@ -1,3 +1,22 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
# Add project specific ProGuard rules here.
# By default, the flags in this file are appended to flags specified
# in /Users/ouy/Library/AndroidStudio/sdk/tools/proguard/proguard-android.txt
@@ -19,4 +38,4 @@
-keep class com.taobao.weex.layout.** { *; }
-keep class com.taobao.weex.WXSDKEngine { *; }
-keep class com.taobao.weex.base.SystemMessageHandler { *; }
--dontwarn com.taobao.weex.bridge.**
\ No newline at end of file
+-dontwarn com.taobao.weex.bridge.**
diff --git a/android/sdk/publish.sh b/android/sdk/publish.sh
index 4d70a7ce00..7700dd320b 100755
--- a/android/sdk/publish.sh
+++ b/android/sdk/publish.sh
@@ -1,2 +1,21 @@
#!/usr/bin/env bash
-./gradlew clean assemble publish
\ No newline at end of file
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+#
[incubator-weex] branch rc-0.20.0 updated: [Release] Added the missing Apache license (#1753)
This is an automated email from the ASF dual-hosted git repository.
hanks pushed a commit to branch rc-0.20.0
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git
The following commit(s) were added to refs/heads/rc-0.20.0 by this push:
new 7139ca2 [Release] Added the missing Apache license (#1753)
7139ca2 is described below
commit 7139ca29c8223083ca8b6c09994852f376dea530
Author: Jonathan Dong
AuthorDate: Wed Nov 14 10:24:39 2018 +0800
[Release] Added the missing Apache license (#1753)
---
android/sdk/build.gradle | 19 +++
android/sdk/gradle.properties | 19 +++
android/sdk/proguard-rules.pro | 21 +++-
android/sdk/publish.sh | 21 +++-
weex_core/CMakeLists.txt | 18 +++
weex_core/Source/CMakeLists.txt| 18 +++
weex_core/Source/IPC/CMakeLists.txt| 19 +++
weex_core/Source/core/data_render/class_factory.cc | 37 +++---
weex_core/Source/core/data_render/tokenizer.cc | 27 +---
weex_core/Source/third_party/json11/CMakeLists.txt | 19 +++
weex_core/Source/weexjsc_version_script.txt| 18 +++
weex_core/Source/wson/CMakeLists.txt | 19 +++
12 files changed, 238 insertions(+), 17 deletions(-)
diff --git a/android/sdk/build.gradle b/android/sdk/build.gradle
index 3665675..85a6674 100755
--- a/android/sdk/build.gradle
+++ b/android/sdk/build.gradle
@@ -1,3 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:2.3.3'
diff --git a/android/sdk/gradle.properties b/android/sdk/gradle.properties
index 08b9d65..c621f8c 100755
--- a/android/sdk/gradle.properties
+++ b/android/sdk/gradle.properties
@@ -1,3 +1,22 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
# Project-wide Gradle settings.
# IDE (e.g. Android Studio) users:
diff --git a/android/sdk/proguard-rules.pro b/android/sdk/proguard-rules.pro
index 73247bc..957227f 100755
--- a/android/sdk/proguard-rules.pro
+++ b/android/sdk/proguard-rules.pro
@@ -1,3 +1,22 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
# Add project specific ProGuard rules here.
# By default, the flags in this file are appended to flags specified
# in /Users/ouy/Library/AndroidStudio/sdk/tools/proguard/proguard-android.txt
@@ -19,4 +38,4 @@
-keep class com.taobao.weex.layout.** { *; }
-keep class com.taobao.weex.WXSDKEngine { *; }
-keep class com.taobao.weex.base.SystemMessageHandler { *; }
--dontwarn
[GitHub] weex-bot edited a comment on issue #1753: [Release] Added missing Apache license
weex-bot edited a comment on issue #1753: [Release] Added missing Apache license URL: https://github.com/apache/incubator-weex/pull/1753#issuecomment-438293579 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jondong commented on issue #1753: [Release] Added missing Apache license
jondong commented on issue #1753: [Release] Added missing Apache license URL: https://github.com/apache/incubator-weex/pull/1753#issuecomment-438505532 @Hanks10100 PTAL again, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1753: [Release] Added missing Apache license
weex-bot edited a comment on issue #1753: [Release] Added missing Apache license URL: https://github.com/apache/incubator-weex/pull/1753#issuecomment-438293579 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1753: [Release] Added missing Apache license
weex-bot edited a comment on issue #1753: [Release] Added missing Apache license URL: https://github.com/apache/incubator-weex/pull/1753#issuecomment-438293579 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jondong commented on a change in pull request #1753: [Release] Added missing Apache license
jondong commented on a change in pull request #1753: [Release] Added missing Apache license URL: https://github.com/apache/incubator-weex/pull/1753#discussion_r233287521 ## File path: runtime/frameworks/legacy/core/array.js ## @@ -1,5 +1,22 @@ /* eslint-disable */ - +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ Review comment: Got it. will reformat the patch. thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Yhspehy edited a comment on issue #1728: render eroor: border in
Yhspehy edited a comment on issue #1728: render eroor: border in URL: https://github.com/apache/incubator-weex/issues/1728#issuecomment-438504639 @Hanks10100 i mean using border in scroller instead of div This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Yhspehy commented on issue #1728: render eroor: border in
Yhspehy commented on issue #1728: render eroor: border in URL: https://github.com/apache/incubator-weex/issues/1728#issuecomment-438504639 @Hanks10100 i mean using border in instead of This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gengjiawen opened a new issue #1755: [Discussion] Move android build file to root
gengjiawen opened a new issue #1755: [Discussion] Move android build file to root URL: https://github.com/apache/incubator-weex/issues/1755 Currently it's in android folder, it make IDE like android studio and IntelliJ IDEA hard to view other directory like cpp code. I can send a pr to this, but I would like to know will this kind of change will be accept. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool)
weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool)
weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool)
weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1330: [android]update zxing core to gradle dependency
weex-bot edited a comment on issue #1330: [android]update zxing core to gradle dependency URL: https://github.com/apache/incubator-weex/pull/1330#issuecomment-405150844 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1330: [android]update zxing core to gradle dependency
weex-bot edited a comment on issue #1330: [android]update zxing core to gradle dependency URL: https://github.com/apache/incubator-weex/pull/1330#issuecomment-405150844 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1330: [android]update zxing core to gradle dependency
weex-bot edited a comment on issue #1330: [android]update zxing core to gradle dependency URL: https://github.com/apache/incubator-weex/pull/1330#issuecomment-405150844 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gengjiawen commented on issue #1330: [android]update zxing core to gradle dependency
gengjiawen commented on issue #1330: [android]update zxing core to gradle dependency URL: https://github.com/apache/incubator-weex/pull/1330#issuecomment-438314130 @YorkShen Can you review this pr, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cxfeng1 closed pull request #1750: [WEEX-660][iOS]add component ignoreInteraction flag (bad case addEle…
cxfeng1 closed pull request #1750: [WEEX-660][iOS]add component
ignoreInteraction flag (bad case addEle…
URL: https://github.com/apache/incubator-weex/pull/1750
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
b/ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
index e9b1733e7f..434ef36dad 100644
--- a/ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
+++ b/ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
@@ -40,6 +40,7 @@
#import "WXRootView.h"
#import "WXComponent+Layout.h"
#import "WXCoreBridge.h"
+#import "WXComponent_performance.h"
static NSThread *WXComponentThread;
@@ -279,6 +280,12 @@ - (void)addComponent:(NSString*)ref
} else {
index = (index == -1 ? supercomponent->_subcomponents.count : index);
}
+if (supercomponent.ignoreInteraction) {
+component.ignoreInteraction = YES;
+}
+if ([[component.attributes objectForKey:@"ignoreInteraction"]
isEqualToString:@"1"]) {
+component.ignoreInteraction = YES;
+}
#ifdef DEBUG
WXLogDebug(@"flexLayout -> _recursivelyAddComponent :
super:(%@,%@):[%f,%f] ,child:(%@,%@):[%f,%f],childClass:%@",
diff --git a/ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h
b/ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h
index 17153ee160..bbc18cf4e1 100644
--- a/ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h
+++ b/ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h
@@ -21,6 +21,7 @@
@interface WXComponent()
-@property (nonatomic,assign) bool hasAdd;
+@property (nonatomic,assign) BOOL hasAdd;
+@property (nonatomic,assign) BOOL ignoreInteraction;
@end
diff --git a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance_performance.m
b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance_performance.m
index 49da81345e..a8002b9fab 100644
--- a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance_performance.m
+++ b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance_performance.m
@@ -70,6 +70,9 @@ - (void) _handleRenderTime:(WXComponent*)targetComponent
withModifyTime:(double)
if (nil == targetComponent) {
return;
}
+if (targetComponent.ignoreInteraction) {
+return;
+}
double diff = modifyTime - self.renderTimeOrigin;
if (diff > 8000) {
return;
@@ -85,11 +88,8 @@ - (void) _handleRenderTime:(WXComponent*)targetComponent
withModifyTime:(double)
CGRect absoluteFrame = [targetComponent.view.superview
convertRect:targetComponent.view.frame
toView:targetComponent.weexInstance.rootView];
CGRect rootFrame = targetComponent.weexInstance.rootView.frame;
-CGPoint leftTop = absoluteFrame.origin;
-CGPoint rightBottom =
CGPointMake(absoluteFrame.origin.x+absoluteFrame.size.width,
absoluteFrame.origin.y+absoluteFrame.size.height);
-
-if (!self.hasRecordFsRenderTimeByPosition && rightBottom.y >
rootFrame.size.height +1 && ![self _isViewGroup:targetComponent] ) {
+if (!self.hasRecordFsRenderTimeByPosition &&
absoluteFrame.origin.y+absoluteFrame.size.height > rootFrame.size.height +1 &&
![self _isViewGroup:targetComponent] ) {
self.newFsRenderTime = diff;
self.hasRecordFsRenderTimeByPosition = true;
[targetComponent.weexInstance.apmInstance
onStage:KEY_PAGE_STAGES_NEW_FSRENDER];
@@ -107,18 +107,17 @@ - (void) _handleRenderTime:(WXComponent*)targetComponent
withModifyTime:(double)
return;
}
-bool inScreen = CGRectContainsPoint(rootFrame, leftTop) ||
CGRectContainsPoint(rootFrame, rightBottom);
+bool inScreen = CGRectIntersectsRect(rootFrame, absoluteFrame);
if (!inScreen) {
return;
}
#ifdef DEBUG
-WXLogDebug(@"onElementChange _-> size, count :%f,inScreen:%d,
lefttop:%@,rightBottom:%@, rootFrame:%@",
+WXLogDebug(@"onElementChange _-> size, count :%f,inScreen:%d,
type:%@,attr:%@",
self.interactionAddCountRecord,
inScreen,
- NSStringFromCGPoint(leftTop),
- NSStringFromCGPoint(rightBottom),
- NSStringFromCGRect(targetComponent.weexInstance.rootView.frame)
+ targetComponent.type,
+ targetComponent.attributes
);
#endif
if
(!targetComponent.weexInstance.apmInstance.hasRecordFirstInterationView) {
diff --git a/ios/sdk/WeexSDK/Sources/Monitor/WXMonitor.m
b/ios/sdk/WeexSDK/Sources/Monitor/WXMonitor.m
index 1abe38f83d..d7fafd7532 100644
--- a/ios/sdk/WeexSDK/Sources/Monitor/WXMonitor.m
+++ b/ios/sdk/WeexSDK/Sources/Monitor/WXMonitor.m
@@ -55,7 +55,7 @@ + (void)performancePoint:(WXPerformanceTag)tag
didEndWithInstance:(WXSDKInstance
NSMutableDictionary *performanceDict = [self
performanceDictForInstance:instance];
NSMutableDictionary *dict =
[incubator-weex] branch master updated: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addElement onScreen with loop) (#1750)
This is an automated email from the ASF dual-hosted git repository.
cxfeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git
The following commit(s) were added to refs/heads/master by this push:
new a1f6823 *[iOS][WEEX-660]add component ignoreInteraction flag (bad
case addElement onScreen with loop) (#1750)
a1f6823 is described below
commit a1f682395e132231056ecb960cd38ebf7f143b96
Author: chen
AuthorDate: Tue Nov 13 23:44:46 2018 +0800
*[iOS][WEEX-660]add component ignoreInteraction flag (bad case addElement
onScreen with loop) (#1750)
use method CGRectIntersectsRect
---
ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm | 7 +++
ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h | 3 ++-
.../WeexSDK/Sources/Model/WXSDKInstance_performance.m | 17 -
ios/sdk/WeexSDK/Sources/Monitor/WXMonitor.m | 4 ++--
ios/sdk/WeexSDK/Sources/Performance/WXApmForInstance.h | 1 +
ios/sdk/WeexSDK/Sources/Performance/WXApmForInstance.m | 10 ++
6 files changed, 30 insertions(+), 12 deletions(-)
diff --git a/ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
b/ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
index e9b1733..434ef36 100644
--- a/ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
+++ b/ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
@@ -40,6 +40,7 @@
#import "WXRootView.h"
#import "WXComponent+Layout.h"
#import "WXCoreBridge.h"
+#import "WXComponent_performance.h"
static NSThread *WXComponentThread;
@@ -279,6 +280,12 @@ static NSThread *WXComponentThread;
} else {
index = (index == -1 ? supercomponent->_subcomponents.count : index);
}
+if (supercomponent.ignoreInteraction) {
+component.ignoreInteraction = YES;
+}
+if ([[component.attributes objectForKey:@"ignoreInteraction"]
isEqualToString:@"1"]) {
+component.ignoreInteraction = YES;
+}
#ifdef DEBUG
WXLogDebug(@"flexLayout -> _recursivelyAddComponent :
super:(%@,%@):[%f,%f] ,child:(%@,%@):[%f,%f],childClass:%@",
diff --git a/ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h
b/ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h
index 17153ee..bbc18cf 100644
--- a/ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h
+++ b/ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h
@@ -21,6 +21,7 @@
@interface WXComponent()
-@property (nonatomic,assign) bool hasAdd;
+@property (nonatomic,assign) BOOL hasAdd;
+@property (nonatomic,assign) BOOL ignoreInteraction;
@end
diff --git a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance_performance.m
b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance_performance.m
index 49da813..a8002b9 100644
--- a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance_performance.m
+++ b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance_performance.m
@@ -70,6 +70,9 @@
if (nil == targetComponent) {
return;
}
+if (targetComponent.ignoreInteraction) {
+return;
+}
double diff = modifyTime - self.renderTimeOrigin;
if (diff > 8000) {
return;
@@ -85,11 +88,8 @@
CGRect absoluteFrame = [targetComponent.view.superview
convertRect:targetComponent.view.frame
toView:targetComponent.weexInstance.rootView];
CGRect rootFrame = targetComponent.weexInstance.rootView.frame;
-CGPoint leftTop = absoluteFrame.origin;
-CGPoint rightBottom =
CGPointMake(absoluteFrame.origin.x+absoluteFrame.size.width,
absoluteFrame.origin.y+absoluteFrame.size.height);
-
-if (!self.hasRecordFsRenderTimeByPosition && rightBottom.y >
rootFrame.size.height +1 && ![self _isViewGroup:targetComponent] ) {
+if (!self.hasRecordFsRenderTimeByPosition &&
absoluteFrame.origin.y+absoluteFrame.size.height > rootFrame.size.height +1 &&
![self _isViewGroup:targetComponent] ) {
self.newFsRenderTime = diff;
self.hasRecordFsRenderTimeByPosition = true;
[targetComponent.weexInstance.apmInstance
onStage:KEY_PAGE_STAGES_NEW_FSRENDER];
@@ -107,18 +107,17 @@
return;
}
-bool inScreen = CGRectContainsPoint(rootFrame, leftTop) ||
CGRectContainsPoint(rootFrame, rightBottom);
+bool inScreen = CGRectIntersectsRect(rootFrame, absoluteFrame);
if (!inScreen) {
return;
}
#ifdef DEBUG
-WXLogDebug(@"onElementChange _-> size, count :%f,inScreen:%d,
lefttop:%@,rightBottom:%@, rootFrame:%@",
+WXLogDebug(@"onElementChange _-> size, count :%f,inScreen:%d,
type:%@,attr:%@",
self.interactionAddCountRecord,
inScreen,
- NSStringFromCGPoint(leftTop),
- NSStringFromCGPoint(rightBottom),
- NSStringFromCGRect(targetComponent.weexInstance.rootView.frame)
+ targetComponent.type,
+ targetComponent.attributes
);
#endif
if
(!targetComponent.weexInstance.apmInstance.hasRecordFirstInterationView) {
diff --git
[incubator-weex] branch master updated: [iOS] fix weexsdk compile error (#1754)
This is an automated email from the ASF dual-hosted git repository.
kyork pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git
The following commit(s) were added to refs/heads/master by this push:
new 0dc92f3 [iOS] fix weexsdk compile error (#1754)
0dc92f3 is described below
commit 0dc92f348ec266fb97a9233c19a0846b2726b5a0
Author: jianhan-he <41508406+jianhan...@users.noreply.github.com>
AuthorDate: Tue Nov 13 23:40:09 2018 +0800
[iOS] fix weexsdk compile error (#1754)
---
ios/sdk/WeexSDK.xcodeproj/project.pbxproj | 44 +-
weex_core/Source/base/LogDefines.h | 2 -
.../core/data_render/vnode/vnode_render_manager.cc | 13 ++-
3 files changed, 55 insertions(+), 4 deletions(-)
diff --git a/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
b/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
index bfbf06c..11eb08f 100644
--- a/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
+++ b/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
@@ -71,6 +71,25 @@
33CE19142153444900CF9670 /* WXJSFrameworkLoadProtocol.h in
Headers */ = {isa = PBXBuildFile; fileRef = 33CE19122153444900CF9670 /*
WXJSFrameworkLoadProtocol.h */; settings = {ATTRIBUTES = (Public, ); }; };
37B51EE41E97804D0040A743 /* WXCycleSliderComponent.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 37B51EE21E97804D0040A743 /*
WXCycleSliderComponent.h */; };
37B51EE51E97804D0040A743 /* WXCycleSliderComponent.mm in
Sources */ = {isa = PBXBuildFile; fileRef = 37B51EE31E97804D0040A743 /*
WXCycleSliderComponent.mm */; };
+ 4505D11B219B1F720083A1A2 /* class_math.h in Headers */ = {isa =
PBXBuildFile; fileRef = 4505D119219B1F710083A1A2 /* class_math.h */; };
+ 4505D11C219B1F720083A1A2 /* class_math.cc in Sources */ = {isa
= PBXBuildFile; fileRef = 4505D11A219B1F710083A1A2 /* class_math.cc */; };
+ 4505D11D219B1F9E0083A1A2 /* class_math.cc in Sources */ = {isa
= PBXBuildFile; fileRef = 4505D11A219B1F710083A1A2 /* class_math.cc */; };
+ 4505D11E219B1FAC0083A1A2 /* class_math.h in Headers */ = {isa =
PBXBuildFile; fileRef = 4505D119219B1F710083A1A2 /* class_math.h */; };
+ 4505D11F219B20290083A1A2 /* vcomponent.cc in Sources */ = {isa
= PBXBuildFile; fileRef = 453267132140E38900DAA620 /* vcomponent.cc */; };
+ 4505D120219B20310083A1A2 /* vcomponent.h in Headers */ = {isa =
PBXBuildFile; fileRef = 453267122140E38900DAA620 /* vcomponent.h */; };
+ 4505D121219B206B0083A1A2 /* exec_state_binary.cc in Sources */
= {isa = PBXBuildFile; fileRef = 98399A7F21916A9600D83CCE /*
exec_state_binary.cc */; };
+ 4505D122219B207D0083A1A2 /* exec_state_binary.h in Headers */ =
{isa = PBXBuildFile; fileRef = 98399A8121916A9600D83CCE /* exec_state_binary.h
*/; };
+ 4505D124219B20A80083A1A2 /* exec_state_section.cc in Sources */
= {isa = PBXBuildFile; fileRef = 98399A7E21916A9600D83CCE /*
exec_state_section.cc */; };
+ 4505D125219B20B20083A1A2 /* exec_state_section.h in Headers */
= {isa = PBXBuildFile; fileRef = 98399A8821916A9700D83CCE /*
exec_state_section.h */; };
+ 4505D126219B20DA0083A1A2 /* class_function.cc in Sources */ =
{isa = PBXBuildFile; fileRef = 98399A8421916A9700D83CCE /* class_function.cc
*/; };
+ 4505D127219B20E70083A1A2 /* class_function.h in Headers */ =
{isa = PBXBuildFile; fileRef = 98399A8921916A9800D83CCE /* class_function.h */;
};
+ 4505D128219B21110083A1A2 /* class_console.cc in Sources */ =
{isa = PBXBuildFile; fileRef = 98399A8221916A9700D83CCE /* class_console.cc */;
};
+ 4505D129219B211D0083A1A2 /* class_console.h in Headers */ =
{isa = PBXBuildFile; fileRef = 98399A8621916A9700D83CCE /* class_console.h */;
};
+ 4505D12A219B213B0083A1A2 /* class_regex.cc in Sources */ = {isa
= PBXBuildFile; fileRef = 98399A8021916A9600D83CCE /* class_regex.cc */; };
+ 4505D12B219B21470083A1A2 /* class_regex.h in Headers */ = {isa
= PBXBuildFile; fileRef = 98399A8721916A9700D83CCE /* class_regex.h */; };
+ 4505D12C219B216D0083A1A2 /* class_window.cc in Sources */ =
{isa = PBXBuildFile; fileRef = 98399A8321916A9700D83CCE /* class_window.cc */;
};
+ 4505D12D219B21760083A1A2 /* class_window.h in Headers */ = {isa
= PBXBuildFile; fileRef = 98399A8521916A9700D83CCE /* class_window.h */; };
+ 4505D12E219B22630083A1A2 /* op_code.cc in Sources */ = {isa =
PBXBuildFile; fileRef = 98399A8A21916A9800D83CCE /* op_code.cc */; };
4532670A213FC84A00DAA620 /* WXDisplayLinkManager.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 45326708213FC84900DAA620 /*
WXDisplayLinkManager.h */; settings = {ATTRIBUTES = (Public, ); }; };
4532670B213FC84A00DAA620 /* WXDisplayLinkManager.m in Sources
*/ = {isa = PBXBuildFile; fileRef =
[GitHub] YorkShen closed pull request #1754: [iOS] fix weexsdk compile error
YorkShen closed pull request #1754: [iOS] fix weexsdk compile error
URL: https://github.com/apache/incubator-weex/pull/1754
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
b/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
index bfbf06cf5d..11eb08fa2d 100644
--- a/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
+++ b/ios/sdk/WeexSDK.xcodeproj/project.pbxproj
@@ -71,6 +71,25 @@
33CE19142153444900CF9670 /* WXJSFrameworkLoadProtocol.h in
Headers */ = {isa = PBXBuildFile; fileRef = 33CE19122153444900CF9670 /*
WXJSFrameworkLoadProtocol.h */; settings = {ATTRIBUTES = (Public, ); }; };
37B51EE41E97804D0040A743 /* WXCycleSliderComponent.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 37B51EE21E97804D0040A743 /*
WXCycleSliderComponent.h */; };
37B51EE51E97804D0040A743 /* WXCycleSliderComponent.mm in
Sources */ = {isa = PBXBuildFile; fileRef = 37B51EE31E97804D0040A743 /*
WXCycleSliderComponent.mm */; };
+ 4505D11B219B1F720083A1A2 /* class_math.h in Headers */ = {isa =
PBXBuildFile; fileRef = 4505D119219B1F710083A1A2 /* class_math.h */; };
+ 4505D11C219B1F720083A1A2 /* class_math.cc in Sources */ = {isa
= PBXBuildFile; fileRef = 4505D11A219B1F710083A1A2 /* class_math.cc */; };
+ 4505D11D219B1F9E0083A1A2 /* class_math.cc in Sources */ = {isa
= PBXBuildFile; fileRef = 4505D11A219B1F710083A1A2 /* class_math.cc */; };
+ 4505D11E219B1FAC0083A1A2 /* class_math.h in Headers */ = {isa =
PBXBuildFile; fileRef = 4505D119219B1F710083A1A2 /* class_math.h */; };
+ 4505D11F219B20290083A1A2 /* vcomponent.cc in Sources */ = {isa
= PBXBuildFile; fileRef = 453267132140E38900DAA620 /* vcomponent.cc */; };
+ 4505D120219B20310083A1A2 /* vcomponent.h in Headers */ = {isa =
PBXBuildFile; fileRef = 453267122140E38900DAA620 /* vcomponent.h */; };
+ 4505D121219B206B0083A1A2 /* exec_state_binary.cc in Sources */
= {isa = PBXBuildFile; fileRef = 98399A7F21916A9600D83CCE /*
exec_state_binary.cc */; };
+ 4505D122219B207D0083A1A2 /* exec_state_binary.h in Headers */ =
{isa = PBXBuildFile; fileRef = 98399A8121916A9600D83CCE /* exec_state_binary.h
*/; };
+ 4505D124219B20A80083A1A2 /* exec_state_section.cc in Sources */
= {isa = PBXBuildFile; fileRef = 98399A7E21916A9600D83CCE /*
exec_state_section.cc */; };
+ 4505D125219B20B20083A1A2 /* exec_state_section.h in Headers */
= {isa = PBXBuildFile; fileRef = 98399A8821916A9700D83CCE /*
exec_state_section.h */; };
+ 4505D126219B20DA0083A1A2 /* class_function.cc in Sources */ =
{isa = PBXBuildFile; fileRef = 98399A8421916A9700D83CCE /* class_function.cc
*/; };
+ 4505D127219B20E70083A1A2 /* class_function.h in Headers */ =
{isa = PBXBuildFile; fileRef = 98399A8921916A9800D83CCE /* class_function.h */;
};
+ 4505D128219B21110083A1A2 /* class_console.cc in Sources */ =
{isa = PBXBuildFile; fileRef = 98399A8221916A9700D83CCE /* class_console.cc */;
};
+ 4505D129219B211D0083A1A2 /* class_console.h in Headers */ =
{isa = PBXBuildFile; fileRef = 98399A8621916A9700D83CCE /* class_console.h */;
};
+ 4505D12A219B213B0083A1A2 /* class_regex.cc in Sources */ = {isa
= PBXBuildFile; fileRef = 98399A8021916A9600D83CCE /* class_regex.cc */; };
+ 4505D12B219B21470083A1A2 /* class_regex.h in Headers */ = {isa
= PBXBuildFile; fileRef = 98399A8721916A9700D83CCE /* class_regex.h */; };
+ 4505D12C219B216D0083A1A2 /* class_window.cc in Sources */ =
{isa = PBXBuildFile; fileRef = 98399A8321916A9700D83CCE /* class_window.cc */;
};
+ 4505D12D219B21760083A1A2 /* class_window.h in Headers */ = {isa
= PBXBuildFile; fileRef = 98399A8521916A9700D83CCE /* class_window.h */; };
+ 4505D12E219B22630083A1A2 /* op_code.cc in Sources */ = {isa =
PBXBuildFile; fileRef = 98399A8A21916A9800D83CCE /* op_code.cc */; };
4532670A213FC84A00DAA620 /* WXDisplayLinkManager.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 45326708213FC84900DAA620 /*
WXDisplayLinkManager.h */; settings = {ATTRIBUTES = (Public, ); }; };
4532670B213FC84A00DAA620 /* WXDisplayLinkManager.m in Sources
*/ = {isa = PBXBuildFile; fileRef = 45326709213FC84900DAA620 /*
WXDisplayLinkManager.m */; };
4532670C213FCF2300DAA620 /* WXDisplayLinkManager.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 45326708213FC84900DAA620 /*
WXDisplayLinkManager.h */; settings = {ATTRIBUTES = (Public, ); }; };
@@ -1090,6 +1109,8 @@
33CE19122153444900CF9670 /* WXJSFrameworkLoadProtocol.h */ =
{isa = PBXFileReference;
[GitHub] weex-bot edited a comment on issue #1754: [iOS] fix weexsdk compile error
weex-bot edited a comment on issue #1754: [iOS] fix weexsdk compile error URL: https://github.com/apache/incubator-weex/pull/1754#issuecomment-438304710 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1754: [iOS] fix weexsdk compile error
weex-bot edited a comment on issue #1754: [iOS] fix weexsdk compile error URL: https://github.com/apache/incubator-weex/pull/1754#issuecomment-438304710 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1754: [iOS] fix weexsdk compile error
weex-bot commented on issue #1754: [iOS] fix weexsdk compile error URL: https://github.com/apache/incubator-weex/pull/1754#issuecomment-438304710 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jianhan-he opened a new pull request #1754: [iOS] fix weexsdk compile error
jianhan-he opened a new pull request #1754: [iOS] fix weexsdk compile error URL: https://github.com/apache/incubator-weex/pull/1754 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on a change in pull request #1753: [Release] Added missing Apache license
Hanks10100 commented on a change in pull request #1753: [Release] Added missing Apache license URL: https://github.com/apache/incubator-weex/pull/1753#discussion_r233074819 ## File path: runtime/frameworks/legacy/core/array.js ## @@ -1,5 +1,22 @@ /* eslint-disable */ - +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ Review comment: Actually, these files are copied from Vue.js v1.0.12 which is using MIT license, so they should not include the Apache 2.0 license comments. We have already mentioned it in the LICENSE file, please refer to https://github.com/apache/incubator-weex/blob/0.19.0/LICENSE#L213-L242 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1753: [Release] Added missing Apache license
weex-bot edited a comment on issue #1753: [Release] Added missing Apache license URL: https://github.com/apache/incubator-weex/pull/1753#issuecomment-438293579 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1753: [Release] Added missing Apache license
weex-bot edited a comment on issue #1753: [Release] Added missing Apache license URL: https://github.com/apache/incubator-weex/pull/1753#issuecomment-438293579 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1753: [Release] Added missing Apache license
weex-bot commented on issue #1753: [Release] Added missing Apache license URL: https://github.com/apache/incubator-weex/pull/1753#issuecomment-438293579 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jondong commented on issue #1753: [Release] Added missing Apache license
jondong commented on issue #1753: [Release] Added missing Apache license URL: https://github.com/apache/incubator-weex/pull/1753#issuecomment-438293325 @cxfeng1 @Hanks10100 @YorkShen PTAL, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jondong opened a new pull request #1753: [Release] Added missing Apache license
jondong opened a new pull request #1753: [Release] Added missing Apache license URL: https://github.com/apache/incubator-weex/pull/1753 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jondong closed pull request #1752: [Release] Added missing Apache license
jondong closed pull request #1752: [Release] Added missing Apache license
URL: https://github.com/apache/incubator-weex/pull/1752
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/android/playground/app/build.gradle
b/android/playground/app/build.gradle
index ba27f35f4f..6870572ef6 100755
--- a/android/playground/app/build.gradle
+++ b/android/playground/app/build.gradle
@@ -13,7 +13,7 @@ android {
minSdkVersion project.minSdkVersion
targetSdkVersion project.targetSdkVersion
versionCode 17
-versionName "0.19.0"
+versionName "0.20.0"
testInstrumentationRunner
"android.support.test.runner.AndroidJUnitRunner"
multiDexEnabled true
ndk{
diff --git a/android/sdk/build.gradle b/android/sdk/build.gradle
index 476d6736ac..85a6674f5b 100755
--- a/android/sdk/build.gradle
+++ b/android/sdk/build.gradle
@@ -1,3 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:2.3.3'
@@ -36,7 +55,7 @@ checkstyle {
}
-version = "0.19.0.4"
+version = "0.20.0"
android {
diff --git a/android/sdk/gradle.properties b/android/sdk/gradle.properties
index 08b9d65cdf..c621f8c509 100755
--- a/android/sdk/gradle.properties
+++ b/android/sdk/gradle.properties
@@ -1,3 +1,22 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
# Project-wide Gradle settings.
# IDE (e.g. Android Studio) users:
diff --git a/android/sdk/proguard-rules.pro b/android/sdk/proguard-rules.pro
index 73247bc730..957227f8c9 100755
--- a/android/sdk/proguard-rules.pro
+++ b/android/sdk/proguard-rules.pro
@@ -1,3 +1,22 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
# Add project specific ProGuard rules here.
# By default, the flags in this file are appended to flags specified
# in /Users/ouy/Library/AndroidStudio/sdk/tools/proguard/proguard-android.txt
@@ -19,4 +38,4 @@
-keep class com.taobao.weex.layout.** { *; }
-keep class com.taobao.weex.WXSDKEngine { *; }
-keep class com.taobao.weex.base.SystemMessageHandler { *; }
--dontwarn com.taobao.weex.bridge.**
\ No newline at end of file
+-dontwarn com.taobao.weex.bridge.**
diff --git a/android/sdk/publish.sh b/android/sdk/publish.sh
index 4d70a7ce00..7700dd320b 100755
--- a/android/sdk/publish.sh
+++ b/android/sdk/publish.sh
@@ -1,2 +1,21 @@
#!/usr/bin/env bash
-./gradlew clean assemble publish
\ No newline at end of file
+
+#
+# Licensed to the Apache
[GitHub] jondong opened a new pull request #1752: [Release] Added missing Apache license
jondong opened a new pull request #1752: [Release] Added missing Apache license URL: https://github.com/apache/incubator-weex/pull/1752 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1751: [iOS] new feature for analyze interaction info (dev_tool)
weex-bot edited a comment on issue #1751: [iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1751: [iOS] new feature for analyze interaction info (dev_tool)
weex-bot edited a comment on issue #1751: [iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1751: [iOS] new feature for analyze interaction info (dev_tool)
weex-bot commented on issue #1751: [iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucky-chen opened a new pull request #1751: Ios feature interaction devtool
lucky-chen opened a new pull request #1751: Ios feature interaction devtool URL: https://github.com/apache/incubator-weex/pull/1751 - transfer peformance info to devtool - add log switch of jsengin/jsfm/weexcore ,to analyze interactionTime This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle…
weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle…
weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle…
weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] LionBuer commented on issue #1735: 请问weex如何利用recycle-list实现cell的折叠与展开效果？？？
LionBuer commented on issue #1735: 请问weex如何利用recycle-list实现cell的折叠与展开效果？？？ URL: https://github.com/apache/incubator-weex/issues/1735#issuecomment-438245965 @Hanks10100 我是长列表，请问直接使用前端实现，不会出现内存暴增吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle…
weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shawon1220 commented on issue #1748: IOS stream get方法不支持graphql语法
shawon1220 commented on issue #1748: IOS stream get方法不支持graphql语法 URL: https://github.com/apache/incubator-weex/issues/1748#issuecomment-438242719 @Hanks10100 thks, 目前我们都改成POST了，post没问题。另外playground新版本不支持调试了吗？找不到顶部那个小按钮了。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle…
weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle…
weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle…
weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle…
weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle…
weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle…
weex-bot commented on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucky-chen opened a new pull request #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle…
lucky-chen opened a new pull request #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750 add component ignoreInteraction flag bad case addElement onScreen with loop This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1748: IOS stream get方法不支持graphql语法
Hanks10100 commented on issue #1748: IOS stream get方法不支持graphql语法 URL: https://github.com/apache/incubator-weex/issues/1748#issuecomment-438239579 很可能与网络库或者服务端接口有关，请提供例子和复现问题的步骤。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1747: 希望添加麦克风读取功能
Hanks10100 commented on issue #1747: 希望添加麦克风读取功能 URL: https://github.com/apache/incubator-weex/issues/1747#issuecomment-438239170 这个功能可以用独立的模块来实现，Weex SDK 为了保持精简，未必适合内置此功能。 参考： + http://weex-project.io/cn/guide/extend-android.html + http://weex-project.io/cn/guide/extend-ios.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1746: iOS版本 div的@ShouldStopPropagation方法无效 weeksdk版本为0.19.0.2
Hanks10100 commented on issue #1746: iOS版本 div的@ShouldStopPropagation方法无效 weeksdk版本为0.19.0.2 URL: https://github.com/apache/incubator-weex/issues/1746#issuecomment-438238623 请提供完整例子和复现步骤。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1739: weex 从一个页面点击进入下一个页面 然后回到上个页面 在进入 发现接口数据不请求 什么原因
Hanks10100 commented on issue #1739: weex 从一个页面点击进入下一个页面 然后回到上个页面 在进入 发现接口数据不请求 什么原因 URL: https://github.com/apache/incubator-weex/issues/1739#issuecomment-438238011 信息不足，issue 先关掉了，如果还有问题，请按照 issue 模板提供更详细的信息。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 closed issue #1739: weex 从一个页面点击进入下一个页面 然后回到上个页面 在进入 发现接口数据不请求 什么原因
Hanks10100 closed issue #1739: weex 从一个页面点击进入下一个页面 然后回到上个页面 在进入 发现接口数据不请求 什么原因 URL: https://github.com/apache/incubator-weex/issues/1739 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1735: 请问weex如何利用recycle-list实现cell的折叠与展开效果？？？
Hanks10100 commented on issue #1735: 请问weex如何利用recycle-list实现cell的折叠与展开效果？？？ URL: https://github.com/apache/incubator-weex/issues/1735#issuecomment-438235810 #1736 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 closed issue #1735: 请问weex如何利用recycle-list实现cell的折叠与展开效果？？？
Hanks10100 closed issue #1735: 请问weex如何利用recycle-list实现cell的折叠与展开效果？？？ URL: https://github.com/apache/incubator-weex/issues/1735 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1735: 请问weex如何利用recycle-list实现cell的折叠与展开效果？？？
Hanks10100 commented on issue #1735: 请问weex如何利用recycle-list实现cell的折叠与展开效果？？？ URL: https://github.com/apache/incubator-weex/issues/1735#issuecomment-438234608 折叠展开这种效果，在前端里就可以实现。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1728: render eroor: border in
Hanks10100 commented on issue #1728: render eroor: border in URL: https://github.com/apache/incubator-weex/issues/1728#issuecomment-438233806 It works fine for me. http://dotwe.org/vue/539c38f46c2d232009b76e8d6c0ce294 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 closed issue #1727: navigator 为什么跳转之后界面没东西
Hanks10100 closed issue #1727: navigator 为什么跳转之后界面没东西 URL: https://github.com/apache/incubator-weex/issues/1727 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1727: navigator 为什么跳转之后界面没东西
Hanks10100 commented on issue #1727: navigator 为什么跳转之后界面没东西 URL: https://github.com/apache/incubator-weex/issues/1727#issuecomment-438232347 这里有 navigator 的例子： http://weex-project.io/cn/examples.html#module/navigator 信息提供不全，很可能是 URL 地址或者网络原因， issue 先关掉了，如果还有问题请提供更详细的信息。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 closed issue #1725: weex中插入实体字符
Hanks10100 closed issue #1725: weex中插入实体字符 URL: https://github.com/apache/incubator-weex/issues/1725 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1725: weex中插入实体字符
Hanks10100 commented on issue #1725: weex中插入实体字符 URL: https://github.com/apache/incubator-weex/issues/1725#issuecomment-438231719 参考这里的例子： http://weex-project.io/cn/examples.html#component/text http://dotwe.org/vue/b0e734ebc5d24f030154ff2d954781f5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1749: [WEEX-659][core][eagle] support more feature in parser
weex-bot edited a comment on issue #1749: [WEEX-659][core][eagle] support more feature in parser URL: https://github.com/apache/incubator-weex/pull/1749#issuecomment-438209245 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1749: [WEEX-659][core][eagle] support more feature in parser
weex-bot edited a comment on issue #1749: [WEEX-659][core][eagle] support more feature in parser URL: https://github.com/apache/incubator-weex/pull/1749#issuecomment-438209245 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] erha19 commented on issue #1630: weex macbookpro安装失败
erha19 commented on issue #1630: weex macbookpro安装失败 URL: https://github.com/apache/incubator-weex/issues/1630#issuecomment-438209801 @Hanks10100 This issue is no longer active, it should be closed now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] erha19 commented on issue #1604: `$ weex create helloworld` 报一系列警告（错误）
erha19 commented on issue #1604: `$ weex create helloworld` 报一系列警告（错误） URL: https://github.com/apache/incubator-weex/issues/1604#issuecomment-438209394 @forwardNow you can see the document here http://weex.apache.org/cn/guide/index.html. @Hanks10100 And this issue is no longer active, it can be temporarily closed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1749: [WEEX-659][core][eagle] support more feature in parser
weex-bot commented on issue #1749: [WEEX-659][core][eagle] support more feature in parser URL: https://github.com/apache/incubator-weex/pull/1749#issuecomment-438209245 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXImage.java without metion it in commit message. You'd better add '@notdanger' in your commit log. Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yxping opened a new pull request #1749: Feature dr parser
yxping opened a new pull request #1749: Feature dr parser URL: https://github.com/apache/incubator-weex/pull/1749 Detail: 1. Support more feature in parser like try catch & switch case & regular expression & class property 2. Restructure decoder and encoder of opcode 3. Support more basic built-in api like math & string 4. Support object like window & console 【this will be remove next version】 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] erha19 commented on issue #1685: Xcode10使用weex create 模板创建使用vue-router之后页面渲染不出来
erha19 commented on issue #1685: Xcode10使用weex create 模板创建使用vue-router之后页面渲染不出来 URL: https://github.com/apache/incubator-weex/issues/1685#issuecomment-438208369 @Hanks10100 Duplicate issues can be closed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] erha19 commented on issue #1685: Xcode10使用weex create 模板创建使用vue-router之后页面渲染不出来
erha19 commented on issue #1685: Xcode10使用weex create 模板创建使用vue-router之后页面渲染不出来 URL: https://github.com/apache/incubator-weex/issues/1685#issuecomment-438208176 @allen2437 @weenta @weenta see https://github.com/apache/incubator-weex/issues/1686#issuecomment-438207973. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] erha19 commented on issue #1686: 新建项目启动白屏，process.env.NODE_ENV找不到
erha19 commented on issue #1686: 新建项目启动白屏，process.env.NODE_ENV找不到 URL: https://github.com/apache/incubator-weex/issues/1686#issuecomment-438207973 @foyel @qzcsgs The official `webpack` configuration has been updated, and the `process .env.NODE_ENV` variable will be automatically replaced. You can re-run the `weex create` command to create a template and put `configs` folder (which has some webpack config files) into your old project to replace the old configuration. commit: https://github.com/weex-templates/webpack/commit/f7c7d04d30b734be9e1c2b54df4a8ad723f5b988 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shawon1220 opened a new issue #1748: IOS stream get方法不支持graphql语法
shawon1220 opened a new issue #1748: IOS stream get方法不支持graphql语法
URL: https://github.com/apache/incubator-weex/issues/1748
使用Weex playground app 测试 IOS stream get方法不支持graphql语法，android可以。
类似请求 '/graphql?query={userInfo{id,userName}}' 返回 {"status":-1,"ok":false}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mythbobo opened a new issue #1747: 希望添加麦克风读取功能
mythbobo opened a new issue #1747: 希望添加麦克风读取功能 URL: https://github.com/apache/incubator-weex/issues/1747 麦克风的使用频率还是很高的。希望能作为基础模块接口调用。非常感谢！ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
