[GitHub] incubator-weex pull request #1190: Update WXRecyclerUpdateController.m
GitHub user AntiMoron opened a pull request: https://github.com/apache/incubator-weex/pull/1190 Update WXRecyclerUpdateController.m Fix one crash. ``` *** -[__NSDictionaryM setObject:forKey:]: key cannot be nil ``` This exception will be yelled at line 167. You can merge this pull request into a Git repository by running: $ git pull https://github.com/AntiMoron/incubator-weex master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1190.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1190 commit 320979ece56e10c76ff6b7239c0fb360f76437ff Author: AntiMoron <anti2moron@...> Date: 2018-05-22T04:13:19Z Update WXRecyclerUpdateController.m Fix one crash. ``` *** -[__NSDictionaryM setObject:forKey:]: key cannot be nil ``` This exception will be yelled at line 167. ---
[GitHub] incubator-weex pull request #1108: Fix compile problem. 'progressBlock:' not...
GitHub user AntiMoron opened a pull request: https://github.com/apache/incubator-weex/pull/1108 Fix compile problem. 'progressBlock:' not found in the function declaration [-Werror,-Wdocumentation] parameter 'progressBlock:' not found in the function declaration [-Werror,-Wdocumentation] * @param progressBlock: A block called while the download start ^~ éå«åä¿®æ¹ãæ° demoãè¾å°ç bugfixãçè³è¾å¤§çåè½é½å¯ä»¥ç´æ¥æå° `master` åæ¯ï¼ You can merge this pull request into a Git repository by running: $ git pull https://github.com/AntiMoron/incubator-weex master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1108.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1108 commit 060c7b4546f2a8eeea5043802b0937fbad064ec5 Author: AntiMoron <anti2moron@...> Date: 2018-04-10T15:03:08Z Fix compile problem. parameter 'progressBlock:' not found in the function declaration [-Werror,-Wdocumentation] * @param progressBlock: A block called while the download start ^~ ---
[GitHub] incubator-weex issue #864: [iOS] Make sure gesture recognizers won't be lost...
Github user AntiMoron commented on the issue: https://github.com/apache/incubator-weex/pull/864 @cxfeng1 No, customized weex component is involved. I can send you the demo. ---
[GitHub] incubator-weex pull request #864: [iOS] Make sure gesture recognizers won't ...
GitHub user AntiMoron opened a pull request: https://github.com/apache/incubator-weex/pull/864 [iOS] Make sure gesture recognizers won't be lost. First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. You can merge this pull request into a Git repository by running: $ git pull https://github.com/AntiMoron/incubator-weex master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/864.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #864 commit c71931d8d76f0dfabbc9ce2bd92329ba9a74a4fc Author: MeoJa <boyuan@alibaba-inc.com> Date: 2017-11-15T03:57:25Z [iOS] Make sure gesture recognizers won't be lost. ---
