[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011 Warnings :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue :warning: If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document Messages :book: danger test finished. Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 52ff6689457515ee1c731d8ffe362a648b163353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011 Warnings :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue :warning: If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document Messages :book: danger test finished. Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 4bf1e4e14f0e2b0c78b73d5762fb977eab30ae69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011 Warnings :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue :warning: If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document Messages :book: danger test finished. Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 0f86d81187d54b456c2decf2189c34fd6d893dca This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011 Warnings :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue :warning: If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document Messages :book: danger test finished. Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 6122f55d7de05a06593ed1a4b2d32d151d33a7c2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011 Warnings :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/bridge/RequestHandler.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue :warning: If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document Messages :book: danger test finished. Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 0ff50f7fa539556849b27c37d677e1e059880b27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011 Warnings :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/bridge/RequestHandler.java without metion it in commit message. You'd better add '@notdanger' in your commit log. :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue :warning: If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document Messages :book: danger test finished. Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 04bc4068fe798b3a7eb5501897b7f14547a475ef This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-weex] weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash
weex-bot edited a comment on issue #2827: [Android] Fix Android JNI Crash URL: https://github.com/apache/incubator-weex/pull/2827#issuecomment-521192011 Warnings :warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md :warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue :warning: If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document Messages :book: danger test finished. Generated by :no_entry_sign: https://danger.systems/js;>dangerJS against 174029f742a978992100a55fc5d11ae6c2eea7bd This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services