[GitHub] incubator-weex pull request #1129: [WEEX-305][iOS] support more performance ...

2018-04-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/1129


---


[GitHub] incubator-weex pull request #1129: [WEEX-305][iOS] support more performance ...

2018-04-25 Thread acton393
Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1129#discussion_r184260545
  
--- Diff: ios/sdk/WeexSDK.xcodeproj/project.pbxproj ---
@@ -2341,8 +2379,10 @@
DCA4456E1EFA55B300D0CFA8 /* WXModalUIModule.m 
in Sources */,
DCA4456F1EFA55B300D0CFA8 /* WXWebViewModule.m 
in Sources */,
DCA445701EFA55B300D0CFA8 /* WXCanvasModule.m in 
Sources */,
+   170B4668208733E500562666 /* WXAnalyzerCenter.m 
in Sources */,
DCA445711EFA55B300D0CFA8 /* WXMetaModule.m in 
Sources */,
DCA445721EFA55B300D0CFA8 /* WXBoxShadow.m in 
Sources */,
+   170B4666208733D200562666 /* (null) in Sources 
*/,
--- End diff --

null ?


---


[GitHub] incubator-weex pull request #1129: [WEEX-305][iOS] support more performance ...

2018-04-25 Thread acton393
Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1129#discussion_r184259269
  
--- Diff: ios/sdk/WeexSDK.xcodeproj/project.pbxproj ---
@@ -8,6 +8,21 @@
 
 /* Begin PBXBuildFile section */
042013AD1E66CD6A001FC79C /* WXValidateProtocol.h in Headers */ 
= {isa = PBXBuildFile; fileRef = 042013AC1E66CD6A001FC79C /* 
WXValidateProtocol.h */; settings = {ATTRIBUTES = (Public, ); }; };
+   170B4664208733AF00562666 /* WXAnalyzerCenter.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 17C74F092072145000AB4CAB /* WXAnalyzerCenter.h 
*/; settings = {ATTRIBUTES = (Public, ); }; };
+   170B4665208733BF00562666 /* WXAnalyzerCenter+Transfer.h in 
Headers */ = {isa = PBXBuildFile; fileRef = 17C74F082072145000AB4CAB /* 
WXAnalyzerCenter+Transfer.h */; };
+   170B4666208733D200562666 /* (null) in Sources */ = {isa = 
PBXBuildFile; };
+   170B4667208733D800562666 /* (null) in Headers */ = {isa = 
PBXBuildFile; };
--- End diff --

what's `null `  in headers 


---