[GitHub] incubator-weex pull request #696: * [ios] clear toast queue when instance di...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/696


---

[GitHub] incubator-weex pull request #696: * [ios] clear toast queue when instance di...

[acton393]

GitHub user acton393 reopened a pull request:

https://github.com/apache/incubator-weex/pull/696

* [ios] clear toast queue when instance disappear @notdanger



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/acton393/incubator-weex 
ios-feature-modal-toast

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/696.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #696


commit c8c73cd01fe94a2a0b5068808cc3776e6d6ecb00
Author: acton393 
Date:   2017-09-13T08:16:23Z

* [ios] clear toast queue when instance disappear




---

[GitHub] incubator-weex pull request #696: * [ios] clear toast queue when instance di...

[acton393]

Github user acton393 closed the pull request at:

https://github.com/apache/incubator-weex/pull/696


---

[GitHub] incubator-weex pull request #696: * [ios] clear toast queue when instance di...

[acton393]

Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/696#discussion_r138793696
  
--- Diff: ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m ---
@@ -378,7 +379,8 @@ - (void)destroyInstance
 if(url.length > 0){
 [WXPrerenderManager addGlobalTask:url callback:nil];
 }
-
+NSMutableArray * toastQueue = [[WXToastManager sharedManager] 
valueForKey:@"toastQueue"];
--- End diff --

Singleton method for sharedManager  will initialize toastQueue as a 
mutableArray， here I just removeAllObject.  In other side , if toastQueue is 
nil,  sending message to nil value will take no effect.


---

[GitHub] incubator-weex pull request #696: * [ios] clear toast queue when instance di...

[kfeagle]

Github user kfeagle commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/696#discussion_r138554778
  
--- Diff: ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m ---
@@ -378,7 +379,8 @@ - (void)destroyInstance
 if(url.length > 0){
 [WXPrerenderManager addGlobalTask:url callback:nil];
 }
-
+NSMutableArray * toastQueue = [[WXToastManager sharedManager] 
valueForKey:@"toastQueue"];
--- End diff --

toastQueue 会不会是空值？


---