[GitHub] [incubator-weex-site] cnryb commented on a change in pull request #586: Update list.md

2020-07-14 Thread GitBox


cnryb commented on a change in pull request #586:
URL: 
https://github.com/apache/incubator-weex-site/pull/586#discussion_r454267964



##
File path: docs/zh/docs/components/list.md
##
@@ -89,7 +89,35 @@
 
 ## 事件
 * `loadmore` 事件  
-  如果列表滚动到底部将会立即触发这个事件,你可以在这个事件的处理函数中加载下一页的列表项。 
如果未触发,请检查是否设置了loadmoreoffset的值,建议此值设置大于0
+  如果列表滚动到底部将会立即触发这个事件,你可以在这个事件的处理函数中加载下一页的列表项。 
如果未触发,请检查是否设置了loadmoreoffset的值,建议此值设置大于0 
+  
+`如何重置`

Review comment:
   你误会刚刚的留言了。 
   你看上一句说了  `如果未触发,x` , 你刚刚又写了一遍, `如果未触发,x` 。
   我意思是你把这两句合起来。





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-weex-site] kang558 opened a new pull request #586: Update list.md

2020-07-14 Thread GitBox


kang558 opened a new pull request #586:
URL: https://github.com/apache/incubator-weex-site/pull/586


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-weex-site] cnryb commented on pull request #586: Update list.md

2020-07-14 Thread GitBox


cnryb commented on pull request #586:
URL: 
https://github.com/apache/incubator-weex-site/pull/586#issuecomment-658070665


   请结合上文,稍作修改。



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-weex-site] kang558 commented on a change in pull request #586: Update list.md

2020-07-14 Thread GitBox


kang558 commented on a change in pull request #586:
URL: 
https://github.com/apache/incubator-weex-site/pull/586#discussion_r454284353



##
File path: docs/zh/docs/components/list.md
##
@@ -89,7 +89,35 @@
 
 ## 事件
 * `loadmore` 事件  
-  如果列表滚动到底部将会立即触发这个事件,你可以在这个事件的处理函数中加载下一页的列表项。 
如果未触发,请检查是否设置了loadmoreoffset的值,建议此值设置大于0
+  如果列表滚动到底部将会立即触发这个事件,你可以在这个事件的处理函数中加载下一页的列表项。 
如果未触发,请检查是否设置了loadmoreoffset的值,建议此值设置大于0 
+  
+`如何重置`

Review comment:
   改好了,这样比较清晰





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-weex-ui] branch master updated: [!] English documentation fixes

2020-07-14 Thread cnryb
This is an automated email from the ASF dual-hosted git repository.

cnryb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex-ui.git


The following commit(s) were added to refs/heads/master by this push:
 new 927d825  [!] English documentation fixes
 new c233792  Merge pull request #501 from joyhchen/docs-improvement
927d825 is described below

commit 927d825ed379747040397c284cbc746cd35d9c48
Author: Joy Chen 
AuthorDate: Fri Jul 10 09:25:35 2020 -0500

[!] English documentation fixes
---
 README.md  | 10 +-
 docs/faq.md| 10 +-
 docs/with-weex-toolkit.md  |  2 +-
 packages/wxc-tab-bar/README.md |  2 +-
 4 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/README.md b/README.md
index bbfca0e..faeadc6 100644
--- a/README.md
+++ b/README.md
@@ -23,7 +23,7 @@
 
 https://img.alicdn.com/tfs/TB1O2ulhgoQMeJjy0FoXXcShVXa-1282-986.jpg; 
width=540/>
 
-Try 
[**it**](https://h5.m.taobao.com/trip/weex-ui/index.html?_wx_tpl=https%3A%2F%2Fh5.m.taobao.com%2Ftrip%2Fweex-ui%2Fdemo%2Findex.native-min.js)
 with Fliggy、Taobao、Tmall、Weex Playground or any browsers now!
+Try 
[**it**](https://h5.m.taobao.com/trip/weex-ui/index.html?_wx_tpl=https%3A%2F%2Fh5.m.taobao.com%2Ftrip%2Fweex-ui%2Fdemo%2Findex.native-min.js)
 with Fliggy, Taobao, Tmall, Weex Playground or any browsers now!
 
 ## Installation
 
@@ -72,7 +72,7 @@ npm i weex-ui -S
 ### Before use
 
 In order to not pack all the components, you need to use 
[`babel-plugin-component`](https://www.npmjs.com/package/babel-plugin-component)
 to import the specified component.
-At the same time, if you haven't installed `babel-preset-stage-0`, its 
necessary to install it.
+At the same time, if you haven't installed `babel-preset-stage-0`, it's 
necessary to install it.
 
 ```shell
 npm i babel-preset-stage-0 babel-plugin-component -D
@@ -96,10 +96,10 @@ npm i babel-preset-stage-0 babel-plugin-component -D
 
 ### More
 
-* If babel-loader in `webpack.config.js` has a exclude for node_modules, 
please turn on for week-ui as `exclude: /node_modules(?!(\/|\\).*(weex).*)/`.
+* If babel-loader in `webpack.config.js` has a exclude for node_modules, 
please turn on for weex-ui as `exclude: /node_modules(?!(\/|\\).*(weex).*)/`.
 * In order to get the latest features, please focus on the 
[ChangeLog](https://github.com/apache/incubator-weex-ui/releases) and often 
update `weex-ui` to the latest.
-* Many questions can be found from 
[faq](https://apache.github.io/incubator-weex-ui/#/faq) and [issue 
list](https://github.com/apache/incubator-weex-ui/issues?utf8=%E2%9C%93=), if 
you find a new bug, just file a 
[issue](https://github.com/apache/incubator-weex-ui/issues/new).
-* More experience in Weex construction can be learned from [Weex + Ui - Weex 
Conf 
2018](https://apache.github.io/incubator-weex-ui/#/docs/weex-ui-weex-conf-2018) 
,welcome to translate it.
+* Many questions can be found in the 
[faq](https://apache.github.io/incubator-weex-ui/#/docs/faq) and [issue 
list](https://github.com/apache/incubator-weex-ui/issues?utf8=%E2%9C%93=), if 
you find a new bug, just file an 
[issue](https://github.com/apache/incubator-weex-ui/issues/new).
+* More experience in Weex construction can be learned from [Weex + Ui - Weex 
Conf 
2018](https://apache.github.io/incubator-weex-ui/#/docs/weex-ui-weex-conf-2018),
 welcome to translate it.
 
 ## Development
 
diff --git a/docs/faq.md b/docs/faq.md
index ed7fcf1..2fc88de 100644
--- a/docs/faq.md
+++ b/docs/faq.md
@@ -1,12 +1,12 @@
 ## FAQ
 
- wxc-ep-slider、wxc-slider-bar Can't slide
+ wxc-ep-slider, wxc-slider-bar Can't slide
 - The two components in Weex Ui now depend on an innovative interaction 
feature called [BindingX](https://alibaba.github.io/bindingx/), And this 
feature is already open source, please refer to github [to 
import](https://github.com/alibaba/bindingx#installation).
 
 
  Suggestions for using images in Weex.
 - Use CDN image:It is recommended to use, and to ensure that the actual size 
and size of the image is consistent with what you need to show.
-- Use local image:Weex’s native runtime support load image file from device’s 
disk, all you have to do set the file url like 
file:///sdcard/image_new0.png,More you can see 
[here](http://blog.csdn.net/codingfire/article/details/79528639), At the same 
time, Weex does not support the loading of image files in your project, nor 
does it support the direct use of local images by downgrade Web version. 
Therefore, it is recommended to use the CDN image link.
+- Use local image:Weex’s native runtime support load image file from device’s 
disk, all you have to do set the file url like file:///sdcard/image_new0.png. 
See more [here](http://blog.csdn.net/codingfire/article/details/79528639). At 
the same time, Weex does not support the loading of image files in your 
project, nor does it support the direct use of local images by downgrade Web 

[GitHub] [incubator-weex-ui] cnryb merged pull request #501: [!] English documentation improvement

2020-07-14 Thread GitBox


cnryb merged pull request #501:
URL: https://github.com/apache/incubator-weex-ui/pull/501


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-weex-ui] tw93 commented on pull request #501: [!] English documentation improvement

2020-07-14 Thread GitBox


tw93 commented on pull request #501:
URL: https://github.com/apache/incubator-weex-ui/pull/501#issuecomment-658148586


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org