[GitHub] cxfeng1 opened a new pull request #1623: Test PR for mailing list
cxfeng1 opened a new pull request #1623: Test PR for mailing list URL: https://github.com/apache/incubator-weex/pull/1623 First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1623: Test PR for mailing list
weex-bot edited a comment on issue #1623: Test PR for mailing list URL: https://github.com/apache/incubator-weex/pull/1623#issuecomment-428054300 Fails :no_entry_sign: jsfm run test failed! Messages :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1623: Test PR for mailing list
weex-bot edited a comment on issue #1623: Test PR for mailing list URL: https://github.com/apache/incubator-weex/pull/1623#issuecomment-428054300 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cxfeng1 closed pull request #1623: Test PR for mailing list
cxfeng1 closed pull request #1623: Test PR for mailing list URL: https://github.com/apache/incubator-weex/pull/1623 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] CGerAJ opened a new issue #1624: 安卓 webview无法加载动态地址 weex 在线编辑器测试ok
CGerAJ opened a new issue #1624: 安卓 webview无法加载动态地址 weex 在线编辑器测试ok URL: https://github.com/apache/incubator-weex/issues/1624 ## Description 安卓 webview无法加载动态地址 weex 在线编辑器测试ok webview 加载远程固定地址可以正常显示，加载远程动态拼接地址无法成功渲染 ## Environment weex -v v1.0.1-beta.6 weex-debugger : v1.1.16 - weex-devtool : v0.3.8 - weexpack : v1.2.7 AppName com.m417946.kqx [15516] DeviceMode lBKL-AL00 platform android Weex Version 0.18.0 ## Broken Example web端不能复现该bug ## Steps to Reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wqyfavor opened a new pull request #1625: [iOS] fix rax object leak.
wqyfavor opened a new pull request #1625: [iOS] fix rax object leak. URL: https://github.com/apache/incubator-weex/pull/1625 First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1625: [iOS] fix rax object leak.
weex-bot commented on issue #1625: [iOS] fix rax object leak. URL: https://github.com/apache/incubator-weex/pull/1625#issuecomment-428422314 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1625: [iOS] fix rax object leak.
weex-bot edited a comment on issue #1625: [iOS] fix rax object leak. URL: https://github.com/apache/incubator-weex/pull/1625#issuecomment-428422314 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1625: [iOS] fix rax object leak.
weex-bot edited a comment on issue #1625: [iOS] fix rax object leak. URL: https://github.com/apache/incubator-weex/pull/1625#issuecomment-428422314 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cxfeng1 closed pull request #1625: [iOS] fix rax object leak.
cxfeng1 closed pull request #1625: [iOS] fix rax object leak.
URL: https://github.com/apache/incubator-weex/pull/1625
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
index bc25837c62..c8b1ecafbc 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
@@ -475,65 +475,7 @@ - (void)createInstance:(NSString *)instanceIdString
}
weakSelf.jsBridge.javaScriptContext[@"wxExtFuncInfo"]= nil;
-NSMutableArray* allKeys = nil;
-
-if ([WXUtility useJSCApiForCreateInstance]) {
-JSContextRef contextRef =
instanceContextEnvironment.context.JSGlobalContextRef;
-WXAssert([instanceContextEnvironment isObject], @"Invalid
instance context.");
-JSValueRef jsException = NULL;
-JSObjectRef instanceContextObjectRef =
JSValueToObject(contextRef, instanceContextEnvironment.JSValueRef,
&jsException);
-if (jsException != NULL) {
-WXLogError(@"JSValueToObject Exception during create
instance.");
-}
-BOOL somethingWrong = NO;
-if (instanceContextObjectRef != NULL) {
-JSPropertyNameArrayRef allKeyRefs =
JSObjectCopyPropertyNames(contextRef, instanceContextObjectRef);
-size_t keyCount =
JSPropertyNameArrayGetCount(allKeyRefs);
-
-allKeys = [[NSMutableArray alloc]
initWithCapacity:keyCount];
-for (size_t i = 0; i < keyCount; i ++) {
-JSStringRef nameRef =
JSPropertyNameArrayGetNameAtIndex(allKeyRefs, i);
-size_t len =
JSStringGetMaximumUTF8CStringSize(nameRef);
-if (len > 1024) {
-somethingWrong = YES;
-break;
-}
-char* buf = (char*)malloc(len + 5);
-if (buf == NULL) {
-somethingWrong = YES;
-break;
-}
-bzero(buf, len + 5);
-if (JSStringGetUTF8CString(nameRef, buf, len + 5)
> 0) {
-NSString* keyString = [NSString
stringWithUTF8String:buf];
-if ([keyString length] == 0) {
-somethingWrong = YES;
-free(buf);
-break;
-}
-[allKeys addObject:keyString];
-}
-else {
-somethingWrong = YES;
-free(buf);
-break;
-}
-free(buf);
-}
-JSPropertyNameArrayRelease(allKeyRefs);
-} else {
-somethingWrong = YES;
-}
-
-if (somethingWrong) {
-// [instanceContextEnvironment toDictionary] may
contain retain-cycle.
-allKeys =
(NSMutableArray*)[[instanceContextEnvironment toDictionary] allKeys];
-}
-}
-else {
-allKeys = (NSMutableArray*)[[instanceContextEnvironment
toDictionary] allKeys];
-}
-
+NSArray* allKeys = [WXUtility
extractPropertyNamesOfJSValueObject:instanceContextEnvironment];
sdkInstance.createInstanceContextResult = [NSString
stringWithFormat:@"%@", allKeys];
JSGlobalContextRef instanceContextRef =
sdkInstance.instanceJavaScriptContext.javaScriptContext.JSGlobalContextRef;
JSObjectRef instanceGlobalObject =
JSContextGetGlobalObject(instanceContextRef);
@@ -560,7 +502,8 @@ - (void)createInstance:(NSString *)instanceIdString
if (raxAPIScript) {
[sdkInstance.instanceJavaScriptContext
executeJavascript:raxAPIScript withSourceURL:[NSURL
URLWithString:raxAPIScriptPath]];
-sdkInstance.executeRaxApiResult = [NSString
stringWithFormat:@"%@",
[[sdkInstance.instanceJavaScriptContext.javaScriptContext.globalObject
toDict
[GitHub] CGerAJ closed issue #1624: 安卓 webview无法加载动态地址 weex 在线编辑器测试ok
CGerAJ closed issue #1624: 安卓 webview无法加载动态地址 weex 在线编辑器测试ok URL: https://github.com/apache/incubator-weex/issues/1624 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] CGerAJ commented on issue #1624: 安卓 webview无法加载动态地址 weex 在线编辑器测试ok
CGerAJ commented on issue #1624: 安卓 webview无法加载动态地址 weex 在线编辑器测试ok URL: https://github.com/apache/incubator-weex/issues/1624#issuecomment-428505252 神奇bug This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] imfenghuang opened a new issue #1626: are there some methods to prevent support RecyclerView?
imfenghuang opened a new issue #1626: are there some methods to prevent support RecyclerView? URL: https://github.com/apache/incubator-weex/issues/1626 always, this feature is useful, however, sometimes it makes some difficulties. For example, if one `` has more than 30 images (or other things be added by ajax), it may be rerendered when it reenters to visual area, then it will make the page be blocked in a short time. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dongrong-fu opened a new issue #1627: weex初始化进入onException回调
dongrong-fu opened a new issue #1627: weex初始化进入onException回调 URL: https://github.com/apache/incubator-weex/issues/1627 weex偶现进入onException回调，各个安卓版本和手机类型都有，并且在出现问题的手机上也是非必现，经线上数据统计出错概率大约为0.25%，报错内容为： erroecode -1001 degradeToH5|createInstance fail|wx_create_instance_error isJSFrameworkInit==false reInitCount == 1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mahaiyannn opened a new pull request #1628: [iOS]Catch exception 'NSInternalInconsistencyException', reason: 'Mis…
mahaiyannn opened a new pull request #1628: [iOS]Catch exception 'NSInternalInconsistencyException', reason: 'Mis… URL: https://github.com/apache/incubator-weex/pull/1628 …sing cell for newly visible row 8'. It's a iOS bug, It disappear after iOS11.2. . https://github.com/mahaiyannn/TableViewExceptionDemo.git is the reproduction demo First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1628: [iOS]Catch exception 'NSInternalInconsistencyException', reason: 'Mis…
weex-bot commented on issue #1628: [iOS]Catch exception 'NSInternalInconsistencyException', reason: 'Mis… URL: https://github.com/apache/incubator-weex/pull/1628#issuecomment-42892 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1628: [iOS]Catch exception 'NSInternalInconsistencyException', reason: 'Mis…
weex-bot edited a comment on issue #1628: [iOS]Catch exception 'NSInternalInconsistencyException', reason: 'Mis… URL: https://github.com/apache/incubator-weex/pull/1628#issuecomment-42892 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1628: [iOS]Catch exception 'NSInternalInconsistencyException', reason: 'Mis…
weex-bot edited a comment on issue #1628: [iOS]Catch exception 'NSInternalInconsistencyException', reason: 'Mis… URL: https://github.com/apache/incubator-weex/pull/1628#issuecomment-42892 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cxfeng1 closed pull request #1628: [iOS]Catch exception 'NSInternalInconsistencyException', reason: 'Mis…
cxfeng1 closed pull request #1628: [iOS]Catch exception
'NSInternalInconsistencyException', reason: 'Mis…
URL: https://github.com/apache/incubator-weex/pull/1628
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
b/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
index 55116af68a..b4cc6c77c7 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
+++ b/ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm
@@ -904,7 +904,12 @@ - (void)_performUpdates:(void(^)(void))updates
withKeepScrollPosition:(BOOL)keep
- (void)_insertTableViewSectionAtIndex:(NSUInteger)section
keepScrollPosition:(BOOL)keepScrollPosition
animation:(UITableViewRowAnimation)animation
{
[self _performUpdates:^{
-[_tableView insertSections:[NSIndexSet indexSetWithIndex:section]
withRowAnimation:animation];
+// catch system exception under 11.2
https://forums.developer.apple.com/thread/49676
+@try {
+[_tableView insertSections:[NSIndexSet indexSetWithIndex:section]
withRowAnimation:animation];
+} @catch(NSException *) {
+
+}
} withKeepScrollPosition:keepScrollPosition
adjustmentBlock:^CGFloat(NSIndexPath *top) {
if (section <= top.section) {
return [self tableView:_tableView
heightForHeaderInSection:section];
@@ -917,7 +922,13 @@ - (void)_insertTableViewSectionAtIndex:(NSUInteger)section
keepScrollPosition:(B
- (void)_deleteTableViewSectionAtIndex:(NSUInteger)section
keepScrollPosition:(BOOL)keepScrollPosition
animation:(UITableViewRowAnimation)animation
{
[self _performUpdates:^{
-[_tableView deleteSections:[NSIndexSet indexSetWithIndex:section]
withRowAnimation:animation];
+// catch system exception under 11.2
https://forums.developer.apple.com/thread/49676
+@try {
+[_tableView deleteSections:[NSIndexSet indexSetWithIndex:section]
withRowAnimation:animation];
+} @catch(NSException *) {
+
+}
+
} withKeepScrollPosition:keepScrollPosition
adjustmentBlock:^CGFloat(NSIndexPath *top) {
if (section <= top.section) {
return [self tableView:_tableView
heightForHeaderInSection:section];
@@ -933,7 +944,12 @@ - (void)_insertTableViewCellAtIndexPath:(NSIndexPath
*)indexPath keepScrollPosit
if ([_updataType isEqual: @"reload"]) {
[_tableView reloadData];
} else {
-[_tableView insertRowsAtIndexPaths:[NSArray
arrayWithObject:indexPath] withRowAnimation:animation];
+// catch system exception under 11.2
https://forums.developer.apple.com/thread/49676
+@try {
+[_tableView insertRowsAtIndexPaths:[NSArray
arrayWithObject:indexPath] withRowAnimation:animation];
+} @catch(NSException *e) {
+
+}
}
} withKeepScrollPosition:keepScrollPosition
adjustmentBlock:^CGFloat(NSIndexPath *top) {
if (([indexPath compare:top] <= 0) || [_updataType isEqual:
@"reload"]) {
@@ -950,7 +966,12 @@ - (void)_deleteTableViewCellAtIndexPath:(NSIndexPath
*)indexPath keepScrollPosit
return ;
}
[self _performUpdates:^{
-[_tableView deleteRowsAtIndexPaths:[NSArray arrayWithObject:indexPath]
withRowAnimation:animation];
+// catch system exception under 11.2
https://forums.developer.apple.com/thread/49676
+@try {
+[_tableView deleteRowsAtIndexPaths:[NSArray
arrayWithObject:indexPath] withRowAnimation:animation];
+} @catch (NSException* e) {
+
+}
} withKeepScrollPosition:keepScrollPosition
adjustmentBlock:^CGFloat(NSIndexPath *top) {
if ([indexPath compare:top] <= 0) {
return [self tableView:_tableView
heightForRowAtIndexPath:indexPath];
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Yhspehy opened a new issue #1629: something wrong in render
Yhspehy opened a new issue #1629: something wrong in render URL: https://github.com/apache/incubator-weex/issues/1629 ## Description Hi, when i use , and i loadmore some data, i find something wrong in the render. Problems: 1. some img is not rendered 2. some item element is mixed 3. some space in the bottom of the item ## Environment ios, iphonexs ## Broken Example Example: [dotwe url](http://dotwe.org/vue/9fa9d2f489d1988f7334aeabcae802df)  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wangqian2017 opened a new issue #1630: weex macbookpro安装失败
wangqian2017 opened a new issue #1630: weex macbookpro安装失败 URL: https://github.com/apache/incubator-weex/issues/1630  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] KrMick opened a new issue #1631: 新版本地址下载链接失败：404
KrMick opened a new issue #1631: 新版本地址下载链接失败：404
URL: https://github.com/apache/incubator-weex/issues/1631
Android studio:
Could not find weex_sdk.jar (com.taobao.android:weex_sdk:0.19.0.3).
Searched in the following locations:
https://jcenter.bintray.com/com/taobao/android/weex_sdk/0.19.0.3/weex_sdk-0.19.0.3.jar
{
"errors" : [ {
"status" : 404,
"message" : "Could not find resource"
} ]
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] KrMick closed issue #1631: 新版本地址下载链接失败：404
KrMick closed issue #1631: 新版本地址下载链接失败：404 URL: https://github.com/apache/incubator-weex/issues/1631 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] likenow commented on issue #1587: @viewappear 刷新界面 在ios 中不起作用
likenow commented on issue #1587: @viewappear 刷新界面 在ios 中不起作用 URL: https://github.com/apache/incubator-weex/issues/1587#issuecomment-429694092 看一下文档中 [](http://weex-project.io/cn/wiki/common-events.html) 的 Page 事件。摘录如下： > viewappear 和 viewdisappear 事件关注的是整个页面的状态，所以它们必须绑定到页面的根元素上。 > 特殊情况下，这两个事件也能被绑定到非根元素的body组件上，例如wxc-navpage组件 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] likenow edited a comment on issue #1587: @viewappear 刷新界面 在ios 中不起作用
likenow edited a comment on issue #1587: @viewappear 刷新界面 在ios 中不起作用 URL: https://github.com/apache/incubator-weex/issues/1587#issuecomment-429694092 看一下文档中 [通用事件](http://weex-project.io/cn/wiki/common-events.html) 的 Page 事件。摘录如下： > viewappear 和 viewdisappear 事件关注的是整个页面的状态，所以它们必须绑定到页面的根元素上。 > 特殊情况下，这两个事件也能被绑定到非根元素的body组件上，例如wxc-navpage组件 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yxping opened a new pull request #1632: [WEEX-643][Android] fix image flash in sticky item
yxping opened a new pull request #1632: [WEEX-643][Android] fix image flash in sticky item URL: https://github.com/apache/incubator-weex/pull/1632 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1632: [WEEX-643][Android] fix image flash in sticky item
weex-bot edited a comment on issue #1632: [WEEX-643][Android] fix image flash in sticky item URL: https://github.com/apache/incubator-weex/pull/1632#issuecomment-429728778 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1632: [WEEX-643][Android] fix image flash in sticky item
weex-bot commented on issue #1632: [WEEX-643][Android] fix image flash in sticky item URL: https://github.com/apache/incubator-weex/pull/1632#issuecomment-429728778 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1632: [WEEX-643][Android] fix image flash in sticky item
weex-bot edited a comment on issue #1632: [WEEX-643][Android] fix image flash in sticky item URL: https://github.com/apache/incubator-weex/pull/1632#issuecomment-429728778 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] erha19 commented on issue #1630: weex macbookpro安装失败
erha19 commented on issue #1630: weex macbookpro安装失败 URL: https://github.com/apache/incubator-weex/issues/1630#issuecomment-429732678 @wangqian2017 you may have installed `weex-toolkit` before you run the above command, and that's bug is cause by `npm5`, you can delete the `weex-toolkit` cache on `/usr/local/lib/node_modules/weex-toolkit` or using `npm@4` to install it. ps: do not use `sudo` command to install a npm package at all, it will cause many permission issues while you using npm package. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Yhspehy opened a new issue #1633: ios Refresh component slide too much when refreshing is over
Yhspehy opened a new issue #1633: ios Refresh component slide too much when refreshing is over URL: https://github.com/apache/incubator-weex/issues/1633 ## Description Refresh component slide too much when refreshing is over ## Environment weex: v1.3.11 - weexpack : v1.2.7 - weex-debugger : v1.1.17 - weex-builder : v0.4.0 - weex-previewer : v1.5.1 ios, iphonexs ## Broken Example [example](http://dotwe.org/vue/f541ed72a121db8447a233b777003e8a) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen closed pull request #1632: [WEEX-643][Android] fix image flash in sticky item
YorkShen closed pull request #1632: [WEEX-643][Android] fix image flash in
sticky item
URL: https://github.com/apache/incubator-weex/pull/1632
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java
b/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java
index 844cdc09d7..2419b6ec71 100644
---
a/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java
+++
b/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java
@@ -34,13 +34,17 @@
*/
public class ListBaseViewHolder extends RecyclerView.ViewHolder {
private int mViewType;
- private boolean isRecycled = true;
+ private boolean isRecycled;
private WeakReference mComponent;
public ListBaseViewHolder(WXComponent component, int viewType) {
super(component.getHostView());
mViewType = viewType;
mComponent = new WeakReference(component);
+// This tag is used to determine whether bind / rebind data is needed.
+// It should be false When component can not be recycled Which means
+// no need to bind / rebind data.
+isRecycled = component.canRecycled();
}
public ListBaseViewHolder(View view, int viewType) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] yxping opened a new pull request #1634: [WEEX-644][Android] fix transform origin not right when animating with Animatio…
yxping opened a new pull request #1634: [WEEX-644][Android] fix transform origin not right when animating with Animatio… URL: https://github.com/apache/incubator-weex/pull/1634 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1634: [WEEX-644][Android] fix transform origin not right when animating with Animatio…
weex-bot edited a comment on issue #1634: [WEEX-644][Android] fix transform origin not right when animating with Animatio… URL: https://github.com/apache/incubator-weex/pull/1634#issuecomment-429773109 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1634: [WEEX-644][Android] fix transform origin not right when animating with Animatio…
weex-bot commented on issue #1634: [WEEX-644][Android] fix transform origin not right when animating with Animatio… URL: https://github.com/apache/incubator-weex/pull/1634#issuecomment-429773109 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1634: [WEEX-644][Android] fix transform origin not right when animating with Animatio…
weex-bot edited a comment on issue #1634: [WEEX-644][Android] fix transform origin not right when animating with Animatio… URL: https://github.com/apache/incubator-weex/pull/1634#issuecomment-429773109 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen closed pull request #1634: [WEEX-644][Android] fix transform origin not right when animating with Animatio…
YorkShen closed pull request #1634: [WEEX-644][Android] fix transform origin
not right when animating with Animatio…
URL: https://github.com/apache/incubator-weex/pull/1634
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionAnimation.java
b/android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionAnimation.java
index 6df77b2448..4023b0c232 100644
---
a/android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionAnimation.java
+++
b/android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionAnimation.java
@@ -41,6 +41,7 @@
import com.alibaba.fastjson.JSONObject;
import com.taobao.weex.WXSDKInstance;
import com.taobao.weex.WXSDKManager;
+import com.taobao.weex.common.Constants;
import com.taobao.weex.ui.animation.BackgroundColorProperty;
import com.taobao.weex.ui.animation.HeightProperty;
import com.taobao.weex.ui.animation.WXAnimationBean;
@@ -120,6 +121,12 @@ public void executeAction() {
if (null != mAnimationBean.styles) {
if(styleNeedInit) {
+// Synchronize transformOrigin between component styles and animation
style before
+// animation start.
+String transformOrigin = (String)
component.getStyles().get(Constants.Name.TRANSFORM_ORIGIN);
+if (TextUtils.isEmpty(mAnimationBean.styles.transformOrigin)) {
+ mAnimationBean.styles.transformOrigin = transformOrigin;
+}
mAnimationBean.styles.init(mAnimationBean.styles.transformOrigin,
mAnimationBean.styles.transform, (int) component.getLayoutWidth(),
(int) component.getLayoutHeight(),
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dim0xff opened a new issue #1635: jacoco agent in 0.19.0.3 release
dim0xff opened a new issue #1635: jacoco agent in 0.19.0.3 release
URL: https://github.com/apache/incubator-weex/issues/1635
I'm trying to upgrade weex lib for my app (from 0.18.0 to 0.19.0.3) from
here:
https://bintray.com/alibabaweex/maven/weex_sdk#files/com/taobao/android/weex_sdk/0.19.0.3
But unfortunately I got error on app start:
```
E/AndroidRuntime: FATAL EXCEPTION: main
Process: my.sample.app, PID: 12213
java.lang.NoClassDefFoundError: Failed resolution of:
Lorg/jacoco/agent/rt/internal_b0d6a23/Offline;
at
com.taobao.weex.WXSDKEngine.$jacocoInit(WXSDKEngine.java)
at
com.taobao.weex.WXSDKEngine.(WXSDKEngine.java)
at
com.taobao.weex.WXSDKEngine.addCustomOptions(WXSDKEngine.java)
at
my.sample.app.WXApplication.onCreate(WXApplication.java:96)
...
```
I don't need jacoco in my app, so, how could it be solved?
PS
Looking inside `weex_sdk-0.19.0.3-release.aar` I see that it is using
`org.jacoco.agent.rt.internal_b0d6a23.Offline`
```
package com.taobao.weex;
import org.jacoco.agent.rt.internal_b0d6a23.Offline;
public final class BuildConfig {
private static final transient /* synthetic */ boolean[] $jacocoData =
null;
public static final String APPLICATION_ID = "com.taobao.weex";
public static final long ARMEABIV7_Size = 0;
public static final long ARMEABI_Size = 0;
public static final String BUILD_TYPE = "release";
public static final boolean DEBUG = Boolean.parseBoolean("true");
public static final boolean ENABLE_TRACE = false;
public static final String FLAVOR = "";
public static final int VERSION_CODE = 1;
public static final String VERSION_NAME = "1.0";
public static final long X86_Size = 0;
public static final String buildJavascriptFrameworkVersion = "null";
public static final String buildVersion = "0.19.0.3";
private static /* synthetic */ boolean[] $jacocoInit() {
boolean[] zArr = $jacocoData;
if (zArr != null) {
return zArr;
}
zArr = Offline.getProbes(4181343490275274697L,
"com/taobao/weex/BuildConfig", 2);
$jacocoData = zArr;
return zArr;
}
public BuildConfig() {
$jacocoInit()[0] = true;
}
static {
boolean[] $jacocoInit = $jacocoInit();
$jacocoInit[1] = true;
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] doumafang opened a new pull request #1636: [WEEX-645][iOS] videocomponent support hide controls
doumafang opened a new pull request #1636: [WEEX-645][iOS] videocomponent support hide controls URL: https://github.com/apache/incubator-weex/pull/1636 videocomponent support hide controls you can try demo here: http://rax.alibaba-inc.com/playground/3f449805-49d7-4b80-ae92-e8c34039e521 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1636: [WEEX-645][iOS] videocomponent support hide controls
weex-bot commented on issue #1636: [WEEX-645][iOS] videocomponent support hide controls URL: https://github.com/apache/incubator-weex/pull/1636#issuecomment-430085677 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1636: [WEEX-645][iOS] videocomponent support hide controls
weex-bot edited a comment on issue #1636: [WEEX-645][iOS] videocomponent support hide controls URL: https://github.com/apache/incubator-weex/pull/1636#issuecomment-430085677 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1636: [WEEX-645][iOS] videocomponent support hide controls
weex-bot edited a comment on issue #1636: [WEEX-645][iOS] videocomponent support hide controls URL: https://github.com/apache/incubator-weex/pull/1636#issuecomment-430085677 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kang558 opened a new issue #1637: 组件自动滚动到可视区域了
kang558 opened a new issue #1637: 组件自动滚动到可视区域了 URL: https://github.com/apache/incubator-weex/issues/1637 ## Description ## 组件自动滚动到可视区域了 ## Environment Android ## Broken Example [在线示例：http://dotwe.org/vue/23a82060ad9649623214593b4a2c2e85](http://dotwe.org/vue/23a82060ad9649623214593b4a2c2e85) ## Steps to Reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] miomin opened a new pull request #1638: * [android] Support keyboardSize
miomin opened a new pull request #1638: * [android] Support keyboardSize URL: https://github.com/apache/incubator-weex/pull/1638 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1638: * [android] Support keyboardSize
weex-bot commented on issue #1638: * [android] Support keyboardSize URL: https://github.com/apache/incubator-weex/pull/1638#issuecomment-430153989 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1638: * [android] Support keyboardSize
weex-bot edited a comment on issue #1638: * [android] Support keyboardSize URL: https://github.com/apache/incubator-weex/pull/1638#issuecomment-430153989 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1638: * [android] Support keyboardSize
weex-bot edited a comment on issue #1638: * [android] Support keyboardSize URL: https://github.com/apache/incubator-weex/pull/1638#issuecomment-430153989 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cxfeng1 closed pull request #1636: [WEEX-645][iOS] videocomponent support hide controls
cxfeng1 closed pull request #1636: [WEEX-645][iOS] videocomponent support hide
controls
URL: https://github.com/apache/incubator-weex/pull/1636
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m
b/ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m
index 483f838c19..a9cb1bfda1 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m
+++ b/ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m
@@ -39,9 +39,9 @@ @implementation WXPlayer
@interface WXVideoView()
-@property (nonatomic, strong) UIViewController* playerViewController;
-@property (nonatomic, strong) AVPlayerItem* playerItem;
-@property (nonatomic, strong) WXSDKInstance* weexSDKInstance;
+@property (nonatomic, strong) UIViewController *playerViewController;
+@property (nonatomic, strong) AVPlayerItem *playerItem;
+@property (nonatomic, strong) WXSDKInstance *weexSDKInstance;
@property (nonatomic, strong) UIImageView *posterImageView;
@property (nonatomic, strong) id imageOperation;
@property (nonatomic, assign) BOOL playerDidPlayed;
@@ -192,7 +192,8 @@ - (void)setURL:(NSURL *)URL
}
}
-- (void)setPosterURL:(NSURL *)posterURL {
+- (void)setPosterURL:(NSURL *)posterURL
+{
if (!posterURL) {
return;
}
@@ -213,6 +214,19 @@ - (void)setPosterURL:(NSURL *)posterURL {
}];
}
+- (void)setControlShow:(BOOL)showControl
+{
+if ([self greater8SysVer]) {
+AVPlayerViewController *AVVC =
(AVPlayerViewController*)_playerViewController;
+AVVC.showsPlaybackControls = showControl;
+}
+else
+{
+MPMoviePlayerViewController *MPVC =
(MPMoviePlayerViewController*)_playerViewController;
+MPVC.moviePlayer.controlStyle = showControl ?
MPMovieControlStyleEmbedded : MPMovieControlStyleNone;
+}
+}
+
- (void)playFinish
{
if (_playbackStateChanged)
@@ -293,6 +307,7 @@ @interface WXVideoComponent()
@property (nonatomic, strong) NSURL *posterURL;
@property (nonatomic) BOOL autoPlay;
@property (nonatomic) BOOL playStatus;
+@property (nonatomic) BOOL showControl;
@end
@@ -316,6 +331,9 @@ - (instancetype)initWithRef:(NSString *)ref type:(NSString
*)type styles:(NSDict
if (attributes[@"poster"]) {
_posterURL = [NSURL URLWithString: attributes[@"poster"]];
}
+if (attributes[@"controls"]) {
+_showControl = ![attributes[@"controls"]
isEqualToString:@"controls"];
+}
}
return self;
}
@@ -333,6 +351,7 @@ - (void)viewDidLoad
_videoView.layer.mask = [self drawBorderRadiusMaskLayer:_videoView.bounds];
[_videoView setURL:_videoURL];
[_videoView setPosterURL:_posterURL];
+[_videoView setControlShow:_showControl];
__weak __typeof__(self) weakSelf = self;
_videoView.posterClickHandle = ^{
@@ -370,7 +389,7 @@ - (void)viewDidLoad
}
}
--(void)updateAttributes:(NSDictionary *)attributes
+- (void)updateAttributes:(NSDictionary *)attributes
{
if (attributes[@"src"]) {
_videoURL = [NSURL URLWithString: attributes[@"src"]];
@@ -392,6 +411,10 @@ -(void)updateAttributes:(NSDictionary *)attributes
_posterURL = [NSURL URLWithString: attributes[@"poster"]];
[_videoView setPosterURL:_posterURL];
}
+if (attributes[@"controls"]) {
+_showControl = ![attributes[@"controls"] isEqualToString:@"controls"];
+[_videoView setControlShow:_showControl];
+}
}
@end
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] joy2helloworld opened a new issue #1639: android 自定义的components，必须设置高度吗，有没有办法不设置高度，自动适应的
joy2helloworld opened a new issue #1639: android 自定义的components，必须设置高度吗，有没有办法不设置高度，自动适应的 URL: https://github.com/apache/incubator-weex/issues/1639 ## Description ## Environment ## Broken Example ## Steps to Reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joy2helloworld opened a new issue #1640: Android 0.19.0.3 404 NOT FOUND
joy2helloworld opened a new issue #1640: Android 0.19.0.3 404 NOT FOUND URL: https://github.com/apache/incubator-weex/issues/1640 ## Description ## Environment ## Broken Example ## Steps to Reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joy2helloworld commented on issue #1635: jacoco agent in 0.19.0.3 release
joy2helloworld commented on issue #1635: jacoco agent in 0.19.0.3 release URL: https://github.com/apache/incubator-weex/issues/1635#issuecomment-430460314 @dim0xff 你好问下 你是通过gradle引用的 0.19.0.3吗，我这边引用不到。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yxping opened a new pull request #1641: [WEEX-646][Android] fix loading disappear when refresh more than one time
yxping opened a new pull request #1641: [WEEX-646][Android] fix loading disappear when refresh more than one time URL: https://github.com/apache/incubator-weex/pull/1641 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1641: [WEEX-646][Android] fix loading disappear when refresh more than one time
weex-bot commented on issue #1641: [WEEX-646][Android] fix loading disappear when refresh more than one time URL: https://github.com/apache/incubator-weex/pull/1641#issuecomment-430486940 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1641: [WEEX-646][Android] fix loading disappear when refresh more than one time
weex-bot edited a comment on issue #1641: [WEEX-646][Android] fix loading disappear when refresh more than one time URL: https://github.com/apache/incubator-weex/pull/1641#issuecomment-430486940 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1641: [WEEX-646][Android] fix loading disappear when refresh more than one time
weex-bot edited a comment on issue #1641: [WEEX-646][Android] fix loading disappear when refresh more than one time URL: https://github.com/apache/incubator-weex/pull/1641#issuecomment-430486940 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen commented on a change in pull request #1641: [WEEX-646][Android] fix loading disappear when refresh more than one time
YorkShen commented on a change in pull request #1641: [WEEX-646][Android] fix
loading disappear when refresh more than one time
URL: https://github.com/apache/incubator-weex/pull/1641#discussion_r225811461
##
File path:
android/sdk/src/main/java/com/taobao/weex/ui/component/WXLoading.java
##
@@ -60,6 +60,16 @@ public void onLoading() {
}
}
+ @Override
+ protected void setHostLayoutParams(WXFrameLayout host, int width, int height,
+ int left, int right, int top, int bottom)
{
+// The view of WXLoading will always be wrapped by a WXRefreshView at some
point
+// which is unknowable for front-end so the margins should always be 0 in
LayoutParams,
+// otherwise it will bring visible layout errors. This means WXLoading do
not
+// support margin.
+super.setHostLayoutParams(host, width, height, 0, 0, 0, 0);
Review comment:
why top=bottom=0 ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chenzefeng09 opened a new issue #1642: 如何应对js劫持？
chenzefeng09 opened a new issue #1642: 如何应对js劫持？ URL: https://github.com/apache/incubator-weex/issues/1642 我在客户端渲染weex js 文件之前会对文件做md5 校验. 监控发现有些用户在某个网络环境下持续的md5校验失败，无法显示页面，切换网络环境就可以恢复. 怀疑是运营商对http 请求的js文件做了某些修改注入,有什么办法应对吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joy2helloworld commented on issue #1635: jacoco agent in 0.19.0.3 release
joy2helloworld commented on issue #1635: jacoco agent in 0.19.0.3 release URL: https://github.com/apache/incubator-weex/issues/1635#issuecomment-430536976 遇到同样的问题 ，求解 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen commented on issue #1641: [WEEX-646][Android] fix loading disappear when refresh more than one time
YorkShen commented on issue #1641: [WEEX-646][Android] fix loading disappear when refresh more than one time URL: https://github.com/apache/incubator-weex/pull/1641#issuecomment-430539562 Got it, don't bother This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen closed pull request #1641: [WEEX-646][Android] fix loading disappear when refresh more than one time
YorkShen closed pull request #1641: [WEEX-646][Android] fix loading disappear
when refresh more than one time
URL: https://github.com/apache/incubator-weex/pull/1641
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXLoading.java
b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXLoading.java
index 8130ace9cd..9ddd15a75a 100644
--- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXLoading.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXLoading.java
@@ -60,6 +60,16 @@ public void onLoading() {
}
}
+ @Override
+ protected void setHostLayoutParams(WXFrameLayout host, int width, int height,
+ int left, int right, int top, int bottom)
{
+// The view of WXLoading will always be wrapped by a WXRefreshView at some
point
+// which is unknowable for front-end so the margins should always be 0 in
LayoutParams,
+// otherwise it will bring visible layout errors. This means WXLoading do
not
+// support margin.
+super.setHostLayoutParams(host, width, height, 0, 0, 0, 0);
+ }
+
@Override
public void onPullingUp(float dy, int pullOutDistance, float viewHeight) {
if (getEvents().contains(Constants.Event.ONPULLING_UP)) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] leoyin opened a new issue #1643: IOS - input 值精度丢失
leoyin opened a new issue #1643: IOS - input 值精度丢失 URL: https://github.com/apache/incubator-weex/issues/1643 ## Description 千牛客户端，weex 开发的差距，input 输入框。 value值设置为部分浮点数值 如：8.55、8.53、8.88 等，展示值存在精度丢失问题。value值设置为字符串类型无此问题 ## Environment 系统：i0S WeexVersion 0.17.0 ## Broken Example 展示值为8.551 ## Steps to Reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] imfenghuang commented on issue #1642: 如何应对js劫持？
imfenghuang commented on issue #1642: 如何应对js劫持？ URL: https://github.com/apache/incubator-weex/issues/1642#issuecomment-430598209 http -> https This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chenzefeng09 commented on issue #1642: 如何应对js劫持？
chenzefeng09 commented on issue #1642: 如何应对js劫持？ URL: https://github.com/apache/incubator-weex/issues/1642#issuecomment-430600974 > http -> https https还是比较慢，有什么方法，比如修改请求或返回header之类的让运营商认为这不是个js？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] acton393 opened a new pull request #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript
acton393 opened a new pull request #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript URL: https://github.com/apache/incubator-weex/pull/1644 wrap a series of dom operations with beginBatch and endBatch directives, when every V-sync signal comes, we try to ensure that the operations between beginBatch and endBatch can be performed in current V-sync, this policy can drop frames maybe, for our policy dropping frames, we only allow 20 frames at most. feature:648 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript
weex-bot commented on issue #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript URL: https://github.com/apache/incubator-weex/pull/1644#issuecomment-430659894 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript
weex-bot edited a comment on issue #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript URL: https://github.com/apache/incubator-weex/pull/1644#issuecomment-430659894 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript
weex-bot edited a comment on issue #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript URL: https://github.com/apache/incubator-weex/pull/1644#issuecomment-430659894 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joy2helloworld commented on issue #1631: 新版本地址下载链接失败：404
joy2helloworld commented on issue #1631: 新版本地址下载链接失败：404 URL: https://github.com/apache/incubator-weex/issues/1631#issuecomment-430855181 这个问题是解决了吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] holyace opened a new pull request #1645: [core]fix string operating number
holyace opened a new pull request #1645: [core]fix string operating number URL: https://github.com/apache/incubator-weex/pull/1645 fix OP_DIV operation when one of the operation of the operator is a string. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1645: [core]fix string operating number
weex-bot commented on issue #1645: [core]fix string operating number URL: https://github.com/apache/incubator-weex/pull/1645#issuecomment-430887528 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1645: [core]fix string operating number
weex-bot commented on issue #1645: [core]fix string operating number URL: https://github.com/apache/incubator-weex/pull/1645#issuecomment-430887526 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1645: [core]fix string operating number
weex-bot edited a comment on issue #1645: [core]fix string operating number URL: https://github.com/apache/incubator-weex/pull/1645#issuecomment-430887526 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucky-chen opened a new pull request #1646: [WEEX-649][Android] add `isBundleRequest` flag to requestParams when downLoadBundle
lucky-chen opened a new pull request #1646: [WEEX-649][Android] add `isBundleRequest` flag to requestParams when downLoadBundle URL: https://github.com/apache/incubator-weex/pull/1646 add `isBundleRequest` flag to requestParams when downLoadBundle This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1646: [WEEX-649][Android] add `isBundleRequest` flag to requestParams when downLoadBundle
weex-bot commented on issue #1646: [WEEX-649][Android] add `isBundleRequest` flag to requestParams when downLoadBundle URL: https://github.com/apache/incubator-weex/pull/1646#issuecomment-430901572 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1646: [WEEX-649][Android] add `isBundleRequest` flag to requestParams when downLoadBundle
weex-bot edited a comment on issue #1646: [WEEX-649][Android] add `isBundleRequest` flag to requestParams when downLoadBundle URL: https://github.com/apache/incubator-weex/pull/1646#issuecomment-430901572 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1646: [WEEX-649][Android] add `isBundleRequest` flag to requestParams when downLoadBundle
weex-bot edited a comment on issue #1646: [WEEX-649][Android] add `isBundleRequest` flag to requestParams when downLoadBundle URL: https://github.com/apache/incubator-weex/pull/1646#issuecomment-430901572 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] acton393 opened a new pull request #1647: [WEEX-648][Android]native batch for dom operations generating from JavaScript
acton393 opened a new pull request #1647: [WEEX-648][Android]native batch for dom operations generating from JavaScript URL: https://github.com/apache/incubator-weex/pull/1647 introduce a native batch for dom operations generating from JavaScript wrap a series of dom operations with beginBatch and endBatch directives, when every V-sync signal comes, we try to ensure that the operations between beginBatch and endBatch can be performed in current V-sync, this policy can drop frames maybe, for our policy dropping frames, we only allow 20 frames at most. see iOS pull request https://github.com/apache/incubator-weex/pull/1644 feature:648 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1647: [WEEX-648][Android]native batch for dom operations generating from JavaScript
weex-bot edited a comment on issue #1647: [WEEX-648][Android]native batch for dom operations generating from JavaScript URL: https://github.com/apache/incubator-weex/pull/1647#issuecomment-430949728 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1647: [WEEX-648][Android]native batch for dom operations generating from JavaScript
weex-bot commented on issue #1647: [WEEX-648][Android]native batch for dom operations generating from JavaScript URL: https://github.com/apache/incubator-weex/pull/1647#issuecomment-430949728 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1647: [WEEX-648][Android]native batch for dom operations generating from JavaScript
weex-bot edited a comment on issue #1647: [WEEX-648][Android]native batch for dom operations generating from JavaScript URL: https://github.com/apache/incubator-weex/pull/1647#issuecomment-430949728 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen closed pull request #1646: [WEEX-649][Android] add `isBundleRequest` flag to requestParams when downLoadBundle
YorkShen closed pull request #1646: [WEEX-649][Android] add `isBundleRequest`
flag to requestParams when downLoadBundle
URL: https://github.com/apache/incubator-weex/pull/1646
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
b/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
index 386d0c19b6..b470d6d67e 100644
--- a/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
+++ b/android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
@@ -755,6 +755,7 @@ private void renderByUrlInternal(String pageName,
}
wxRequest.instanceId = getInstanceId();
wxRequest.paramMap.put(KEY_USER_AGENT,
WXHttpUtil.assembleUserAgent(mContext,WXEnvironment.getConfig()));
+wxRequest.paramMap.put("isBundleRequest","true");
WXHttpListener httpListener =
new WXHttpListener(pageName, renderOptions, jsonInitData, flag,
System.currentTimeMillis());
httpListener.setSDKInstance(this);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] weex-bot edited a comment on issue #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript
weex-bot edited a comment on issue #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript URL: https://github.com/apache/incubator-weex/pull/1644#issuecomment-430659894 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript
weex-bot edited a comment on issue #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript URL: https://github.com/apache/incubator-weex/pull/1644#issuecomment-430659894 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript
weex-bot edited a comment on issue #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript URL: https://github.com/apache/incubator-weex/pull/1644#issuecomment-430659894 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zdqdtc opened a new issue #1648: box-shadow draw bug
zdqdtc opened a new issue #1648: box-shadow draw bug
URL: https://github.com/apache/incubator-weex/issues/1648
## Description
i use box-shadow in list component ，when i scroll the list，the shadow is
drawed out of the list
## Environment
Weex Version: 0.17.0
Device Mode: MI 5s AND All Devices
## Broken Example
.m-gift-card {
flex-direction: column;
justify-content: space-between;
height: 105wx;
margin-left: 10wx;
margin-right: 10wx;
border-radius: 5wx;
margin-bottom: 5wx;
margin-top: 5wx;
border-width: 1px;
box-shadow: 10wx,20wx 5px #66;
}
## Steps to Reproduce
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chinabrant commented on issue #1513: JS Service无法调用
chinabrant commented on issue #1513: JS Service无法调用 URL: https://github.com/apache/incubator-weex/issues/1513#issuecomment-431274121 > 按照[官方文档](http://weex.apache.org/cn/references/js-service.html)编写了一个：[KSService.js](http://test-1252137158.file.myqcloud.com/myFloder/KSService.js) > > 原生中也注册了这个service，但是在vue中调用没有反应，是否因为文档中这个JS Service的编写例子不是完整的？ 你好，我还是跑不起来。官网上关于js service的文档太简单了。可以发个例子看看不？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chinabrant opened a new issue #1649: how to use js service?
chinabrant opened a new issue #1649: how to use js service?
URL: https://github.com/apache/incubator-weex/issues/1649
My js service register code：
```objective-c
NSString *path = [[NSBundle mainBundle] pathForResource:@"utils_service"
ofType:@"js"];
NSString *content = [NSString stringWithContentsOfFile:path
encoding:NSUTF8StringEncoding error:nil];
[WXSDKEngine registerService:@"utilsService" withScript:content
withOptions:@{ @"serviceName": @"utilsService" }];
```
JS Service code:
```javascript
service.register("utilsService", {
create: function (id, env, config) {
return {
NormalService: function (weex) {
var modal = weex.requireModule('modal')
return {
toast: function (title) {
modal.toast({ message: title })
},
...
```
use code:
var utilService = new service.normalService(weex)
error:
service name not defined
Question:
Follow this
[document](https://weex.apache.org/cn/references/js-service.html), i can't
understand how to use JS Service.
If i want to register more than one JS Service, what should i do?
Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xuyouyang commented on issue #1643: IOS - input 值精度丢失
xuyouyang commented on issue #1643: IOS - input 值精度丢失 URL: https://github.com/apache/incubator-weex/issues/1643#issuecomment-431295732 @leoyin This problem maybe cased by JSON serializing in iOS. So I think you'd better handle digital precision issues in front-end code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xuyouyang commented on issue #1633: ios Refresh component slide too much when refreshing is over
xuyouyang commented on issue #1633: ios Refresh component slide too much when refreshing is over URL: https://github.com/apache/incubator-weex/issues/1633#issuecomment-431296997 @Yhspehy Hi, can you give us an example on http://dotwe.org/vue . Thx. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 closed issue #1648: box-shadow draw bug
Hanks10100 closed issue #1648: box-shadow draw bug URL: https://github.com/apache/incubator-weex/issues/1648 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1648: box-shadow draw bug
Hanks10100 commented on issue #1648: box-shadow draw bug URL: https://github.com/apache/incubator-weex/issues/1648#issuecomment-431315978 Not support using `,` in box-shadow yet. You should write `box-shadow: 20wx 5px #66;` without `10wx,`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 closed issue #1642: 如何应对js劫持？
Hanks10100 closed issue #1642: 如何应对js劫持？ URL: https://github.com/apache/incubator-weex/issues/1642 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1642: 如何应对js劫持？
Hanks10100 commented on issue #1642: 如何应对js劫持？ URL: https://github.com/apache/incubator-weex/issues/1642#issuecomment-431316267 https 是正解。 这个问题好像和 Weex SDK 无关，欢迎在其他地方讨论。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 closed issue #1503: iOS中textArea组件中频繁大量复制粘贴文字点击done隐藏键盘时会出现键盘隐藏但页面没恢复正常的情况，非必现
Hanks10100 closed issue #1503: iOS中textArea组件中频繁大量复制粘贴文字点击done隐藏键盘时会出现键盘隐藏但页面没恢复正常的情况，非必现 URL: https://github.com/apache/incubator-weex/issues/1503 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1503: iOS中textArea组件中频繁大量复制粘贴文字点击done隐藏键盘时会出现键盘隐藏但页面没恢复正常的情况，非必现
Hanks10100 commented on issue #1503: iOS中textArea组件中频繁大量复制粘贴文字点击done隐藏键盘时会出现键盘隐藏但页面没恢复正常的情况，非必现 URL: https://github.com/apache/incubator-weex/issues/1503#issuecomment-431319698 This issue has been closed because of no feedback or lack of activity. It can be reopened If you offer more information about. Thank you for your contributions. > 长时间没回复，issue 关掉了。如果还想继续讨论，请提供更详细的信息。谢谢配合。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 closed issue #1499: web 内的 视频无法播放 weex
Hanks10100 closed issue #1499: web 内的 视频无法播放 weex URL: https://github.com/apache/incubator-weex/issues/1499 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1499: web 内的 视频无法播放 weex
Hanks10100 commented on issue #1499: web 内的 视频无法播放 weex URL: https://github.com/apache/incubator-weex/issues/1499#issuecomment-431319909 This issue has been closed because of no feedback or lack of activity. It can be reopened If you offer more information about. Thank you for your contributions. > 长时间没回复，issue 关掉了。如果还想继续讨论，请提供更详细的信息，然后会 reopen 此 issue。谢谢配合。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1558: picker is undefined !
Hanks10100 commented on issue #1558: picker is undefined ! URL: https://github.com/apache/incubator-weex/issues/1558#issuecomment-431321344 The `weex-picker` has been moved out of the `weex-vue-render` package. Here is the source code, you can import manually. https://github.com/weexteam/weex-picker By the way, I think the picker module should be put back to the `weex-vue-render` package. Maybe @imyzf can help with this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 closed issue #1643: IOS - input 值精度丢失
Hanks10100 closed issue #1643: IOS - input 值精度丢失 URL: https://github.com/apache/incubator-weex/issues/1643 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Hanks10100 commented on issue #1637: 组件自动滚动到可视区域了
Hanks10100 commented on issue #1637: 组件自动滚动到可视区域了 URL: https://github.com/apache/incubator-weex/issues/1637#issuecomment-431335126 Please offer more information, especially the steps to reproduce it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
