svn commit: r648531 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosureTest.java

2008-04-15 Thread jcompagner
Author: jcompagner
Date: Tue Apr 15 22:45:25 2008
New Revision: 648531

URL: http://svn.apache.org/viewvc?rev=648531&view=rev
Log:
java 1.5 methods... bad bad igor

Modified:

wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosureTest.java

Modified: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosureTest.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosureTest.java?rev=648531&r1=648530&r2=648531&view=diff
==
--- 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosureTest.java
 (original)
+++ 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosureTest.java
 Tue Apr 15 22:45:25 2008
@@ -120,19 +120,19 @@
// render with enclosure initally visible
tester.startPage(EnclosurePage_6.class);
String doc = tester.getServletResponse().getDocument();
-   assertTrue(doc.contains("content1"));
-   assertTrue(doc.contains("content2"));
+   assertTrue(doc.indexOf("content1") != -1);
+   assertTrue(doc.indexOf("content2") != -1);
 
// render with enclosure hidden
tester.clickLink("link");
doc = tester.getServletResponse().getDocument();
-   assertFalse(doc.contains("content1"));
-   assertFalse(doc.contains("content2"));
+   assertFalse(doc.indexOf("content1") != -1);
+   assertFalse(doc.indexOf("content2") != -1);
 
// render with enclosure visible again
tester.clickLink("link");
doc = tester.getServletResponse().getDocument();
-   assertTrue(doc.contains("content1"));
-   assertTrue(doc.contains("content2"));
+   assertTrue(doc.indexOf("content1") != -1);
+   assertTrue(doc.indexOf("content2") != -1);
}
 }




[jira] Commented: (WICKET-1497) viewport height not correctly calculated on IE7

2008-04-15 Thread Arnout Engelen (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589255#action_12589255
 ] 

Arnout Engelen commented on WICKET-1497:


It happened when I had a DateField near the bottom of the screen while showing 
a high page scrolled 'upwards'. 

The popup was correctly moved upwards in firefox, but dropped 'down' in IE7. 
After some fiddling around I found out it was because the viewport-height was 
'undefined'. This made the condition that checks whether the popup should be 
compensated vertically fail.

> viewport height not correctly calculated on IE7
> ---
>
> Key: WICKET-1497
> URL: https://issues.apache.org/jira/browse/WICKET-1497
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-datetime
>Affects Versions: 1.3.3
>Reporter: Arnout Engelen
>
> I noticed the vertical positioning of the popup isn't corrected properly 
> under IE7.
> Digging in the code, I found that Wicket.DateTime.getViewportHeight() returns 
> 'undefined' under IE7. This is a hack to work around an old problem in the 
> standard YAHOO.util.Dom.getViewportHeight();.
> It seems the hack is now broken, and the standard 
> YAHOO.util.Dom.getViewportHeight(); has since been fixed: after replacing 
> Wicket.DateTime.getViewportHeight() with YAHOO.util.Dom.getViewportHeight(); 
> it now works fine under both IE and FF again.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r648409 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java

2008-04-15 Thread ivaynberg
Author: ivaynberg
Date: Tue Apr 15 13:56:58 2008
New Revision: 648409

URL: http://svn.apache.org/viewvc?rev=648409&view=rev
Log:
javac 1.5 had a problem compiling this

Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java?rev=648409&r1=648408&r2=648409&view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
 Tue Apr 15 13:56:58 2008
@@ -147,6 +147,7 @@
 * 
 * @return enclosure's parent markup container
 */
+   @SuppressWarnings("unchecked")
private MarkupContainer< ? > getEnclosureParent()
{
MarkupContainer< ? > parent = getParent();
@@ -158,7 +159,7 @@
}
else if (parent instanceof BorderBodyContainer)
{
-   parent = ((Border< ? 
>.BorderBodyContainer)parent).findParent(Border.class);
+   parent = 
((BorderBodyContainer)parent).findParent(Border.class);
}
else
{




[jira] Resolved: (WICKET-1536) Enclosure permanently hides direct children after it has been hidden

2008-04-15 Thread Igor Vaynberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1536.
---

Resolution: Fixed

> Enclosure permanently hides direct children after it has been hidden
> 
>
> Key: WICKET-1536
> URL: https://issues.apache.org/jira/browse/WICKET-1536
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Reporter: Igor Vaynberg
>Assignee: Igor Vaynberg
> Fix For: 1.3.4, 1.4-M1
>
>
> enclosure calls setvisibilityallowed(false) on children, but never resets it 
> back to true

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (WICKET-1536) Enclosure permanently hides direct children after it has been hidden

2008-04-15 Thread Igor Vaynberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg reassigned WICKET-1536:
-

Assignee: Igor Vaynberg

> Enclosure permanently hides direct children after it has been hidden
> 
>
> Key: WICKET-1536
> URL: https://issues.apache.org/jira/browse/WICKET-1536
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Reporter: Igor Vaynberg
>Assignee: Igor Vaynberg
> Fix For: 1.3.4, 1.4-M1
>
>
> enclosure calls setvisibilityallowed(false) on children, but never resets it 
> back to true

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1536) Enclosure permanently hides direct children after it has been itself hidden once

2008-04-15 Thread Igor Vaynberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg updated WICKET-1536:
--

Summary: Enclosure permanently hides direct children after it has been 
itself hidden once  (was: Enclosure permanently hides direct children after it 
has been hidden)

> Enclosure permanently hides direct children after it has been itself hidden 
> once
> 
>
> Key: WICKET-1536
> URL: https://issues.apache.org/jira/browse/WICKET-1536
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Reporter: Igor Vaynberg
>Assignee: Igor Vaynberg
> Fix For: 1.3.4, 1.4-M1
>
>
> enclosure calls setvisibilityallowed(false) on children, but never resets it 
> back to true

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r648377 - in /wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src: main/java/org/apache/wicket/markup/html/internal/ test/java/org/apache/wicket/markup/html/internal/

2008-04-15 Thread ivaynberg
Author: ivaynberg
Date: Tue Apr 15 11:54:39 2008
New Revision: 648377

URL: http://svn.apache.org/viewvc?rev=648377&view=rev
Log:
WICKET-1536

Added:

wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_6.html
   (with props)

wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_6.java
   (with props)
Modified:

wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java

wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosureTest.java

Modified: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java?rev=648377&r1=648376&r2=648377&view=diff
==
--- 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
 (original)
+++ 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
 Tue Apr 15 11:54:39 2008
@@ -16,6 +16,11 @@
  */
 package org.apache.wicket.markup.html.internal;
 
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.Map.Entry;
+
 import org.apache.wicket.Component;
 import org.apache.wicket.MarkupContainer;
 import org.apache.wicket.WicketRuntimeException;
@@ -86,6 +91,9 @@
/** Id of the child component that will control visibility of the 
enclosure */
private final CharSequence childId;
 
+   /** Map of component->boolean that tracks original visibility allowed 
flag values */
+   private transient Map originalVisibilityStatus;
+
/**
 * Construct.
 * 
@@ -185,6 +193,7 @@
setVisible(controller.determineVisibility());
 
// transfer visibility to direct children
+   originalVisibilityStatus = new HashMap();
DirectChildTagIterator it = new 
DirectChildTagIterator(markupStream, openTag);
MarkupContainer controllerParent = getEnclosureParent();
while (it.hasNext())
@@ -193,6 +202,7 @@
Component child = controllerParent.get(t.getId());
if (child != null)
{
+   originalVisibilityStatus.put(child, 
Boolean.valueOf(child.isVisibilityAllowed()));
child.setVisibilityAllowed(isVisible());
}
}
@@ -206,6 +216,24 @@
{
markupStream.skipToMatchingCloseTag(openTag);
}
+   }
+
+   protected void onDetach()
+   {
+   if (originalVisibilityStatus != null)
+   {
+   // restore original visibility statuses
+   Iterator it = 
originalVisibilityStatus.entrySet().iterator();
+   while (it.hasNext())
+   {
+   final Map.Entry entry = (Entry)it.next();
+   final Component c = (Component)entry.getKey();
+   final boolean vis = 
((Boolean)entry.getValue()).booleanValue();
+   c.setVisibilityAllowed(vis);
+   }
+   originalVisibilityStatus = null;
+   }
+   super.onDetach();
}
 
/**

Added: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_6.html
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_6.html?rev=648377&view=auto
==
--- 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_6.html
 (added)
+++ 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_6.html
 Tue Apr 15 11:54:39 2008
@@ -0,0 +1,9 @@
+
+
+toggle
+
+
+
+
+
+
\ No newline at end of file

Propchange: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_6.html
--
svn:mime-type = text/plain

Added: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_6.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_6.

[jira] Commented: (WICKET-1534) Allow multiple URL coding strategies on the same mount path

2008-04-15 Thread Frank Bille Jensen (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589190#action_12589190
 ] 

Frank Bille Jensen commented on WICKET-1534:


Patches are always welcome :)

> Allow multiple URL coding strategies on the same mount path
> ---
>
> Key: WICKET-1534
> URL: https://issues.apache.org/jira/browse/WICKET-1534
> Project: Wicket
>  Issue Type: New Feature
>  Components: wicket
>Affects Versions: 1.3.3
>Reporter: Erik van Oosten
> Fix For: 1.4-M1
>
> Attachments: VersatileWebRequestCodingStrategy.java
>
>
> It is currently not possible to mount multiple URL coding strategies on the 
> same mount path. However, in combination with method #matches(String urlPath) 
> this would be quite easy to accomplish in a backward compatible way.
> Please find attached a class that can be used instead of 
> WebRequestCodingStrategy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r648369 - in /wicket/trunk/wicket/src: main/java/org/apache/wicket/markup/html/internal/ test/java/org/apache/wicket/markup/html/internal/

2008-04-15 Thread ivaynberg
Author: ivaynberg
Date: Tue Apr 15 11:39:31 2008
New Revision: 648369

URL: http://svn.apache.org/viewvc?rev=648369&view=rev
Log:
WICKET-1536

Added:

wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_6.html
   (with props)

wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_6.java
   (with props)
Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java

wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/internal/EnclosureTest.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java?rev=648369&r1=648368&r2=648369&view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
 Tue Apr 15 11:39:31 2008
@@ -16,6 +16,9 @@
  */
 package org.apache.wicket.markup.html.internal;
 
+import java.util.HashMap;
+import java.util.Map;
+
 import org.apache.wicket.Component;
 import org.apache.wicket.MarkupContainer;
 import org.apache.wicket.WicketRuntimeException;
@@ -74,18 +77,20 @@
  * @author Juergen Donnerstag
  * @since 1.3
  */
-public class Enclosure extends WebMarkupContainer
+public class Enclosure extends WebMarkupContainer
 {
private static final long serialVersionUID = 1L;
 
private static final Logger log = 
LoggerFactory.getLogger(Enclosure.class);
 
/** The child component to delegate the isVisible() call to */
-   private Component childComponent;
+   private Component< ? > childComponent;
 
/** Id of the child component that will control visibility of the 
enclosure */
private final CharSequence childId;
 
+   private transient Map, Boolean> originalVisibilityStatus;
+
/**
 * Construct.
 * 
@@ -102,6 +107,7 @@
 * 
 * @see org.apache.wicket.MarkupContainer#isTransparentResolver()
 */
+   @Override
public boolean isTransparentResolver()
{
return true;
@@ -112,11 +118,11 @@
 * @param childId
 * @return Child Component
 */
-   public Component getChildComponent()
+   public Component< ? > getChildComponent()
{
if (childComponent == null)
{
-   MarkupContainer parent = getEnclosureParent();
+   MarkupContainer< ? > parent = getEnclosureParent();
 
if (childId == null)
{
@@ -124,7 +130,7 @@
"You most likely forgot to register the 
EnclosureHandler with the MarkupParserFactory");
}
 
-   final Component child = parent.get(childId.toString());
+   final Component< ? > child = 
parent.get(childId.toString());
if (child == null)
{
throw new MarkupException(
@@ -139,11 +145,11 @@
/**
 * Get the real parent container
 * 
-* @return
+* @return enclosure's parent markup container
 */
-   private MarkupContainer getEnclosureParent()
+   private MarkupContainer< ? > getEnclosureParent()
{
-   MarkupContainer parent = getParent();
+   MarkupContainer< ? > parent = getParent();
while (parent != null)
{
if (parent.isTransparentResolver())
@@ -152,7 +158,7 @@
}
else if (parent instanceof BorderBodyContainer)
{
-   parent = 
((BorderBodyContainer)parent).findParent(Border.class);
+   parent = ((Border< ? 
>.BorderBodyContainer)parent).findParent(Border.class);
}
else
{
@@ -173,9 +179,10 @@
 * @see 
org.apache.wicket.MarkupContainer#onComponentTagBody(org.apache.wicket.markup.MarkupStream,
 *  org.apache.wicket.markup.ComponentTag)
 */
+   @Override
protected void onComponentTagBody(MarkupStream markupStream, 
ComponentTag openTag)
{
-   final Component controller = getChildComponent();
+   final Component< ? > controller = getChildComponent();
if (controller == this)
{
throw new WicketRuntimeException(
@@ -185,15 +192,19 @@
setVisible(controller.determineVisibility());
 
// transfer visibility to direct children
+   o

svn commit: r648366 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/Border.java

2008-04-15 Thread ivaynberg
Author: ivaynberg
Date: Tue Apr 15 11:35:08 2008
New Revision: 648366

URL: http://svn.apache.org/viewvc?rev=648366&view=rev
Log:
generics fixes

Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/Border.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/Border.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/Border.java?rev=648366&r1=648365&r2=648366&view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/Border.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/Border.java
 Tue Apr 15 11:35:08 2008
@@ -321,7 +321,9 @@
/**
 * The container to be associated with the  tag
 */
-   public class BorderBodyContainer extends WebMarkupContainer implements 
IComponentResolver
+   public class BorderBodyContainer extends WebMarkupContainer
+   implements
+   IComponentResolver
{
private static final long serialVersionUID = 1L;
 
@@ -386,15 +388,15 @@
 * @see 
org.apache.wicket.markup.resolver.IComponentResolver#resolve(org.apache.wicket.MarkupContainer,
 *  org.apache.wicket.markup.MarkupStream, 
org.apache.wicket.markup.ComponentTag)
 */
-   public boolean resolve(final MarkupContainer container, final 
MarkupStream markupStream,
-   final ComponentTag tag)
+   public boolean resolve(final MarkupContainer< ? > container,
+   final MarkupStream markupStream, final ComponentTag tag)
{
// Usually you add child components to Border instead 
of Body. Hence
// we need to help Body to properly resolve the 
children.
String id = tag.getId();
if (!id.equals(BODY_ID))
{
-   Component component = Border.this.get(id);
+   Component< ? > component = Border.this.get(id);
if (component != null)
{
component.render(markupStream);




svn commit: r648365 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java

2008-04-15 Thread ivaynberg
Author: ivaynberg
Date: Tue Apr 15 11:31:43 2008
New Revision: 648365

URL: http://svn.apache.org/viewvc?rev=648365&view=rev
Log:
generics fix

Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java?rev=648365&r1=648364&r2=648365&view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java 
(original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java Tue Apr 
15 11:31:43 2008
@@ -1216,12 +1216,16 @@
/**
 * Finds the first container parent of this component of the given 
class.
 * 
+* @param 
+*class of parent component
+* 
 * @param c
 *MarkupContainer class to search for
 * @return First container parent that is an instance of the given 
class, or null if none can be
 * found
 */
-   public final MarkupContainer< ? > findParent(final Class< ? extends 
MarkupContainer> c)
+   @SuppressWarnings("unchecked")
+   public final > Z findParent(final 
Class c)
{
// Start with immediate parent
MarkupContainer< ? > current = parent;
@@ -1232,7 +1236,7 @@
// Is current an instance of this class?
if (c.isInstance(current))
{
-   return current;
+   return (Z)current;
}
 
// Check parent




svn commit: r648354 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java

2008-04-15 Thread ivaynberg
Author: ivaynberg
Date: Tue Apr 15 10:44:57 2008
New Revision: 648354

URL: http://svn.apache.org/viewvc?rev=648354&view=rev
Log:
fix generics screw up

Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java?rev=648354&r1=648353&r2=648354&view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java 
(original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java Tue Apr 
15 10:44:57 2008
@@ -1306,7 +1306,7 @@
 * @deprecated To be removed. Please use/ override [EMAIL PROTECTED] 
#getConverter(Class)} instead.
 */
@Deprecated
-   public final IConverter getConverter()
+   public final IConverter< ? > getConverter()
{
throw new UnsupportedOperationException("use 
#getConverter(Class) instead");
}
@@ -1319,7 +1319,7 @@
 * 
 * @return The converter that should be used by this component
 */
-   public  IConverter getConverter(Class type)
+   public  IConverter getConverter(Class type)
{
return 
getApplication().getConverterLocator().getConverter(type);
}




[jira] Created: (WICKET-1537) SelectOption generates non xhtml compliant markup

2008-04-15 Thread Igor Vaynberg (JIRA)
SelectOption generates non xhtml compliant markup
-

 Key: WICKET-1537
 URL: https://issues.apache.org/jira/browse/WICKET-1537
 Project: Wicket
  Issue Type: Bug
  Components: wicket-extensions
Affects Versions: 1.3.3
Reporter: Igor Vaynberg
Priority: Minor
 Fix For: 1.3.4, 1.4-M1


selectoption outputs selected="true" instead of selected="selected"


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (WICKET-1537) SelectOption generates non xhtml compliant markup

2008-04-15 Thread Igor Vaynberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1537.
---

Resolution: Fixed

> SelectOption generates non xhtml compliant markup
> -
>
> Key: WICKET-1537
> URL: https://issues.apache.org/jira/browse/WICKET-1537
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 1.3.3
>Reporter: Igor Vaynberg
>Priority: Minor
> Fix For: 1.3.4, 1.4-M1
>
>
> selectoption outputs selected="true" instead of selected="selected"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r648345 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOption.java

2008-04-15 Thread ivaynberg
Author: ivaynberg
Date: Tue Apr 15 10:25:31 2008
New Revision: 648345

URL: http://svn.apache.org/viewvc?rev=648345&view=rev
Log:
 make selectoption xhtml compliant

Modified:

wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOption.java

Modified: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOption.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOption.java?rev=648345&r1=648344&r2=648345&view=diff
==
--- 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOption.java
 (original)
+++ 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOption.java
 Tue Apr 15 10:25:31 2008
@@ -79,7 +79,7 @@
 
if (select.isSelected(this))
{
-   tag.put("selected", "true");
+   tag.put("selected", "selected");
}
 
// Default handling for component tag




[jira] Created: (WICKET-1536) Enclosure permanently hides direct children after it has been hidden

2008-04-15 Thread Igor Vaynberg (JIRA)
Enclosure permanently hides direct children after it has been hidden


 Key: WICKET-1536
 URL: https://issues.apache.org/jira/browse/WICKET-1536
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Reporter: Igor Vaynberg
 Fix For: 1.3.4, 1.4-M1


enclosure calls setvisibilityallowed(false) on children, but never resets it 
back to true

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r648307 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOption.java

2008-04-15 Thread ivaynberg
Author: ivaynberg
Date: Tue Apr 15 09:10:48 2008
New Revision: 648307

URL: http://svn.apache.org/viewvc?rev=648307&view=rev
Log:
xhtml compliance

Modified:

wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOption.java

Modified: 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOption.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOption.java?rev=648307&r1=648306&r2=648307&view=diff
==
--- 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOption.java
 (original)
+++ 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOption.java
 Tue Apr 15 09:10:48 2008
@@ -57,6 +57,7 @@
 * @param tag
 *the abstraction representing html tag of this component
 */
+   @Override
protected void onComponentTag(final ComponentTag tag)
{
 
@@ -67,9 +68,9 @@
if (select == null)
{
throw new WicketRuntimeException(
-   "SelectOption component [" +
-   getPath() +
-   "] cannot find its 
parent Select. All SelectOption components must be a child of or below in the 
hierarchy of a Select component.");
+   "SelectOption component [" +
+   getPath() +
+   "] cannot find its parent Select. All 
SelectOption components must be a child of or below in the hierarchy of a 
Select component.");
}
 
// assign name and value
@@ -79,7 +80,7 @@
 
if (select.isSelected(this))
{
-   tag.put("selected", "true");
+   tag.put("selected", "selected");
}
 
// Default handling for component tag




[jira] Commented: (WICKET-1534) Allow multiple URL coding strategies on the same mount path

2008-04-15 Thread Erik van Oosten (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589122#action_12589122
 ] 

Erik van Oosten commented on WICKET-1534:
-

A CompoundRequestTargetUrlCodingStrategy is probably possible as well. I am 
however not sure how to code it. It would be a better solution because then you 
stay more compatible with other code (e.g. compresses coding strategy).

If this is chosen instead of the attached code, the WebRequestCodingStrategy 
(in particular the MountMap and the code that uses it) could still use some 
cleanup activity :)

> Allow multiple URL coding strategies on the same mount path
> ---
>
> Key: WICKET-1534
> URL: https://issues.apache.org/jira/browse/WICKET-1534
> Project: Wicket
>  Issue Type: New Feature
>  Components: wicket
>Affects Versions: 1.3.3
>Reporter: Erik van Oosten
> Fix For: 1.4-M1
>
> Attachments: VersatileWebRequestCodingStrategy.java
>
>
> It is currently not possible to mount multiple URL coding strategies on the 
> same mount path. However, in combination with method #matches(String urlPath) 
> this would be quite easy to accomplish in a backward compatible way.
> Please find attached a class that can be used instead of 
> WebRequestCodingStrategy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1534) Allow multiple URL coding strategies on the same mount path

2008-04-15 Thread Frank Bille Jensen (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589120#action_12589120
 ] 

Frank Bille Jensen commented on WICKET-1534:


Wouldn't this be possible to achieve the same thing with something like a 
CompoundRequestTargetUrlCodingStrategy?

> Allow multiple URL coding strategies on the same mount path
> ---
>
> Key: WICKET-1534
> URL: https://issues.apache.org/jira/browse/WICKET-1534
> Project: Wicket
>  Issue Type: New Feature
>  Components: wicket
>Affects Versions: 1.3.3
>Reporter: Erik van Oosten
> Fix For: 1.4-M1
>
> Attachments: VersatileWebRequestCodingStrategy.java
>
>
> It is currently not possible to mount multiple URL coding strategies on the 
> same mount path. However, in combination with method #matches(String urlPath) 
> this would be quite easy to accomplish in a backward compatible way.
> Please find attached a class that can be used instead of 
> WebRequestCodingStrategy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1484) class cast exception (String) in MixedParamUrlCodingStrategy with additional params with patch

2008-04-15 Thread Erik van Oosten (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589084#action_12589084
 ] 

Erik van Oosten commented on WICKET-1484:
-

An alternative is to replace the getParameterMap() method in ServletWebRequest 
like this:

public Map getParameterMap()
{
// Lazy-init parameter map. Only make one copy. It's more 
efficient, and
// we can add stuff to it (which the BookmarkablePage stuff 
does).
if (parameterMap == null)
{
parameterMap = new 
HashMap(httpServletRequest.getParameterMap());

// Replace single value parameter arrays with a single string.
for (Iterator i = parameterMap.keySet().iterator(); i.hasNext(); )
{
Object key = i.next();
Object value = parameterMap.get(key);
if ((value instanceof String[]) && ((String[]) value).length == 
1)
{
parameterMap.put(key, ((String[]) value)[0]);
}
}
}
// return a mutable copy
return parameterMap;
}


> class cast exception (String) in MixedParamUrlCodingStrategy with additional 
> params with patch
> --
>
> Key: WICKET-1484
> URL: https://issues.apache.org/jira/browse/WICKET-1484
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.2
>Reporter: Michael Grinner
> Attachments: 1484_patch.txt
>
>
> MixedParamUrlCodingStrategy has a bug in
> MixedParamUrlCodingStrategy
> appendParameters
>   if (!parameterNamesToAdd.isEmpty())
>   {
>   boolean first = true;
>   final Iterator iterator;
>   if (UnitTestSettings.getSortUrlParameters())
>   {
>   iterator = new 
> TreeSet(parameterNamesToAdd).iterator();
>   }
>   else
>   {
>   iterator = parameterNamesToAdd.iterator();
>   }
>   while (iterator.hasNext())
>   {
>   url.append(first ? '?' : '&');
>   String parameterName = (String)iterator.next();
> @@@   String value = (String)parameters.get(parameterName);
>   
> url.append(urlEncode(parameterName)).append("=").append(urlEncode(value));
>   first = false;
>   }
>   }
> where value should be a String[] not a String.
> like in AbstractRequestTargetUrlCodingStrategy
> appendParameters
>   String[] values = (String[])value;
>   for (int i = 0; i < values.length; i++)
>   {
>   appendValue(url, entry.getKey().toString(), values[i]);
>   }
> it works ok after patching MixedParamUrlCodingStrategy to
>if (!parameterNamesToAdd.isEmpty()) {
>boolean first = true;
>final Iterator iterator;
>if (UnitTestSettings.getSortUrlParameters()) {
>iterator = new TreeSet(parameterNamesToAdd).iterator();
>} else {
>iterator = parameterNamesToAdd.iterator();
>}
>while (iterator.hasNext()) {
>url.append(first ? '?' : '&');
>String parameterName = (String) iterator.next();
>Object value = parameters.get(parameterName);
>if (value != null) {
>if (value instanceof String[]) {
>String[] values = (String[]) value;
>for (String element : values) {
> url.append(this.urlEncode(parameterName)).append("=").append(this.urlEncode(element));
>}
>} else {
> url.append(this.urlEncode(parameterName)).append("=").append(this.urlEncode(value.toString()));
>}
>}
>first = false;
>}
>}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[CONF] Apache Wicket: Slides and presentations (page edited)

2008-04-15 Thread confluence










Page Edited :
WICKET :
Slides and presentations



 
Slides and presentations
has been edited by Johan Compagner
(Apr 15, 2008).
 

 
 (View changes)
 

Content:


 created for/events 
 authors 
 wicket's version 
 lang 
 agenda/toc 
 links/attachments 


 Javapolis 2005 (2005-12-12) 
 Eelco Hillenius, Martijn Dashorst 
 ??? 
 en 

	Introduction
	Component based web development
	Wicket concepts
	10 minute workout
	Working with forms
	Q&A



	slides (need registration)




 JavaZone 2007 
 Xavier Hanin, Martijn Dashorst 
 wicket-1.3.0-beta2 
 en 

	What is Wicket
	Core concepts of Wicket
	Developing a custom component
	Q&A



	slides,
	eclipse project




 JUG Hamburg 10/2007 
 based on the JavaZone presentation 
 German 
 Jan Kriesten 
 wicket-1.3.0-beta4 
 de 

	Was ist Wicket
	Aufbau und Konzept
	Komponenten by Example
	Wicket testen
	Ausblick und Resümee



	Vortrag (PDF),
	Demo Source




 Amsterdam Meetup'07 
 Several 
 Wicket 1.3 
 English 
 
 presentations 


 JavaEdge 2007 
 Yoav Hackman  
 Wicket 1.3 
 English 

	Overview
	The Wicket Way
	Features
	Demo
	Q&A



	slides




 ApacheCon EU '08 
 Gerolf Seitz 
 Wicket 1.3 
 English 

	What is Wicket?
	Core Concepts
	Developing a Custom Component



	slides
	source




 Amsterdam Meetup'08 
 Wicket Next
 Wicket 1.4/1.5 
 English 
 
 slides 













Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences








[jira] Updated: (WICKET-1535) ExternalLink JavaScript not working in FF 3

2008-04-15 Thread Gwyn Evans (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gwyn Evans updated WICKET-1535:
---

Priority: Minor  (was: Major)

> ExternalLink JavaScript not working in FF 3
> ---
>
> Key: WICKET-1535
> URL: https://issues.apache.org/jira/browse/WICKET-1535
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.3
> Environment: WinXP; Firefox 3.0 Beta 5
>Reporter: Gwyn Evans
>Priority: Minor
> Fix For: 1.3.4
>
>
> If the link target isn't a proper anchor, the code generates a JS on-click 
> handler, i.e. 
>tag.put("onclick", "window.location.href='" + url + "';");
> which generates code such as 
>   onclick='window.location.href="http://news.bbc.co.uk";;'
> The problem is that when this is used with a button in a form, while this 
> works with IE & FF2, it appears that FF3 needs a 'return false;' at the end 
> of the JS before it works, otherwise it just treats the button as a 'submit' 
> action.
> So, is there any down-side to changing the above line in 
>   \org\apache\wicket\markup\html\link\ExternalLink.java
> to be 
>   tag.put("onclick", "window.location.href='" + url + "'; return false;"); ?
> /Gwyn

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (WICKET-1535) ExternalLink JavaScript not working in FF 3

2008-04-15 Thread Gwyn Evans (JIRA)
ExternalLink JavaScript not working in FF 3
---

 Key: WICKET-1535
 URL: https://issues.apache.org/jira/browse/WICKET-1535
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3
 Environment: WinXP; Firefox 3.0 Beta 5
Reporter: Gwyn Evans
 Fix For: 1.3.4


If the link target isn't a proper anchor, the code generates a JS on-click 
handler, i.e. 
   tag.put("onclick", "window.location.href='" + url + "';");
which generates code such as 
  onclick='window.location.href="http://news.bbc.co.uk";;'

The problem is that when this is used with a button in a form, while this works 
with IE & FF2, it appears that FF3 needs a 'return false;' at the end of the JS 
before it works, otherwise it just treats the button as a 'submit' action.

So, is there any down-side to changing the above line in 
  \org\apache\wicket\markup\html\link\ExternalLink.java
to be 
  tag.put("onclick", "window.location.href='" + url + "'; return false;"); ?

/Gwyn

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1534) Allow multiple URL coding strategies on the same mount path

2008-04-15 Thread Erik van Oosten (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589048#action_12589048
 ] 

Erik van Oosten commented on WICKET-1534:
-

Nothing changes there. It is already possible that multiple URL encoders are 
mounted for the same page type.

> Allow multiple URL coding strategies on the same mount path
> ---
>
> Key: WICKET-1534
> URL: https://issues.apache.org/jira/browse/WICKET-1534
> Project: Wicket
>  Issue Type: New Feature
>  Components: wicket
>Affects Versions: 1.3.3
>Reporter: Erik van Oosten
> Fix For: 1.4-M1
>
> Attachments: VersatileWebRequestCodingStrategy.java
>
>
> It is currently not possible to mount multiple URL coding strategies on the 
> same mount path. However, in combination with method #matches(String urlPath) 
> this would be quite easy to accomplish in a backward compatible way.
> Please find attached a class that can be used instead of 
> WebRequestCodingStrategy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[CONF] Apache Wicket: Community meetups (page edited)

2008-04-15 Thread confluence










Page Edited :
WICKET :
Community meetups



 
Community meetups
has been edited by Guðmundur Bjarni Ólafsson
(Apr 15, 2008).
 

 
 (View changes)
 

Content:
Bookmarkable link

If you're thinking about organizing a local meetup, don't hesitate to add your initiative to this list!
Pictures of past Wicket meetings can be found here: http://flickr.com/photos/tags/wicketmeeting/

There are already efforts to organize meetups in the following countries:


  United Kingdom
  Belgium
  The Netherlands
  Denmark
  Sweden
  Brazil
  Argentina
  United States
  Austria
  Canada


United Kingdom

Location: London
Regular meetups: The first Wednesday of every month
To register, go here: http://jweekend.co.uk/dev/LWUGReg

Belgium

Last meetup: JavaPolis'07 (dec 12th-14th)

Martijn Dashorst will give a Wicket presentation at the conference. We are interested in a Birds of a Feather (BoF) meeting, and interest can be registered here.
When you want to attend, you need to be registered at the conference too. The presentation and BoF will be in English.


 Name 
 Interested 
 Will come! 
 BoF? 


 Martijn Dashorst 
 x 
 x 
 x 


 Per Ejeklint 
 x 
 x 
 yeah! 


 Xavier Hanin 
 x 
 x 
 x 


 Francis De Brabandere 
 x 
 ? 
 x 



The Netherlands

The excitement in the Netherlands keeps growing check it out: Wicket Community meetups - Amsterdam.

Denmark

Location: Copenhagen
Next meetup: 23 april 16 hrs has been proposed. 

Speakers/ areas of interest? Write what you want to hear about here.. Then people can add themselves as speakers


 content 
 speaker? 


 Wicket-Spring-JPA-Hibernate (only if theres interest in it)
 Nino 


 Testing Wicket experiences 
 Nino


 Creating behaviors (only if theres interest in it)
 Nino


 Selling wicket (to your company, and customers) 
 Discussion 





 Name 
 Interested 
 Will come 
 Language 
 Comments 
 Cant Come Dates 


 Frank Bille 
 x 
 x 
 Danish,English 
 
 


 Nino Martinez 
 x 
 x 
 Danish,English 
 
 29.nov - 06 dec 


 Jan Mikkelsen 
 x 
 ? 
 Danish,English 
 
 


 Flemming Boller 
 x 
 x 
 Danish,English 
 
 


 Guðmundur Bjarni 
 x 
 x 
 Danish,English,Icelandic 
 
 


 Henrik Eiriksson 
 x  
 ?  
 Danish,English,Icelandic 
 


 Finn Bock 
 x 
 x 
 Danish,English 
 


 Kristian Jensen 
 x 
 x 
 Danish,English 
 



Sweden

Location: Stockholm
Next meetup: 3rd April

Web page: http://wicket.jalbum.net

Please also join the google group (at the web page) to receive invitations to the meetups.

Brazil

Location: Rio de Janeiro
Next meetup: to be scheduled

Register here or send an e-mail to Alexandre Bairos (alexandre.bairos at gmail.com) and let us know you are interested.


 Name 
 Interested 
 Will come 
 Language 
 Comments 


 Alexandre Bairos 
 x 
 x 
 Portuguese,English,P 


 Bruno Borges 
 x 
 x 
 Portuguese,English,P 



Argentina

Location: Buenos Aires
Next meetup: to be scheduled

Register here or send an e-mail to  (fernando.wermus at gmail.com) and let us know you are interested.


 Name 
 Interested 
 Will come 
 Language 
 Comments 


 Fernando Wermus 
 x 
 x 
 Portuguese,English,Spanish,P 


 Juan G. Arias 
 x 
 x 
 English,Spanish,P 


 Eduardo Constantin 
 x 
 x 
 Portuguese,English,Spanish,P 




United States

Wicket Users Group - Twin Cities
Location: Minneapolis, MN
Next meetup: to be scheduled (see group website)

http://groups.google.com/group/wicket-user-group-twincities

Location: Seattle
Next meetup: to be scheduled

Send an e-mail to Eelco Hillenius (eelco.hillenius at gmail.com) if you'd like to see this happen



 Name 
 Interested 
 Comments 


 Eelco Hillenius 
 x 
 


 Jonathan Locke 
 x 
 


 Eric Crampton 
 x 
 


 Jose Collas 
 x 
 



Location: San Francisco
Next meetup: to be scheduled

Send an email to Orion Letizi ([EMAIL PROTECTED]) and let us know if you are interested


 Name 
 Interested 
 Will come 
 Dec. 6 
 Dec. 14 
 Comments 


 Orion Letizi 
 x 
 x 
 x 
 x 
 


 Nick Johnson 
 x 
 x 
 x 
 x 
 


 Al Maw 
 x 
 
 
 
 Can only make it if between 28th Nov and 12th Dec 


 Julian Sinai  
 x  
 
 
 
 


 Sehyo Chang 
 x 
 
 
 
 


 David Pollak 
 x 
 x 
 
 
 


 Enrique Rodriguez 
 x 
 x 
 
 
 


 David Sean Taylor 
 
 
 
 
 


 Sean Sullivan 
 x 
 x 
 
 
 December 2 through December 6 



Austria

Location: Linz or Hagenberg
Next meetup: to be scheduled

Send an e-mail to Gerolf Seitz (gerolf.seitz at gmail.com) if you're interested in a "get together" and/or register below


 Name 
 Interested 
 Will come 
 Comments 


 Gerolf Seitz 
 x 
 x 



Canada

Location: Ottawa
Next meetup: to be scheduled

Send an e-mail to Jay Lawrence (jay.a2 at infonium.ca) and let us know you are interested


 Name 
 Interested 
 Will come 
 Comments 


 Jay Lawrence 
 x 
 x 
 



Location: Toronto
Next meetup: to be scheduled

Send an e-mail to Mike O'Cleirigh (mike at rivulet.ca) if you're intereste

[jira] Commented: (WICKET-1534) Allow multiple URL coding strategies on the same mount path

2008-04-15 Thread Johan Compagner (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589040#action_12589040
 ] 

Johan Compagner commented on WICKET-1534:
-

and which one to use when you do setResponsePage()



> Allow multiple URL coding strategies on the same mount path
> ---
>
> Key: WICKET-1534
> URL: https://issues.apache.org/jira/browse/WICKET-1534
> Project: Wicket
>  Issue Type: New Feature
>  Components: wicket
>Affects Versions: 1.3.3
>Reporter: Erik van Oosten
> Fix For: 1.4-M1
>
> Attachments: VersatileWebRequestCodingStrategy.java
>
>
> It is currently not possible to mount multiple URL coding strategies on the 
> same mount path. However, in combination with method #matches(String urlPath) 
> this would be quite easy to accomplish in a backward compatible way.
> Please find attached a class that can be used instead of 
> WebRequestCodingStrategy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Issue Comment Edited: (WICKET-1534) Allow multiple URL coding strategies on the same mount path

2008-04-15 Thread Johan Compagner (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589040#action_12589040
 ] 

jcompagner edited comment on WICKET-1534 at 4/15/08 4:31 AM:
--

and which one to use when you do setResponsePage()?



  was (Author: jcompagner):
and which one to use when you do setResponsePage()


  
> Allow multiple URL coding strategies on the same mount path
> ---
>
> Key: WICKET-1534
> URL: https://issues.apache.org/jira/browse/WICKET-1534
> Project: Wicket
>  Issue Type: New Feature
>  Components: wicket
>Affects Versions: 1.3.3
>Reporter: Erik van Oosten
> Fix For: 1.4-M1
>
> Attachments: VersatileWebRequestCodingStrategy.java
>
>
> It is currently not possible to mount multiple URL coding strategies on the 
> same mount path. However, in combination with method #matches(String urlPath) 
> this would be quite easy to accomplish in a backward compatible way.
> Please find attached a class that can be used instead of 
> WebRequestCodingStrategy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (WICKET-1534) Allow multiple URL coding strategies on the same mount path

2008-04-15 Thread Erik van Oosten (JIRA)
Allow multiple URL coding strategies on the same mount path
---

 Key: WICKET-1534
 URL: https://issues.apache.org/jira/browse/WICKET-1534
 Project: Wicket
  Issue Type: New Feature
  Components: wicket
Affects Versions: 1.3.3
Reporter: Erik van Oosten
 Fix For: 1.4-M1
 Attachments: VersatileWebRequestCodingStrategy.java

It is currently not possible to mount multiple URL coding strategies on the 
same mount path. However, in combination with method #matches(String urlPath) 
this would be quite easy to accomplish in a backward compatible way.

Please find attached a class that can be used instead of 
WebRequestCodingStrategy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1534) Allow multiple URL coding strategies on the same mount path

2008-04-15 Thread Erik van Oosten (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erik van Oosten updated WICKET-1534:


Attachment: VersatileWebRequestCodingStrategy.java

> Allow multiple URL coding strategies on the same mount path
> ---
>
> Key: WICKET-1534
> URL: https://issues.apache.org/jira/browse/WICKET-1534
> Project: Wicket
>  Issue Type: New Feature
>  Components: wicket
>Affects Versions: 1.3.3
>Reporter: Erik van Oosten
> Fix For: 1.4-M1
>
> Attachments: VersatileWebRequestCodingStrategy.java
>
>
> It is currently not possible to mount multiple URL coding strategies on the 
> same mount path. However, in combination with method #matches(String urlPath) 
> this would be quite easy to accomplish in a backward compatible way.
> Please find attached a class that can be used instead of 
> WebRequestCodingStrategy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (WICKET-1533) Open Component#getApplication and #getRequestCycle for return type covariance

2008-04-15 Thread Johan Compagner (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Johan Compagner closed WICKET-1533.
---

Resolution: Won't Fix

if i want to do something. then it is to remove all those methods from Component
The component interface is polluted because of all those stupid helper methods.

You can do what you want as easy in your own RequestCycle and Application 
classes:

class MyRequestCycle
{
   static MyRequestCycle get()
   { 
 return (MyRequestCycle)RequestCycle.get();
   }
}



> Open Component#getApplication and #getRequestCycle for return type  covariance
> --
>
> Key: WICKET-1533
> URL: https://issues.apache.org/jira/browse/WICKET-1533
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.4-M1
>Reporter: Martin Benda
>Priority: Minor
>
> It would be nice to be able to override Component's getApplication and 
> getRequestCycle to return your own Application or RequestCycle subclass to 
> take advantage of Java5 return type covariance. Component#getSession is 
> already non-final.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (WICKET-1533) Open Component#getApplication and #getRequestCycle for return type covariance

2008-04-15 Thread Martin Benda (JIRA)
Open Component#getApplication and #getRequestCycle for return type  covariance
--

 Key: WICKET-1533
 URL: https://issues.apache.org/jira/browse/WICKET-1533
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 1.4-M1
Reporter: Martin Benda
Priority: Minor


It would be nice to be able to override Component's getApplication and 
getRequestCycle to return your own Application or RequestCycle subclass to take 
advantage of Java5 return type covariance. Component#getSession is already 
non-final.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1428) AutoLinkResolver and Parent-Relative (../) Links

2008-04-15 Thread Johan Compagner (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588950#action_12588950
 ] 

Johan Compagner commented on WICKET-1428:
-

we chould use a param, but then only for these situations.
if you dont want the classname you can set an alias for that thats already 
possible for a long time. (or really mount it)

and no we cant just generate that and remember it because a shared resource is 
dynamically generated on the fly

so

/resources/x.Y/foo.js

has to work also if the app server just restarted without any hit yet to the 
resource yet (so it isn't rendered through a page yet)
Then purely that url has to be able to resolve the resource.

So if you make something make sure that that is working, that the resource can 
be created and found by just the information that you have in the url and 
nothing more.

> AutoLinkResolver and Parent-Relative (../) Links
> 
>
> Key: WICKET-1428
> URL: https://issues.apache.org/jira/browse/WICKET-1428
> Project: Wicket
>  Issue Type: New Feature
>  Components: wicket
>Affects Versions: 1.3.2
>Reporter: James Carman
> Fix For: 1.5-M1
>
> Attachments: WICKET-1428.patch, wicket-link-outside-of-package.zip
>
>
> Suppose I have a package structure like this:
> com.mycompany.myproject
> --- module1
> --- page
> - Page1.html
> --- module2
> --- page
> - Page2.html
> If I want to autolink from Page1.html to Page2.html, it would look like:
> 
>  Click Here!
> 
> This is not working, however.  The AutoLinkResolver spits out a warning 
> message:
> "WARN  - AutoLinkResolver   - Did not find corresponding java class: 
> .module2.page.Page2"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.