[jira] Created: (WICKET-1539) Rework UrlValidator using jdk5's java.net.URI

2008-04-16 Thread Igor Vaynberg (JIRA)
Rework UrlValidator using jdk5's java.net.URI
-

 Key: WICKET-1539
 URL: https://issues.apache.org/jira/browse/WICKET-1539
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 1.4-M1
Reporter: Igor Vaynberg
 Fix For: 1.4-M1


this should help eliminate some of our code if it works out

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (WICKET-1541) PopupSettings' windowName fixes for IE

2008-04-16 Thread Martin Grigorov (JIRA)
PopupSettings' windowName fixes for IE
--

 Key: WICKET-1541
 URL: https://issues.apache.org/jira/browse/WICKET-1541
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 1.3.2
 Environment: Internet Explorer 6/7
Reporter: Martin Grigorov
Priority: Trivial


In o.a.w.markup.html.link.PopupSettings.java there is a fix for IE at line 177:

// Fix for IE bug.
windowTitle = windowTitle.replace(':', '_');

This fix should either be improved/extended or there would be stated in the 
javadocs for 'pageMap' that IE supports only alphanumeric characters 
and underscore in the windowTitle.

Attached quickstart shows the problem in IE.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1541) PopupSettings' windowName fixes for IE

2008-04-16 Thread Martin Grigorov (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov updated WICKET-1541:


Attachment: popups.tgz

 PopupSettings' windowName fixes for IE
 --

 Key: WICKET-1541
 URL: https://issues.apache.org/jira/browse/WICKET-1541
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 1.3.2
 Environment: Internet Explorer 6/7
Reporter: Martin Grigorov
Priority: Trivial
 Attachments: popups.tgz


 In o.a.w.markup.html.link.PopupSettings.java there is a fix for IE at line 
 177:
   // Fix for IE bug.
   windowTitle = windowTitle.replace(':', '_');
 This fix should either be improved/extended or there would be stated in the 
 javadocs for 'pageMap' that IE supports only alphanumeric characters 
 and underscore in the windowTitle.
 Attached quickstart shows the problem in IE.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (WICKET-1542) Transparent Resolvers as targets for Ajax requests

2008-04-16 Thread Jan Kriesten (JIRA)
Transparent Resolvers as targets for Ajax requests
--

 Key: WICKET-1542
 URL: https://issues.apache.org/jira/browse/WICKET-1542
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 1.3.3
 Environment: Any
Reporter: Jan Kriesten


As it is now, using Componants which are transparent resolvers as targets for 
Ajax requests don't lead to actually rerender their Markup-children.

Now I have an urgent implementation issue with this where I want to have two 
table rows with a DataTable for certain rows, so I have to change the Markup 
hierarchy. To not break the functionality of the contained DataGrid, I have to 
use a transparent resolver:

  wicket:container wicket:id=rows
tr wicket:id=rowtd wicket:id=cellsspan 
wicket:id=cell[cell]/span/td/tr
tr wicket:id=action-rowtd wicket:id=action-cellsspan 
wicket:id=action-cell[cell]/span/td/tr
  /wicket:container

'row' would be the transparent resolver in this case - and also a target for 
Ajax requests.

This doesn't work at the moment, since the 'cells' aren't re-rendered on Ajax 
requests. 

Is there another solution to this problem I didn't think of? Or is there 
another solution to have the cells rerendered?


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1541) PopupSettings' windowName fixes for IE

2008-04-16 Thread Martin Grigorov (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov updated WICKET-1541:


Description: 
In o.a.w.markup.html.link.PopupSettings.java there is a fix for IE at line 177:

// Fix for IE bug.
windowTitle = windowTitle.replace(':', '_');

This fix should either be improved/extended or it would be good if the javadocs 
for 'pageMap' state that IE supports only alphanumeric characters 
and underscore in the windowTitle.

Attached quickstart shows the problem in IE: a pageMap/windowTitle with a dash 
leads to Illegal argument JavaScript error.

  was:
In o.a.w.markup.html.link.PopupSettings.java there is a fix for IE at line 177:

// Fix for IE bug.
windowTitle = windowTitle.replace(':', '_');

This fix should either be improved/extended or there would be stated in the 
javadocs for 'pageMap' that IE supports only alphanumeric characters 
and underscore in the windowTitle.

Attached quickstart shows the problem in IE.   


 PopupSettings' windowName fixes for IE
 --

 Key: WICKET-1541
 URL: https://issues.apache.org/jira/browse/WICKET-1541
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 1.3.2
 Environment: Internet Explorer 6/7
Reporter: Martin Grigorov
Priority: Trivial
 Attachments: popups.tgz


 In o.a.w.markup.html.link.PopupSettings.java there is a fix for IE at line 
 177:
   // Fix for IE bug.
   windowTitle = windowTitle.replace(':', '_');
 This fix should either be improved/extended or it would be good if the 
 javadocs for 'pageMap' state that IE supports only alphanumeric characters 
 and underscore in the windowTitle.
 Attached quickstart shows the problem in IE: a pageMap/windowTitle with a 
 dash leads to Illegal argument JavaScript error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (WICKET-1543) AjaxFormSubmitBehavior fails to find the form if it is added directly to the form

2008-04-16 Thread Kent Tong (JIRA)
AjaxFormSubmitBehavior fails to find the form if it is added directly to the 
form
-

 Key: WICKET-1543
 URL: https://issues.apache.org/jira/browse/WICKET-1543
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3
Reporter: Kent Tong


In the getForm() method in AjaxFormSubmitBehavior, when it is looking for the 
enclosing Form, it starts from the parent of the associated component. This 
will fail if the associated component itself is the Form:

protected Form getForm()
{
if (form == null)
{
Component component = getComponent();
form = (Form)component.findParent(Form.class); //fails 
if component itself is the Form
...
}
}


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (WICKET-1545) problems with stateless forms and radiogroups/checkgroups

2008-04-16 Thread Alexei Sokolov (JIRA)
problems with stateless forms and radiogroups/checkgroups
-

 Key: WICKET-1545
 URL: https://issues.apache.org/jira/browse/WICKET-1545
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3
Reporter: Alexei Sokolov


I'm trying to use radiogroup/checkgroup with stateless form, and it is not 
possible at the moment. I get the following exception:

submitted http post value [radio4] for RadioGroup component [0:form:whatever] 
is illegal because it does not contain relative path to a Radio componnet. Due 
to this the RadioGroup component cannot resolve the selected Radio component 
pointed to by the illegal value. A possible reason is that component hierarchy 
changed between rendering and form submission.

I think the problem lies inside Check  Radio components, which use 
Page.getAutoIndex()  and that value is different before and after page 
submission for Check/Radio components.

Now, it is not possible to override getValue() on Check/Radio components, so 
I'm kind of stuck now...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (WICKET-1546) Package resource not found for YUI package

2008-04-16 Thread Per Newgro (JIRA)
Package resource not found for YUI package
--

 Key: WICKET-1546
 URL: https://issues.apache.org/jira/browse/WICKET-1546
 Project: Wicket
  Issue Type: Wish
  Components: wicket-extensions
Affects Versions: 1.3.3
 Environment: windows xp prof, suse 10.3
Reporter: Per Newgro


We get some warnings in our logs. Its a bit annoying because we don't know how 
to fix it

2008-03-27 10:14:24,966 INFO  [ajp-127.0.0.1-8009-19] STDOUT: 10:14:24,966
WARN  [PackageResource] Unable to find package resource [path =
org/apache/wicket/extensions/yui/skin.css, style = null, locale = null]
2008-03-27 10:14:24,966 INFO  [ajp-127.0.0.1-8009-19] STDOUT: 10:14:24,966
WARN  [PackageResource] Unable to find package resource [path =
org/apache/wicket/extensions/yui/skin.css, style = null, locale = null]
2008-03-27 10:14:24,970 INFO  [ajp-127.0.0.1-8009-1] STDOUT: 10:14:24,970
WARN  [PackageResource] Unable to find package resource [path =
org/apache/wicket/extensions/yui/button/button-min.js, style = null, locale
= null]
2008-03-27 10:14:24,971 INFO  [ajp-127.0.0.1-8009-29] STDOUT: 10:14:24,971
WARN  [PackageResource] Unable to find package resource [path =
org/apache/wicket/extensions/yui/charts/charts-experimental-min.js, style =
null, locale = null]
2008-03-27 10:14:24,973 INFO  [ajp-127.0.0.1-8009-31] STDOUT: 10:14:24,972
WARN  [PackageResource] Unable to find package resource [path =
org/apache/wicket/extensions/yui/colorpicker/colorpicker-beta-min.js, style
= null, locale = null]
2008-03-27 10:14:24,973 INFO  [ajp-127.0.0.1-8009-31] STDOUT: 10:14:24,973
WARN  [PackageResource] Unable to find package resource [path =
org/apache/wicket/extensions/yui/colorpicker/colorpicker-beta-min.js, style
= null, locale = null]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r648797 - /wicket/branches/wicket-1.3.x/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/authentication/MyAuthenticatedWebSession.java

2008-04-16 Thread marrink
Author: marrink
Date: Wed Apr 16 12:23:28 2008
New Revision: 648797

URL: http://svn.apache.org/viewvc?rev=648797view=rev
Log:
fix deprecated 2 arg constructor

Modified:

wicket/branches/wicket-1.3.x/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/authentication/MyAuthenticatedWebSession.java

Modified: 
wicket/branches/wicket-1.3.x/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/authentication/MyAuthenticatedWebSession.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/authentication/MyAuthenticatedWebSession.java?rev=648797r1=648796r2=648797view=diff
==
--- 
wicket/branches/wicket-1.3.x/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/authentication/MyAuthenticatedWebSession.java
 (original)
+++ 
wicket/branches/wicket-1.3.x/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/authentication/MyAuthenticatedWebSession.java
 Wed Apr 16 12:23:28 2008
@@ -17,7 +17,6 @@
 package org.apache.wicket.examples.authentication;
 
 import org.apache.wicket.Request;
-import org.apache.wicket.authentication.AuthenticatedWebApplication;
 import org.apache.wicket.authentication.AuthenticatedWebSession;
 import org.apache.wicket.authorization.strategies.role.Roles;
 
@@ -32,14 +31,12 @@
/**
 * Construct.
 * 
-* @param application
-*The application
 * @param request
 *The current request object
 */
-   public MyAuthenticatedWebSession(final AuthenticatedWebApplication 
application, Request request)
+   public MyAuthenticatedWebSession(Request request)
{
-   super(application, request);
+   super(request);
}
 
/**




svn commit: r648812 - /wicket/trunk/wicket-examples/.tomcatplugin

2008-04-16 Thread marrink
Author: marrink
Date: Wed Apr 16 12:43:07 2008
New Revision: 648812

URL: http://svn.apache.org/viewvc?rev=648812view=rev
Log:
fix tomcat classpath (for those of us using the eclipse tomcat plugin)

Modified:
wicket/trunk/wicket-examples/.tomcatplugin

Modified: wicket/trunk/wicket-examples/.tomcatplugin
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-examples/.tomcatplugin?rev=648812r1=648811r2=648812view=diff
==
Binary files - no diff available.




svn commit: r648813 - /wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/authentication/MyAuthenticatedWebSession.java

2008-04-16 Thread marrink
Author: marrink
Date: Wed Apr 16 12:43:23 2008
New Revision: 648813

URL: http://svn.apache.org/viewvc?rev=648813view=rev
Log:
fix deprecated 2 arg constructor

Modified:

wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/authentication/MyAuthenticatedWebSession.java

Modified: 
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/authentication/MyAuthenticatedWebSession.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/authentication/MyAuthenticatedWebSession.java?rev=648813r1=648812r2=648813view=diff
==
--- 
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/authentication/MyAuthenticatedWebSession.java
 (original)
+++ 
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/authentication/MyAuthenticatedWebSession.java
 Wed Apr 16 12:43:23 2008
@@ -17,7 +17,6 @@
 package org.apache.wicket.examples.authentication;
 
 import org.apache.wicket.Request;
-import org.apache.wicket.authentication.AuthenticatedWebApplication;
 import org.apache.wicket.authentication.AuthenticatedWebSession;
 import org.apache.wicket.authorization.strategies.role.Roles;
 
@@ -32,14 +31,12 @@
/**
 * Construct.
 * 
-* @param application
-*The application
 * @param request
 *The current request object
 */
-   public MyAuthenticatedWebSession(final AuthenticatedWebApplication 
application, Request request)
+   public MyAuthenticatedWebSession(Request request)
{
-   super(application, request);
+   super(request);
}
 
/**




svn commit: r648815 - /wicket/branches/wicket-1.3.x/jdk-1.5/wicket-examples/.tomcatplugin

2008-04-16 Thread marrink
Author: marrink
Date: Wed Apr 16 12:45:17 2008
New Revision: 648815

URL: http://svn.apache.org/viewvc?rev=648815view=rev
Log:
fix tomcat classpath (for those of us using the eclipse tomcat plugin)

Modified:
wicket/branches/wicket-1.3.x/jdk-1.5/wicket-examples/.tomcatplugin

Modified: wicket/branches/wicket-1.3.x/jdk-1.5/wicket-examples/.tomcatplugin
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.5/wicket-examples/.tomcatplugin?rev=648815r1=648814r2=648815view=diff
==
Binary files - no diff available.




svn commit: r648844 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket: ./ markup/ markup/html/border/ markup/html/form/

2008-04-16 Thread jdonnerstag
Author: jdonnerstag
Date: Wed Apr 16 13:58:34 2008
New Revision: 648844

URL: http://svn.apache.org/viewvc?rev=648844view=rev
Log:
generics

Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/Request.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/ContainerInfo.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/Border.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/BoxBorder.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/MarkupComponentBorder.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractChoice.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractSingleSelectChoice.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractSubmitLink.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractTextComponent.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Button.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Check.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroupSelector.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/FormComponentLabel.java

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java?rev=648844r1=648843r2=648844view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java 
(original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java Wed Apr 
16 13:58:34 2008
@@ -2594,7 +2594,7 @@
 * @param container
 *The HtmlHeaderContainer
 */
-   public void renderHead(final HtmlHeaderContainer container)
+   public void renderHead(final HtmlHeaderContainer ?  container)
{
if (isVisible())
{

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Request.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Request.java?rev=648844r1=648843r2=648844view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Request.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Request.java Wed Apr 16 
13:58:34 2008
@@ -88,7 +88,7 @@
 * 
 * @return Map of parameters
 */
-   public abstract Map getParameterMap();
+   public abstract MapString, String[] getParameterMap();
 
/**
 * Gets an array of multiple parameters by name.
@@ -136,6 +136,7 @@
 * @return Request URL
 * @deprecated Use [EMAIL PROTECTED] #getURL()} instead.
 */
+   @Deprecated
public String getRelativeURL()
{
return getURL();
@@ -161,7 +162,7 @@
if (encoder == null)
{
throw new WicketRuntimeException(request encoder must 
be not-null (provided by  +
-   processor + ));
+   processor + ));
}
 
// decode the request parameters into a strongly typed 
parameters
@@ -181,7 +182,7 @@
if (requestParameters == null)
{
throw new WicketRuntimeException(request parameters 
must be not-null (provided by  +
-   encoder + ));
+   encoder + ));
}
return requestParameters;
}
@@ -220,15 +221,16 @@
/**
 * @see java.lang.Object#toString()
 */
+   @Override
public String toString()
{
return Request[url= + getURL() + ];
}
-   
+
/**
 * Returns the query string (part after ?) of this request.
 * 
-* @return request query string 
+* @return request query string
 */
-   public abstract String getQueryString(); 
+   public abstract String getQueryString();
 }

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/ContainerInfo.java
URL: 

svn commit: r648846 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup: html/basic/Label.java html/body/BodyTagAttributeModifier.java html/debug/PageView.java parser/filter/HeadForceTagI

2008-04-16 Thread jdonnerstag
Author: jdonnerstag
Date: Wed Apr 16 14:01:14 2008
New Revision: 648846

URL: http://svn.apache.org/viewvc?rev=648846view=rev
Log:
generics

Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/basic/Label.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/body/BodyTagAttributeModifier.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/debug/PageView.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/HeadForceTagIdHandler.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/basic/Label.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/basic/Label.java?rev=648846r1=648845r2=648846view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/basic/Label.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/basic/Label.java
 Wed Apr 16 14:01:14 2008
@@ -63,6 +63,8 @@
  * /pre
  * 
  * @author Jonathan Locke
+ * @param T
+ *The model object type
  */
 public class LabelT extends WebComponentT
 {

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/body/BodyTagAttributeModifier.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/body/BodyTagAttributeModifier.java?rev=648846r1=648845r2=648846view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/body/BodyTagAttributeModifier.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/body/BodyTagAttributeModifier.java
 Wed Apr 16 14:01:14 2008
@@ -48,7 +48,7 @@
/**
 * Make sure we don't keep a reference to the component longer than 
really needed.
 */
-   private transient WeakReference componentReference;
+   private transient WeakReferenceComponent ?  componentReference;
 
/**
 * Create a new attribute modifier with the given attribute name and 
model to replace with. The
@@ -64,7 +64,7 @@
 *The component which created (owns) the modifier
 */
public BodyTagAttributeModifier(final String attribute, final boolean 
addAttributeIfNotPresent,
-   final IModel replaceModel, final Component 
behaviorOwner)
+   final IModel ?  replaceModel, final Component ?  
behaviorOwner)
{
super(attribute, addAttributeIfNotPresent, replaceModel);
init(behaviorOwner);
@@ -81,8 +81,8 @@
 * @param behaviorOwner
 *The component which created (owns) the modifier
 */
-   public BodyTagAttributeModifier(final String attribute, final IModel 
replaceModel,
-   final Component behaviorOwner)
+   public BodyTagAttributeModifier(final String attribute, final IModel ? 
 replaceModel,
+   final Component ?  behaviorOwner)
{
super(attribute, replaceModel);
init(behaviorOwner);
@@ -107,8 +107,8 @@
 *The component which created (owns) the modifier
 */
public BodyTagAttributeModifier(final String attribute, final String 
pattern,
-   final boolean addAttributeIfNotPresent, final IModel 
replaceModel,
-   final Component behaviorOwner)
+   final boolean addAttributeIfNotPresent, final IModel ?  
replaceModel,
+   final Component ?  behaviorOwner)
{
super(attribute, pattern, addAttributeIfNotPresent, 
replaceModel);
init(behaviorOwner);
@@ -129,7 +129,7 @@
 *The component which created (owns) the modifier
 */
public BodyTagAttributeModifier(final String attribute, final String 
pattern,
-   final IModel replaceModel, final Component 
behaviorOwner)
+   final IModel ?  replaceModel, final Component ?  
behaviorOwner)
{
super(attribute, pattern, replaceModel);
init(behaviorOwner);
@@ -141,17 +141,18 @@
 * @param behaviorOwner
 *The component which creates (owns) the modifier
 */
-   private void init(final Component behaviorOwner)
+   private void init(final Component ?  behaviorOwner)
{
if (behaviorOwner != null)
{
-   componentReference = new WeakReference(behaviorOwner);
+   componentReference = new WeakReferenceComponent ? 
(behaviorOwner);
}
}
 
/**
 * @see org.apache.wicket.AttributeModifier#newValue(java.lang.String, 
java.lang.String)
 */
+   @Override
protected String newValue(final 

svn commit: r648890 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java

2008-04-16 Thread ivaynberg
Author: ivaynberg
Date: Wed Apr 16 15:42:16 2008
New Revision: 648890

URL: http://svn.apache.org/viewvc?rev=648890view=rev
Log:
generics

Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java?rev=648890r1=648889r2=648890view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
 Wed Apr 16 15:42:16 2008
@@ -213,7 +213,7 @@
 *The newly selected object of the backing model NOTE this 
is the same as you would
 *get by calling getModelObject() if the new selection were 
current
 */
-   protected void onSelectionChanged(final Object newSelection)
+   protected void onSelectionChanged(final T newSelection)
{
}
 




svn commit: r648892 - in /wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples: dates/DatesPage.java forminput/FormInput.java

2008-04-16 Thread ivaynberg
Author: ivaynberg
Date: Wed Apr 16 15:48:05 2008
New Revision: 648892

URL: http://svn.apache.org/viewvc?rev=648892view=rev
Log:
generics

Modified:

wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/dates/DatesPage.java

wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java

Modified: 
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/dates/DatesPage.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/dates/DatesPage.java?rev=648892r1=648891r2=648892view=diff
==
--- 
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/dates/DatesPage.java
 (original)
+++ 
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/dates/DatesPage.java
 Wed Apr 16 15:48:05 2008
@@ -107,7 +107,7 @@
 * @see 
org.apache.wicket.markup.html.form.DropDownChoice#onSelectionChanged(java.lang.Object)
 */
@Override
-   public void onSelectionChanged(Object newSelection)
+   public void onSelectionChanged(Locale newSelection)
{
}
 

Modified: 
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java?rev=648892r1=648891r2=648892view=diff
==
--- 
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java
 (original)
+++ 
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java
 Wed Apr 16 15:48:05 2008
@@ -281,7 +281,7 @@
 * @see 
org.apache.wicket.markup.html.form.DropDownChoice#onSelectionChanged(java.lang.Object)
 */
@Override
-   public void onSelectionChanged(Object newSelection)
+   public void onSelectionChanged(Locale newSelection)
{
// note that we don't have to do anything here, as our 
property
// model allready calls FormInput.setLocale when the 
model is




[jira] Commented: (WICKET-1349) Wicket Ajax response generates a ^ character in the javascript code

2008-04-16 Thread H Q T (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12589765#action_12589765
 ] 

H Q T commented on WICKET-1349:
---

I have this issue also - where I put javascript functions in a panel between 
wicket:head tags in a panel markup. When I refresh that panel in IE it 
doesn't work. I notice that when on IE the generated ajax response shown on the 
wicket debugger shows ^ symbols. While on firefox the same action does not 
generate javascript  with the ^ symbol.

I solved this by putting my javascript into a separate .js file and put a 
reference to it from the panel wicket:head tag instead   of putting the js 
script there. This works for me and the parent container gets refreshed on ajax 
submit. I'm curious though how I can find out more why does the javascript 
placed between wicket:head causes one output on IE and a different one on FF.

 Wicket Ajax response generates a ^ character in the javascript code
 -

 Key: WICKET-1349
 URL: https://issues.apache.org/jira/browse/WICKET-1349
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.1
 Environment: IE6 and IE7
Reporter: Wen Tong Allan
Assignee: Igor Vaynberg

 I have a page that uses AjaxFallbackDefaultDataTable (using 
 SortableDataProvider ). The markup contains user-define javascript that I 
 added. When I try to do some action (delete row) with the table, the page 
 doesn't refresh in IE6 and IE7. I checked the Wicket Ajax Debugger and it 
 displays:
 ERROR: Error while parsing response: Object required
 INFO: Invoking post-call handler(s)...
 INFO: invoking failure handler(s)...
 I also noticed that the user-define javascript that was returned by the ajax 
 debugger was appended by ^. (See javascript below):
 // enable disable button.
 function setButtonState() {
 var formObj = 
 eval(document.getElementsByName(contactListForm)[0]^);
 var state = anyChecked(formObj);
 
 document.getElementsByName(deleteContactsButton)[0]^.disabled = !state;
 
 document.getElementsByName(newContactGroupButton)[0]^.disabled = !state;
 document.getElementsByName(newEventButton)[0]^.disabled 
 = !state;
 }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1534) Allow multiple URL coding strategies on the same mount path

2008-04-16 Thread Erik van Oosten (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12589834#action_12589834
 ] 

Erik van Oosten commented on WICKET-1534:
-

After a small investigation I found that a 
CompoundRequestTargetUrlCodingStrategy is indeed possible.

However, it would not really work well unless WebRequestCodingStrategy is 
changed such that the IRequestTargetUrlCodingStrategy#matches methods are 
executed outside a synchronized block.

In my application I have to access the database in the matches methods. 
(Although the data is heavily cached, I can not afford to have all requests to 
stand still while the database is accessed for one page.)

I'll try to make new patches, but if someone else is quicker I would welcome 
that :)

 Allow multiple URL coding strategies on the same mount path
 ---

 Key: WICKET-1534
 URL: https://issues.apache.org/jira/browse/WICKET-1534
 Project: Wicket
  Issue Type: New Feature
  Components: wicket
Affects Versions: 1.3.3
Reporter: Erik van Oosten
 Fix For: 1.4-M1

 Attachments: VersatileWebRequestCodingStrategy.java


 It is currently not possible to mount multiple URL coding strategies on the 
 same mount path. However, in combination with method #matches(String urlPath) 
 this would be quite easy to accomplish in a backward compatible way.
 Please find attached a class that can be used instead of 
 WebRequestCodingStrategy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.