[jira] Commented: (WICKET-1878) ExternalLink should have title field

2008-10-28 Thread Erik van Oosten (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12643227#action_12643227
 ] 

Erik van Oosten commented on WICKET-1878:
-

Proposed solution: Won't fix.

Wicket should stay clean and mean. Adding these kinds of options all over the 
place won't help achive this goal.

Here is a custom component that reaches the comitters goal with a custom 
component.

public abstract class TitledLink extends Link {

public TitledLink(String id, String title) {
this(id, new ModelString(title));
}

public TitledLink(String id, IModelString titleModel) {
super(id);
add(new AttributeModifier(title, true, titleModel));
}

}

 ExternalLink should have title field
 

 Key: WICKET-1878
 URL: https://issues.apache.org/jira/browse/WICKET-1878
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 1.3.4, 1.4-M3
Reporter: Steve Swinsburg

 The ExternalLink component should either by default have a title field, or 
 have another constructor that takes the title as a paremeter. Currently this 
 is only achieved by using AttributeAppender and setting the title attribute 
 onto the link.
 eg current:
 ExternalLink emailLink = new ExternalLink(mailToLink,new Model(mailto:; + 
 emailAddress),new Model(emailAddress));
 emailLink.add(new AttributeAppender(title, new Model(emailAddress),  ));
 I propose the following constructor:
 ExternalLink(java.lang.String id, java.lang.String href, java.lang.String 
 label, java.lang.String title) 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (WICKET-1899) Update javadocs to include information about accessibility on components that render HTML

2008-10-28 Thread Steve Swinsburg (JIRA)
Update  javadocs to include information about accessibility on components that 
render HTML
--

 Key: WICKET-1899
 URL: https://issues.apache.org/jira/browse/WICKET-1899
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 1.4-M3, 1.4-M2, 1.4-M1, 1.3.5
Reporter: Steve Swinsburg


This is a general Jira ticket to wrap up the effort to update the javadocs so 
that people using components which render HTML can use the components 
effectively to produce accessible content.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-982) Add accessibility support

2008-10-28 Thread Steve Swinsburg (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12643240#action_12643240
 ] 

Steve Swinsburg commented on WICKET-982:


This issue (WICKET-1899) is a subtask of this one, can they please be linked?

 Add accessibility support
 -

 Key: WICKET-982
 URL: https://issues.apache.org/jira/browse/WICKET-982
 Project: Wicket
  Issue Type: New Feature
  Components: wicket
Reporter: James Renfro
 Fix For: 1.5-M1


 It would be helpful to have support in Wicket specifically for programmers 
 looking to develop applications that are accessible to people with 
 disabilities. This ticket is to provide a base from which to gather specs for 
 that effort. 
 Here are some relevant links:
 http://www.w3.org/TR/aria-role/
 http://www.smartlabsoftware.com/wai-validator.htm
 http://www.w3.org/WAI/wcag-curric/sam119-0.htm
 http://www.w3.org/WAI/ 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1899) Update javadocs to include information about accessibility on components that render HTML

2008-10-28 Thread Steve Swinsburg (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Swinsburg updated WICKET-1899:


Attachment: ExternalLink.java

Attached diff for ExternalLink component adding extra Javadoc.


 Update  javadocs to include information about accessibility on components 
 that render HTML
 --

 Key: WICKET-1899
 URL: https://issues.apache.org/jira/browse/WICKET-1899
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 1.3.5, 1.4-M1, 1.4-M2, 1.4-M3
Reporter: Steve Swinsburg
 Attachments: ExternalLink.java


 This is a general Jira ticket to wrap up the effort to update the javadocs so 
 that people using components which render HTML can use the components 
 effectively to produce accessible content.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1899) Update javadocs to include information about accessibility on components that render HTML

2008-10-28 Thread Steve Swinsburg (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Swinsburg updated WICKET-1899:


Attachment: Link.java

Attached diff for Link component adding extra Javadoc. 

 Update  javadocs to include information about accessibility on components 
 that render HTML
 --

 Key: WICKET-1899
 URL: https://issues.apache.org/jira/browse/WICKET-1899
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 1.3.5, 1.4-M1, 1.4-M2, 1.4-M3
Reporter: Steve Swinsburg
 Attachments: ExternalLink.java, Link.java


 This is a general Jira ticket to wrap up the effort to update the javadocs so 
 that people using components which render HTML can use the components 
 effectively to produce accessible content.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (WICKET-1878) ExternalLink should have title field

2008-10-28 Thread Steve Swinsburg (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Swinsburg closed WICKET-1878.
---

Resolution: Later

For now, the Javadocs should be updated to show people how to add the attribute 
in themselves. This is being tracked here:
WICKET-1899

 ExternalLink should have title field
 

 Key: WICKET-1878
 URL: https://issues.apache.org/jira/browse/WICKET-1878
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 1.3.4, 1.4-M3
Reporter: Steve Swinsburg

 The ExternalLink component should either by default have a title field, or 
 have another constructor that takes the title as a paremeter. Currently this 
 is only achieved by using AttributeAppender and setting the title attribute 
 onto the link.
 eg current:
 ExternalLink emailLink = new ExternalLink(mailToLink,new Model(mailto:; + 
 emailAddress),new Model(emailAddress));
 emailLink.add(new AttributeAppender(title, new Model(emailAddress),  ));
 I propose the following constructor:
 ExternalLink(java.lang.String id, java.lang.String href, java.lang.String 
 label, java.lang.String title) 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.