[jira] Created: (WICKET-2433) Ajax support for multipart forms broken in a nested form
Ajax support for multipart forms broken in a nested form Key: WICKET-2433 URL: https://issues.apache.org/jira/browse/WICKET-2433 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.1 Environment: Java: 1.6.0_13; Java HotSpot(TM) Client VM 11.3-b02 System: Windows XP version 5.1 running on x86; Cp1250; pl_PL (nb) Reporter: Marcin Palka Ajax support for multipart forms broken in case of using a nested multipart form. The file does not get uploaded, uploadField.getFileUpload() returns null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2433) Ajax support for multipart forms broken in a nested form
[ https://issues.apache.org/jira/browse/WICKET-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcin Palka updated WICKET-2433: - Attachment: NestedUploadForm.zip A quickstart project to reproduce the issue. Ajax support for multipart forms broken in a nested form Key: WICKET-2433 URL: https://issues.apache.org/jira/browse/WICKET-2433 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.1 Environment: Java: 1.6.0_13; Java HotSpot(TM) Client VM 11.3-b02 System: Windows XP version 5.1 running on x86; Cp1250; pl_PL (nb) Reporter: Marcin Palka Attachments: NestedUploadForm.zip Ajax support for multipart forms broken in case of using a nested multipart form. The file does not get uploaded, uploadField.getFileUpload() returns null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r807285 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/ContainerWithAssociatedMarkupHelper.java
Author: jcompagner Date: Mon Aug 24 15:51:10 2009 New Revision: 807285 URL: http://svn.apache.org/viewvc?rev=807285view=rev Log: dont generated illegal uuid when creating the header part Modified: wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/ContainerWithAssociatedMarkupHelper.java Modified: wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/ContainerWithAssociatedMarkupHelper.java URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/ContainerWithAssociatedMarkupHelper.java?rev=807285r1=807284r2=807285view=diff == --- wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/ContainerWithAssociatedMarkupHelper.java (original) +++ wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/ContainerWithAssociatedMarkupHelper.java Mon Aug 24 15:51:10 2009 @@ -150,9 +150,10 @@ // found wicket:head // create a unique id for the HtmlHeaderContainer to be // created - final String headerId = _ + Classes.simpleName(markupClass) + - (container.getVariation() == null ? : container.getVariation()) + Header + - index; + final String headerId = _ + + Classes.simpleName(markupClass) + + (container.getVariation() == null ? : container.getVariation().replace(':', + '_')) + Header + index; // Create the header container and associate the markup with // it
[jira] Updated: (WICKET-2404) Quickstart for 1.4 uses 1.3 dtd in HomePage.html
[ https://issues.apache.org/jira/browse/WICKET-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2404: Attachment: WICKET-2404-1.5.patch WICKET-2404-1.4.patch Patch for Wicket 1.4 (please apply in 1.4 branch) and Wicket 1.5 (please apply in trunk). Quickstart for 1.4 uses 1.3 dtd in HomePage.html Key: WICKET-2404 URL: https://issues.apache.org/jira/browse/WICKET-2404 Project: Wicket Issue Type: Bug Components: wicket-quickstart Affects Versions: 1.4.0 Reporter: Erik van Oosten Priority: Trivial Attachments: WICKET-2404-1.4.patch, WICKET-2404-1.5.patch The generated HomePage.html contains the following header: html xmlns:wicket=http://wicket.apache.org/dtds.data/wicket-xhtml1.3-strict.dtd; That should be: html xmlns:wicket=http://wicket.apache.org/dtds.data/wicket-xhtml1.4-strict.dtd; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2404) Quickstart for 1.4 uses 1.3 dtd in HomePage.html (with patch)
[ https://issues.apache.org/jira/browse/WICKET-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2404: Summary: Quickstart for 1.4 uses 1.3 dtd in HomePage.html (with patch) (was: Quickstart for 1.4 uses 1.3 dtd in HomePage.html) Quickstart for 1.4 uses 1.3 dtd in HomePage.html (with patch) - Key: WICKET-2404 URL: https://issues.apache.org/jira/browse/WICKET-2404 Project: Wicket Issue Type: Bug Components: wicket-quickstart Affects Versions: 1.4.0 Reporter: Erik van Oosten Priority: Trivial Attachments: WICKET-2404-1.4.patch, WICKET-2404-1.5.patch The generated HomePage.html contains the following header: html xmlns:wicket=http://wicket.apache.org/dtds.data/wicket-xhtml1.3-strict.dtd; That should be: html xmlns:wicket=http://wicket.apache.org/dtds.data/wicket-xhtml1.4-strict.dtd; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2288) Refactor DefaultPageFactory#constructor
[ https://issues.apache.org/jira/browse/WICKET-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten resolved WICKET-2288. - Resolution: Invalid Seems to be fixed already. Refactor DefaultPageFactory#constructor --- Key: WICKET-2288 URL: https://issues.apache.org/jira/browse/WICKET-2288 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4-RC3 Reporter: Erik van Oosten Priority: Trivial Original Estimate: 0.03h Remaining Estimate: 0.03h Method DefaultPageFactory#constructor should loose the second parameter (argumentType) as it looks up cached Constructor instances without regard of the argument type. Instead the type (always PageParameters.class) should be hard coded in DefaultPageFactory#constructor. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1974) render_to_buffer does not work for absolute URLs
[ https://issues.apache.org/jira/browse/WICKET-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-1974: Attachment: WICKET-1974.patch This patch will remove the leading / from the buffer id (when present) in WebApplication#addBufferedResponse. mvn test runs fine. Please apply to wicket 1.4 branch. If trunk is still similar, please apply there to. render_to_buffer does not work for absolute URLs Key: WICKET-1974 URL: https://issues.apache.org/jira/browse/WICKET-1974 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4-RC1 Reporter: Erik van Oosten Attachments: WICKET-1974.patch After installing a WebRequest instance that makes all URLs absolute, render_to_buffer does not work anymore. The problem is that WicketFilter assumes that all URLs are relative (WebFilter#getRelativePath removes the first char of the URL). Proposed fixes: -1- in WebApplication#addBufferedResponse remove the leading / from the buffer id when present -2- or alternatively, remove the leading / from the URL (when present) in WebRequestCycle, just before addBudderedResponse is called Here is the installed AbsoluteServletWebRequest: /** * WebServletRequest that makes bookmarkable links absolute. * Note: use this only when WickterFilter listens on the root context. * * @author Erik van Oosten */ public class AbsoluteServletWebRequest extends ServletWebRequest { public AbsoluteServletWebRequest(HttpServletRequest servletRequest) { super(servletRequest); } @Override public int getDepthRelativeToWicketHandler() { return 0; } @Override public String getRelativePathPrefixToWicketHandler() { return /; } @Override public String getRelativePathPrefixToContextRoot() { return /; } } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1974) render_to_buffer does not work for absolute URLs (with patch)
[ https://issues.apache.org/jira/browse/WICKET-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-1974: Summary: render_to_buffer does not work for absolute URLs (with patch) (was: render_to_buffer does not work for absolute URLs) render_to_buffer does not work for absolute URLs (with patch) - Key: WICKET-1974 URL: https://issues.apache.org/jira/browse/WICKET-1974 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4-RC1 Reporter: Erik van Oosten Attachments: WICKET-1974.patch After installing a WebRequest instance that makes all URLs absolute, render_to_buffer does not work anymore. The problem is that WicketFilter assumes that all URLs are relative (WebFilter#getRelativePath removes the first char of the URL). Proposed fixes: -1- in WebApplication#addBufferedResponse remove the leading / from the buffer id when present -2- or alternatively, remove the leading / from the URL (when present) in WebRequestCycle, just before addBudderedResponse is called Here is the installed AbsoluteServletWebRequest: /** * WebServletRequest that makes bookmarkable links absolute. * Note: use this only when WickterFilter listens on the root context. * * @author Erik van Oosten */ public class AbsoluteServletWebRequest extends ServletWebRequest { public AbsoluteServletWebRequest(HttpServletRequest servletRequest) { super(servletRequest); } @Override public int getDepthRelativeToWicketHandler() { return 0; } @Override public String getRelativePathPrefixToWicketHandler() { return /; } @Override public String getRelativePathPrefixToContextRoot() { return /; } } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.