[jira] Commented: (WICKET-2569) Inheritance layout excludes XML header from output
[ https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787957#action_12787957 ] Igor Vaynberg commented on WICKET-2569: --- i agree with juergen, otherwise the child is "magically" overriding something in the parent which is inconsistent with how everything else works. > Inheritance layout excludes XML header from output > -- > > Key: WICKET-2569 > URL: https://issues.apache.org/jira/browse/WICKET-2569 > Project: Wicket > Issue Type: Bug >Affects Versions: 1.3.7, 1.4.3 >Reporter: Neil Curzon >Assignee: Juergen Donnerstag > Attachments: wicket-2569.patch, wicket-2569.tgz > > > When using inheritance layout, if the superclass (Layout class) has an ?xml > header at the top, it's excluded from the rendering of subclasses, if they > have an associated html file. If the subclass has no .html file associated > with it, the ?xml header is preserved in the rendering output. > To reproduce: Create a SuperPage class extending WebPage. At the top of > SuperPage.html, put "" . Create two > subclasses of SuperPage, one with an HTML file and one without. View the sub > pages. Notice when the one with an HTML file is rendered, the xml header is > excluded. > Expected: The ?xml header should always be preserved in the rendered output > as it's vital to the layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r888717 - in /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket: Component.java IComponentBorder.java
Author: jdonnerstag
Date: Wed Dec 9 07:19:53 2009
New Revision: 888717
URL: http://svn.apache.org/viewvc?rev=888717&view=rev
Log:
deprecated IComponentBorder in 1.4
Issue: WICKET-2280
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Component.java
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/IComponentBorder.java
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Component.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Component.java?rev=888717&r1=888716&r2=888717&view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Component.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Component.java
Wed Dec 9 07:19:53 2009
@@ -1345,7 +1345,9 @@
/**
* @return component border assigned to this component, or null if none
+* @deprecated
*/
+ @Deprecated
public final IComponentBorder getComponentBorder()
{
return getMetaData(BORDER_KEY);
@@ -2775,7 +2777,9 @@
* @param border
*component border to assign, or null to clear
any previous
* @return component for chaining
+* @deprecated
*/
+ @Deprecated
public final Component setComponentBorder(final IComponentBorder border)
{
if (!Objects.equal(getComponentBorder(), border))
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/IComponentBorder.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/IComponentBorder.java?rev=888717&r1=888716&r2=888717&view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/IComponentBorder.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/IComponentBorder.java
Wed Dec 9 07:19:53 2009
@@ -24,7 +24,9 @@
* @author jcompagner
*
* @see MarkupComponentBorder
+ * @deprecated please use IBehavior instead
*/
+...@deprecated
public interface IComponentBorder extends IClusterable
{
/**
[jira] Commented: (WICKET-2569) Inheritance layout excludes XML header from output
[ https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787949#action_12787949 ] Juergen Donnerstag commented on WICKET-2569: Which file contains the page/panel information and which the extension. The base markup contains the page/panel layout and the "inherited" markup the specific extension. In my opinion it is more logical that the base markup (the page layout) provides the xml declaration when merging the markups. > Inheritance layout excludes XML header from output > -- > > Key: WICKET-2569 > URL: https://issues.apache.org/jira/browse/WICKET-2569 > Project: Wicket > Issue Type: Bug >Affects Versions: 1.3.7, 1.4.3 >Reporter: Neil Curzon >Assignee: Juergen Donnerstag > Attachments: wicket-2569.patch, wicket-2569.tgz > > > When using inheritance layout, if the superclass (Layout class) has an ?xml > header at the top, it's excluded from the rendering of subclasses, if they > have an associated html file. If the subclass has no .html file associated > with it, the ?xml header is preserved in the rendering output. > To reproduce: Create a SuperPage class extending WebPage. At the top of > SuperPage.html, put "" . Create two > subclasses of SuperPage, one with an HTML file and one without. View the sub > pages. Notice when the one with an HTML file is rendered, the xml header is > excluded. > Expected: The ?xml header should always be preserved in the rendered output > as it's vital to the layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2600) Redirect to home page still does not work (regression)
[ https://issues.apache.org/jira/browse/WICKET-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787921#action_12787921 ] Igor Vaynberg commented on WICKET-2600: --- have you tested that this works with firefox and chrome? > Redirect to home page still does not work (regression) > -- > > Key: WICKET-2600 > URL: https://issues.apache.org/jira/browse/WICKET-2600 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3.7, 1.4.4, 1.5-M1 >Reporter: Erik van Oosten > Attachments: WICKET-2600.patch > > > It is still not possible to redirect to the home under all circumstances with > Tomcat + IE (6, 7 and 8). > WICKET-847 fixed a problem by removing any "./" at the start of the redirect > URL. > WICKET-1916 undid this for redirect URLs that are exactly equal to "./". > The latter fix is not correct, IE can not redirect to "./". > The correct addition to WICKET-847 would be to redirect to ".". See patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2601) Proposal: remove final modifier for Component#getModel
[
https://issues.apache.org/jira/browse/WICKET-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-2601.
---
Resolution: Won't Fix
Assignee: Igor Vaynberg
doesnt make sense? why have an indirection for a model which is already itself
an indirection.
> Proposal: remove final modifier for Component#getModel
> --
>
> Key: WICKET-2601
> URL: https://issues.apache.org/jira/browse/WICKET-2601
> Project: Wicket
> Issue Type: Wish
> Components: wicket
>Affects Versions: 1.3.4
>Reporter: Peter Parson
>Assignee: Igor Vaynberg
>Priority: Minor
>
> Would be handy, e.g. for labels which are to display different strings
> depending on runtime logic.
> Ex:
> new Label("conditionalLabel") {
> public IModel getModel() {
> return new StringResourceModel(condition?"mystring.yes":"mystring.no", this,
> null);
> }
> }
> Workarounds I can think of are:
> * using a PropertyModel, pointing to a getter outside conditionalLabel
> * overriding onBeforeRender in order to re-set the model before each time
> the component is rendered
> Both options do not seem very straightforward to me.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2569) Inheritance layout excludes XML header from output
[ https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787858#action_12787858 ] Neil Curzon commented on WICKET-2569: - I've attached a patch against 1.4.x that fixes the quickstart and (I think) the bug. When merging markup of a base class and its superclass, currently it seems that the XML header that wins is the one at the bottom of the inheritance tree. I think it makes more sense for the top of the inheritance tree to win... so the ?xml declaration I have in my base Layout appears at the top of my rendered pages as expected. > Inheritance layout excludes XML header from output > -- > > Key: WICKET-2569 > URL: https://issues.apache.org/jira/browse/WICKET-2569 > Project: Wicket > Issue Type: Bug >Affects Versions: 1.3.7, 1.4.3 >Reporter: Neil Curzon >Assignee: Juergen Donnerstag > Attachments: wicket-2569.patch, wicket-2569.tgz > > > When using inheritance layout, if the superclass (Layout class) has an ?xml > header at the top, it's excluded from the rendering of subclasses, if they > have an associated html file. If the subclass has no .html file associated > with it, the ?xml header is preserved in the rendering output. > To reproduce: Create a SuperPage class extending WebPage. At the top of > SuperPage.html, put "" . Create two > subclasses of SuperPage, one with an HTML file and one without. View the sub > pages. Notice when the one with an HTML file is rendered, the xml header is > excluded. > Expected: The ?xml header should always be preserved in the rendered output > as it's vital to the layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2569) Inheritance layout excludes XML header from output
[ https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neil Curzon updated WICKET-2569: Attachment: wicket-2569.patch > Inheritance layout excludes XML header from output > -- > > Key: WICKET-2569 > URL: https://issues.apache.org/jira/browse/WICKET-2569 > Project: Wicket > Issue Type: Bug >Affects Versions: 1.3.7, 1.4.3 >Reporter: Neil Curzon >Assignee: Juergen Donnerstag > Attachments: wicket-2569.patch, wicket-2569.tgz > > > When using inheritance layout, if the superclass (Layout class) has an ?xml > header at the top, it's excluded from the rendering of subclasses, if they > have an associated html file. If the subclass has no .html file associated > with it, the ?xml header is preserved in the rendering output. > To reproduce: Create a SuperPage class extending WebPage. At the top of > SuperPage.html, put "" . Create two > subclasses of SuperPage, one with an HTML file and one without. View the sub > pages. Notice when the one with an HTML file is rendered, the xml header is > excluded. > Expected: The ?xml header should always be preserved in the rendered output > as it's vital to the layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2602) Delay display of upload progress bar
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787513#action_12787513 ] Erik van Oosten commented on WICKET-2602: - An even better fix would show the upload bar only when there is a file to upload. > Delay display of upload progress bar > > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten > Attachments: WICKET-2602.patch > > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. > The patch will display the upload bar only after 1 second. Presumably a > submit without file will be finished by then. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Delay display of upload progress bar
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2602: Attachment: WICKET-2602.patch Please apply this patch to: - trunk - branch 1.4.x - branch 1.3.x > Delay display of upload progress bar > > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten > Attachments: WICKET-2602.patch > > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. > The patch will display the upload bar only after 1 second. Presumably a > submit without file will be finished by then. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2602) Delay display of upload progress bar
Delay display of upload progress bar Key: WICKET-2602 URL: https://issues.apache.org/jira/browse/WICKET-2602 Project: Wicket Issue Type: Improvement Components: wicket-extensions Reporter: Erik van Oosten When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message. The patch will display the upload bar only after 1 second. Presumably a submit without file will be finished by then. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2601) Proposal: remove final modifier for Component#getModel
[
https://issues.apache.org/jira/browse/WICKET-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787474#action_12787474
]
Johan Compagner commented on WICKET-2601:
-
what about not overriding getModel() of Component
but overrirde getObject() from a Model?
> Proposal: remove final modifier for Component#getModel
> --
>
> Key: WICKET-2601
> URL: https://issues.apache.org/jira/browse/WICKET-2601
> Project: Wicket
> Issue Type: Wish
> Components: wicket
>Affects Versions: 1.3.4
>Reporter: Peter Parson
>Priority: Minor
>
> Would be handy, e.g. for labels which are to display different strings
> depending on runtime logic.
> Ex:
> new Label("conditionalLabel") {
> public IModel getModel() {
> return new StringResourceModel(condition?"mystring.yes":"mystring.no", this,
> null);
> }
> }
> Workarounds I can think of are:
> * using a PropertyModel, pointing to a getter outside conditionalLabel
> * overriding onBeforeRender in order to re-set the model before each time
> the component is rendered
> Both options do not seem very straightforward to me.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2601) Proposal: remove final modifier for Component#getModel
Proposal: remove final modifier for Component#getModel
--
Key: WICKET-2601
URL: https://issues.apache.org/jira/browse/WICKET-2601
Project: Wicket
Issue Type: Wish
Components: wicket
Affects Versions: 1.3.4
Reporter: Peter Parson
Priority: Minor
Would be handy, e.g. for labels which are to display different strings
depending on runtime logic.
Ex:
new Label("conditionalLabel") {
public IModel getModel() {
return new StringResourceModel(condition?"mystring.yes":"mystring.no", this,
null);
}
}
Workarounds I can think of are:
* using a PropertyModel, pointing to a getter outside conditionalLabel
* overriding onBeforeRender in order to re-set the model before each time the
component is rendered
Both options do not seem very straightforward to me.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2600) Redirect to home page still does not work (regression)
[ https://issues.apache.org/jira/browse/WICKET-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2600: Attachment: WICKET-2600.patch Patch can be applied in: - trunk - branch 1.4.x - branch 1.3.x > Redirect to home page still does not work (regression) > -- > > Key: WICKET-2600 > URL: https://issues.apache.org/jira/browse/WICKET-2600 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3.7, 1.4.4, 1.5-M1 >Reporter: Erik van Oosten > Attachments: WICKET-2600.patch > > > It is still not possible to redirect to the home under all circumstances with > Tomcat + IE (6, 7 and 8). > WICKET-847 fixed a problem by removing any "./" at the start of the redirect > URL. > WICKET-1916 undid this for redirect URLs that are exactly equal to "./". > The latter fix is not correct, IE can not redirect to "./". > The correct addition to WICKET-847 would be to redirect to ".". See patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2600) Redirect to home page still does not work (regression)
Redirect to home page still does not work (regression) -- Key: WICKET-2600 URL: https://issues.apache.org/jira/browse/WICKET-2600 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.4, 1.3.7, 1.5-M1 Reporter: Erik van Oosten It is still not possible to redirect to the home under all circumstances with Tomcat + IE (6, 7 and 8). WICKET-847 fixed a problem by removing any "./" at the start of the redirect URL. WICKET-1916 undid this for redirect URLs that are exactly equal to "./". The latter fix is not correct, IE can not redirect to "./". The correct addition to WICKET-847 would be to redirect to ".". See patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2599) Missing XML prolog in wicket-extensions panel htmls
Missing XML prolog in wicket-extensions panel htmls --- Key: WICKET-2599 URL: https://issues.apache.org/jira/browse/WICKET-2599 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.4.3 Reporter: Marat Radchenko Almost all wicket-extensions panel HTML files are missing XML prologs. That makes it impossible to use wicket-extensions with throwExceptionOnMissingXmlDeclaration=true -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2598) Some components still escape non-ASCII symbols by default
Some components still escape non-ASCII symbols by default - Key: WICKET-2598 URL: https://issues.apache.org/jira/browse/WICKET-2598 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.3 Reporter: Marat Radchenko With fix for WICKET-1054 Wicket (almost) stopped escaping non-ASCII symbols by default, it calls Strings.escapeMarkup(String) or Strings.escapeMarkup(String, false, false). However, there are still some places that also call Strings.escapeMarkup with different args. I used "Strings.escapeMarkup\(.*, false, true\)" regex to find them: AbstractChoice.escapeOptionHtml, CheckBoxMultipleChoice.onComponentTagBody (the reason i started to dig into this issue) RadioChoice.onComponentTagBody They should either call String.escapeMarkup(String) or even use Component.getDefaultModelObjectAsString -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
