[jira] Commented: (WICKET-2617) ModalWindow can't be shown when it is rendered with ajax request
[
https://issues.apache.org/jira/browse/WICKET-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791838#action_12791838
]
Igor Vaynberg commented on WICKET-2617:
---
check out the source and run mvn install
> ModalWindow can't be shown when it is rendered with ajax request
>
>
> Key: WICKET-2617
> URL: https://issues.apache.org/jira/browse/WICKET-2617
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.4
>Reporter: Michael Mikhulya
>Assignee: Igor Vaynberg
> Fix For: 1.4.5
>
>
> Regression appeared with 1.4.4 release, in previous releases all worked fine.
> I load page in two requests. First one loads very small html, which then
> loads remaining part with ajax request.
> (I do so to pass parameters after '#' to server in similar way as it is done
> in gmail, but there are other reasons to render ModalWindow with ajax
> request).
> ModalWindow is rendered (but not shown) with second (ajax) request.
> The private variable "shown" is set to true:
> protected void onBeforeRender()
> {
> shown = makeContentVisible();
> Because of following implementation of makeContentVisible method:
> protected boolean makeContentVisible()
> {
> // if user is refreshing whole page, the window will not be
> shown
> return getWebRequest().isAjax();
> }
> But when I call "show" method nothing happens:
> public void show(final AjaxRequestTarget target)
> {
> if (shown == false)
> {
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> shown = true;
> }
> }
> Actually there are two problems:
> 1) behavior has changed
> 2) I didn't find safe workaround for this problem.
> Unsafe workaround as follows, notice, it can break with next wicket release
> since base "show" method is not called in sub class:
> class MyModalWindow extends ModalWindow {
> protected boolean visible = false;
> @Override
> protected boolean makeContentVisible() {
> return visible;
> }
> @Override
> public void show(org.apache.wicket.ajax.AjaxRequestTarget target) {
> visible = true;
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> };
> @Override
> public void close(AjaxRequestTarget target) {
> visible = false;
> super.close(target);
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2617) ModalWindow can't be shown when it is rendered with ajax request
[
https://issues.apache.org/jira/browse/WICKET-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791834#action_12791834
]
Michael Mikhulya commented on WICKET-2617:
--
Igor, thank you for quick response.
I would like to test your changes and provide quickstart if there is still an
issue.
Unfortunatelly I can't test your changes because the latest available snapshot
is wicket-1.4-20091031.051535-642.
I was looking for latest snapshot at
http://wicketstuff.org/maven/repository/org/apache/wicket/wicket/1.4-SNAPSHOT/
link to this maven repository is provided by
http://wicket.apache.org/getting-wicket.html
Seems like snapshots aren't automatically generated anymore or
getting-wicket.html points to wrong/obsolete maven repository.
> ModalWindow can't be shown when it is rendered with ajax request
>
>
> Key: WICKET-2617
> URL: https://issues.apache.org/jira/browse/WICKET-2617
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.4
>Reporter: Michael Mikhulya
>Assignee: Igor Vaynberg
> Fix For: 1.4.5
>
>
> Regression appeared with 1.4.4 release, in previous releases all worked fine.
> I load page in two requests. First one loads very small html, which then
> loads remaining part with ajax request.
> (I do so to pass parameters after '#' to server in similar way as it is done
> in gmail, but there are other reasons to render ModalWindow with ajax
> request).
> ModalWindow is rendered (but not shown) with second (ajax) request.
> The private variable "shown" is set to true:
> protected void onBeforeRender()
> {
> shown = makeContentVisible();
> Because of following implementation of makeContentVisible method:
> protected boolean makeContentVisible()
> {
> // if user is refreshing whole page, the window will not be
> shown
> return getWebRequest().isAjax();
> }
> But when I call "show" method nothing happens:
> public void show(final AjaxRequestTarget target)
> {
> if (shown == false)
> {
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> shown = true;
> }
> }
> Actually there are two problems:
> 1) behavior has changed
> 2) I didn't find safe workaround for this problem.
> Unsafe workaround as follows, notice, it can break with next wicket release
> since base "show" method is not called in sub class:
> class MyModalWindow extends ModalWindow {
> protected boolean visible = false;
> @Override
> protected boolean makeContentVisible() {
> return visible;
> }
> @Override
> public void show(org.apache.wicket.ajax.AjaxRequestTarget target) {
> visible = true;
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> };
> @Override
> public void close(AjaxRequestTarget target) {
> visible = false;
> super.close(target);
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r891505 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
Author: ivaynberg
Date: Thu Dec 17 01:17:34 2009
New Revision: 891505
URL: http://svn.apache.org/viewvc?rev=891505&view=rev
Log:
cleanup
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java?rev=891505&r1=891504&r2=891505&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
Thu Dec 17 01:17:34 2009
@@ -378,8 +378,17 @@
/** True if the form has enctype of multipart/form-data */
private short multiPart = 0;
- private static short MULTIPART_HARD = 0x01;
- private static short MULTIPART_HINT = 0x02;
+ /**
+* A user has explicitly called {...@link #setMultiPart(boolean)} with
value {...@code true}forcing it
+* to be true
+*/
+ private static final short MULTIPART_HARD = 0x01;
+
+ /**
+* The form has discovered a multipart component before rendering and
is marking itself as
+* multipart until next render
+*/
+ private static final short MULTIPART_HINT = 0x02;
/**
* Constructs a form with no validation.
svn commit: r891504 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
Author: ivaynberg
Date: Thu Dec 17 01:17:09 2009
New Revision: 891504
URL: http://svn.apache.org/viewvc?rev=891504&view=rev
Log:
cleanup
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java?rev=891504&r1=891503&r2=891504&view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
Thu Dec 17 01:17:09 2009
@@ -387,8 +387,17 @@
/** True if the form has enctype of multipart/form-data */
private short multiPart = 0;
- private static short MULTIPART_HARD = 0x01;
- private static short MULTIPART_HINT = 0x02;
+ /**
+* A user has explicitly called {...@link #setMultiPart(boolean)} with
value {...@code true}forcing it
+* to be true
+*/
+ private static final short MULTIPART_HARD = 0x01;
+
+ /**
+* The form has discovered a multipart component before rendering and
is marking itself as
+* multipart until next render
+*/
+ private static final short MULTIPART_HINT = 0x02;
/**
* Constructs a form with no validation.
[jira] Commented: (WICKET-2621) Ajax buttons inside ModalWindows don't submit properly
[
https://issues.apache.org/jira/browse/WICKET-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791718#action_12791718
]
Igor Vaynberg commented on WICKET-2621:
---
yep, thanks
> Ajax buttons inside ModalWindows don't submit properly
> --
>
> Key: WICKET-2621
> URL: https://issues.apache.org/jira/browse/WICKET-2621
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 1.4.4
>Reporter: Alex Grant
>Assignee: Igor Vaynberg
> Fix For: 1.4.5, 1.5-M1
>
> Attachments: wicket-2621-sample-app.zip
>
>
> I have a ModalWindow that contains an IndicatingAjaxButton. When I click the
> button, I get a big Java error complaining that the form submit wasn't
> multipart.
> Digging into the javascript in wicket-ajax.js, I found this from line 1102 in
> the method handleMultipart
> {code}
> multipart=multipart||form.enctype=="multipart/form-data";
> if (multipart==false) {
> // nothing to handle
> return false;
> }
> {code}
> When this executed, multipart was false, and enctype was "" and therefore the
> submit aborted. This may be the cause.
> Here's the Java stacktrace
> {noformat}
> java.lang.IllegalStateException: ServletRequest does not contain multipart
> content
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:113)
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:83)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.MultipartRequest.(MultipartRequest.java:41)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest.newMultipartWebRequest(UploadWebRequest.java:66)
> at
> org.apache.wicket.markup.html.form.Form.handleMultiPart(Form.java:1651)
> at
> org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:850)
> at
> org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:135)
> at
> org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:177)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:299)
> at
> org.apache.wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:119)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1250)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2621) Ajax buttons inside ModalWindows don't submit properly
[
https://issues.apache.org/jira/browse/WICKET-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791717#action_12791717
]
Alex Grant commented on WICKET-2621:
Thank you for the speedy fix.
I looked at the svn commits (out of curiousity), and noticed these
+ private static short MULTIPART_HARD = 0x01;
+ private static short MULTIPART_HINT = 0x02;
Shouldn't they be final?
> Ajax buttons inside ModalWindows don't submit properly
> --
>
> Key: WICKET-2621
> URL: https://issues.apache.org/jira/browse/WICKET-2621
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 1.4.4
>Reporter: Alex Grant
>Assignee: Igor Vaynberg
> Fix For: 1.4.5, 1.5-M1
>
> Attachments: wicket-2621-sample-app.zip
>
>
> I have a ModalWindow that contains an IndicatingAjaxButton. When I click the
> button, I get a big Java error complaining that the form submit wasn't
> multipart.
> Digging into the javascript in wicket-ajax.js, I found this from line 1102 in
> the method handleMultipart
> {code}
> multipart=multipart||form.enctype=="multipart/form-data";
> if (multipart==false) {
> // nothing to handle
> return false;
> }
> {code}
> When this executed, multipart was false, and enctype was "" and therefore the
> submit aborted. This may be the cause.
> Here's the Java stacktrace
> {noformat}
> java.lang.IllegalStateException: ServletRequest does not contain multipart
> content
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:113)
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:83)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.MultipartRequest.(MultipartRequest.java:41)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest.newMultipartWebRequest(UploadWebRequest.java:66)
> at
> org.apache.wicket.markup.html.form.Form.handleMultiPart(Form.java:1651)
> at
> org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:850)
> at
> org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:135)
> at
> org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:177)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:299)
> at
> org.apache.wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:119)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1250)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2623) The Wicket web site points to Wicket 1.4.1 as the latest release when it should be 1.4.4.
The Wicket web site points to Wicket 1.4.1 as the latest release when it should be 1.4.4. - Key: WICKET-2623 URL: https://issues.apache.org/jira/browse/WICKET-2623 Project: Wicket Issue Type: Bug Components: site Affects Versions: 1.4.4 Environment: Apache Wicket Web site Reporter: Dennis Meade Priority: Minor The information for obtaining Wicket on http://wicket.apache.org/getting-wicket.html and the page it links to are incorrect. It now states that 1.4.1 is the latest release when the latest is now 1.4.4. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r891482 - in /wicket/branches/wicket-1.4.5: ./ archetypes/quickstart/ archetypes/quickstart/src/main/resources/archetype-resources/ testing/wicket-threadtest/ wicket-auth-roles/ wicket-dat
Author: ivaynberg Date: Wed Dec 16 23:42:38 2009 New Revision: 891482 URL: http://svn.apache.org/viewvc?rev=891482&view=rev Log: 1.5.5 setup Modified: wicket/branches/wicket-1.4.5/CHANGELOG-1.4 wicket/branches/wicket-1.4.5/archetypes/quickstart/pom.xml wicket/branches/wicket-1.4.5/archetypes/quickstart/src/main/resources/archetype-resources/pom.xml wicket/branches/wicket-1.4.5/pom.xml wicket/branches/wicket-1.4.5/testing/wicket-threadtest/pom.xml wicket/branches/wicket-1.4.5/wicket-auth-roles/pom.xml wicket/branches/wicket-1.4.5/wicket-datetime/pom.xml wicket/branches/wicket-1.4.5/wicket-devutils/pom.xml wicket/branches/wicket-1.4.5/wicket-examples/pom.xml wicket/branches/wicket-1.4.5/wicket-extensions/pom.xml wicket/branches/wicket-1.4.5/wicket-guice/pom.xml wicket/branches/wicket-1.4.5/wicket-ioc/pom.xml wicket/branches/wicket-1.4.5/wicket-jmx/pom.xml wicket/branches/wicket-1.4.5/wicket-objectssizeof-agent/pom.xml wicket/branches/wicket-1.4.5/wicket-quickstart/pom.xml wicket/branches/wicket-1.4.5/wicket-spring/pom.xml wicket/branches/wicket-1.4.5/wicket-velocity/pom.xml wicket/branches/wicket-1.4.5/wicket/pom.xml Modified: wicket/branches/wicket-1.4.5/CHANGELOG-1.4 URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.5/CHANGELOG-1.4?rev=891482&r1=891481&r2=891482&view=diff == --- wicket/branches/wicket-1.4.5/CHANGELOG-1.4 (original) +++ wicket/branches/wicket-1.4.5/CHANGELOG-1.4 Wed Dec 16 23:42:38 2009 @@ -1,5 +1,27 @@ This file contains all changes done on the 1.4 version. +Release Notes - Wicket - Version 1.4.5 + +** Bug +* [WICKET-2598] - Some components still escape non-ASCII symbols by default +* [WICKET-2599] - Missing XML prolog in wicket-extensions panel htmls +* [WICKET-2600] - Redirect to home page still does not work (regression) +* [WICKET-2606] - Enclosure reports incorrect component id for missing components inside the enclosure +* [WICKET-2609] - EnumChoiceRenderer misbehaves with anonymous enum classes +* [WICKET-2613] - Content-Length Issue with 1.4.4 +* [WICKET-2617] - ModalWindow can't be shown when it is rendered with ajax request +* [WICKET-2621] - Ajax buttons inside ModalWindows don't submit properly + +** Improvement +* [WICKET-1888] - FormComponents (and subclasses) should be able to provide their own resource bundles +* [WICKET-2247] - IndexedHybridUrlCodingStrategy constructor should accept a redirectOnBookmarkableRequest boolan +* [WICKET-2428] - AbstractSingleSelectChoice: custom resource key for null option +* [WICKET-2592] - Add support for arbitrary PageParameters values in QueryStringUrlCodingStrategy +* [WICKET-2597] - The PagingNavigator.newNavigation method does not provide a markup id of the element to create an navigation for +* [WICKET-2602] - Display upload progress bar only when a file is selected +* [WICKET-2603] - javadoc update +* [WICKET-2604] - Add another german Wicket book + Release Notes - Wicket - Version 1.4.4 ** Bug Modified: wicket/branches/wicket-1.4.5/archetypes/quickstart/pom.xml URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.5/archetypes/quickstart/pom.xml?rev=891482&r1=891481&r2=891482&view=diff == --- wicket/branches/wicket-1.4.5/archetypes/quickstart/pom.xml (original) +++ wicket/branches/wicket-1.4.5/archetypes/quickstart/pom.xml Wed Dec 16 23:42:38 2009 @@ -3,7 +3,7 @@ org.apache.wicket wicket-parent - 1.4-SNAPSHOT + 1.4.5 ../../pom.xml Modified: wicket/branches/wicket-1.4.5/archetypes/quickstart/src/main/resources/archetype-resources/pom.xml URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.5/archetypes/quickstart/src/main/resources/archetype-resources/pom.xml?rev=891482&r1=891481&r2=891482&view=diff == --- wicket/branches/wicket-1.4.5/archetypes/quickstart/src/main/resources/archetype-resources/pom.xml (original) +++ wicket/branches/wicket-1.4.5/archetypes/quickstart/src/main/resources/archetype-resources/pom.xml Wed Dec 16 23:42:38 2009 @@ -127,7 +127,7 @@ - 1.4-SNAPSHOT + 1.4.5 6.1.4 #end Modified: wicket/branches/wicket-1.4.5/pom.xml URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.5/pom.xml?rev=891482&r1=891481&r2=891482&view=diff == --- wicket/branches/wicket-1.4.5/pom.xml (original) +++ wicket/branches/wicket-1.4.5/pom.xml Wed Dec 16 23:42:38 2009 @@ -19,7 +19,7 @@ 4.0.0 org.apache.wicket wicket-parent - 1.4-SNAPSHOT
svn commit: r891478 - /wicket/branches/wicket-1.4.5/
Author: ivaynberg Date: Wed Dec 16 23:34:31 2009 New Revision: 891478 URL: http://svn.apache.org/viewvc?rev=891478&view=rev Log: release branch Added: wicket/branches/wicket-1.4.5/ (props changed) - copied from r891477, wicket/branches/wicket-1.4.x/ Propchange: wicket/branches/wicket-1.4.5/ -- --- subclipse:tags (added) +++ subclipse:tags Wed Dec 16 23:34:31 2009 @@ -0,0 +1,5 @@ +550610,wicket-1.3.0-beta2,/wicket/tags/wicket-1.3.0-beta2,tag +567792,wicket-1.3.0-beta3,/wicket/tags/wicket-1.3.0-beta3,tag +582590,wicket-1.3.0-beta4,/wicket/tags/wicket-1.3.0-beta4,tag +591745,wicket-1.3.0-rc1,/wicket/tags/wicket-1.3.0-rc1,tag +601799,wicket-1.3.0-rc2,/wicket/tags/wicket-1.3.0-rc2,tag Propchange: wicket/branches/wicket-1.4.5/ -- --- svn:ignore (added) +++ svn:ignore Wed Dec 16 23:34:31 2009 @@ -0,0 +1,4 @@ +target +.metadata +.project +velocity.log Propchange: wicket/branches/wicket-1.4.5/ -- --- svn:mergeinfo (added) +++ svn:mergeinfo Wed Dec 16 23:34:31 2009 @@ -0,0 +1,2 @@ +/wicket/sandbox/jthomerson/experimental/wicket-devutils:760296-760351,760353-760355 +/wicket/trunk/wicket-devutils:760352
svn commit: r891477 - /wicket/branches/wicket-1.4.x/CHANGELOG-1.4
Author: ivaynberg Date: Wed Dec 16 23:33:31 2009 New Revision: 891477 URL: http://svn.apache.org/viewvc?rev=891477&view=rev Log: changelog from 1.4.4 Modified: wicket/branches/wicket-1.4.x/CHANGELOG-1.4 Modified: wicket/branches/wicket-1.4.x/CHANGELOG-1.4 URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/CHANGELOG-1.4?rev=891477&r1=891476&r2=891477&view=diff == --- wicket/branches/wicket-1.4.x/CHANGELOG-1.4 (original) +++ wicket/branches/wicket-1.4.x/CHANGELOG-1.4 Wed Dec 16 23:33:31 2009 @@ -1,5 +1,55 @@ This file contains all changes done on the 1.4 version. +Release Notes - Wicket - Version 1.4.4 + +** Bug +* [WICKET-625] - Wicket doesn't clean up properly when hot-deploying; hangs onto Class references. +* [WICKET-2080] - InjectorHolder is broken when wicket-ioc.jar is shared between multiple web applications +* [WICKET-2317] - Deprecated JavaDoc for org.apache.wicket.behavior.HeaderContributor +* [WICKET-2419] - AjaxEditableMultiLineLabel doesn't handle huge text properly +* [WICKET-2491] - Ajax multipart broken on mounted pages +* [WICKET-2518] - Application_bg.properties property file is incorrectly encoded +* [WICKET-2519] - 1.4.2 enclosure problem +* [WICKET-2534] - File Handle Leak in URLResourceStream +* [WICKET-2545] - NullPointerException thrown from BaseWicketTester isComponent +* [WICKET-2546] - DataTable does not generate "thead" tag +* [WICKET-2548] - MetaDataKey does not meet hashCode() contract +* [WICKET-2550] - DatePicker introduces a bug regarding the back button support of the browser. +* [WICKET-2551] - Bug in WicketTester when submitting forms +* [WICKET-2552] - CreditCardValidator accepts invalid inputs +* [WICKET-2553] - Wicket-ajax.js: Javascript error on submitting of form with wicketSubmitFormById. +* [WICKET-2554] - WebRequestCodingStrategy assumes that a shared resource URL should always be relative to the Wicket handler +* [WICKET-2567] - Images and stylesheets leave open file handles +* [WICKET-2568] - Unnecessary method calls in IDataProvider +* [WICKET-2570] - Form submitting component is not checked for being enabled during submit +* [WICKET-2580] - Javadoc of Component#setOutputMarkupPlaceholderTag is wrong +* [WICKET-2582] - org.apache.wicket.markup.html.form.Check should call Component.isEnabledInHierarchy() +* [WICKET-2583] - Warnings flood if incorrect credentials endered on SignInPage +* [WICKET-2587] - UploadProgressBar producing warning log messages incorrectly +* [WICKET-2589] - FeedbackPanel in FormComponentFeedbackBorder throws ConcurrentModificationException +* [WICKET-2593] - wicket:message can cause infinite loop in render +* [WICKET-2595] - Ajax multipart fails for inner forms added via ajax + +** Improvement +* [WICKET-12] - open Modal Window without AjaxRequestTarget +* [WICKET-2326] - Text on BrowserInfoPage should be customizable +* [WICKET-2364] - CLONE -Make LoadableDetachableModel writable +* [WICKET-2531] - Open DropDownChoice null value internationalization key +* [WICKET-2533] - Behavior for accepted locales should fit the HTTP Specification +* [WICKET-2536] - Guice 2.0 and its maven2 repository groupId +* [WICKET-2539] - PackageStringResourceLoader does not look up to superclasses +* [WICKET-2540] - Date Validation - message formatting of the date +* [WICKET-2564] - Modify wicket-devutils DebugBar so it emits valid XHTML +* [WICKET-2573] - Allow applications to chose not to use CGLIB proxies for @SpringBean injections +* [WICKET-2575] - RepeatingView's Javadoc to include newChildId() and add() +* [WICKET-2578] - Polish resource files for wicket 1.4.3 +* [WICKET-2581] - French translation of Wicket-auth resources +* [WICKET-2590] - AjaxLazyLoadPanel callback script rendering + +** New Feature +* [WICKET-1157] - Generic internationalization for Enums +* [WICKET-2572] - Add capability for SpringWebApplicationFactory to create its own application context + Release Notes - Wicket - Version 1.4.3 ** Bug
[jira] Updated: (WICKET-2617) ModalWindow can't be shown when it is rendered with ajax request
[
https://issues.apache.org/jira/browse/WICKET-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg updated WICKET-2617:
--
Fix Version/s: (was: 1.4.6)
1.4.5
> ModalWindow can't be shown when it is rendered with ajax request
>
>
> Key: WICKET-2617
> URL: https://issues.apache.org/jira/browse/WICKET-2617
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.4
>Reporter: Michael Mikhulya
>Assignee: Igor Vaynberg
> Fix For: 1.4.5
>
>
> Regression appeared with 1.4.4 release, in previous releases all worked fine.
> I load page in two requests. First one loads very small html, which then
> loads remaining part with ajax request.
> (I do so to pass parameters after '#' to server in similar way as it is done
> in gmail, but there are other reasons to render ModalWindow with ajax
> request).
> ModalWindow is rendered (but not shown) with second (ajax) request.
> The private variable "shown" is set to true:
> protected void onBeforeRender()
> {
> shown = makeContentVisible();
> Because of following implementation of makeContentVisible method:
> protected boolean makeContentVisible()
> {
> // if user is refreshing whole page, the window will not be
> shown
> return getWebRequest().isAjax();
> }
> But when I call "show" method nothing happens:
> public void show(final AjaxRequestTarget target)
> {
> if (shown == false)
> {
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> shown = true;
> }
> }
> Actually there are two problems:
> 1) behavior has changed
> 2) I didn't find safe workaround for this problem.
> Unsafe workaround as follows, notice, it can break with next wicket release
> since base "show" method is not called in sub class:
> class MyModalWindow extends ModalWindow {
> protected boolean visible = false;
> @Override
> protected boolean makeContentVisible() {
> return visible;
> }
> @Override
> public void show(org.apache.wicket.ajax.AjaxRequestTarget target) {
> visible = true;
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> };
> @Override
> public void close(AjaxRequestTarget target) {
> visible = false;
> super.close(target);
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2617) ModalWindow can't be shown when it is rendered with ajax request
[
https://issues.apache.org/jira/browse/WICKET-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-2617.
---
Resolution: Fixed
Fix Version/s: 1.4.6
found the regression, should be fixed
> ModalWindow can't be shown when it is rendered with ajax request
>
>
> Key: WICKET-2617
> URL: https://issues.apache.org/jira/browse/WICKET-2617
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.4
>Reporter: Michael Mikhulya
>Assignee: Igor Vaynberg
> Fix For: 1.4.6
>
>
> Regression appeared with 1.4.4 release, in previous releases all worked fine.
> I load page in two requests. First one loads very small html, which then
> loads remaining part with ajax request.
> (I do so to pass parameters after '#' to server in similar way as it is done
> in gmail, but there are other reasons to render ModalWindow with ajax
> request).
> ModalWindow is rendered (but not shown) with second (ajax) request.
> The private variable "shown" is set to true:
> protected void onBeforeRender()
> {
> shown = makeContentVisible();
> Because of following implementation of makeContentVisible method:
> protected boolean makeContentVisible()
> {
> // if user is refreshing whole page, the window will not be
> shown
> return getWebRequest().isAjax();
> }
> But when I call "show" method nothing happens:
> public void show(final AjaxRequestTarget target)
> {
> if (shown == false)
> {
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> shown = true;
> }
> }
> Actually there are two problems:
> 1) behavior has changed
> 2) I didn't find safe workaround for this problem.
> Unsafe workaround as follows, notice, it can break with next wicket release
> since base "show" method is not called in sub class:
> class MyModalWindow extends ModalWindow {
> protected boolean visible = false;
> @Override
> protected boolean makeContentVisible() {
> return visible;
> }
> @Override
> public void show(org.apache.wicket.ajax.AjaxRequestTarget target) {
> visible = true;
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> };
> @Override
> public void close(AjaxRequestTarget target) {
> visible = false;
> super.close(target);
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2610) OddEvenListItem should append css attribute instead of replacing/adding it
[ https://issues.apache.org/jira/browse/WICKET-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg updated WICKET-2610: -- Fix Version/s: (was: 1.4.5) 1.4.6 > OddEvenListItem should append css attribute instead of replacing/adding it > -- > > Key: WICKET-2610 > URL: https://issues.apache.org/jira/browse/WICKET-2610 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4.4 >Reporter: Martin Simons >Priority: Minor > Fix For: 1.4.6 > > > Title says it all: Right now OddEvenListItem simply adds the class attribute > without checking whether another one already exists, essentially overwriting > any style definition the designer might have added. Instead, the odd/even > classes should be appended as in AttributeAppender behavior. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r891470 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket: markup/html/form/Form.java markup/html/form/upload/MultiFileUploadField.java protocol/http/servlet/MultipartServletWebReq
Author: ivaynberg
Date: Wed Dec 16 23:24:16 2009
New Revision: 891470
URL: http://svn.apache.org/viewvc?rev=891470&view=rev
Log:
WICKET-2621
Issue: WICKET-2621
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequest.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/FormTester.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java?rev=891470&r1=891469&r2=891470&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
Wed Dec 16 23:24:16 2009
@@ -376,7 +376,10 @@
private Bytes maxSize = null;
/** True if the form has enctype of multipart/form-data */
- private boolean multiPart = false;
+ private short multiPart = 0;
+
+ private static short MULTIPART_HARD = 0x01;
+ private static short MULTIPART_HINT = 0x02;
/**
* Constructs a form with no validation.
@@ -1051,7 +1054,14 @@
*/
public void setMultiPart(boolean multiPart)
{
- this.multiPart = multiPart;
+ if (multiPart)
+ {
+ this.multiPart |= MULTIPART_HARD;
+ }
+ else
+ {
+ this.multiPart &= ~MULTIPART_HARD;
+ }
}
/**
@@ -1399,7 +1409,7 @@
private boolean isMultiPart()
{
- if (multiPart)
+ if (multiPart != 0)
{
return true;
}
@@ -1411,7 +1421,7 @@
public Object component(Form form)
{
- if (form.multiPart)
+ if (form.multiPart != 0)
{
anyEmbeddedMultipart[0] = true;
return STOP_TRAVERSAL;
@@ -1788,6 +1798,9 @@
@Override
protected void onRender()
{
+ // clear multipart hint, it will be set if necessary by the
visitor
+ this.multiPart &= ~MULTIPART_HINT;
+
// Force multi-part on if any child form component is multi-part
visitFormComponents(new FormComponent.AbstractVisitor()
{
@@ -1796,7 +1809,7 @@
{
if (formComponent.isVisible() &&
formComponent.isMultiPart())
{
- setMultiPart(true);
+ multiPart |= MULTIPART_HINT;
}
}
});
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java?rev=891470&r1=891469&r2=891470&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java
Wed Dec 16 23:24:16 2009
@@ -193,9 +193,13 @@
throw new IllegalStateException("Component " +
getClass().getName() + " must have a " +
Form.class.getName() + " component above in the
hierarchy");
}
- form.setMultiPart(true);
}
+ @Override
+ public boolean isMultiPart()
+ {
+ return true;
+ }
/**
* @see
org.apache.wicket.markup.html.IHeaderContributor#renderHead(org.apache.wicket.markup.html.IHeaderResponse)
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequest.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequest.java?rev=891470&r1=891469&r2=891470&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequest.java
(original)
+++
wicket/trunk/wicket/s
svn commit: r891469 - in /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket: markup/html/form/Form.java markup/html/form/upload/MultiFileUploadField.java protocol/http/servlet/Multip
Author: ivaynberg
Date: Wed Dec 16 23:21:47 2009
New Revision: 891469
URL: http://svn.apache.org/viewvc?rev=891469&view=rev
Log:
WICKET-2621
Issue: WICKET-2621
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequest.java
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/util/tester/FormTester.java
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java?rev=891469&r1=891468&r2=891469&view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
Wed Dec 16 23:21:47 2009
@@ -385,7 +385,10 @@
private Bytes maxSize = null;
/** True if the form has enctype of multipart/form-data */
- private boolean multiPart = false;
+ private short multiPart = 0;
+
+ private static short MULTIPART_HARD = 0x01;
+ private static short MULTIPART_HINT = 0x02;
/**
* Constructs a form with no validation.
@@ -1135,7 +1138,14 @@
*/
public void setMultiPart(boolean multiPart)
{
- this.multiPart = multiPart;
+ if (multiPart)
+ {
+ this.multiPart |= MULTIPART_HARD;
+ }
+ else
+ {
+ this.multiPart &= ~MULTIPART_HARD;
+ }
}
/**
@@ -1603,7 +1613,7 @@
private boolean isMultiPart()
{
- if (multiPart)
+ if (multiPart != 0)
{
return true;
}
@@ -1615,7 +1625,7 @@
public Object component(Form form)
{
- if (form.multiPart)
+ if (form.multiPart != 0)
{
anyEmbeddedMultipart[0] = true;
return STOP_TRAVERSAL;
@@ -1991,6 +2001,9 @@
@Override
protected void onRender(final MarkupStream markupStream)
{
+ // clear multipart hint, it will be set if necessary by the
visitor
+ this.multiPart &= ~MULTIPART_HINT;
+
// Force multi-part on if any child form component is multi-part
visitFormComponents(new FormComponent.AbstractVisitor()
{
@@ -1999,7 +2012,7 @@
{
if (formComponent.isVisible() &&
formComponent.isMultiPart())
{
- setMultiPart(true);
+ multiPart |= MULTIPART_HINT;
}
}
});
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java?rev=891469&r1=891468&r2=891469&view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java
Wed Dec 16 23:21:47 2009
@@ -193,9 +193,13 @@
throw new IllegalStateException("Component " +
getClass().getName() + " must have a " +
Form.class.getName() + " component above in the
hierarchy");
}
- form.setMultiPart(true);
}
+ @Override
+ public boolean isMultiPart()
+ {
+ return true;
+ }
/**
* @see
org.apache.wicket.markup.html.IHeaderContributor#renderHead(org.apache.wicket.markup.html.IHeaderResponse)
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequest.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequest.java?rev=891469&r1=
[jira] Resolved: (WICKET-2621) Ajax buttons inside ModalWindows don't submit properly
[
https://issues.apache.org/jira/browse/WICKET-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-2621.
---
Resolution: Fixed
Fix Version/s: 1.5-M1
1.4.5
> Ajax buttons inside ModalWindows don't submit properly
> --
>
> Key: WICKET-2621
> URL: https://issues.apache.org/jira/browse/WICKET-2621
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 1.4.4
>Reporter: Alex Grant
>Assignee: Igor Vaynberg
> Fix For: 1.4.5, 1.5-M1
>
> Attachments: wicket-2621-sample-app.zip
>
>
> I have a ModalWindow that contains an IndicatingAjaxButton. When I click the
> button, I get a big Java error complaining that the form submit wasn't
> multipart.
> Digging into the javascript in wicket-ajax.js, I found this from line 1102 in
> the method handleMultipart
> {code}
> multipart=multipart||form.enctype=="multipart/form-data";
> if (multipart==false) {
> // nothing to handle
> return false;
> }
> {code}
> When this executed, multipart was false, and enctype was "" and therefore the
> submit aborted. This may be the cause.
> Here's the Java stacktrace
> {noformat}
> java.lang.IllegalStateException: ServletRequest does not contain multipart
> content
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:113)
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:83)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.MultipartRequest.(MultipartRequest.java:41)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest.newMultipartWebRequest(UploadWebRequest.java:66)
> at
> org.apache.wicket.markup.html.form.Form.handleMultiPart(Form.java:1651)
> at
> org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:850)
> at
> org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:135)
> at
> org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:177)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:299)
> at
> org.apache.wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:119)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1250)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2602) Display upload progress bar only when a file is selected
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2602. --- Resolution: Fixed > Display upload progress bar only when a file is selected > > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten >Assignee: Igor Vaynberg > Fix For: 1.4.5, 1.5-M1 > > Attachments: Serialization_optimization_.patch, > WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch > > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r891448 - /wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
Author: ivaynberg
Date: Wed Dec 16 22:03:57 2009
New Revision: 891448
URL: http://svn.apache.org/viewvc?rev=891448&view=rev
Log:
WICKET-2602 Display upload progress bar only when a file is selected
Issue: WICKET-2602
Modified:
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
Modified:
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java?rev=891448&r1=891447&r2=891448&view=diff
==
---
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
Wed Dec 16 22:03:57 2009
@@ -102,7 +102,7 @@
*the file upload field to check for a file upload, or null
to display the upload
*field for every submit of the given form
*/
- public UploadProgressBar(String id, final Form form, final
FileUploadField fileUploadField)
+ public UploadProgressBar(String id, final Form form, FileUploadField
fileUploadField)
{
super(id);
setOutputMarkupId(true);
@@ -130,6 +130,9 @@
log.warn("UploadProgressBar will not work without an
UploadWebRequest. See the javadoc for details.");
}
+ final String fileUploadFieldMarkupId = fileUploadField == null
? ""
+ : fileUploadField.getMarkupId();
+
form.add(new AttributeModifier("onsubmit", true, new
Model()
{
@@ -141,8 +144,6 @@
{
ResourceReference ref = new
ResourceReference(RESOURCE_NAME);
- String fileUploadFieldMarkupId =
fileUploadField == null ? ""
- : fileUploadField.getMarkupId();
return "var def=new Wicket.WUPB.Def('" +
form.getMarkupId() + "', '" +
statusDiv.getMarkupId() + "', '" +
barDiv.getMarkupId() + "', '" +
getPage().urlFor(ref) + "','" +
fileUploadFieldMarkupId +
svn commit: r891447 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
Author: ivaynberg
Date: Wed Dec 16 22:03:46 2009
New Revision: 891447
URL: http://svn.apache.org/viewvc?rev=891447&view=rev
Log:
WICKET-2602 Display upload progress bar only when a file is selected
Issue: WICKET-2602
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java?rev=891447&r1=891446&r2=891447&view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
Wed Dec 16 22:03:46 2009
@@ -102,7 +102,7 @@
*the file upload field to check for a file upload, or null
to display the upload
*field for every submit of the given form
*/
- public UploadProgressBar(String id, final Form form, final
FileUploadField fileUploadField)
+ public UploadProgressBar(String id, final Form form, FileUploadField
fileUploadField)
{
super(id);
setOutputMarkupId(true);
@@ -134,6 +134,9 @@
log.warn("UploadProgressBar will not work without an
UploadWebRequest. See the javadoc for details.");
}
+ final String fileUploadFieldMarkupId = fileUploadField == null
? ""
+ : fileUploadField.getMarkupId();
+
form.add(new AttributeModifier("onsubmit", true, new
Model()
{
@@ -145,8 +148,6 @@
{
ResourceReference ref = new
ResourceReference(RESOURCE_NAME);
- String fileUploadFieldMarkupId =
fileUploadField == null ? ""
- : fileUploadField.getMarkupId();
return "var def=new Wicket.WUPB.Def('" +
form.getMarkupId() + "', '" +
statusDiv.getMarkupId() + "', '" +
barDiv.getMarkupId() + "', '" +
getPage().urlFor(ref) + "','" +
fileUploadFieldMarkupId +
[jira] Commented: (WICKET-2621) Ajax buttons inside ModalWindows don't submit properly
[
https://issues.apache.org/jira/browse/WICKET-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791613#action_12791613
]
Alex Grant commented on WICKET-2621:
Thanks for reopening it. Sorry about the delay, I'm in a different time zone so
only recently got your request for a testcase, and it took me a while to
isolate the problem.
> Ajax buttons inside ModalWindows don't submit properly
> --
>
> Key: WICKET-2621
> URL: https://issues.apache.org/jira/browse/WICKET-2621
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 1.4.4
>Reporter: Alex Grant
>Assignee: Igor Vaynberg
> Attachments: wicket-2621-sample-app.zip
>
>
> I have a ModalWindow that contains an IndicatingAjaxButton. When I click the
> button, I get a big Java error complaining that the form submit wasn't
> multipart.
> Digging into the javascript in wicket-ajax.js, I found this from line 1102 in
> the method handleMultipart
> {code}
> multipart=multipart||form.enctype=="multipart/form-data";
> if (multipart==false) {
> // nothing to handle
> return false;
> }
> {code}
> When this executed, multipart was false, and enctype was "" and therefore the
> submit aborted. This may be the cause.
> Here's the Java stacktrace
> {noformat}
> java.lang.IllegalStateException: ServletRequest does not contain multipart
> content
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:113)
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:83)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.MultipartRequest.(MultipartRequest.java:41)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest.newMultipartWebRequest(UploadWebRequest.java:66)
> at
> org.apache.wicket.markup.html.form.Form.handleMultiPart(Form.java:1651)
> at
> org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:850)
> at
> org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:135)
> at
> org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:177)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:299)
> at
> org.apache.wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:119)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1250)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r891446 - /wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
Author: ivaynberg
Date: Wed Dec 16 21:58:41 2009
New Revision: 891446
URL: http://svn.apache.org/viewvc?rev=891446&view=rev
Log:
WICKET-2617 ModalWindow can't be shown when it is rendered with ajax request
Issue: WICKET-2617
Modified:
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
Modified:
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java?rev=891446&r1=891445&r2=891446&view=diff
==
---
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
Wed Dec 16 21:58:41 2009
@@ -828,7 +828,14 @@
protected boolean makeContentVisible()
{
// if user is refreshing whole page, the window will not be
shown
- return getWebRequest().isAjax();
+ if (getWebRequest().isAjax() == false)
+ {
+ return false;
+ }
+ else
+ {
+ return shown;
+ }
}
/**
svn commit: r891445 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
Author: ivaynberg
Date: Wed Dec 16 21:58:24 2009
New Revision: 891445
URL: http://svn.apache.org/viewvc?rev=891445&view=rev
Log:
WICKET-2617 ModalWindow can't be shown when it is rendered with ajax request
Issue: WICKET-2617
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java?rev=891445&r1=891444&r2=891445&view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
Wed Dec 16 21:58:24 2009
@@ -771,7 +771,14 @@
protected boolean makeContentVisible()
{
// if user is refreshing whole page, the window will not be
shown
- return getWebRequest().isAjax();
+ if (getWebRequest().isAjax() == false)
+ {
+ return false;
+ }
+ else
+ {
+ return shown;
+ }
}
/**
[jira] Assigned: (WICKET-2617) ModalWindow can't be shown when it is rendered with ajax request
[
https://issues.apache.org/jira/browse/WICKET-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg reassigned WICKET-2617:
-
Assignee: Igor Vaynberg
> ModalWindow can't be shown when it is rendered with ajax request
>
>
> Key: WICKET-2617
> URL: https://issues.apache.org/jira/browse/WICKET-2617
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.4
>Reporter: Michael Mikhulya
>Assignee: Igor Vaynberg
>
> Regression appeared with 1.4.4 release, in previous releases all worked fine.
> I load page in two requests. First one loads very small html, which then
> loads remaining part with ajax request.
> (I do so to pass parameters after '#' to server in similar way as it is done
> in gmail, but there are other reasons to render ModalWindow with ajax
> request).
> ModalWindow is rendered (but not shown) with second (ajax) request.
> The private variable "shown" is set to true:
> protected void onBeforeRender()
> {
> shown = makeContentVisible();
> Because of following implementation of makeContentVisible method:
> protected boolean makeContentVisible()
> {
> // if user is refreshing whole page, the window will not be
> shown
> return getWebRequest().isAjax();
> }
> But when I call "show" method nothing happens:
> public void show(final AjaxRequestTarget target)
> {
> if (shown == false)
> {
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> shown = true;
> }
> }
> Actually there are two problems:
> 1) behavior has changed
> 2) I didn't find safe workaround for this problem.
> Unsafe workaround as follows, notice, it can break with next wicket release
> since base "show" method is not called in sub class:
> class MyModalWindow extends ModalWindow {
> protected boolean visible = false;
> @Override
> protected boolean makeContentVisible() {
> return visible;
> }
> @Override
> public void show(org.apache.wicket.ajax.AjaxRequestTarget target) {
> visible = true;
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> };
> @Override
> public void close(AjaxRequestTarget target) {
> visible = false;
> super.close(target);
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-2621) Ajax buttons inside ModalWindows don't submit properly
[
https://issues.apache.org/jira/browse/WICKET-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg reopened WICKET-2621:
---
now we have a testcase
> Ajax buttons inside ModalWindows don't submit properly
> --
>
> Key: WICKET-2621
> URL: https://issues.apache.org/jira/browse/WICKET-2621
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 1.4.4
>Reporter: Alex Grant
>Assignee: Igor Vaynberg
> Attachments: wicket-2621-sample-app.zip
>
>
> I have a ModalWindow that contains an IndicatingAjaxButton. When I click the
> button, I get a big Java error complaining that the form submit wasn't
> multipart.
> Digging into the javascript in wicket-ajax.js, I found this from line 1102 in
> the method handleMultipart
> {code}
> multipart=multipart||form.enctype=="multipart/form-data";
> if (multipart==false) {
> // nothing to handle
> return false;
> }
> {code}
> When this executed, multipart was false, and enctype was "" and therefore the
> submit aborted. This may be the cause.
> Here's the Java stacktrace
> {noformat}
> java.lang.IllegalStateException: ServletRequest does not contain multipart
> content
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:113)
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:83)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.MultipartRequest.(MultipartRequest.java:41)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest.newMultipartWebRequest(UploadWebRequest.java:66)
> at
> org.apache.wicket.markup.html.form.Form.handleMultiPart(Form.java:1651)
> at
> org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:850)
> at
> org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:135)
> at
> org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:177)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:299)
> at
> org.apache.wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:119)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1250)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2621) Ajax buttons inside ModalWindows don't submit properly
[
https://issues.apache.org/jira/browse/WICKET-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791609#action_12791609
]
Alex Grant commented on WICKET-2621:
Form.setMultipart(true) does not fix the problem - The Java Form is already in
multipart mode (as the one Form is shared by the wizard across all steps and
the first step had a upload component). The problem is the ajax submit is not
multipart (presumably because there are no upload components on the page).
> Ajax buttons inside ModalWindows don't submit properly
> --
>
> Key: WICKET-2621
> URL: https://issues.apache.org/jira/browse/WICKET-2621
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 1.4.4
>Reporter: Alex Grant
>Assignee: Igor Vaynberg
> Attachments: wicket-2621-sample-app.zip
>
>
> I have a ModalWindow that contains an IndicatingAjaxButton. When I click the
> button, I get a big Java error complaining that the form submit wasn't
> multipart.
> Digging into the javascript in wicket-ajax.js, I found this from line 1102 in
> the method handleMultipart
> {code}
> multipart=multipart||form.enctype=="multipart/form-data";
> if (multipart==false) {
> // nothing to handle
> return false;
> }
> {code}
> When this executed, multipart was false, and enctype was "" and therefore the
> submit aborted. This may be the cause.
> Here's the Java stacktrace
> {noformat}
> java.lang.IllegalStateException: ServletRequest does not contain multipart
> content
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:113)
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:83)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.MultipartRequest.(MultipartRequest.java:41)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest.newMultipartWebRequest(UploadWebRequest.java:66)
> at
> org.apache.wicket.markup.html.form.Form.handleMultiPart(Form.java:1651)
> at
> org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:850)
> at
> org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:135)
> at
> org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:177)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:299)
> at
> org.apache.wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:119)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1250)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2621) Ajax buttons inside ModalWindows don't submit properly
[
https://issues.apache.org/jira/browse/WICKET-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Grant updated WICKET-2621:
---
Attachment: wicket-2621-sample-app.zip
> Ajax buttons inside ModalWindows don't submit properly
> --
>
> Key: WICKET-2621
> URL: https://issues.apache.org/jira/browse/WICKET-2621
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 1.4.4
>Reporter: Alex Grant
>Assignee: Igor Vaynberg
> Attachments: wicket-2621-sample-app.zip
>
>
> I have a ModalWindow that contains an IndicatingAjaxButton. When I click the
> button, I get a big Java error complaining that the form submit wasn't
> multipart.
> Digging into the javascript in wicket-ajax.js, I found this from line 1102 in
> the method handleMultipart
> {code}
> multipart=multipart||form.enctype=="multipart/form-data";
> if (multipart==false) {
> // nothing to handle
> return false;
> }
> {code}
> When this executed, multipart was false, and enctype was "" and therefore the
> submit aborted. This may be the cause.
> Here's the Java stacktrace
> {noformat}
> java.lang.IllegalStateException: ServletRequest does not contain multipart
> content
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:113)
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:83)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.MultipartRequest.(MultipartRequest.java:41)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest.newMultipartWebRequest(UploadWebRequest.java:66)
> at
> org.apache.wicket.markup.html.form.Form.handleMultiPart(Form.java:1651)
> at
> org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:850)
> at
> org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:135)
> at
> org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:177)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:299)
> at
> org.apache.wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:119)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1250)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2621) Ajax buttons inside ModalWindows don't submit properly
[
https://issues.apache.org/jira/browse/WICKET-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791607#action_12791607
]
Alex Grant commented on WICKET-2621:
Thanks. I have attached a zipped standalone Eclipse project.
Visit the URL
http://localhost:8080/wicket-modal-dialog/app/home
Click Next, click to open the popup, then click OK on the popup.
> Ajax buttons inside ModalWindows don't submit properly
> --
>
> Key: WICKET-2621
> URL: https://issues.apache.org/jira/browse/WICKET-2621
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 1.4.4
>Reporter: Alex Grant
>Assignee: Igor Vaynberg
> Attachments: wicket-2621-sample-app.zip
>
>
> I have a ModalWindow that contains an IndicatingAjaxButton. When I click the
> button, I get a big Java error complaining that the form submit wasn't
> multipart.
> Digging into the javascript in wicket-ajax.js, I found this from line 1102 in
> the method handleMultipart
> {code}
> multipart=multipart||form.enctype=="multipart/form-data";
> if (multipart==false) {
> // nothing to handle
> return false;
> }
> {code}
> When this executed, multipart was false, and enctype was "" and therefore the
> submit aborted. This may be the cause.
> Here's the Java stacktrace
> {noformat}
> java.lang.IllegalStateException: ServletRequest does not contain multipart
> content
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:113)
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:83)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.MultipartRequest.(MultipartRequest.java:41)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest.newMultipartWebRequest(UploadWebRequest.java:66)
> at
> org.apache.wicket.markup.html.form.Form.handleMultiPart(Form.java:1651)
> at
> org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:850)
> at
> org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:135)
> at
> org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:177)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:299)
> at
> org.apache.wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:119)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1250)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2621) Ajax buttons inside ModalWindows don't submit properly
[
https://issues.apache.org/jira/browse/WICKET-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791604#action_12791604
]
Igor Vaynberg commented on WICKET-2621:
---
attach your quickstart and i will take a look
> Ajax buttons inside ModalWindows don't submit properly
> --
>
> Key: WICKET-2621
> URL: https://issues.apache.org/jira/browse/WICKET-2621
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 1.4.4
>Reporter: Alex Grant
>Assignee: Igor Vaynberg
>
> I have a ModalWindow that contains an IndicatingAjaxButton. When I click the
> button, I get a big Java error complaining that the form submit wasn't
> multipart.
> Digging into the javascript in wicket-ajax.js, I found this from line 1102 in
> the method handleMultipart
> {code}
> multipart=multipart||form.enctype=="multipart/form-data";
> if (multipart==false) {
> // nothing to handle
> return false;
> }
> {code}
> When this executed, multipart was false, and enctype was "" and therefore the
> submit aborted. This may be the cause.
> Here's the Java stacktrace
> {noformat}
> java.lang.IllegalStateException: ServletRequest does not contain multipart
> content
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:113)
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:83)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.MultipartRequest.(MultipartRequest.java:41)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest.newMultipartWebRequest(UploadWebRequest.java:66)
> at
> org.apache.wicket.markup.html.form.Form.handleMultiPart(Form.java:1651)
> at
> org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:850)
> at
> org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:135)
> at
> org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:177)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:299)
> at
> org.apache.wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:119)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1250)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2617) ModalWindow can't be shown when it is rendered with ajax request
[
https://issues.apache.org/jira/browse/WICKET-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791601#action_12791601
]
Igor Vaynberg commented on WICKET-2617:
---
or provide a quickstart so we can reproduce this.
> ModalWindow can't be shown when it is rendered with ajax request
>
>
> Key: WICKET-2617
> URL: https://issues.apache.org/jira/browse/WICKET-2617
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.4
>Reporter: Michael Mikhulya
>
> Regression appeared with 1.4.4 release, in previous releases all worked fine.
> I load page in two requests. First one loads very small html, which then
> loads remaining part with ajax request.
> (I do so to pass parameters after '#' to server in similar way as it is done
> in gmail, but there are other reasons to render ModalWindow with ajax
> request).
> ModalWindow is rendered (but not shown) with second (ajax) request.
> The private variable "shown" is set to true:
> protected void onBeforeRender()
> {
> shown = makeContentVisible();
> Because of following implementation of makeContentVisible method:
> protected boolean makeContentVisible()
> {
> // if user is refreshing whole page, the window will not be
> shown
> return getWebRequest().isAjax();
> }
> But when I call "show" method nothing happens:
> public void show(final AjaxRequestTarget target)
> {
> if (shown == false)
> {
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> shown = true;
> }
> }
> Actually there are two problems:
> 1) behavior has changed
> 2) I didn't find safe workaround for this problem.
> Unsafe workaround as follows, notice, it can break with next wicket release
> since base "show" method is not called in sub class:
> class MyModalWindow extends ModalWindow {
> protected boolean visible = false;
> @Override
> protected boolean makeContentVisible() {
> return visible;
> }
> @Override
> public void show(org.apache.wicket.ajax.AjaxRequestTarget target) {
> visible = true;
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> };
> @Override
> public void close(AjaxRequestTarget target) {
> visible = false;
> super.close(target);
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2621) Ajax buttons inside ModalWindows don't submit properly
[
https://issues.apache.org/jira/browse/WICKET-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791602#action_12791602
]
Alex Grant commented on WICKET-2621:
I've just finished creating a test case to reproduce this one.
The problem is, it's *not* a multipart form.
I'm using a wizard. On the first step of the wizard, there is a file upload
component, (and that works correctly). But on the second step, there is no
upload component, but the ajax popup fails, because the java Form object still
thinks it *is* multipart.
> Ajax buttons inside ModalWindows don't submit properly
> --
>
> Key: WICKET-2621
> URL: https://issues.apache.org/jira/browse/WICKET-2621
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 1.4.4
>Reporter: Alex Grant
>Assignee: Igor Vaynberg
>
> I have a ModalWindow that contains an IndicatingAjaxButton. When I click the
> button, I get a big Java error complaining that the form submit wasn't
> multipart.
> Digging into the javascript in wicket-ajax.js, I found this from line 1102 in
> the method handleMultipart
> {code}
> multipart=multipart||form.enctype=="multipart/form-data";
> if (multipart==false) {
> // nothing to handle
> return false;
> }
> {code}
> When this executed, multipart was false, and enctype was "" and therefore the
> submit aborted. This may be the cause.
> Here's the Java stacktrace
> {noformat}
> java.lang.IllegalStateException: ServletRequest does not contain multipart
> content
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:113)
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:83)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.MultipartRequest.(MultipartRequest.java:41)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest.newMultipartWebRequest(UploadWebRequest.java:66)
> at
> org.apache.wicket.markup.html.form.Form.handleMultiPart(Form.java:1651)
> at
> org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:850)
> at
> org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:135)
> at
> org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:177)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:299)
> at
> org.apache.wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:119)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1250)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-2621) Ajax buttons inside ModalWindows don't submit properly
[
https://issues.apache.org/jira/browse/WICKET-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg closed WICKET-2621.
-
Resolution: Won't Fix
Assignee: Igor Vaynberg
due to a lot of other fixes we have done for ajax-related file uploads you will
have to call form.setmultipart(true) yourself. wicket tries its best to detect
multipart forms, but its always a good idea to call it explicitly because with
ajax there are cases where wicket cannot detect multipart forms early enough.
> Ajax buttons inside ModalWindows don't submit properly
> --
>
> Key: WICKET-2621
> URL: https://issues.apache.org/jira/browse/WICKET-2621
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 1.4.4
>Reporter: Alex Grant
>Assignee: Igor Vaynberg
>
> I have a ModalWindow that contains an IndicatingAjaxButton. When I click the
> button, I get a big Java error complaining that the form submit wasn't
> multipart.
> Digging into the javascript in wicket-ajax.js, I found this from line 1102 in
> the method handleMultipart
> {code}
> multipart=multipart||form.enctype=="multipart/form-data";
> if (multipart==false) {
> // nothing to handle
> return false;
> }
> {code}
> When this executed, multipart was false, and enctype was "" and therefore the
> submit aborted. This may be the cause.
> Here's the Java stacktrace
> {noformat}
> java.lang.IllegalStateException: ServletRequest does not contain multipart
> content
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:113)
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:83)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.MultipartRequest.(MultipartRequest.java:41)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest.newMultipartWebRequest(UploadWebRequest.java:66)
> at
> org.apache.wicket.markup.html.form.Form.handleMultiPart(Form.java:1651)
> at
> org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:850)
> at
> org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:135)
> at
> org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:177)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:299)
> at
> org.apache.wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:119)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1250)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2617) ModalWindow can't be shown when it is rendered with ajax request
[
https://issues.apache.org/jira/browse/WICKET-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791423#action_12791423
]
Igor Vaynberg commented on WICKET-2617:
---
try with latest snapshot, may be related to WICKET-2613
> ModalWindow can't be shown when it is rendered with ajax request
>
>
> Key: WICKET-2617
> URL: https://issues.apache.org/jira/browse/WICKET-2617
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.4
>Reporter: Michael Mikhulya
>
> Regression appeared with 1.4.4 release, in previous releases all worked fine.
> I load page in two requests. First one loads very small html, which then
> loads remaining part with ajax request.
> (I do so to pass parameters after '#' to server in similar way as it is done
> in gmail, but there are other reasons to render ModalWindow with ajax
> request).
> ModalWindow is rendered (but not shown) with second (ajax) request.
> The private variable "shown" is set to true:
> protected void onBeforeRender()
> {
> shown = makeContentVisible();
> Because of following implementation of makeContentVisible method:
> protected boolean makeContentVisible()
> {
> // if user is refreshing whole page, the window will not be
> shown
> return getWebRequest().isAjax();
> }
> But when I call "show" method nothing happens:
> public void show(final AjaxRequestTarget target)
> {
> if (shown == false)
> {
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> shown = true;
> }
> }
> Actually there are two problems:
> 1) behavior has changed
> 2) I didn't find safe workaround for this problem.
> Unsafe workaround as follows, notice, it can break with next wicket release
> since base "show" method is not called in sub class:
> class MyModalWindow extends ModalWindow {
> protected boolean visible = false;
> @Override
> protected boolean makeContentVisible() {
> return visible;
> }
> @Override
> public void show(org.apache.wicket.ajax.AjaxRequestTarget target) {
> visible = true;
> getContent().setVisible(true);
> target.addComponent(this);
> target.appendJavascript(getWindowOpenJavascript());
> };
> @Override
> public void close(AjaxRequestTarget target) {
> visible = false;
> super.close(target);
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2621) Ajax buttons inside ModalWindows don't submit properly
[
https://issues.apache.org/jira/browse/WICKET-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791421#action_12791421
]
Igor Vaynberg commented on WICKET-2621:
---
got a quickstart?
> Ajax buttons inside ModalWindows don't submit properly
> --
>
> Key: WICKET-2621
> URL: https://issues.apache.org/jira/browse/WICKET-2621
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 1.4.4
>Reporter: Alex Grant
>
> I have a ModalWindow that contains an IndicatingAjaxButton. When I click the
> button, I get a big Java error complaining that the form submit wasn't
> multipart.
> Digging into the javascript in wicket-ajax.js, I found this from line 1102 in
> the method handleMultipart
> {code}
> multipart=multipart||form.enctype=="multipart/form-data";
> if (multipart==false) {
> // nothing to handle
> return false;
> }
> {code}
> When this executed, multipart was false, and enctype was "" and therefore the
> submit aborted. This may be the cause.
> Here's the Java stacktrace
> {noformat}
> java.lang.IllegalStateException: ServletRequest does not contain multipart
> content
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:113)
> at
> org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest.(MultipartServletWebRequest.java:83)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.MultipartRequest.(MultipartRequest.java:41)
> at
> org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest.newMultipartWebRequest(UploadWebRequest.java:66)
> at
> org.apache.wicket.markup.html.form.Form.handleMultiPart(Form.java:1651)
> at
> org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:850)
> at
> org.apache.wicket.ajax.form.AjaxFormSubmitBehavior.onEvent(AjaxFormSubmitBehavior.java:135)
> at
> org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:177)
> at
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:299)
> at
> org.apache.wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:119)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1250)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-2622) DatePicker doesn't appear
[ https://issues.apache.org/jira/browse/WICKET-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg closed WICKET-2622. - Resolution: Duplicate Assignee: Igor Vaynberg > DatePicker doesn't appear > - > > Key: WICKET-2622 > URL: https://issues.apache.org/jira/browse/WICKET-2622 > Project: Wicket > Issue Type: Bug >Affects Versions: 1.4.4 >Reporter: Alex Grant >Assignee: Igor Vaynberg >Priority: Minor > > I am using org.apache.wicket.extensions.yui.calendar.DateField > When I upgraded to Wicket 1.4.4, the DatePickers stopped functioning. The > mouse changes to a pointer when I hover over the little calendar icon, but > clicking on them doesn't do anything. > The only other related behaviour I've seen is my ModalWindows don't load > their borders anymore - maybe there's a problem loading some referenced > resources? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-2602) Display upload progress bar only when a file is selected
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten reopened WICKET-2602: - Pleas apply attached patch to optimize serialization. > Display upload progress bar only when a file is selected > > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten >Assignee: Igor Vaynberg > Fix For: 1.4.5, 1.5-M1 > > Attachments: Serialization_optimization_.patch, > WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch > > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Display upload progress bar only when a file is selected
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2602: Attachment: Serialization_optimization_.patch > Display upload progress bar only when a file is selected > > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten >Assignee: Igor Vaynberg > Fix For: 1.4.5, 1.5-M1 > > Attachments: Serialization_optimization_.patch, > WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch > > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
