svn commit: r1085659 - /wicket/branches/wicket-1.4.x/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java

2011-03-25 Thread ivaynberg
Author: ivaynberg
Date: Sat Mar 26 06:57:49 2011
New Revision: 1085659

URL: http://svn.apache.org/viewvc?rev=1085659&view=rev
Log:
WICKET-3548

Modified:

wicket/branches/wicket-1.4.x/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java

Modified: 
wicket/branches/wicket-1.4.x/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java?rev=1085659&r1=1085658&r2=1085659&view=diff
==
--- 
wicket/branches/wicket-1.4.x/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java
 (original)
+++ 
wicket/branches/wicket-1.4.x/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java
 Sat Mar 26 06:57:49 2011
@@ -226,17 +226,16 @@ public class LazyInitProxyFactory
 
private Object readResolve() throws ObjectStreamException
{
-   Class clazz;
try
{
-   clazz = Objects.resolveClass(type);
+   Class clazz = Objects.resolveClass(type);
+   return LazyInitProxyFactory.createProxy(clazz, 
locator);
}
catch (ClassNotFoundException e)
{
throw new RuntimeException("Could not resolve 
class [" + type +
"] when deserializing proxy", e);
}
-   return LazyInitProxyFactory.createProxy(clazz, locator);
}
}
 




svn commit: r1085658 - in /wicket/trunk: wicket-core/src/main/java/org/apache/wicket/util/lang/WicketObjects.java wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java

2011-03-25 Thread ivaynberg
Author: ivaynberg
Date: Sat Mar 26 06:57:06 2011
New Revision: 1085658

URL: http://svn.apache.org/viewvc?rev=1085658&view=rev
Log:

Issue: WICKET-3548

Modified:

wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/lang/WicketObjects.java

wicket/trunk/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java

Modified: 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/lang/WicketObjects.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/lang/WicketObjects.java?rev=1085658&r1=1085657&r2=1085658&view=diff
==
--- 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/lang/WicketObjects.java
 (original)
+++ 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/lang/WicketObjects.java
 Sat Mar 26 06:57:06 2011
@@ -56,30 +56,19 @@ public class WicketObjects
 * @param className
 *Class to resolve
 * @return Resolved class
+* @throws ClassNotFoundException
 */
@SuppressWarnings("unchecked")
-   public static  Class resolveClass(final String className)
+   public static  Class resolveClass(final String className) throws 
ClassNotFoundException
{
-   if (className == null)
+   if (Application.exists())
{
-   return null;
-   }
-   try
-   {
-   if (Application.exists())
-   {
-   return (Class)Application.get()
-   .getApplicationSettings()
-   .getClassResolver()
-   .resolveClass(className);
-   }
-   return (Class)Class.forName(className);
-   }
-   catch (ClassNotFoundException e)
-   {
-   log.warn("Could not resolve class: " + className);
-   return null;
+   return (Class)Application.get()
+   .getApplicationSettings()
+   .getClassResolver()
+   .resolveClass(className);
}
+   return (Class)Class.forName(className);
}
 
/**
@@ -435,21 +424,9 @@ public class WicketObjects
try
{
Class c = 
WicketObjects.resolveClass(className);
-   if (c == null)
-   {
-   throw new 
WicketRuntimeException("Unable to create " + className);
-   }
return c.newInstance();
}
-   catch (ClassCastException e)
-   {
-   throw new WicketRuntimeException("Unable to 
create " + className, e);
-   }
-   catch (InstantiationException e)
-   {
-   throw new WicketRuntimeException("Unable to 
create " + className, e);
-   }
-   catch (IllegalAccessException e)
+   catch (Exception e)
{
throw new WicketRuntimeException("Unable to 
create " + className, e);
}

Modified: 
wicket/trunk/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java?rev=1085658&r1=1085657&r2=1085658&view=diff
==
--- 
wicket/trunk/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java
 (original)
+++ 
wicket/trunk/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java
 Sat Mar 26 06:57:06 2011
@@ -16,7 +16,6 @@
  */
 package org.apache.wicket.proxy;
 
-import java.io.InvalidClassException;
 import java.io.ObjectStreamException;
 import java.io.Serializable;
 import java.lang.reflect.InvocationHandler;
@@ -228,14 +227,16 @@ public class LazyInitProxyFactory
 
private Object readResolve() throws ObjectStreamException
{
-   Class clazz;
-   clazz = WicketObjects.resolveClass(type);
-   if (clazz == null)
+   try
+   {
+   Class clazz = 
WicketObjects.resolveClass(type);
+   return LazyInitProxyFactory.createProxy(clazz, 
locator);
+   }
+   catch (ClassNotFoundExcep

svn commit: r1085656 - in /wicket/branches/wicket-1.4.x: wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java wicket/src/main/java/org/apache/wicket/util/lang/Objects.java

2011-03-25 Thread ivaynberg
Author: ivaynberg
Date: Sat Mar 26 06:54:12 2011
New Revision: 1085656

URL: http://svn.apache.org/viewvc?rev=1085656&view=rev
Log:

Issue: WICKET-3548

Modified:

wicket/branches/wicket-1.4.x/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java

wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/util/lang/Objects.java

Modified: 
wicket/branches/wicket-1.4.x/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java?rev=1085656&r1=1085655&r2=1085656&view=diff
==
--- 
wicket/branches/wicket-1.4.x/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java
 (original)
+++ 
wicket/branches/wicket-1.4.x/wicket-ioc/src/main/java/org/apache/wicket/proxy/LazyInitProxyFactory.java
 Sat Mar 26 06:54:12 2011
@@ -16,7 +16,6 @@
  */
 package org.apache.wicket.proxy;
 
-import java.io.InvalidClassException;
 import java.io.ObjectStreamException;
 import java.io.Serializable;
 import java.lang.reflect.InvocationHandler;
@@ -227,13 +226,16 @@ public class LazyInitProxyFactory
 
private Object readResolve() throws ObjectStreamException
{
-   Class clazz = Objects.resolveClass(type);
-   if (clazz == null)
+   Class clazz;
+   try
{
-   throw new InvalidClassException(type, "could 
not resolve class [" + type +
-   "] when deserializing proxy");
+   clazz = Objects.resolveClass(type);
+   }
+   catch (ClassNotFoundException e)
+   {
+   throw new RuntimeException("Could not resolve 
class [" + type +
+   "] when deserializing proxy", e);
}
-
return LazyInitProxyFactory.createProxy(clazz, locator);
}
}

Modified: 
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/util/lang/Objects.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/util/lang/Objects.java?rev=1085656&r1=1085655&r2=1085656&view=diff
==
--- 
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/util/lang/Objects.java
 (original)
+++ 
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/util/lang/Objects.java
 Sat Mar 26 06:54:12 2011
@@ -1262,33 +1262,21 @@ public final class Objects
 * @param className
 *Class to resolve
 * @return Resolved class
+* @throws ClassNotFoundException
 */
@SuppressWarnings("unchecked")
-   public static  Class resolveClass(final String className)
+   public static  Class resolveClass(final String className) throws 
ClassNotFoundException
{
-   if (className == null)
+   if (Application.exists())
{
-   return null;
-   }
-   try
-   {
-   if (Application.exists())
-   {
-   return (Class)Application.get()
-   .getApplicationSettings()
-   .getClassResolver()
-   .resolveClass(className);
-   }
-   return (Class)Class.forName(className);
-   }
-   catch (ClassNotFoundException e)
-   {
-   log.warn("Could not resolve class: " + className);
-   return null;
+   return (Class)Application.get()
+   .getApplicationSettings()
+   .getClassResolver()
+   .resolveClass(className);
}
+   return (Class)Class.forName(className);
}
 
-
/**
 * Instantiation not allowed
 */




[jira] [Resolved] (WICKET-3473) Inline Javascript evaluated is executed before head contributions are loaded

2011-03-25 Thread Igor Vaynberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-3473.
---

   Resolution: Fixed
Fix Version/s: 1.5-RC3
   1.4.17
 Assignee: Igor Vaynberg

> Inline Javascript evaluated is executed before head contributions are loaded
> 
>
> Key: WICKET-3473
> URL: https://issues.apache.org/jira/browse/WICKET-3473
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-core
>Affects Versions: 1.4.15, 1.5-RC2
> Environment: Firefox 3.6.13
>Reporter: Jannis Bloemendal
>Assignee: Igor Vaynberg
> Fix For: 1.4.17, 1.5-RC3
>
> Attachments: WICKET-3473.patch, WICKET-3473_firefox.tar.gz, 
> WICKET-3473_quickstart.tar.gz
>
>
> When a script added to the head loads an external script firefox postpones 
> processing of the following script added to the head. This is a problem, 
> because wicket assumes that head contributions are loaded immediately. So if 
> for example a library is used as a head contribution it will not be loaded 
> for it's actual usage.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


svn commit: r1085654 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/wicket-ajax.js

2011-03-25 Thread ivaynberg
Author: ivaynberg
Date: Sat Mar 26 06:07:39 2011
New Revision: 1085654

URL: http://svn.apache.org/viewvc?rev=1085654&view=rev
Log:

Issue: WICKET-3473

Modified:

wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/wicket-ajax.js

Modified: 
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/wicket-ajax.js
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/wicket-ajax.js?rev=1085654&r1=1085653&r2=1085654&view=diff
==
--- 
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/wicket-ajax.js
 (original)
+++ 
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/wicket-ajax.js
 Sat Mar 26 06:07:39 2011
@@ -126,6 +126,7 @@ Wicket.Log = { 
}
 },
 
+
 /**
  * Functions executer takes array of functions and executes them. Each 
function gets
  * the notify object, which needs to be called for the next function to be 
executed.
@@ -172,6 +173,12 @@ Wicket.FunctionsExecuter.prototype = {
}
 }
 
+/*
+  WICKET-3473 Helper to proceed to next step, execution of notify needs to be 
delayed until the head contributions are loaded
+*/
+Wicket.functionExecuterSeq = 0;
+Wicket.functionExecuterCallbacks = {};
+
 Wicket.replaceOuterHtmlIE = function(element, text) {  

 
// replaces all 

svn commit: r1085653 - /wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/wicket-ajax.js

2011-03-25 Thread ivaynberg
Author: ivaynberg
Date: Sat Mar 26 06:07:30 2011
New Revision: 1085653

URL: http://svn.apache.org/viewvc?rev=1085653&view=rev
Log:

Issue: WICKET-3473

Modified:
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/wicket-ajax.js

Modified: 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/wicket-ajax.js
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/wicket-ajax.js?rev=1085653&r1=1085652&r2=1085653&view=diff
==
--- 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/wicket-ajax.js 
(original)
+++ 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/wicket-ajax.js 
Sat Mar 26 06:07:30 2011
@@ -122,6 +122,7 @@ Wicket.Log = { 
}
 },
 
+
 /**
  * Functions executer takes array of functions and executes them. Each 
function gets
  * the notify object, which needs to be called for the next function to be 
executed.
@@ -168,6 +169,12 @@ Wicket.FunctionsExecuter.prototype = {
}
 }
 
+/*
+  WICKET-3473 Helper to proceed to next step, execution of notify needs to be 
delayed until the head contributions are loaded
+*/
+Wicket.functionExecuterSeq = 0;
+Wicket.functionExecuterCallbacks = {};
+
 Wicket.replaceOuterHtmlIE = function(element, text) {  

 
// replaces all 

[jira] [Resolved] (WICKET-3510) DateTimeField improperly converts time causing wrong dates when the server's current date is different from the client's date.

2011-03-25 Thread Igor Vaynberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-3510.
---

Resolution: Fixed
  Assignee: Igor Vaynberg

latest patch applied

> DateTimeField improperly converts time causing wrong dates when the server's 
> current date is different from the client's date.
> --
>
> Key: WICKET-3510
> URL: https://issues.apache.org/jira/browse/WICKET-3510
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-datetime
>Affects Versions: 1.5-RC2
>Reporter: Bertrand Guay-Paquet
>Assignee: Igor Vaynberg
>  Labels: datepicker, datetime
> Fix For: 1.5-RC3
>
> Attachments: DateConverterFix.patch, FailingTest.patch, 
> TestDateConverter.java, dateModelConversionFix.patch, 
> dateModelConversionFix_TimeField.patch, 
> dateModelConversionFix_TimeField_NoEnclosure.patch, 
> doubleConversionFix.patch, testsWithDateModels.patch
>
>
> The bug is in DateTimeField#convertInput().
> 
> // Get year, month and day ignoring any timezone of the Date object
> Calendar cal = Calendar.getInstance();
> cal.setTime(dateFieldInput);
> int year = cal.get(Calendar.YEAR);
> int month = cal.get(Calendar.MONTH) + 1;
> int day = cal.get(Calendar.DAY_OF_MONTH);
> int hours = (hoursInput == null ? 0 : hoursInput % 24);
> int minutes = (minutesInput == null ? 0 : minutesInput);
> // Use the input to create a date object with proper timezone
> MutableDateTime date = new MutableDateTime(year, month, day, hours, minutes, 
> 0, 0,
>   DateTimeZone.forTimeZone(getClientTimeZone()));
> 
> If the server's current date is different from the client's, this produces 
> wrong output. I attached a patch with a test case that simulates this 
> condition.
> I don't know why this "casting" of day, month, year is done.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


svn commit: r1085651 - in /wicket/trunk/wicket-datetime/src: main/java/org/apache/wicket/extensions/yui/calendar/ test/java/org/apache/wicket/extensions/yui/calendar/

2011-03-25 Thread ivaynberg
Author: ivaynberg
Date: Sat Mar 26 05:50:56 2011
New Revision: 1085651

URL: http://svn.apache.org/viewvc?rev=1085651&view=rev
Log:
3510

Modified:

wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.html

wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java

wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/TimeField.java

wicket/trunk/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatePickerTest.java

wicket/trunk/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage2.html

wicket/trunk/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage2.java

Modified: 
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.html
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.html?rev=1085651&r1=1085650&r2=1085651&view=diff
==
--- 
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.html
 (original)
+++ 
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.html
 Sat Mar 26 05:50:56 2011
@@ -18,7 +18,8 @@
 
   
 
- :
+   
+    :
 
 
   

Modified: 
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java?rev=1085651&r1=1085650&r2=1085651&view=diff
==
--- 
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
 (original)
+++ 
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
 Sat Mar 26 05:50:56 2011
@@ -26,6 +26,7 @@ import java.util.TimeZone;
 import org.apache.wicket.Session;
 import org.apache.wicket.datetime.markup.html.form.DateTextField;
 import org.apache.wicket.markup.html.IHeaderResponse;
+import org.apache.wicket.markup.html.WebMarkupContainer;
 import org.apache.wicket.markup.html.form.DropDownChoice;
 import org.apache.wicket.markup.html.form.FormComponentPanel;
 import org.apache.wicket.markup.html.form.TextField;
@@ -173,6 +174,16 @@ public class DateTimeField extends FormC
// Create and add the "AM/PM" Listbox
add(amOrPmChoice = new DropDownChoice(AM_OR_PM_CHOICE, 
new PropertyModel(
this, AM_OR_PM), Arrays.asList(AM_PM.values(;
+   
+   add(new WebMarkupContainer("hoursSeparator"){
+   private static final long serialVersionUID = 1L;
+
+   @Override
+   public boolean isVisible()
+   {
+   return minutesField.determineVisibility();
+   }
+   });
}
 
/**
@@ -402,15 +413,15 @@ public class DateTimeField extends FormC
}
else
{
-   MutableDateTime mDate = new 
MutableDateTime(modelObject);
-
// convert date to the client's time zone if we have 
that info
TimeZone zone = getClientTimeZone();
if (zone != null)
{
-   mDate.setZone(DateTimeZone.forTimeZone(zone));
+   modelObject = changeTimeZone(modelObject, zone);
}
 
+   MutableDateTime mDate = new 
MutableDateTime(modelObject);
+
date = mDate.toDate();
 
if (use12HourFormat)
@@ -431,6 +442,32 @@ public class DateTimeField extends FormC
}
 
/**
+* Change a date in another timezone
+* 
+* @param date
+*The input date.
+* @param zone
+*The target timezone.
+* @return A new converted date.
+*/
+   public static Date changeTimeZone(Date date, TimeZone zone)
+   {
+   Calendar first = Calendar.getInstance(zone);
+   first.setTimeInMillis(date.getTime());
+
+   Calendar output = Calendar.getInstance();
+   output.set(Calendar.YEAR, first.get(Calendar.YEAR));
+   output.set(Calendar.MONTH, first.get(Calendar.MONTH));
+   output.set(Calendar.DAY_OF_MONTH, 
first.get(Calendar.DAY_OF_MONTH));
+   output.set(Calendar.HOUR_OF_DAY, 
first.get(Calendar.HOUR_OF_DAY));
+   output.set(Calendar.MINUTE, first.get(Calenda

svn commit: r1085649 - in /wicket/trunk/wicket-core/src: main/java/org/apache/wicket/ test/java/org/apache/wicket/

2011-03-25 Thread ivaynberg
Author: ivaynberg
Date: Sat Mar 26 05:49:20 2011
New Revision: 1085649

URL: http://svn.apache.org/viewvc?rev=1085649&view=rev
Log:
delay first onInitialize cascade just before render so pages can use 
onInitialize() as well
Issue: WICKET-3218

Added:

wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentInitializationIntegrationTest.java
   (with props)
Modified:

wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java

wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentInitializationTest.java

Modified: 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java?rev=1085649&r1=1085648&r2=1085649&view=diff
==
--- 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java 
(original)
+++ 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java 
Sat Mar 26 05:49:20 2011
@@ -924,7 +924,10 @@ public abstract class MarkupContainer ex
page.componentAdded(child);
 
// initialie the component
-   child.internalInitialize();
+   if (page.getFlag(FLAG_INITIALIZED))
+   {
+   child.internalInitialize();
+   }
}
 
// if the PREPARED_FOR_RENDER flag is set, we have already 
called

Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java?rev=1085649&r1=1085648&r2=1085649&view=diff
==
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java 
(original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java Sat Mar 
26 05:49:20 2011
@@ -572,17 +572,6 @@ public abstract class Page extends Marku
return stateless;
}
 
-   @Override
-   protected final void onInitialize()
-   {
-   /*
-* final in the page because: *** doesnt make sense for pages 
*** can be called from page's
-* constructor - which is bad *** if delayed can lead to page 
not being initialized after
-* its constructor call - which is bad
-*/
-   super.onInitialize();
-   }
-
/**
 * Redirect to this page.
 * 
@@ -1017,12 +1006,6 @@ public abstract class Page extends Marku
 */
final void componentAdded(final Component component)
{
-   if (!getFlag(FLAG_INITIALIZED))
-   {
-   // initialize the page if not yet initialized
-   internalInitialize();
-   }
-
if (!component.isAuto())
{
dirty();

Added: 
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentInitializationIntegrationTest.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentInitializationIntegrationTest.java?rev=1085649&view=auto
==
--- 
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentInitializationIntegrationTest.java
 (added)
+++ 
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentInitializationIntegrationTest.java
 Sat Mar 26 05:49:20 2011
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket;
+
+import static org.junit.Assert.assertEquals;
+
+import org.apache.wicket.markup.IMarkupResourceStreamProvider;
+import org.apache.wicket.markup.html.WebMarkupContainer;
+import org.apache.wicket.markup.html.WebPage;
+import org.apache.wicket.util.resource.IResourceStream;
+import org.apache.wicket.util.resource.StringResourceStream;
+import org.apache.wick

[jira] [Commented] (WICKET-3218) Component#onInitialize is broken for Pages

2011-03-25 Thread Igor Vaynberg (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011574#comment-13011574
 ] 

Igor Vaynberg commented on WICKET-3218:
---

initial cascade is now delayed just prior to first render of the page. however, 
once the page has been initialized further component initialization will happen 
on immediate availability of the page just like it does now.

> Component#onInitialize is broken for Pages
> --
>
> Key: WICKET-3218
> URL: https://issues.apache.org/jira/browse/WICKET-3218
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-core
>Affects Versions: 1.4.14
>Reporter: Carl-Eric Menzel
>Assignee: Igor Vaynberg
> Fix For: 1.5-RC3
>
> Attachments: 
> 0001-delay-oninitialize-until-just-before-onconfigure.patch
>
>
> As first mentioned at 
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201012.mbox/%3c1291238699.1749.1408166...@webmail.messagingengine.com%3E
>  , I think the current (Wicket 1.4.14) implementation of 
> Component#onInitialize is broken for Pages. Pages get initialized as soon as 
> the first component is added, which is correct. But this usually happens 
> within the constructor of the page, which means that the page object isn't 
> fully initialized yet. The entire point of having onInitialize, however, is 
> to be able to do further work once all constructors have run. See 
> https://github.com/duesenklipper/wicket-oninitialize for a quickstart that 
> demonstrates the problem.
> Pedro Santos suggested in the above thread to just switch the entire object 
> construction to onInitialize. I don't think this is a good idea, because
> 1) it is completely counter-intuitive
> 2) it is not always realistic to have an entire class hierarchy not using the 
> constructor just because a subclass somewhere might want to use onInitialize
> 3) it is inconsistent with onInitialize behavior for all other (non-Page) 
> components. Here I can easily mix work in the constructor with onInitialize.
> I propose the following patch:
> - override onInitialize in Page and make it final, so Pages can't use this 
> any more. This should not cause any unnecessary breaking, since currently 
> it's not working for pages anyway.
> - introduce Page#onPageInitialize to provide a safe alternative to 
> onInitialize
> - make a special case for Page in Component's beforeRender to fire 
> Page#onPageInitialize if necessary
> Yes, this is a bit of special casing for Page, but there's quite a lot of 
> that needed for Page anyway. I think the impact of this should be minimal.
> My page includes documentation and a new testcase that verifies the new 
> behavior. I modified the old ComponentInitializationTest to reflect the fact 
> that Page doesn't get onInitialize any more.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Reopened] (WICKET-3218) Component#onInitialize is broken for Pages

2011-03-25 Thread Igor Vaynberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg reopened WICKET-3218:
---


> Component#onInitialize is broken for Pages
> --
>
> Key: WICKET-3218
> URL: https://issues.apache.org/jira/browse/WICKET-3218
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-core
>Affects Versions: 1.4.14
>Reporter: Carl-Eric Menzel
>Assignee: Igor Vaynberg
> Fix For: 1.5-RC3
>
> Attachments: 
> 0001-delay-oninitialize-until-just-before-onconfigure.patch
>
>
> As first mentioned at 
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201012.mbox/%3c1291238699.1749.1408166...@webmail.messagingengine.com%3E
>  , I think the current (Wicket 1.4.14) implementation of 
> Component#onInitialize is broken for Pages. Pages get initialized as soon as 
> the first component is added, which is correct. But this usually happens 
> within the constructor of the page, which means that the page object isn't 
> fully initialized yet. The entire point of having onInitialize, however, is 
> to be able to do further work once all constructors have run. See 
> https://github.com/duesenklipper/wicket-oninitialize for a quickstart that 
> demonstrates the problem.
> Pedro Santos suggested in the above thread to just switch the entire object 
> construction to onInitialize. I don't think this is a good idea, because
> 1) it is completely counter-intuitive
> 2) it is not always realistic to have an entire class hierarchy not using the 
> constructor just because a subclass somewhere might want to use onInitialize
> 3) it is inconsistent with onInitialize behavior for all other (non-Page) 
> components. Here I can easily mix work in the constructor with onInitialize.
> I propose the following patch:
> - override onInitialize in Page and make it final, so Pages can't use this 
> any more. This should not cause any unnecessary breaking, since currently 
> it's not working for pages anyway.
> - introduce Page#onPageInitialize to provide a safe alternative to 
> onInitialize
> - make a special case for Page in Component's beforeRender to fire 
> Page#onPageInitialize if necessary
> Yes, this is a bit of special casing for Page, but there's quite a lot of 
> that needed for Page anyway. I think the impact of this should be minimal.
> My page includes documentation and a new testcase that verifies the new 
> behavior. I modified the old ComponentInitializationTest to reflect the fact 
> that Page doesn't get onInitialize any more.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Resolved] (WICKET-3218) Component#onInitialize is broken for Pages

2011-03-25 Thread Igor Vaynberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-3218.
---

   Resolution: Fixed
Fix Version/s: (was: 1.5-RC1)
   1.5-RC3

> Component#onInitialize is broken for Pages
> --
>
> Key: WICKET-3218
> URL: https://issues.apache.org/jira/browse/WICKET-3218
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-core
>Affects Versions: 1.4.14
>Reporter: Carl-Eric Menzel
>Assignee: Igor Vaynberg
> Fix For: 1.5-RC3
>
> Attachments: 
> 0001-delay-oninitialize-until-just-before-onconfigure.patch
>
>
> As first mentioned at 
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201012.mbox/%3c1291238699.1749.1408166...@webmail.messagingengine.com%3E
>  , I think the current (Wicket 1.4.14) implementation of 
> Component#onInitialize is broken for Pages. Pages get initialized as soon as 
> the first component is added, which is correct. But this usually happens 
> within the constructor of the page, which means that the page object isn't 
> fully initialized yet. The entire point of having onInitialize, however, is 
> to be able to do further work once all constructors have run. See 
> https://github.com/duesenklipper/wicket-oninitialize for a quickstart that 
> demonstrates the problem.
> Pedro Santos suggested in the above thread to just switch the entire object 
> construction to onInitialize. I don't think this is a good idea, because
> 1) it is completely counter-intuitive
> 2) it is not always realistic to have an entire class hierarchy not using the 
> constructor just because a subclass somewhere might want to use onInitialize
> 3) it is inconsistent with onInitialize behavior for all other (non-Page) 
> components. Here I can easily mix work in the constructor with onInitialize.
> I propose the following patch:
> - override onInitialize in Page and make it final, so Pages can't use this 
> any more. This should not cause any unnecessary breaking, since currently 
> it's not working for pages anyway.
> - introduce Page#onPageInitialize to provide a safe alternative to 
> onInitialize
> - make a special case for Page in Component's beforeRender to fire 
> Page#onPageInitialize if necessary
> Yes, this is a bit of special casing for Page, but there's quite a lot of 
> that needed for Page anyway. I think the impact of this should be minimal.
> My page includes documentation and a new testcase that verifies the new 
> behavior. I modified the old ComponentInitializationTest to reflect the fact 
> that Page doesn't get onInitialize any more.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (WICKET-3558) Expose active requests via JMX

2011-03-25 Thread Dominik Drzewiecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Drzewiecki updated WICKET-3558:
---

Attachment: (was: exposeActiveViaJMX-1.5.patch)

> Expose active requests via JMX
> --
>
> Key: WICKET-3558
> URL: https://issues.apache.org/jira/browse/WICKET-3558
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket-jmx
>Affects Versions: 1.4.16, 1.5-RC2
>Reporter: Dominik Drzewiecki
>Priority: Minor
> Attachments: exposeActiveViaJMX-1.4.patch, 
> exposeActiveViaJMX-1.5.patch
>
>
> It'd be nice if RequestLogger.active was exposed via JMX in the same manner 
> the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and 
> expose the peak number of concurrent (active) requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (WICKET-3558) Expose active requests via JMX

2011-03-25 Thread Dominik Drzewiecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Drzewiecki updated WICKET-3558:
---

Attachment: exposeActiveViaJMX-1.5.patch

> Expose active requests via JMX
> --
>
> Key: WICKET-3558
> URL: https://issues.apache.org/jira/browse/WICKET-3558
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket-jmx
>Affects Versions: 1.4.16, 1.5-RC2
>Reporter: Dominik Drzewiecki
>Priority: Minor
> Attachments: exposeActiveViaJMX-1.4.patch, 
> exposeActiveViaJMX-1.5.patch
>
>
> It'd be nice if RequestLogger.active was exposed via JMX in the same manner 
> the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and 
> expose the peak number of concurrent (active) requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (WICKET-3558) Expose active requests via JMX

2011-03-25 Thread Dominik Drzewiecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Drzewiecki updated WICKET-3558:
---

Affects Version/s: 1.5-RC2

> Expose active requests via JMX
> --
>
> Key: WICKET-3558
> URL: https://issues.apache.org/jira/browse/WICKET-3558
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket-jmx
>Affects Versions: 1.4.16, 1.5-RC2
>Reporter: Dominik Drzewiecki
>Priority: Minor
> Attachments: exposeActiveViaJMX-1.4.patch, 
> exposeActiveViaJMX-1.5.patch
>
>
> It'd be nice if RequestLogger.active was exposed via JMX in the same manner 
> the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and 
> expose the peak number of concurrent (active) requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (WICKET-3558) Expose active requests via JMX

2011-03-25 Thread Dominik Drzewiecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Drzewiecki updated WICKET-3558:
---

Attachment: (was: exposeActiveViaJMX.patch)

> Expose active requests via JMX
> --
>
> Key: WICKET-3558
> URL: https://issues.apache.org/jira/browse/WICKET-3558
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket-jmx
>Affects Versions: 1.4.16, 1.5-RC2
>Reporter: Dominik Drzewiecki
>Priority: Minor
> Attachments: exposeActiveViaJMX-1.4.patch, 
> exposeActiveViaJMX-1.5.patch
>
>
> It'd be nice if RequestLogger.active was exposed via JMX in the same manner 
> the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and 
> expose the peak number of concurrent (active) requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (WICKET-3558) Expose active requests via JMX

2011-03-25 Thread Dominik Drzewiecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Drzewiecki updated WICKET-3558:
---

Attachment: (was: exposeActiveViaJMX-1.4.patch)

> Expose active requests via JMX
> --
>
> Key: WICKET-3558
> URL: https://issues.apache.org/jira/browse/WICKET-3558
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket-jmx
>Affects Versions: 1.4.16
>Reporter: Dominik Drzewiecki
>Priority: Minor
> Attachments: exposeActiveViaJMX-1.4.patch, 
> exposeActiveViaJMX-1.5.patch, exposeActiveViaJMX.patch
>
>
> It'd be nice if RequestLogger.active was exposed via JMX in the same manner 
> the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and 
> expose the peak number of concurrent (active) requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (WICKET-3558) Expose active requests via JMX

2011-03-25 Thread Dominik Drzewiecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Drzewiecki updated WICKET-3558:
---

Attachment: exposeActiveViaJMX-1.4.patch

> Expose active requests via JMX
> --
>
> Key: WICKET-3558
> URL: https://issues.apache.org/jira/browse/WICKET-3558
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket-jmx
>Affects Versions: 1.4.16
>Reporter: Dominik Drzewiecki
>Priority: Minor
> Attachments: exposeActiveViaJMX-1.4.patch, 
> exposeActiveViaJMX-1.5.patch, exposeActiveViaJMX.patch
>
>
> It'd be nice if RequestLogger.active was exposed via JMX in the same manner 
> the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and 
> expose the peak number of concurrent (active) requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (WICKET-3558) Expose active requests via JMX

2011-03-25 Thread Dominik Drzewiecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Drzewiecki updated WICKET-3558:
---

Attachment: exposeActiveViaJMX-1.4.patch

This one supersedes exposeActiveViaJMX.patch which appears to miss one class 
modifcations.

> Expose active requests via JMX
> --
>
> Key: WICKET-3558
> URL: https://issues.apache.org/jira/browse/WICKET-3558
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket-jmx
>Affects Versions: 1.4.16
>Reporter: Dominik Drzewiecki
>Priority: Minor
> Attachments: exposeActiveViaJMX-1.4.patch, 
> exposeActiveViaJMX-1.5.patch, exposeActiveViaJMX.patch
>
>
> It'd be nice if RequestLogger.active was exposed via JMX in the same manner 
> the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and 
> expose the peak number of concurrent (active) requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (WICKET-3558) Expose active requests via JMX

2011-03-25 Thread Dominik Drzewiecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Drzewiecki updated WICKET-3558:
---

Attachment: exposeActiveViaJMX-1.5.patch

> Expose active requests via JMX
> --
>
> Key: WICKET-3558
> URL: https://issues.apache.org/jira/browse/WICKET-3558
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket-jmx
>Affects Versions: 1.4.16
>Reporter: Dominik Drzewiecki
>Priority: Minor
> Attachments: exposeActiveViaJMX-1.4.patch, 
> exposeActiveViaJMX-1.5.patch, exposeActiveViaJMX.patch
>
>
> It'd be nice if RequestLogger.active was exposed via JMX in the same manner 
> the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and 
> expose the peak number of concurrent (active) requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Issue Comment Edited] (WICKET-3519) DefaultJavascriptCompressor broken jquery v1.5.1 minified file

2011-03-25 Thread Max Raba (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011462#comment-13011462
 ] 

Max Raba edited comment on WICKET-3519 at 3/25/11 10:45 PM:


Could someone please look at this thing here, because i think it's a major 
thing which should be fixed soon and easily. Thanks.

  was (Author: rabam):
Could someone please look at this thing here, because i think it's a major 
thing which should be fixed soon and easily.
  
> DefaultJavascriptCompressor broken jquery v1.5.1 minified file
> --
>
> Key: WICKET-3519
> URL: https://issues.apache.org/jira/browse/WICKET-3519
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-core
>Affects Versions: 1.4.16
> Environment: windows 7 x64
>Reporter: Olivier Dutrieux
>  Labels: javascript, jquery, wicket
> Attachments: JQueryCompressionTest.java, jquery-1.5.1.min.js
>
>
> Hello,
> The DefaultJavascriptCompressor broken jquery v1.5.1 Minified file:
> text/javascript","*":"*/*"},contents:{xml:/xml/,html:/html/,json:/json/},responseFields:{xml:"responseXML",text:"responseText"},converters:{"*
>  text":a.String,"text html":!0,"text json":d.parseJSON,"text 
> xml":d.parseXML}},ajaxPrefilter:bM(bH),ajaxTransport:bM(bI),ajax:function(a,c){function
>  
> v(a,c,l,n){if(r!==2){r=2,p&&clearTimeout(p),o=b,m=n||"",u.readyState=a?4:0;var
>  
> q,t,v,w=l?bP(e,u,l):b,x,y;if(a>=200&&a<300||a===304){if(e.ifModified){if(x=u.getResponseHeader("Last-Modified"))d.lastModified[k]=x;if(y=u.getResponseHeader("Etag"))d.etag[k]=y}if(a===304)c="notmodified",q=!0;else
>  
> try{t=bQ(e,w),c="success",q=!0}catch(z){c="parsererror",v=z}}else{v=c;if(!c||a)c="error",a<0&&(a=0)}u.status=a,u.statusText=c,q?h.resolveWith(f,[t,c,u]):h.rejectWith(f,[u,c,v]),u.statusCode(j),j=b,s&&g.trigger("ajax"+(q?"Success":"Error"),[u,e,q?t:v]),i.resolveWith(f,[u,c]),s&&(g.trigger("ajaxComplete",[u,e]),--d.active||d.event.trigger("ajaxStop"))}}typeof
>  a==="object"&&(c=a,a=b),c=c||{};var 
> e=d.ajaxSetup({},c),f=e.context||e,g=f!==e&&(f.nodeType||f instanceof 
> d)?d(f):d.event,h=d.Deferred(),i=d._Deferred(),j=e.statusCode||{},k,l={},m,n,o,p,q,r=0,s,t,u={readyState:0,setRequestHeader:function(a,b){r||(l[a.toLowerCase().replace(bD,bE)]=b);return
>  this},getAllResponseHeaders:function(){return 
> r===2?m:null},getResponseHeader:function(a){var 
> c;if(r===2){if(!n){n={};while(c=bt.exec(m))n[c[1].toLowerCase()]=c[2]}c=n[a.toLowerCase()]}return
>  c===b?null:c},overrideMimeType:function(a){r||(e.mimeType=a);return 
> this},abort:function(a){a=a||"abort",o&&o.abort(a),v(0,a);return 
> this}};h.promise(u),u.success=u.done,u.error=u.fail,u.complete=i.done,u.statusCode=function(a){if(a){var
>  b;if(r<2)for(b in a)j[b]=[j[b],a[b]];else b=a[u.status],u.then(b,b)}return 
> this},e.url=((a||e.url)+"").replace(bs,"").replace(bx,bK[1]+"//"),e.dataTypes=d.trim(e.dataType||"*").toLowerCase().split(bB),e.crossDomain||(q=bF.exec(e.url.toLowerCase()),e.crossDomain=q&&(q[1]!=bK[1]||q[2]!=bK[2]||(q[3]||(q[1]==="http:"?80:443))!=(bK[3]||(bK[1]==="http:"?80:443,e.data&&e.processData&&typeof
>  
> e.data!=="string"&&(e.data=d.param(e.data,e.traditional)),bN(bH,e,c,u);if(r===2)return!1;s=e.global,e.type=e.type.toUpperCase(),e.hasContent=!bw.test(e.type),s&&d.active++===0&&d.event.trigger("ajaxStart");if(!e.hasContent){e.data&&(e.url+=(by.test(e.url)?"&":"?")+e.data),k=e.url;if(e.cache===!1){var
>  
> w=d.now(),x=e.url.replace(bC,"$1_="+w);e.url=x+(x===e.url?(by.test(e.url)?"&":"?")+"_="+w:"")}}if(e.data&&e.hasContent&&e.contentType!==!1||c.contentType)l["Content-Type"]=e.contentType;e.ifModified&&(k=k||e.url,d.lastModified[k]&&(l["If-Modified-Since"]=d.lastModified[k]),d.etag[k]&&(l["If-None-Match"]=d.etag[k])),l.Accept=e.dataTypes[0]&&e.accepts[e.dataTypes[0]]?e.accepts[e.dataTypes[0]]+(e.dataTypes[0]!=="*"?",
>  */*; q=0.01":"")
> become :
> text/javascript","*":"**; q=0.01":"")
> I think is due to the /* ...  */ on the javascript file and is interpreted by 
> stripCommentsAndWhitespace as a comment.
> Best regards

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (WICKET-3519) DefaultJavascriptCompressor broken jquery v1.5.1 minified file

2011-03-25 Thread Max Raba (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011462#comment-13011462
 ] 

Max Raba commented on WICKET-3519:
--

Could someone please look at this thing here, because i think it's a major 
thing which should be fixed soon and easily.

> DefaultJavascriptCompressor broken jquery v1.5.1 minified file
> --
>
> Key: WICKET-3519
> URL: https://issues.apache.org/jira/browse/WICKET-3519
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-core
>Affects Versions: 1.4.16
> Environment: windows 7 x64
>Reporter: Olivier Dutrieux
>  Labels: javascript, jquery, wicket
> Attachments: JQueryCompressionTest.java, jquery-1.5.1.min.js
>
>
> Hello,
> The DefaultJavascriptCompressor broken jquery v1.5.1 Minified file:
> text/javascript","*":"*/*"},contents:{xml:/xml/,html:/html/,json:/json/},responseFields:{xml:"responseXML",text:"responseText"},converters:{"*
>  text":a.String,"text html":!0,"text json":d.parseJSON,"text 
> xml":d.parseXML}},ajaxPrefilter:bM(bH),ajaxTransport:bM(bI),ajax:function(a,c){function
>  
> v(a,c,l,n){if(r!==2){r=2,p&&clearTimeout(p),o=b,m=n||"",u.readyState=a?4:0;var
>  
> q,t,v,w=l?bP(e,u,l):b,x,y;if(a>=200&&a<300||a===304){if(e.ifModified){if(x=u.getResponseHeader("Last-Modified"))d.lastModified[k]=x;if(y=u.getResponseHeader("Etag"))d.etag[k]=y}if(a===304)c="notmodified",q=!0;else
>  
> try{t=bQ(e,w),c="success",q=!0}catch(z){c="parsererror",v=z}}else{v=c;if(!c||a)c="error",a<0&&(a=0)}u.status=a,u.statusText=c,q?h.resolveWith(f,[t,c,u]):h.rejectWith(f,[u,c,v]),u.statusCode(j),j=b,s&&g.trigger("ajax"+(q?"Success":"Error"),[u,e,q?t:v]),i.resolveWith(f,[u,c]),s&&(g.trigger("ajaxComplete",[u,e]),--d.active||d.event.trigger("ajaxStop"))}}typeof
>  a==="object"&&(c=a,a=b),c=c||{};var 
> e=d.ajaxSetup({},c),f=e.context||e,g=f!==e&&(f.nodeType||f instanceof 
> d)?d(f):d.event,h=d.Deferred(),i=d._Deferred(),j=e.statusCode||{},k,l={},m,n,o,p,q,r=0,s,t,u={readyState:0,setRequestHeader:function(a,b){r||(l[a.toLowerCase().replace(bD,bE)]=b);return
>  this},getAllResponseHeaders:function(){return 
> r===2?m:null},getResponseHeader:function(a){var 
> c;if(r===2){if(!n){n={};while(c=bt.exec(m))n[c[1].toLowerCase()]=c[2]}c=n[a.toLowerCase()]}return
>  c===b?null:c},overrideMimeType:function(a){r||(e.mimeType=a);return 
> this},abort:function(a){a=a||"abort",o&&o.abort(a),v(0,a);return 
> this}};h.promise(u),u.success=u.done,u.error=u.fail,u.complete=i.done,u.statusCode=function(a){if(a){var
>  b;if(r<2)for(b in a)j[b]=[j[b],a[b]];else b=a[u.status],u.then(b,b)}return 
> this},e.url=((a||e.url)+"").replace(bs,"").replace(bx,bK[1]+"//"),e.dataTypes=d.trim(e.dataType||"*").toLowerCase().split(bB),e.crossDomain||(q=bF.exec(e.url.toLowerCase()),e.crossDomain=q&&(q[1]!=bK[1]||q[2]!=bK[2]||(q[3]||(q[1]==="http:"?80:443))!=(bK[3]||(bK[1]==="http:"?80:443,e.data&&e.processData&&typeof
>  
> e.data!=="string"&&(e.data=d.param(e.data,e.traditional)),bN(bH,e,c,u);if(r===2)return!1;s=e.global,e.type=e.type.toUpperCase(),e.hasContent=!bw.test(e.type),s&&d.active++===0&&d.event.trigger("ajaxStart");if(!e.hasContent){e.data&&(e.url+=(by.test(e.url)?"&":"?")+e.data),k=e.url;if(e.cache===!1){var
>  
> w=d.now(),x=e.url.replace(bC,"$1_="+w);e.url=x+(x===e.url?(by.test(e.url)?"&":"?")+"_="+w:"")}}if(e.data&&e.hasContent&&e.contentType!==!1||c.contentType)l["Content-Type"]=e.contentType;e.ifModified&&(k=k||e.url,d.lastModified[k]&&(l["If-Modified-Since"]=d.lastModified[k]),d.etag[k]&&(l["If-None-Match"]=d.etag[k])),l.Accept=e.dataTypes[0]&&e.accepts[e.dataTypes[0]]?e.accepts[e.dataTypes[0]]+(e.dataTypes[0]!=="*"?",
>  */*; q=0.01":"")
> become :
> text/javascript","*":"**; q=0.01":"")
> I think is due to the /* ...  */ on the javascript file and is interpreted by 
> stripCommentsAndWhitespace as a comment.
> Best regards

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (WICKET-3360) Datepicker formatting

2011-03-25 Thread Pedro Santos (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011349#comment-13011349
 ] 

Pedro Santos commented on WICKET-3360:
--

Change the component to use  tags instead of  don't fix any reported 
problem in this ticket.

> Datepicker formatting
> -
>
> Key: WICKET-3360
> URL: https://issues.apache.org/jira/browse/WICKET-3360
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-datetime
>Affects Versions: 1.4.15
> Environment: Windows 7, IE 8, Tomcat 6
>Reporter: Peter Diefenthäler
> Attachments: QickStartDatePicker.jpg, QuickStartDatePicker.war
>
>
> The datepicker component often hides behind other html components. Also the 
> sizing is influenced by surronding html tags like tabel and div's.
> I think this issue can be solved by using  tags instead of  tags 
> inside the datepicker. 
> I.e.  switched to http://www.atlassian.com/software/jira


[jira] [Commented] (WICKET-3360) Datepicker formatting

2011-03-25 Thread Pedro Santos (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011344#comment-13011344
 ] 

Pedro Santos commented on WICKET-3360:
--

Hi Peter, in your page you have 2 div tags () 
marking 2 different containers in the same z-index. 
The calendar tag z-index is 9, but IE don't care about it being higher then 
the rest of page because the its parent container is not on a higher z-index 
than its brother. Change the first base container z-index to 1 and the calendar 
will stop to show behind the container 2.
About the sizing, the Yahoo devs already did their work specifying in the css 
that the table header cell has 2em of width:
.yui-skin-sam .yui-calendar .calweekdaycell {
color: #000;
font-weight: bold;
text-align: center;
width: 2em;
}
not sure what we can do more.

> Datepicker formatting
> -
>
> Key: WICKET-3360
> URL: https://issues.apache.org/jira/browse/WICKET-3360
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-datetime
>Affects Versions: 1.4.15
> Environment: Windows 7, IE 8, Tomcat 6
>Reporter: Peter Diefenthäler
> Attachments: QickStartDatePicker.jpg, QuickStartDatePicker.war
>
>
> The datepicker component often hides behind other html components. Also the 
> sizing is influenced by surronding html tags like tabel and div's.
> I think this issue can be solved by using  tags instead of  tags 
> inside the datepicker. 
> I.e.  switched to http://www.atlassian.com/software/jira


svn commit: r1085497 - in /wicket/common/site/trunk: _posts/2011-03-25-wicket-cookbook-published.md _site/2011/03/25/wicket-cookbook-published.html _site/atom.xml _site/index.html

2011-03-25 Thread ivaynberg
Author: ivaynberg
Date: Fri Mar 25 18:09:10 2011
New Revision: 1085497

URL: http://svn.apache.org/viewvc?rev=1085497&view=rev
Log:
changed book image to one with the shadow

Modified:
wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md
wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html
wicket/common/site/trunk/_site/atom.xml
wicket/common/site/trunk/_site/index.html

Modified: 
wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md?rev=1085497&r1=1085496&r2=1085497&view=diff
==
--- wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md 
(original)
+++ wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md Fri 
Mar 25 18:09:10 2011
@@ -3,7 +3,7 @@ layout: post
 title: Apache Wicket Cookbook Published!
 ---
 
-http://wicket.apache.org/learn/books/awc.jpg"; alt="" 
width="180" height="222" />
+http://wicket.apache.org/learn/books/awc.png"; alt="" 
width="180" height="222" />
 For the past nine months I have been quietly working on a book about Wicket. 
Unlike other books on the market this one does not attempt to teach you Wicket 
from the ground up. Instead, it is for developers who already know the basics 
and want to learn how to implement some of the more advanced use cases. 
Essentially, it contains recipes that show the reader how to implement 
solutions to some of, what I think are, the most commonly asked questions and 
stumbling blocks.
 
 This morning I was informed that the book has been published! You can read 
more about it and pick up a copy on https://www.packtpub.com/apache-wicket-cookbook/book";>PACKT's Site.

Modified: 
wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html?rev=1085497&r1=1085496&r2=1085497&view=diff
==
--- wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html 
(original)
+++ wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html 
Fri Mar 25 18:09:10 2011
@@ -144,7 +144,7 @@
 

Apache Wicket Cookbook Published!
-   
+   
 For the past nine months I have been quietly working on a book about 
Wicket. Unlike other books on the market this one does not attempt to teach you 
Wicket from the ground up. Instead, it is for developers who already know the 
basics and want to learn how to implement some of the more advanced use cases. 
Essentially, it contains recipes that show the reader how to implement 
solutions to some of, what I think are, the most commonly asked questions and 
stumbling blocks.
 
 This morning I was informed that the book has been published! You can read 
more about it and pick up a copy on PACKT's 
Site.

Modified: wicket/common/site/trunk/_site/atom.xml
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/atom.xml?rev=1085497&r1=1085496&r2=1085497&view=diff
==
--- wicket/common/site/trunk/_site/atom.xml (original)
+++ wicket/common/site/trunk/_site/atom.xml Fri Mar 25 18:09:10 2011
@@ -4,7 +4,7 @@
  Apache Wicket
  http://wicket.apache.org/atom.xml"; rel="self"/>
  http://wicket.apache.org/"/>
- 2011-03-25T10:48:03-07:00
+ 2011-03-25T11:08:16-07:00
  http://wicket.apache.org/
  
Apache Wicket
@@ -17,7 +17,7 @@
http://wicket.apache.org/2011/03/25/wicket-cookbook-published.html"/>
2011-03-25T00:00:00-07:00
http://wicket.apache.org/2011/03/25/wicket-cookbook-published
-   
+   
 

For the past nine months I have been quietly working on a book about Wicket. Unlike other books on the market this one does not attempt to teach you Wicket from the ground up. Instead, it is for developers who already know the basics and want to learn how to implement some of the more advanced use cases. Essentially, it contains recipes that show the reader how to implement solutions to some of, what I think are, the most commonly asked questions and stumbling blocks.

This morning I was informed that the book has been published! You can read more about it and pick up a copy on PACKT's Site.

Modified: wicket/common/site/trunk/_site/in

svn commit: r1085489 - in /wicket/common/site/trunk: _site/atom.xml _site/learn/books/awc.html learn/books/awc.md

2011-03-25 Thread ivaynberg
Author: ivaynberg
Date: Fri Mar 25 17:49:22 2011
New Revision: 1085489

URL: http://svn.apache.org/viewvc?rev=1085489&view=rev
Log:
corrected a typo

Modified:
wicket/common/site/trunk/_site/atom.xml
wicket/common/site/trunk/_site/learn/books/awc.html
wicket/common/site/trunk/learn/books/awc.md

Modified: wicket/common/site/trunk/_site/atom.xml
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/atom.xml?rev=1085489&r1=1085488&r2=1085489&view=diff
==
--- wicket/common/site/trunk/_site/atom.xml (original)
+++ wicket/common/site/trunk/_site/atom.xml Fri Mar 25 17:49:22 2011
@@ -4,7 +4,7 @@
  Apache Wicket
  http://wicket.apache.org/atom.xml"; rel="self"/>
  http://wicket.apache.org/"/>
- 2011-03-25T10:39:34-07:00
+ 2011-03-25T10:48:03-07:00
  http://wicket.apache.org/
  
Apache Wicket

Modified: wicket/common/site/trunk/_site/learn/books/awc.html
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/learn/books/awc.html?rev=1085489&r1=1085488&r2=1085489&view=diff
==
--- wicket/common/site/trunk/_site/learn/books/awc.html (original)
+++ wicket/common/site/trunk/_site/learn/books/awc.html Fri Mar 25 17:49:22 2011
@@ -188,7 +188,7 @@
 
 About the author
 
-Igor Vaynberg is a software architect with more than ten years of 
experience in the software field. His liking for computers was sparked when his 
parents got him a Sinclair Z80 when he was but ten years old. Since then he has 
worked with companies both large and small building modular and scalable web 
applications. Igor’s main interest is finding ways to simply the 
development of complex user interfaces required by modern web applications. 
Igor is a committer for the Apache Wicket framework, the aim of which is to 
simply the programming model as well as reintroduce OOP to the web UI tier. In 
his AFK time he enjoys snowboarding with his beautiful wife and playing with 
his amazing children.
+Igor Vaynberg is a software architect with more than ten years of 
experience in the software field. His liking for computers was sparked when his 
parents got him a Sinclair Z80 when he was but ten years old. Since then he has 
worked with companies both large and small building modular and scalable web 
applications. Igor’s main interest is finding ways to simplify the 
development of complex user interfaces required by modern web applications. 
Igor is a committer for the Apache Wicket framework, the aim of which is to 
simplify the programming model as well as reintroduce OOP to the web UI tier. 
In his AFK time he enjoys snowboarding with his beautiful wife and playing with 
his amazing children.
 
 Book details
 

Modified: wicket/common/site/trunk/learn/books/awc.md
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/learn/books/awc.md?rev=1085489&r1=1085488&r2=1085489&view=diff
==
--- wicket/common/site/trunk/learn/books/awc.md (original)
+++ wicket/common/site/trunk/learn/books/awc.md Fri Mar 25 17:49:22 2011
@@ -36,7 +36,7 @@ This book is for current users of the Ap
 
 ## About the author ##
 
-Igor Vaynberg is a software architect with more than ten years of experience 
in the software field. His liking for computers was sparked when his parents 
got him a Sinclair Z80 when he was but ten years old. Since then he has worked 
with companies both large and small building modular and scalable web 
applications. Igor's main interest is finding ways to simply the development of 
complex user interfaces required by modern web applications. Igor is a 
committer for the Apache Wicket framework, the aim of which is to simply the 
programming model as well as reintroduce OOP to the web UI tier. In his AFK 
time he enjoys snowboarding with his beautiful wife and playing with his 
amazing children.
+Igor Vaynberg is a software architect with more than ten years of experience 
in the software field. His liking for computers was sparked when his parents 
got him a Sinclair Z80 when he was but ten years old. Since then he has worked 
with companies both large and small building modular and scalable web 
applications. Igor's main interest is finding ways to simplify the development 
of complex user interfaces required by modern web applications. Igor is a 
committer for the Apache Wicket framework, the aim of which is to simplify the 
programming model as well as reintroduce OOP to the web UI tier. In his AFK 
time he enjoys snowboarding with his beautiful wife and playing with his 
amazing children.
 
 
 ## Book details ##




svn commit: r1085486 - in /wicket/common/site/trunk: _posts/2011-03-25-wicket-cookbook-published.md _site/2011/03/ _site/2011/03/25/ _site/2011/03/25/wicket-cookbook-published.html _site/atom.xml _sit

2011-03-25 Thread ivaynberg
Author: ivaynberg
Date: Fri Mar 25 17:40:40 2011
New Revision: 1085486

URL: http://svn.apache.org/viewvc?rev=1085486&view=rev
Log:
added book announcement

Added:
wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md
wicket/common/site/trunk/_site/2011/03/
wicket/common/site/trunk/_site/2011/03/25/
wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html
Modified:
wicket/common/site/trunk/_site/atom.xml
wicket/common/site/trunk/_site/index.html

Added: wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md?rev=1085486&view=auto
==
--- wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md 
(added)
+++ wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md Fri 
Mar 25 17:40:40 2011
@@ -0,0 +1,14 @@
+---
+layout: post
+title: Apache Wicket Cookbook Published!
+---
+
+http://wicket.apache.org/learn/books/awc.jpg"; alt="" 
width="180" height="222" />
+For the past nine months I have been quietly working on a book about Wicket. 
Unlike other books on the market this one does not attempt to teach you Wicket 
from the ground up. Instead, it is for developers who already know the basics 
and want to learn how to implement some of the more advanced use cases. 
Essentially, it contains recipes that show the reader how to implement 
solutions to some of, what I think are, the most commonly asked questions and 
stumbling blocks.
+
+This morning I was informed that the book has been published! You can read 
more about it and pick up a copy on https://www.packtpub.com/apache-wicket-cookbook/book";>PACKT's Site.
+
+I hope you enjoy it, more details are available on http://wicketinaction.com/2011/03/apache-wicket-cookbook-is-published/";>Wicket
 In Action Blog Post
+
+
+

Added: wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html?rev=1085486&view=auto
==
--- wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html 
(added)
+++ wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html 
Fri Mar 25 17:40:40 2011
@@ -0,0 +1,165 @@
+
+
+
+Apache Wicket - Apache Wicket Cookbook Published!
+
+   
+
+
+
+   
+   
+
+
+
+
+Apache 
Wicket
+   
+   Meet Wicket
+   
+   
+   Home
+   
+   
+   Introduction
+   
+   
+   Features
+   
+   
+   Buzz
+   
+   
+   Vision
+   
+   
+   Blogs
+   
+   
+   
+   Get Started
+   
+   
+   
+   Download Wicket
+   
+   
+   Quickstart
+   
+   
+   http://www.jweekend.com/dev/LegUp"; 
rel="nofollow">More archetypes
+   
+   
+   Get help
+   
+   
+   
+   Learn
+   
+   
+   
+   Examples
+   
+   
+   http://wicketstuff.org/wicket14/compref/";>Components
+   
+   
+   Projects
+   
+   
+   http://cwiki.apache.org/WICKET";>Wiki
+   
+   
+   http://cwiki.apache.org/WICKET/reference-library.html";>Reference guide
+   
+   
+   Books
+   
+   
+   IDE plugins
+   
+   
+   
+   Releases
+   
+   
+   
+   http://www.apache.org/dyn/closer.cgi/wicket/1.4.16";>Wicket 1.4
+   (http://wicket.apache.org/apidocs/1.4"; 
title="JavaDocs of the latest stable release - 1.4.x">docs)
+   
+   
+   http://www.apache.org/dyn/closer.cgi/wicket/1.3.7";>Wicket 1.3
+   (http://wicket.apache.org/apidocs/1.3"; 
title="JavaDocs of Apache Wicket 1.3.x">docs)
+   
+   
+   http://wicket.sf.net/wicket-1.2"; 
class="external-link" rel="nofollow">Wicket 1.2
+   
+   
+   http://wicket.sf.net/wicket-1.1"; 
class="external-link" rel="nofollow">Wicket 1.1
+   
+   
+   http://wicket.sf.ne

svn commit: r1085472 - in /wicket/common/site/trunk: _site/index.html _site/learn/books/awc.png _site/learn/books/index.html index.md learn/books/awc.png learn/books/index.md

2011-03-25 Thread dashorst
Author: dashorst
Date: Fri Mar 25 17:00:35 2011
New Revision: 1085472

URL: http://svn.apache.org/viewvc?rev=1085472&view=rev
Log:
Added better image for Igor's book

Added:
wicket/common/site/trunk/_site/learn/books/awc.png   (with props)
wicket/common/site/trunk/learn/books/awc.png   (with props)
Modified:
wicket/common/site/trunk/_site/index.html
wicket/common/site/trunk/_site/learn/books/index.html
wicket/common/site/trunk/index.md
wicket/common/site/trunk/learn/books/index.md

Modified: wicket/common/site/trunk/_site/index.html
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/index.html?rev=1085472&r1=1085471&r2=1085472&view=diff
==
--- wicket/common/site/trunk/_site/index.html (original)
+++ wicket/common/site/trunk/_site/index.html Fri Mar 25 17:00:35 2011
@@ -166,39 +166,35 @@
 
 Wicket 1.5-rc2 released
 The Wicket Team is proud to introduce the second Release Candidate in 
Wicket 1.5 series. See the changelog for the list of bug fixes and improvements 
done between 1.5-RC1 and 1.5-rc2More detailed migration notes are 
available on our Migrate to 
1.5 Wiki PageRelease Artifacts:
-
-Subversion
 tag
-
+Subversion
 tag
 
-
-Changelog
-
+Changelog
 
-
-To use in Maven:
-
-
-
-Download the full 
distribution (including source)
-
+To use in Maven:
+
+org.apache.wicket
+wicket-core
+1.5-rc2
+
+
+
+Download the full 
distribution (including source)
 
 Wicket 1.4.16 released
 This is sixteenth release of the Wicket 1.4.x series. This is primarily a 
minor bugfix release on the 1.4.x (stable) branch.
-
-Subversion 
tag
-
+Subversion 
tag
 
-
-Changelog
-
+Changelog
 
-
-To use in Maven:
-
-
-
-Download the full distribution 
(including source)
-
+To use in Maven:
+
+org.apache.wicket
+wicket
+1.4.16
+
+
+
+Download the full distribution 
(including source)
 Older news items
 
 
@@ -265,7 +261,7 @@
 Books about Wicket
 
 The following books are published regarding Apache Wicket (click a cover to 
learn more about the book):
-
+

 


Added: wicket/common/site/trunk/_site/learn/books/awc.png
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/learn/books/awc.png?rev=1085472&view=auto
==
Binary file - no diff available.

Propchange: wicket/common/site/trunk/_site/learn/books/awc.png
--
svn:mime-type = application/octet-stream

Modified: wicket/common/site/trunk/_site/learn/books/index.html
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/learn/books/index.html?rev=1085472&r1=1085471&r2=1085472&view=diff
==
--- wicket/common/site/trunk/_site/learn/books/index.html (original)
+++ wicket/common/site/trunk/_site/learn/books/index.html Fri Mar 25 17:00:35 
2011
@@ -145,7 +145,7 @@

Books about Wicket
Several books have been written about Apache Wicket, 
4 in English, 2 in German and 1 in Japanese. Click on a cover to learn more 
about each book.
-
+

 


Modified: wicket/common/site/trunk/index.md
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/index.md?rev=1085472&r1=1085471&r2=1085472&view=diff
==
--- wicket/common/site/trunk/index.md (original)
+++ wicket/common/site/trunk/index.md Fri Mar 25 17:00:35 2011
@@ -38,6 +38,7 @@ Wicket is released under the [Apache Lic
 The following books are published regarding Apache Wicket (click a cover to
 learn more about the book):
 
+
 
 
 

Added: wicket/common/site/trunk/learn/books/awc.png
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/learn/books/awc.png?rev=1085472&view=auto
==
Binary file - no diff available.

Propchange: wicket/common/site/trunk/learn/books/awc.png
--
svn:mime-type = application/octet-stream

Modified: wicket/common/site/trunk/learn/books/index.md
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/learn/books/index.md?rev=1085472&r1=1085471&r2=1085472&view=diff
==
--- wicket/common/site/trunk/learn/books/index.md (original)
+++ wicket/common/site/trunk/learn/books/index.md Fri Mar 25 17:00:35 2011
@@ -6,7 +6,7 @@ title: Books about Wicket
 Several books have been written about Apache Wicket, 4 in English, 2 

svn commit: r1085456 - in /wicket/common/site/trunk: _config.yml _site/atom.xml _site/learn/books/awc.html learn/books/awc.md

2011-03-25 Thread ivaynberg
Author: ivaynberg
Date: Fri Mar 25 16:37:16 2011
New Revision: 1085456

URL: http://svn.apache.org/viewvc?rev=1085456&view=rev
Log:
corrected some marketing speak from PACKT's side

Modified:
wicket/common/site/trunk/_config.yml
wicket/common/site/trunk/_site/atom.xml
wicket/common/site/trunk/_site/learn/books/awc.html
wicket/common/site/trunk/learn/books/awc.md

Modified: wicket/common/site/trunk/_config.yml
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_config.yml?rev=1085456&r1=1085455&r2=1085456&view=diff
==
--- wicket/common/site/trunk/_config.yml (original)
+++ wicket/common/site/trunk/_config.yml Fri Mar 25 16:37:16 2011
@@ -11,7 +11,7 @@ maruku:
   png_dir:images/latex
   png_url:/images/latex
   toc:true
-exclude:readme.md
+exclude:readme.md,tmp,regenerate.sh
 wicket:
 version:1.4.16
 released:   2011-02-25

Modified: wicket/common/site/trunk/_site/atom.xml
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/atom.xml?rev=1085456&r1=1085455&r2=1085456&view=diff
==
--- wicket/common/site/trunk/_site/atom.xml (original)
+++ wicket/common/site/trunk/_site/atom.xml Fri Mar 25 16:37:16 2011
@@ -4,7 +4,7 @@
  Apache Wicket
  http://wicket.apache.org/atom.xml"; rel="self"/>
  http://wicket.apache.org/"/>
- 2011-03-25T08:57:59-07:00
+ 2011-03-25T09:32:57-07:00
  http://wicket.apache.org/
  
Apache Wicket

Modified: wicket/common/site/trunk/_site/learn/books/awc.html
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/learn/books/awc.html?rev=1085456&r1=1085455&r2=1085456&view=diff
==
--- wicket/common/site/trunk/_site/learn/books/awc.html (original)
+++ wicket/common/site/trunk/_site/learn/books/awc.html Fri Mar 25 16:37:16 2011
@@ -152,7 +152,7 @@
 
 You will learn how to integrate with client-side technologies such as 
JavaScript libraries or Flash components, which will help you to build your 
application faster. You will discover how to use Wicket paradigms to factor out 
commonly used code into custom Components, which will reduce the maintenance 
cost of your application, and how to leverage the existing Wicket Components to 
make your own code simpler.
 
-A straightforward Cookbook with over 75 highly focused practical recipes to 
make your web application development easier with the Wicket web framework
+A straightforward Cookbook with highly focused practical recipes to make 
your web application development easier with the Wicket web framework
 
 What you will learn from this 
book
 

Modified: wicket/common/site/trunk/learn/books/awc.md
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/learn/books/awc.md?rev=1085456&r1=1085455&r2=1085456&view=diff
==
--- wicket/common/site/trunk/learn/books/awc.md (original)
+++ wicket/common/site/trunk/learn/books/awc.md Fri Mar 25 16:37:16 2011
@@ -11,7 +11,7 @@ Apache Wicket Cookbook provides you with
 
 You will learn how to integrate with client-side technologies such as 
JavaScript libraries or Flash components, which will help you to build your 
application faster. You will discover how to use Wicket paradigms to factor out 
commonly used code into custom Components, which will reduce the maintenance 
cost of your application, and how to leverage the existing Wicket Components to 
make your own code simpler.
 
-A straightforward Cookbook with over 75 highly focused practical recipes to 
make your web application development easier with the Wicket web framework
+A straightforward Cookbook with highly focused practical recipes to make your 
web application development easier with the Wicket web framework
 
 ## What you will learn from this book ##
 




svn commit: r1085441 - in /wicket/common/site/trunk/_site/learn/books: awc.html awc.jpg

2011-03-25 Thread ivaynberg
Author: ivaynberg
Date: Fri Mar 25 16:03:26 2011
New Revision: 1085441

URL: http://svn.apache.org/viewvc?rev=1085441&view=rev
Log:
generated Apache Wicket Cookbook files

Added:
wicket/common/site/trunk/_site/learn/books/awc.html
wicket/common/site/trunk/_site/learn/books/awc.jpg   (with props)

Added: wicket/common/site/trunk/_site/learn/books/awc.html
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/learn/books/awc.html?rev=1085441&view=auto
==
--- wicket/common/site/trunk/_site/learn/books/awc.html (added)
+++ wicket/common/site/trunk/_site/learn/books/awc.html Fri Mar 25 16:03:26 2011
@@ -0,0 +1,248 @@
+
+
+
+Apache Wicket - Books — Apache Wicket Cookbook
+
+   
+
+
+
+   
+   
+
+
+
+
+Apache 
Wicket
+   
+   Meet Wicket
+   
+   
+   Home
+   
+   
+   Introduction
+   
+   
+   Features
+   
+   
+   Buzz
+   
+   
+   Vision
+   
+   
+   Blogs
+   
+   
+   
+   Get Started
+   
+   
+   
+   Download Wicket
+   
+   
+   Quickstart
+   
+   
+   http://www.jweekend.com/dev/LegUp"; 
rel="nofollow">More archetypes
+   
+   
+   Get help
+   
+   
+   
+   Learn
+   
+   
+   
+   Examples
+   
+   
+   http://wicketstuff.org/wicket14/compref/";>Components
+   
+   
+   Projects
+   
+   
+   http://cwiki.apache.org/WICKET";>Wiki
+   
+   
+   http://cwiki.apache.org/WICKET/reference-library.html";>Reference guide
+   
+   
+   Books
+   
+   
+   IDE plugins
+   
+   
+   
+   Releases
+   
+   
+   
+   http://www.apache.org/dyn/closer.cgi/wicket/1.4.16";>Wicket 1.4
+   (http://wicket.apache.org/apidocs/1.4"; 
title="JavaDocs of the latest stable release - 1.4.x">docs)
+   
+   
+   http://www.apache.org/dyn/closer.cgi/wicket/1.3.7";>Wicket 1.3
+   (http://wicket.apache.org/apidocs/1.3"; 
title="JavaDocs of Apache Wicket 1.3.x">docs)
+   
+   
+   http://wicket.sf.net/wicket-1.2"; 
class="external-link" rel="nofollow">Wicket 1.2
+   
+   
+   http://wicket.sf.net/wicket-1.1"; 
class="external-link" rel="nofollow">Wicket 1.1
+   
+   
+   http://wicket.sf.net/wicket-1.0"; 
class="external-link" rel="nofollow">Wicket 1.0
+   
+   
+   
+   Contribute
+   
+   
+   
+   Writing docs
+   
+   
+   Build Wicket
+   
+   
+   Provide a patch
+   
+   
+   Release Wicket
+   
+   
+   http://fisheye6.atlassian.com/browse/wicket"; 
title="SVN Overview" class="external-link" rel="nofollow">Fisheye
+   
+   
+   
+   Apache
+   
+   
+   
+   http://www.apache.org/"; class="external-link" 
rel="nofollow">Apache
+   
+   
+   http://www.apache.org/licenses/"; 
class="external-link" rel="nofollow">License
+   
+   
+   http://www.apache.org/foundation/sponsorship.html"; class="external-link" 
rel="nofollow">Sponsorship
+   
+   
+   http://apache.org/foundation/thanks.html"; 
class="external-link" rel="nofollow">Thanks
+   
+   
+
+
+   
+   Books — Apache Wicket Cookbook
+   Description
+
+Apache Wicket is one of the most famous Java web application frameworks. 
Wicket simplifies web development and makes it fun. Are you bored of going 
through countless pages of theory to find out how to get your web development 
done? With this book in hand, you don’t need to go through hundreds of 
pages to figure out how you will actually build a web application. You will get 
practical soluti

svn commit: r1085437 [3/3] - in /wicket/common/site/trunk: _site/ _site/2009/07/30/ _site/2009/08/21/ _site/2009/10/12/ _site/2009/10/24/ _site/2009/12/13/ _site/2009/12/21/ _site/2010/02/01/ _site/20

2011-03-25 Thread ivaynberg
Modified: wicket/common/site/trunk/_site/learn/examples/navomatic.html
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/learn/examples/navomatic.html?rev=1085437&r1=1085436&r2=1085437&view=diff
==
--- wicket/common/site/trunk/_site/learn/examples/navomatic.html (original)
+++ wicket/common/site/trunk/_site/learn/examples/navomatic.html Fri Mar 25 
16:00:25 2011
@@ -171,148 +171,37 @@
 For example, here is markup for a simple Border subclass, a usage of that 
border, and the markup which would be output on rendering:
 
 Border markup
-
-
-
-First  Last
-
-
-
-
-
+
 Border usage
-
-
-  
-  Middle
-  
-
-
-
-
+
 Rendered markup
-
-
-  First Middle Last
-
-
-
-
+
 In other words, the markup around the  tag 
in the border component is sort of “wrapped around” the body of the 
 tag where the border is used. This seems simple in 
this example, but keep in mind that nested components and even nested borders 
can appear anywhere in either markup file. This can be used to create quite 
complex effects with relatively little code.
 
 NavomaticApplication.java
 
 Just as in the Hello World! example, we need to define our application. In 
this case, we set Page1 to be our home page.
-package 
org.apache.wicket.examples.navomatic;
 
-import org.apache.wicket.protocol.http.WebApplication;
-
-public class NavomaticApplication extends WebApplication {
-public NavomaticApplication() {
-}
-   
-public Class getHomePage() {
-return Page1.class;
-}
-}
-
-
 Page1.java
 
 The Page1 Java and HTML files look like this:
-package 
wicket.examples.navomatic;
-
-import org.apache.wicket.markup.html.WebPage;
 
-public class Page1 extends WebPage {
-public Page1() {
-add(new NavomaticBorder("navomaticBorder"));
-}
-}
-
-
 Page1.html
-
- 
-
-You are viewing Page1
-
-
-
-
-
+
 Notice that the NavomaticBorder component is attached to the 
 tag because the name of the component in the Java 
code is “navomaticBorder” and the  
tag’s wicket:id attribute is set to “navomaticBorder”. 
Because the two names match, Wicket associates the NavomaticBorder Java 
component with the  tag.
 
 Page2.java
 
 The Page2 Java and HTML files look almost identical (and we’ll omit 
the sources for Page3 altogether because it follows the same pattern):
-public 
class Page2 extends WebPage {
-public Page2() {
-add(new NavomaticBorder("navomaticBorder"));
-}
-}
-
-
+
 Page2.html
-
-
-
-You are viewing Page2
-
-
-
-
-
+
 NavomaticBorder.java
 
 So how does NavomaticBorder work? Glad you asked. The Java code below 
simply adds the two BoxBorder components you see. These components are nested 
borders which each draw a thin black line around their contents. The rest of 
the magic is in the NavomaticBorder markup.
-package 
wicket.examples.navomatic;
 
-import org.apache.wicket.markup.html.border.Border;
-import org.apache.wicket.markup.html.border.BoxBorder;
-
-public class NavomaticBorder extends Border {
-public NavomaticBorder(final String componentName) {
-super(componentName);
-
-add(new BoxBorder("navigationBorder"));
-add(new BoxBorder("bodyBorder"));
-}
-}
-
-
 NavomaticBorder.html
-
-
- 
-

-

- - - - -
- - Navigation Links -

- - Page1
- Page2
- Page3 -
-

-
-
- - - -
-

-
- - - - + Notice that the markup above encloses the entire contents of the markup file’s with a tag, as we described earlier. This lets the NavomaticBorder know how much of its markup to use when it wraps itself around the markup it finds in the context where it is used. Notice also the marker which designates where to put whatever is found inside the tag at the use context. Next, notice that the navigation links and the border’s

[jira] [Commented] (WICKET-3558) Expose active requests via JMX

2011-03-25 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011231#comment-13011231
 ] 

Martin Grigorov commented on WICKET-3558:
-

Provide a patch please.
Thanks!

> Expose active requests via JMX
> --
>
> Key: WICKET-3558
> URL: https://issues.apache.org/jira/browse/WICKET-3558
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket-jmx
>Affects Versions: 1.4.16
>Reporter: Dominik Drzewiecki
>Priority: Minor
> Attachments: exposeActiveViaJMX.patch
>
>
> It'd be nice if RequestLogger.active was exposed via JMX in the same manner 
> the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and 
> expose the peak number of concurrent (active) requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (WICKET-3558) Expose active requests via JMX

2011-03-25 Thread Dominik Drzewiecki (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Drzewiecki updated WICKET-3558:
---

Attachment: exposeActiveViaJMX.patch

> Expose active requests via JMX
> --
>
> Key: WICKET-3558
> URL: https://issues.apache.org/jira/browse/WICKET-3558
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket-jmx
>Affects Versions: 1.4.16
>Reporter: Dominik Drzewiecki
>Priority: Minor
> Attachments: exposeActiveViaJMX.patch
>
>
> It'd be nice if RequestLogger.active was exposed via JMX in the same manner 
> the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and 
> expose the peak number of concurrent (active) requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (WICKET-3558) Expose active requests via JMX

2011-03-25 Thread Dominik Drzewiecki (JIRA)
Expose active requests via JMX
--

 Key: WICKET-3558
 URL: https://issues.apache.org/jira/browse/WICKET-3558
 Project: Wicket
  Issue Type: Improvement
  Components: wicket-jmx
Affects Versions: 1.4.16
Reporter: Dominik Drzewiecki
Priority: Minor


It'd be nice if RequestLogger.active was exposed via JMX in the same manner the 
RequestLogger.liveSessions.size() is. Moreover it'd be great to track and 
expose the peak number of concurrent (active) requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (WICKET-3557) Can not add validator to AjaxEditableLabel unless it was added to page

2011-03-25 Thread Erik van Oosten (JIRA)
Can not add validator to AjaxEditableLabel unless it was added to page
--

 Key: WICKET-3557
 URL: https://issues.apache.org/jira/browse/WICKET-3557
 Project: Wicket
  Issue Type: Bug
  Components: wicket-extensions
Reporter: Erik van Oosten
Priority: Minor


Method AjaxEditableLabel#add(IValidator) tries to add the validator to the 
editor. As the editor initiaily does not exist, it is created. Creation of the 
editor fails when the component has not been added to the page yet.

Workaround: add the AjaxEditableLabel to page before adding the validator(s).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


svn commit: r1085272 - in /wicket/trunk/wicket-core/src: main/java/org/apache/wicket/markup/ test/java/org/apache/wicket/markup/html/basic/ test/java/org/apache/wicket/markup/html/page/

2011-03-25 Thread jdonnerstag
Author: jdonnerstag
Date: Fri Mar 25 07:48:41 2011
New Revision: 1085272

URL: http://svn.apache.org/viewvc?rev=1085272&view=rev
Log:
rename Markup.get(String) to .of(String)

Modified:

wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/IMarkupResourceStreamProvider.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/Markup.java

wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimplePage_3.java

wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/page/SimplePanel.java

Modified: 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/IMarkupResourceStreamProvider.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/IMarkupResourceStreamProvider.java?rev=1085272&r1=1085271&r2=1085272&view=diff
==
--- 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/IMarkupResourceStreamProvider.java
 (original)
+++ 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/IMarkupResourceStreamProvider.java
 Fri Mar 25 07:48:41 2011
@@ -23,6 +23,9 @@ import org.apache.wicket.util.resource.I
  * To be implemented by MarkupContainer which wish to implement their own 
algorithms for loading the
  * markup resource stream.
  * 
+ * Since 1.5 you may also use Component.setMarkup() or getMarkup() to attach 
Markup to your
+ * component.
+ * 
  * Note: IResourceStreamLocators should be used in case the strategy to find a 
markup resource is
  * meant to be applied to ALL components of your application.
  * 

Modified: 
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/Markup.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/Markup.java?rev=1085272&r1=1085271&r2=1085272&view=diff
==
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/Markup.java 
(original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/Markup.java 
Fri Mar 25 07:48:41 2011
@@ -55,10 +55,15 @@ public class Markup implements IMarkupFr
 
/**
 * Take the markup string, parse it and return the Markup (list of 
MarkupElements).
+* 
+* Limitation: Please note that MarkupFactory is NOT used and thus no 
caching is used (which
+* doesn't matter for Strings anyway), but what might matter is that 
your own MarkupFilters are
+* not applied, which you might have registered with MarkupFactory.
+* 
 * @param markup
 * @return Markup
 */
-   public static Markup get(final String markup)
+   public static Markup of(final String markup)
{
try
{

Modified: 
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimplePage_3.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimplePage_3.java?rev=1085272&r1=1085271&r2=1085272&view=diff
==
--- 
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimplePage_3.java
 (original)
+++ 
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimplePage_3.java
 Fri Mar 25 07:48:41 2011
@@ -47,7 +47,7 @@ public class SimplePage_3 extends Simple
@Override
public IMarkupFragment getMarkup()
{
-   return Markup.get("" //
+   return Markup.of("" //
+ "mein Label" //
+ "body" //
+ "panel" //

Modified: 
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/page/SimplePanel.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/page/SimplePanel.java?rev=1085272&r1=1085271&r2=1085272&view=diff
==
--- 
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/page/SimplePanel.java
 (original)
+++ 
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/page/SimplePanel.java
 Fri Mar 25 07:48:41 2011
@@ -44,6 +44,6 @@ public class SimplePanel extends Panel
@Override
public IMarkupFragment getMarkup()
{
-   return Markup.get("");
+   return Markup.of("");
}
 }