[jira] [Commented] (WICKET-4881) IE 8 : error when handling Wicket Ajax Response
[
https://issues.apache.org/jira/browse/WICKET-4881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503663#comment-13503663
]
Frédéric Donckels commented on WICKET-4881:
---
I downloaded your project and reproduced the issue.
See here: http://www.screenr.com/GbU7
(sorry about the sound, I turned the microphone off, but that didn't prevent it
from recording some noise)
IE 8 : error when handling Wicket Ajax Response
---
Key: WICKET-4881
URL: https://issues.apache.org/jira/browse/WICKET-4881
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.2.0, 6.3.0
Environment: Internet Explorer 8, Windows 7 64 bits
Reporter: Frédéric Donckels
Attachments: wicket_bug_report.7z, wicket_bug_report.zip
I have a problem with Wicket 6.2.0/6.3.0 and IE (this works perfectly with
Chrome or Firefox). I have a list of items, with Ajax links in the list. The
response to the Ajax link modifies a panel from the page, and redraws the
list (its container).
IE does at least some of the changes correctly, but outputs an error, and it
seems that subsequent Ajax request fail:
(... some UI code ...)
(... Jquery and Wicket ajax references ...)
script type=text/javascript id=wicket-ajax-base-url
/*![CDATA[*/
Wicket.Ajax.baseUrl=other/bictables/list;
/*]^]^*/
/script
/head]]/header-contributionevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-AMEND,e:click,c:AMENDea});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-RETURN,e:click,c:RETURNec});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-view,e:click,c:viewf2});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-edit,e:click,c:editf3});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-reorder-down,e:click,c:downf4});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-view,e:click,c:viewf5});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-edit,e:click,c:editf6});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-up,e:click,c:upf7});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-down,e:click,c:downf8});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-view,e:click,c:viewf9});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-edit,e:click,c:editfa});]]
(... lots of similar code from the table ...)
evaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-actions-edit,e:click,c:edit136});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-reorder-up,e:click,c:up137});]]/evaluate/ajax-response
INFO: returned focused element:
http://localhost:8080/payments/app/other/bictables/list?3#
INFO: returned focused element: null
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript:
[object Error], text:
Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-view,e:click,c:view10d});
ERROR: FunctionsExecuter.processNext: [object Error]
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating
javascript: [object Error], text:
Wicket.Ajax.ajax({u:./list?2-4.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-
view,e:click,c:view2cb});
ERROR: FunctionsExecuter.processNext: [object Error]
all subsequent Ajax requests lead to :
INFO: Channel '0' is busy - scheduling the callback to be executed when the
previous request finish
Is this a bug in Wicket, in IE? Any way to circumvent it if it's in IE?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (WICKET-4881) IE 8 : error when handling Wicket Ajax Response
[
https://issues.apache.org/jira/browse/WICKET-4881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503663#comment-13503663
]
Frédéric Donckels edited comment on WICKET-4881 at 11/26/12 8:22 AM:
-
I downloaded your project and reproduced the issue (using mvn jetty:run).
See here: http://www.screenr.com/GbU7
(sorry about the sound, I turned the microphone off, but that didn't prevent it
from recording some noise)
was (Author: fdonckels):
I downloaded your project and reproduced the issue.
See here: http://www.screenr.com/GbU7
(sorry about the sound, I turned the microphone off, but that didn't prevent it
from recording some noise)
IE 8 : error when handling Wicket Ajax Response
---
Key: WICKET-4881
URL: https://issues.apache.org/jira/browse/WICKET-4881
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.2.0, 6.3.0
Environment: Internet Explorer 8, Windows 7 64 bits
Reporter: Frédéric Donckels
Attachments: wicket_bug_report.7z, wicket_bug_report.zip
I have a problem with Wicket 6.2.0/6.3.0 and IE (this works perfectly with
Chrome or Firefox). I have a list of items, with Ajax links in the list. The
response to the Ajax link modifies a panel from the page, and redraws the
list (its container).
IE does at least some of the changes correctly, but outputs an error, and it
seems that subsequent Ajax request fail:
(... some UI code ...)
(... Jquery and Wicket ajax references ...)
script type=text/javascript id=wicket-ajax-base-url
/*![CDATA[*/
Wicket.Ajax.baseUrl=other/bictables/list;
/*]^]^*/
/script
/head]]/header-contributionevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-AMEND,e:click,c:AMENDea});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-RETURN,e:click,c:RETURNec});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-view,e:click,c:viewf2});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-edit,e:click,c:editf3});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-reorder-down,e:click,c:downf4});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-view,e:click,c:viewf5});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-edit,e:click,c:editf6});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-up,e:click,c:upf7});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-down,e:click,c:downf8});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-view,e:click,c:viewf9});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-edit,e:click,c:editfa});]]
(... lots of similar code from the table ...)
evaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-actions-edit,e:click,c:edit136});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-reorder-up,e:click,c:up137});]]/evaluate/ajax-response
INFO: returned focused element:
http://localhost:8080/payments/app/other/bictables/list?3#
INFO: returned focused element: null
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript:
[object Error], text:
Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-view,e:click,c:view10d});
ERROR: FunctionsExecuter.processNext: [object Error]
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating
javascript: [object Error], text:
Wicket.Ajax.ajax({u:./list?2-4.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-
view,e:click,c:view2cb});
ERROR: FunctionsExecuter.processNext: [object Error]
all subsequent Ajax requests lead to :
INFO: Channel '0' is busy - scheduling the callback to be executed when the
previous request finish
Is this a bug in Wicket, in IE? Any way to circumvent it if it's in IE?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4881) IE 8 : error when handling Wicket Ajax Response
[
https://issues.apache.org/jira/browse/WICKET-4881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503684#comment-13503684
]
Martin Grigorov commented on WICKET-4881:
-
I cannot reproduce the problem here as well.
I use IE9 in compatibility modes and it didn't break with any of them. I cannot
install IE8 here.
The source code of the demo application is too big to make a full code review.
A brief look at it didn't show anything suspicious.
IE 8 : error when handling Wicket Ajax Response
---
Key: WICKET-4881
URL: https://issues.apache.org/jira/browse/WICKET-4881
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.2.0, 6.3.0
Environment: Internet Explorer 8, Windows 7 64 bits
Reporter: Frédéric Donckels
Attachments: wicket_bug_report.7z, wicket_bug_report.zip
I have a problem with Wicket 6.2.0/6.3.0 and IE (this works perfectly with
Chrome or Firefox). I have a list of items, with Ajax links in the list. The
response to the Ajax link modifies a panel from the page, and redraws the
list (its container).
IE does at least some of the changes correctly, but outputs an error, and it
seems that subsequent Ajax request fail:
(... some UI code ...)
(... Jquery and Wicket ajax references ...)
script type=text/javascript id=wicket-ajax-base-url
/*![CDATA[*/
Wicket.Ajax.baseUrl=other/bictables/list;
/*]^]^*/
/script
/head]]/header-contributionevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-AMEND,e:click,c:AMENDea});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-RETURN,e:click,c:RETURNec});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-view,e:click,c:viewf2});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-edit,e:click,c:editf3});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-reorder-down,e:click,c:downf4});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-view,e:click,c:viewf5});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-edit,e:click,c:editf6});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-up,e:click,c:upf7});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-down,e:click,c:downf8});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-view,e:click,c:viewf9});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-edit,e:click,c:editfa});]]
(... lots of similar code from the table ...)
evaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-actions-edit,e:click,c:edit136});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-reorder-up,e:click,c:up137});]]/evaluate/ajax-response
INFO: returned focused element:
http://localhost:8080/payments/app/other/bictables/list?3#
INFO: returned focused element: null
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript:
[object Error], text:
Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-view,e:click,c:view10d});
ERROR: FunctionsExecuter.processNext: [object Error]
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating
javascript: [object Error], text:
Wicket.Ajax.ajax({u:./list?2-4.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-
view,e:click,c:view2cb});
ERROR: FunctionsExecuter.processNext: [object Error]
all subsequent Ajax requests lead to :
INFO: Channel '0' is busy - scheduling the callback to be executed when the
previous request finish
Is this a bug in Wicket, in IE? Any way to circumvent it if it's in IE?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: WICKET-4888 introduce FencedFeedbackPanel
Updated Branches:
refs/heads/master a0b2dd194 - e8db4bbfb
WICKET-4888 introduce FencedFeedbackPanel
Make the metadata key final.
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e8db4bbf
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e8db4bbf
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e8db4bbf
Branch: refs/heads/master
Commit: e8db4bbfb64443252ec2906d308f0df80b54286e
Parents: a0b2dd1
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Mon Nov 26 10:12:16 2012 +0100
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Mon Nov 26 10:12:16 2012 +0100
--
.../wicket/feedback/FencedFeedbackPanel.java |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/e8db4bbf/wicket-core/src/main/java/org/apache/wicket/feedback/FencedFeedbackPanel.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/feedback/FencedFeedbackPanel.java
b/wicket-core/src/main/java/org/apache/wicket/feedback/FencedFeedbackPanel.java
index c39250a..9b60ea1 100644
---
a/wicket-core/src/main/java/org/apache/wicket/feedback/FencedFeedbackPanel.java
+++
b/wicket-core/src/main/java/org/apache/wicket/feedback/FencedFeedbackPanel.java
@@ -79,7 +79,7 @@ public class FencedFeedbackPanel extends FeedbackPanel
{
private static final long serialVersionUID = 1L;
- private static MetaDataKeyInteger FENCE_KEY = new
MetaDataKeyInteger()
+ private static final MetaDataKeyInteger FENCE_KEY = new
MetaDataKeyInteger()
{
private static final long serialVersionUID = 1L;
};
[jira] [Commented] (WICKET-4881) IE 8 : error when handling Wicket Ajax Response
[
https://issues.apache.org/jira/browse/WICKET-4881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503705#comment-13503705
]
Andrea Del Bene commented on WICKET-4881:
-
I suspect you may have a more general problem with AJAX and IE. Does the rest
of the application work fine with AJAX? Does data pagination return any error?
IE 8 : error when handling Wicket Ajax Response
---
Key: WICKET-4881
URL: https://issues.apache.org/jira/browse/WICKET-4881
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.2.0, 6.3.0
Environment: Internet Explorer 8, Windows 7 64 bits
Reporter: Frédéric Donckels
Attachments: wicket_bug_report.7z, wicket_bug_report.zip
I have a problem with Wicket 6.2.0/6.3.0 and IE (this works perfectly with
Chrome or Firefox). I have a list of items, with Ajax links in the list. The
response to the Ajax link modifies a panel from the page, and redraws the
list (its container).
IE does at least some of the changes correctly, but outputs an error, and it
seems that subsequent Ajax request fail:
(... some UI code ...)
(... Jquery and Wicket ajax references ...)
script type=text/javascript id=wicket-ajax-base-url
/*![CDATA[*/
Wicket.Ajax.baseUrl=other/bictables/list;
/*]^]^*/
/script
/head]]/header-contributionevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-AMEND,e:click,c:AMENDea});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-RETURN,e:click,c:RETURNec});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-view,e:click,c:viewf2});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-edit,e:click,c:editf3});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-reorder-down,e:click,c:downf4});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-view,e:click,c:viewf5});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-edit,e:click,c:editf6});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-up,e:click,c:upf7});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-down,e:click,c:downf8});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-view,e:click,c:viewf9});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-edit,e:click,c:editfa});]]
(... lots of similar code from the table ...)
evaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-actions-edit,e:click,c:edit136});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-reorder-up,e:click,c:up137});]]/evaluate/ajax-response
INFO: returned focused element:
http://localhost:8080/payments/app/other/bictables/list?3#
INFO: returned focused element: null
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript:
[object Error], text:
Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-view,e:click,c:view10d});
ERROR: FunctionsExecuter.processNext: [object Error]
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating
javascript: [object Error], text:
Wicket.Ajax.ajax({u:./list?2-4.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-
view,e:click,c:view2cb});
ERROR: FunctionsExecuter.processNext: [object Error]
all subsequent Ajax requests lead to :
INFO: Channel '0' is busy - scheduling the callback to be executed when the
previous request finish
Is this a bug in Wicket, in IE? Any way to circumvent it if it's in IE?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-4889) Label constructor should accept Serializable as label
Emond Papegaaij created WICKET-4889: --- Summary: Label constructor should accept Serializable as label Key: WICKET-4889 URL: https://issues.apache.org/jira/browse/WICKET-4889 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.3.0 Reporter: Emond Papegaaij Assignee: Emond Papegaaij The fixed-label constructor of Label current only accepts strings, which is very limited. Label has no problems in rendering other serializable fixed values through the use of converters. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4881) IE 8 : error when handling Wicket Ajax Response
[
https://issues.apache.org/jira/browse/WICKET-4881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503749#comment-13503749
]
Frédéric Donckels commented on WICKET-4881:
---
Copy-pasted from the ##wicket IRC channel :
inside the catch block of FunctionsExecuter, the exception message is Out of
stack space
depth is 41 / current is 41
of course , I have no idea how this is supposed to work...
the call stack is just a pretty large bunch of anonymous JScript functions
actually, the issue happens in the processEvaluation function, of
Wicket.Ajax.Call when calling eval on the Javascript provided in the Ajax
response
It's odd though: if I change the number of items per page in the pagination,
everything is ok until itemsPerPage = 8 (lower is ok)
IE 8 : error when handling Wicket Ajax Response
---
Key: WICKET-4881
URL: https://issues.apache.org/jira/browse/WICKET-4881
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.2.0, 6.3.0
Environment: Internet Explorer 8, Windows 7 64 bits
Reporter: Frédéric Donckels
Attachments: wicket_bug_report.7z, wicket_bug_report.zip
I have a problem with Wicket 6.2.0/6.3.0 and IE (this works perfectly with
Chrome or Firefox). I have a list of items, with Ajax links in the list. The
response to the Ajax link modifies a panel from the page, and redraws the
list (its container).
IE does at least some of the changes correctly, but outputs an error, and it
seems that subsequent Ajax request fail:
(... some UI code ...)
(... Jquery and Wicket ajax references ...)
script type=text/javascript id=wicket-ajax-base-url
/*![CDATA[*/
Wicket.Ajax.baseUrl=other/bictables/list;
/*]^]^*/
/script
/head]]/header-contributionevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-AMEND,e:click,c:AMENDea});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-RETURN,e:click,c:RETURNec});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-view,e:click,c:viewf2});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-edit,e:click,c:editf3});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-reorder-down,e:click,c:downf4});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-view,e:click,c:viewf5});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-edit,e:click,c:editf6});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-up,e:click,c:upf7});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-down,e:click,c:downf8});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-view,e:click,c:viewf9});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-edit,e:click,c:editfa});]]
(... lots of similar code from the table ...)
evaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-actions-edit,e:click,c:edit136});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-reorder-up,e:click,c:up137});]]/evaluate/ajax-response
INFO: returned focused element:
http://localhost:8080/payments/app/other/bictables/list?3#
INFO: returned focused element: null
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript:
[object Error], text:
Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-view,e:click,c:view10d});
ERROR: FunctionsExecuter.processNext: [object Error]
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating
javascript: [object Error], text:
Wicket.Ajax.ajax({u:./list?2-4.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-
view,e:click,c:view2cb});
ERROR: FunctionsExecuter.processNext: [object Error]
all subsequent Ajax requests lead to :
INFO: Channel '0' is busy - scheduling the callback to be executed when the
previous request finish
Is this a bug in Wicket, in IE? Any way to circumvent it if it's in IE?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4881) IE 8 : error when handling Wicket Ajax Response
[
https://issues.apache.org/jira/browse/WICKET-4881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503751#comment-13503751
]
Martin Grigorov commented on WICKET-4881:
-
Can you try the JavaScript from this comment
https://issues.apache.org/jira/browse/WICKET-4675?focusedCommentId=13426609page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13426609
in your IE8 instance ?
What is the number that it gives ?
IE 8 : error when handling Wicket Ajax Response
---
Key: WICKET-4881
URL: https://issues.apache.org/jira/browse/WICKET-4881
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.2.0, 6.3.0
Environment: Internet Explorer 8, Windows 7 64 bits
Reporter: Frédéric Donckels
Attachments: wicket_bug_report.7z, wicket_bug_report.zip
I have a problem with Wicket 6.2.0/6.3.0 and IE (this works perfectly with
Chrome or Firefox). I have a list of items, with Ajax links in the list. The
response to the Ajax link modifies a panel from the page, and redraws the
list (its container).
IE does at least some of the changes correctly, but outputs an error, and it
seems that subsequent Ajax request fail:
(... some UI code ...)
(... Jquery and Wicket ajax references ...)
script type=text/javascript id=wicket-ajax-base-url
/*![CDATA[*/
Wicket.Ajax.baseUrl=other/bictables/list;
/*]^]^*/
/script
/head]]/header-contributionevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-AMEND,e:click,c:AMENDea});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-RETURN,e:click,c:RETURNec});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-view,e:click,c:viewf2});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-edit,e:click,c:editf3});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-reorder-down,e:click,c:downf4});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-view,e:click,c:viewf5});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-edit,e:click,c:editf6});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-up,e:click,c:upf7});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-down,e:click,c:downf8});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-view,e:click,c:viewf9});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-edit,e:click,c:editfa});]]
(... lots of similar code from the table ...)
evaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-actions-edit,e:click,c:edit136});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-reorder-up,e:click,c:up137});]]/evaluate/ajax-response
INFO: returned focused element:
http://localhost:8080/payments/app/other/bictables/list?3#
INFO: returned focused element: null
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript:
[object Error], text:
Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-view,e:click,c:view10d});
ERROR: FunctionsExecuter.processNext: [object Error]
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating
javascript: [object Error], text:
Wicket.Ajax.ajax({u:./list?2-4.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-
view,e:click,c:view2cb});
ERROR: FunctionsExecuter.processNext: [object Error]
all subsequent Ajax requests lead to :
INFO: Channel '0' is busy - scheduling the callback to be executed when the
previous request finish
Is this a bug in Wicket, in IE? Any way to circumvent it if it's in IE?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4881) IE 8 : error when handling Wicket Ajax Response
[
https://issues.apache.org/jira/browse/WICKET-4881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503753#comment-13503753
]
Frédéric Donckels commented on WICKET-4881:
---
LOG: 272 and then it outputs Out of memory (which is pretty odd and a
different message). That seems quite low to run out of stack space in a Win7 64
bit environment and 8gb of memory...
IE 8 : error when handling Wicket Ajax Response
---
Key: WICKET-4881
URL: https://issues.apache.org/jira/browse/WICKET-4881
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.2.0, 6.3.0
Environment: Internet Explorer 8, Windows 7 64 bits
Reporter: Frédéric Donckels
Attachments: wicket_bug_report.7z, wicket_bug_report.zip
I have a problem with Wicket 6.2.0/6.3.0 and IE (this works perfectly with
Chrome or Firefox). I have a list of items, with Ajax links in the list. The
response to the Ajax link modifies a panel from the page, and redraws the
list (its container).
IE does at least some of the changes correctly, but outputs an error, and it
seems that subsequent Ajax request fail:
(... some UI code ...)
(... Jquery and Wicket ajax references ...)
script type=text/javascript id=wicket-ajax-base-url
/*![CDATA[*/
Wicket.Ajax.baseUrl=other/bictables/list;
/*]^]^*/
/script
/head]]/header-contributionevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-AMEND,e:click,c:AMENDea});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-RETURN,e:click,c:RETURNec});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-view,e:click,c:viewf2});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-edit,e:click,c:editf3});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-reorder-down,e:click,c:downf4});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-view,e:click,c:viewf5});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-edit,e:click,c:editf6});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-up,e:click,c:upf7});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-down,e:click,c:downf8});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-view,e:click,c:viewf9});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-edit,e:click,c:editfa});]]
(... lots of similar code from the table ...)
evaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-actions-edit,e:click,c:edit136});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-reorder-up,e:click,c:up137});]]/evaluate/ajax-response
INFO: returned focused element:
http://localhost:8080/payments/app/other/bictables/list?3#
INFO: returned focused element: null
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript:
[object Error], text:
Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-view,e:click,c:view10d});
ERROR: FunctionsExecuter.processNext: [object Error]
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating
javascript: [object Error], text:
Wicket.Ajax.ajax({u:./list?2-4.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-
view,e:click,c:view2cb});
ERROR: FunctionsExecuter.processNext: [object Error]
all subsequent Ajax requests lead to :
INFO: Channel '0' is busy - scheduling the callback to be executed when the
previous request finish
Is this a bug in Wicket, in IE? Any way to circumvent it if it's in IE?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4881) IE 8 : error when handling Wicket Ajax Response
[
https://issues.apache.org/jira/browse/WICKET-4881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503757#comment-13503757
]
Martin Grigorov commented on WICKET-4881:
-
Each browser has different capabilities.
See
http://stackoverflow.com/questions/7826992/browser-javascript-stack-size-limit
It depends on how much memory you use in each stack frame.
The test that you ran is very simple and I'm not sure why 272 is the max for
you. It could be some configuration property of IE ...
The only solution that I see is to use setTimeout() when the depth is lower.
The current threshold is 1000 recursive calls. Pre-Wicket-4675 it was 50. But
it fails for you at 41 which indeed is very low.
IE 8 : error when handling Wicket Ajax Response
---
Key: WICKET-4881
URL: https://issues.apache.org/jira/browse/WICKET-4881
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.2.0, 6.3.0
Environment: Internet Explorer 8, Windows 7 64 bits
Reporter: Frédéric Donckels
Attachments: wicket_bug_report.7z, wicket_bug_report.zip
I have a problem with Wicket 6.2.0/6.3.0 and IE (this works perfectly with
Chrome or Firefox). I have a list of items, with Ajax links in the list. The
response to the Ajax link modifies a panel from the page, and redraws the
list (its container).
IE does at least some of the changes correctly, but outputs an error, and it
seems that subsequent Ajax request fail:
(... some UI code ...)
(... Jquery and Wicket ajax references ...)
script type=text/javascript id=wicket-ajax-base-url
/*![CDATA[*/
Wicket.Ajax.baseUrl=other/bictables/list;
/*]^]^*/
/script
/head]]/header-contributionevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-AMEND,e:click,c:AMENDea});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-interaction-view-toolbar-RETURN,e:click,c:RETURNec});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-view,e:click,c:viewf2});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-actions-edit,e:click,c:editf3});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-0-reorder-down,e:click,c:downf4});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-view,e:click,c:viewf5});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-actions-edit,e:click,c:editf6});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-up,e:click,c:upf7});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-1-reorder-down,e:click,c:downf8});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-view,e:click,c:viewf9});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-2-actions-edit,e:click,c:editfa});]]
(... lots of similar code from the table ...)
evaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-actions-edit,e:click,c:edit136});]]/evaluateevaluate![CDATA[Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-17-reorder-up,e:click,c:up137});]]/evaluate/ajax-response
INFO: returned focused element:
http://localhost:8080/payments/app/other/bictables/list?3#
INFO: returned focused element: null
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript:
[object Error], text:
Wicket.Ajax.ajax({u:./list?3-1.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-view,e:click,c:view10d});
ERROR: FunctionsExecuter.processNext: [object Error]
ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating
javascript: [object Error], text:
Wicket.Ajax.ajax({u:./list?2-4.IBehaviorListener.0-entities-entitiesList-bictables-7-actions-
view,e:click,c:view2cb});
ERROR: FunctionsExecuter.processNext: [object Error]
all subsequent Ajax requests lead to :
INFO: Channel '0' is busy - scheduling the callback to be executed when the
previous request finish
Is this a bug in Wicket, in IE? Any way to circumvent it if it's in IE?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-4890) Bad validation messages after WICKET-2128
Jonas created WICKET-4890:
-
Summary: Bad validation messages after WICKET-2128
Key: WICKET-4890
URL: https://issues.apache.org/jira/browse/WICKET-4890
Project: Wicket
Issue Type: Bug
Reporter: Jonas
Priority: Minor
In most languages (at least the ones that I speak), the error messages used by
validators don't sound right anymore after WICKET-2128 was fixed. Replacing
'${input}' with '${label}' (what seems to have been done) doesn't yield useful
error messages.
I see the following options:
a) Improve the messages the way Martin Grigorov suggested it in WICKET-2128,
e.g.
'IConverter=The value of '${label}' is not a valid ${type}.'
(instead of just 'IConverter='${label}' is not a valid ${type}.')
Interestingly, all the languages that use .xml properties (e.g.
Application_bg.properties.xml) files seem to have been excluded (by accident?)
from the changes done in WICKET-2128, as they still refer to ${input}.
b) revert the changes from WICKET-2128 completely. I think the new messages
only fit well in scenarios where there's only a single feedback panel per page,
which is anyway not very userfriendly. In cases when you display the error
messages in separate feedback components next to the corresponding
FormComponents, it is anyway clear which field is the culprit, and users don't
need to search for the field that has caused the error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-4891) UrlRenderer.renderRelativeUrl misbehavior if the filterPath is composed.
Jordi Deu-Pons created WICKET-4891:
--
Summary: UrlRenderer.renderRelativeUrl misbehavior if the
filterPath is composed.
Key: WICKET-4891
URL: https://issues.apache.org/jira/browse/WICKET-4891
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.3.0
Reporter: Jordi Deu-Pons
Priority: Minor
Using an application with a composed filterPath like:
filter-mapping
filter-namewicket.jsessionid/filter-name
url-pattern/demo/test/*/url-pattern
/filter-mapping
Wicket fails to properly render a bookmarkable link.
I've debuged my app and the problem is here:
UrlRenderer.removeCommonPrefixes()
Line 309:
String filterPath = request.getFilterPath();
if (filterPath != null segments.isEmpty() == false)
{
if (filterPath.equals(UrlUtils.normalizePath(segments.get(0
{
LOG.debug(Removing the filter path '{}' from '{}', filterPath,
segments);
segments.remove(0);
}
}
This code assumes that the filter path is a single segment path, not a composed
path.
I've only reached this bug browsing my website with the cookies disable. This
is why it's not critical.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-4892) Provide helpful exception message in RequestCycle#urlFor(Class, PageParameters)
Peter Parson created WICKET-4892: Summary: Provide helpful exception message in RequestCycle#urlFor(Class, PageParameters) Key: WICKET-4892 URL: https://issues.apache.org/jira/browse/WICKET-4892 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.2.0 Reporter: Peter Parson When something goes wrong while trying to get the URL for pageClass/pageParameters using RequestCycle, the exception message and its stacktrace is not very helpful in tracking down the component actually causing the problem. (See attached stacktrace that I while rendering a BookmarkablePageLink with a null parameter.) I suggest to catch any exceptions thrown by urlFor(IRequestHandler) and throwing a WicketRuntimeException having pageClass and pageparamters in its message. (See attached patch) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4892) Provide helpful exception message in RequestCycle#urlFor(Class, PageParameters)
[ https://issues.apache.org/jira/browse/WICKET-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Parson updated WICKET-4892: - Attachment: urlFor-stacktrace.txt RequestCycle-urlFor-exception.patch Example stacktrace and patch for helpful exception message Provide helpful exception message in RequestCycle#urlFor(Class, PageParameters) --- Key: WICKET-4892 URL: https://issues.apache.org/jira/browse/WICKET-4892 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.2.0 Reporter: Peter Parson Labels: exception, exception-handling, patch Attachments: RequestCycle-urlFor-exception.patch, urlFor-stacktrace.txt When something goes wrong while trying to get the URL for pageClass/pageParameters using RequestCycle, the exception message and its stacktrace is not very helpful in tracking down the component actually causing the problem. (See attached stacktrace that I while rendering a BookmarkablePageLink with a null parameter.) I suggest to catch any exceptions thrown by urlFor(IRequestHandler) and throwing a WicketRuntimeException having pageClass and pageparamters in its message. (See attached patch) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4892) Provide helpful exception message in RequestCycle#urlFor(Class, PageParameters)
[ https://issues.apache.org/jira/browse/WICKET-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Parson updated WICKET-4892: - Issue Type: Improvement (was: Bug) Provide helpful exception message in RequestCycle#urlFor(Class, PageParameters) --- Key: WICKET-4892 URL: https://issues.apache.org/jira/browse/WICKET-4892 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.2.0 Reporter: Peter Parson Labels: exception, exception-handling, patch Attachments: RequestCycle-urlFor-exception.patch, urlFor-stacktrace.txt When something goes wrong while trying to get the URL for pageClass/pageParameters using RequestCycle, the exception message and its stacktrace is not very helpful in tracking down the component actually causing the problem. (See attached stacktrace that I while rendering a BookmarkablePageLink with a null parameter.) I suggest to catch any exceptions thrown by urlFor(IRequestHandler) and throwing a WicketRuntimeException having pageClass and pageparamters in its message. (See attached patch) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4892) Provide helpful exception message in RequestCycle#urlFor(Class, PageParameters)
[ https://issues.apache.org/jira/browse/WICKET-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Parson updated WICKET-4892: - Priority: Minor (was: Major) Provide helpful exception message in RequestCycle#urlFor(Class, PageParameters) --- Key: WICKET-4892 URL: https://issues.apache.org/jira/browse/WICKET-4892 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.2.0 Reporter: Peter Parson Priority: Minor Labels: exception, exception-handling, patch Attachments: RequestCycle-urlFor-exception.patch, urlFor-stacktrace.txt When something goes wrong while trying to get the URL for pageClass/pageParameters using RequestCycle, the exception message and its stacktrace is not very helpful in tracking down the component actually causing the problem. (See attached stacktrace that I while rendering a BookmarkablePageLink with a null parameter.) I suggest to catch any exceptions thrown by urlFor(IRequestHandler) and throwing a WicketRuntimeException having pageClass and pageparamters in its message. (See attached patch) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4891) UrlRenderer.renderRelativeUrl misbehavior if the filterPath is composed.
[
https://issues.apache.org/jira/browse/WICKET-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordi Deu-Pons updated WICKET-4891:
---
Attachment: WICKET-4891.tar.gz
Minimal example demo application that fails if you browse it with the cookies
disable
UrlRenderer.renderRelativeUrl misbehavior if the filterPath is composed.
Key: WICKET-4891
URL: https://issues.apache.org/jira/browse/WICKET-4891
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.3.0
Reporter: Jordi Deu-Pons
Priority: Minor
Attachments: WICKET-4891.tar.gz
Using an application with a composed filterPath like:
filter-mapping
filter-namewicket.jsessionid/filter-name
url-pattern/demo/test/*/url-pattern
/filter-mapping
Wicket fails to properly render a bookmarkable link.
I've debuged my app and the problem is here:
UrlRenderer.removeCommonPrefixes()
Line 309:
String filterPath = request.getFilterPath();
if (filterPath != null segments.isEmpty() == false)
{
if (filterPath.equals(UrlUtils.normalizePath(segments.get(0
{
LOG.debug(Removing the filter path '{}' from '{}', filterPath,
segments);
segments.remove(0);
}
}
This code assumes that the filter path is a single segment path, not a
composed path.
I've only reached this bug browsing my website with the cookies disable. This
is why it's not critical.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4890) Bad validation messages after WICKET-2128
[
https://issues.apache.org/jira/browse/WICKET-4890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonas updated WICKET-4890:
--
Affects Version/s: 6.3.0
Bad validation messages after WICKET-2128
-
Key: WICKET-4890
URL: https://issues.apache.org/jira/browse/WICKET-4890
Project: Wicket
Issue Type: Bug
Affects Versions: 6.3.0
Reporter: Jonas
Priority: Minor
In most languages (at least the ones that I speak), the error messages used
by validators don't sound right anymore after WICKET-2128 was fixed.
Replacing '${input}' with '${label}' (what seems to have been done) doesn't
yield useful error messages.
I see the following options:
a) Improve the messages the way Martin Grigorov suggested it in WICKET-2128,
e.g.
'IConverter=The value of '${label}' is not a valid ${type}.'
(instead of just 'IConverter='${label}' is not a valid ${type}.')
Interestingly, all the languages that use .xml properties (e.g.
Application_bg.properties.xml) files seem to have been excluded (by
accident?) from the changes done in WICKET-2128, as they still refer to
${input}.
b) revert the changes from WICKET-2128 completely. I think the new messages
only fit well in scenarios where there's only a single feedback panel per
page, which is anyway not very userfriendly. In cases when you display the
error messages in separate feedback components next to the corresponding
FormComponents, it is anyway clear which field is the culprit, and users
don't need to search for the field that has caused the error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4891) UrlRenderer.renderRelativeUrl misbehavior if the filterPath is composed.
[
https://issues.apache.org/jira/browse/WICKET-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503883#comment-13503883
]
Jordi Deu-Pons commented on WICKET-4891:
I've created a pull request:
https://github.com/apache/wicket/pull/22
From the source code I can deduce that it can happen the same with the context
path, so I also check this at the pull request.
UrlRenderer.renderRelativeUrl misbehavior if the filterPath is composed.
Key: WICKET-4891
URL: https://issues.apache.org/jira/browse/WICKET-4891
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.3.0
Reporter: Jordi Deu-Pons
Priority: Minor
Attachments: WICKET-4891.tar.gz
Using an application with a composed filterPath like:
filter-mapping
filter-namewicket.jsessionid/filter-name
url-pattern/demo/test/*/url-pattern
/filter-mapping
Wicket fails to properly render a bookmarkable link.
I've debuged my app and the problem is here:
UrlRenderer.removeCommonPrefixes()
Line 309:
String filterPath = request.getFilterPath();
if (filterPath != null segments.isEmpty() == false)
{
if (filterPath.equals(UrlUtils.normalizePath(segments.get(0
{
LOG.debug(Removing the filter path '{}' from '{}', filterPath,
segments);
segments.remove(0);
}
}
This code assumes that the filter path is a single segment path, not a
composed path.
I've only reached this bug browsing my website with the cookies disable. This
is why it's not critical.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4891) UrlRenderer.renderRelativeUrl misbehavior if the filterPath is composed.
[
https://issues.apache.org/jira/browse/WICKET-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordi Deu-Pons updated WICKET-4891:
---
Attachment: WICKET-4891.patch
A patch
UrlRenderer.renderRelativeUrl misbehavior if the filterPath is composed.
Key: WICKET-4891
URL: https://issues.apache.org/jira/browse/WICKET-4891
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.3.0
Reporter: Jordi Deu-Pons
Priority: Minor
Attachments: WICKET-4891.patch, WICKET-4891.tar.gz
Using an application with a composed filterPath like:
filter-mapping
filter-namewicket.jsessionid/filter-name
url-pattern/demo/test/*/url-pattern
/filter-mapping
Wicket fails to properly render a bookmarkable link.
I've debuged my app and the problem is here:
UrlRenderer.removeCommonPrefixes()
Line 309:
String filterPath = request.getFilterPath();
if (filterPath != null segments.isEmpty() == false)
{
if (filterPath.equals(UrlUtils.normalizePath(segments.get(0
{
LOG.debug(Removing the filter path '{}' from '{}', filterPath,
segments);
segments.remove(0);
}
}
This code assumes that the filter path is a single segment path, not a
composed path.
I've only reached this bug browsing my website with the cookies disable. This
is why it's not critical.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4879) Implementing channels in wicket-atmosphere
[ https://issues.apache.org/jira/browse/WICKET-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503977#comment-13503977 ] Zala Goupil commented on WICKET-4879: - Good evening, I've just tried it. The behaviour is the same: if three clients are connected and that only one's filter returns true, then the same message goes to all the three clients. If two of them return true, then those two send the message to the three clients, and so on. Personally, I'd like to be able to have the message sent by one client broadcasted to only this client. Of course, the use case of one client sends to all is useful, I just wish it was not the only one possible. Anyway, your contextAwareFilter is useful, thanks for that ! I've tried myself to implement a Broadcaster-based message-sending in your code, but for the moment, I failed. Too bad. The one thing I miss is how to provide an AtmosphereResource to my Broadcaster. Anyway, keep up the good work! :-) Implementing channels in wicket-atmosphere -- Key: WICKET-4879 URL: https://issues.apache.org/jira/browse/WICKET-4879 Project: Wicket Issue Type: New Feature Components: wicket-atmosphere Affects Versions: 6.3.0 Environment: Tomcat / Jetty Reporter: Zala Goupil Assignee: Emond Papegaaij Fix For: 6.4.0 Attachments: wicket-atmosphere-quickstart.zip Good evening, Now that both Tomcat Jetty support native WebSockets, it would be a killer-feature to implement Comet / WebSockets channels. i.e. being able to have a channel id and to post a message to one client only or to all the clients who subscribed to a certain channel. For the moment, it is possible to do it, but to the (expensive) price of having a PerRequestBroadcastFilter and tweaking it if we manage to do it. But it would be great to have a link to the Broadcaster API from Atmosphere, which I think, supports this kind of things.That would probably be way more efficient than PerRequestBroadcastFilter tweaking. As of today, when posting a message to the event bus, all pages who have the @Subscribed-decorated method suitable to process this message will do it, which is not always desirable. I'm looking forward to hear from you. Regards -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: WICKET-4879: make it possible to post to a single atmosphere resource
Updated Branches:
refs/heads/master e8db4bbfb - a5421ec48
WICKET-4879: make it possible to post to a single atmosphere resource
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/a5421ec4
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/a5421ec4
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/a5421ec4
Branch: refs/heads/master
Commit: a5421ec488020a3835d49962e1f772dc1435e230
Parents: e8db4bb
Author: Emond Papegaaij papega...@apache.org
Authored: Mon Nov 26 21:59:15 2012 +0100
Committer: Emond Papegaaij papega...@apache.org
Committed: Mon Nov 26 21:59:22 2012 +0100
--
.../wicket/atmosphere/AtmosphereBehavior.java | 31 ---
.../org/apache/wicket/atmosphere/EventBus.java | 69 +++---
2 files changed, 72 insertions(+), 28 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/a5421ec4/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
--
diff --git
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
index 4d18093..87e47b2 100644
---
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
+++
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
@@ -22,6 +22,7 @@ import org.apache.wicket.Application;
import org.apache.wicket.Component;
import org.apache.wicket.IResourceListener;
import org.apache.wicket.MetaDataKey;
+import org.apache.wicket.Page;
import org.apache.wicket.WicketRuntimeException;
import org.apache.wicket.ajax.json.JSONException;
import org.apache.wicket.ajax.json.JSONObject;
@@ -33,7 +34,6 @@ import
org.apache.wicket.protocol.http.servlet.ServletWebRequest;
import org.apache.wicket.request.cycle.RequestCycle;
import org.apache.wicket.request.mapper.parameter.PageParameters;
import org.apache.wicket.resource.CoreLibrariesContributor;
-import org.atmosphere.cpr.ApplicationConfig;
import org.atmosphere.cpr.AtmosphereResource;
import org.atmosphere.cpr.AtmosphereResourceEvent;
import org.atmosphere.cpr.AtmosphereResourceEventListener;
@@ -105,7 +105,7 @@ public class AtmosphereBehavior extends Behavior
// Grab a Meteor
Meteor meteor = Meteor.build(request.getContainerRequest());
- String uuid = getUUID(meteor.getAtmosphereResource());
+ String uuid = meteor.getAtmosphereResource().uuid();
component.getPage().setMetaData(ATMOSPHERE_UUID, uuid);
findEventBus().registerPage(uuid, component.getPage());
@@ -179,7 +179,7 @@ public class AtmosphereBehavior extends Behavior
log.info(String.format(%s connection dropped from ip
%s:%s, transport == null
? websocket : transport, req.getRemoteAddr(),
req.getRemotePort()));
}
-
findEventBus().unregisterConnection(getUUID(event.getResource()));
+ findEventBus().unregisterConnection(event.getResource().uuid());
}
@Override
@@ -210,20 +210,25 @@ public class AtmosphereBehavior extends Behavior
}
/**
+* Find the Atmosphere UUID for the suspended connection for the given
page (if any).
+*
+* @param page
+* @return The UUID of the Atmosphere Resource, or null if no resource
is suspended for the
+* page.
+*/
+ public static String getUUID(Page page)
+ {
+ return page.getMetaData(ATMOSPHERE_UUID);
+ }
+
+ /**
* @param resource
* @return the unique id for the given suspended connection
+* @deprecated use {@link AtmosphereResource#uuid()}
*/
+ @Deprecated
public static String getUUID(AtmosphereResource resource)
{
- Object trackingId =
resource.getRequest().getHeader(HeaderConfig.X_ATMOSPHERE_TRACKING_ID);
- if (trackingId != null !trackingId.equals(0))
- return trackingId.toString();
-
- trackingId = resource.getRequest().getAttribute(
- ApplicationConfig.SUSPENDED_ATMOSPHERE_RESOURCE_UUID);
- if (trackingId != null !trackingId.equals(0))
- return trackingId.toString();
-
- return resource.getRequest().getHeader(Sec-WebSocket-Key);
+ return resource.uuid();
}
}
\ No newline at end of file
git commit: WICKET-4879: null check for the resource
Updated Branches:
refs/heads/master a5421ec48 - bef99f313
WICKET-4879: null check for the resource
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/bef99f31
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/bef99f31
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/bef99f31
Branch: refs/heads/master
Commit: bef99f3135ee545d11cfad41733a1c6a82f54dfb
Parents: a5421ec
Author: Emond Papegaaij papega...@apache.org
Authored: Mon Nov 26 22:04:06 2012 +0100
Committer: Emond Papegaaij papega...@apache.org
Committed: Mon Nov 26 22:04:06 2012 +0100
--
.../org/apache/wicket/atmosphere/EventBus.java |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/bef99f31/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
--
diff --git
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
index f8efd06..4901c7a 100644
---
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
+++
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
@@ -185,14 +185,19 @@ public class EventBus implements UnboundListener
/**
* Post an event to a single resource. This will invoke the event
handlers on all components on
* the page with the suspended connection. The resulting AJAX update
(if any) is pushed to the
-* client. You can find the UUID via {@link
AtmosphereBehavior#getUUID(Page)}.
+* client. You can find the UUID via {@link
AtmosphereBehavior#getUUID(Page)}. If no resource
+* exists with the given UUID, no post is performed.
*
* @param event
* @param resourceUuid
*/
public void post(Object event, String resourceUuid)
{
- post(event,
AtmosphereResourceFactory.getDefault().find(resourceUuid));
+ AtmosphereResource resource =
AtmosphereResourceFactory.getDefault().find(resourceUuid);
+ if (resource != null)
+ {
+ post(event, resource);
+ }
}
/**
[jira] [Commented] (WICKET-4879) Implementing channels in wicket-atmosphere
[ https://issues.apache.org/jira/browse/WICKET-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504093#comment-13504093 ] Emond Papegaaij commented on WICKET-4879: - I don't see how you could return true for one client and false for another (other than using something like random). filter() is used with no receiver context at all. It is meant to be used to filter certain types of events (other than the actual instance type). For example, if you have an event that contains progress of a job and you only want your component to receive the events if the progress is 80% or higher, that's when you use filter(). The same filter should always return true for the same events. Can you take a look at commit a5421ec488020a3835d49962e1f772dc1435e230? I've added methods to post an event to a single resource, either with a resource instance or via its uuid (which I think makes more sense). You can get the UUID with AtmosphereResource.getUUID(page). Implementing channels in wicket-atmosphere -- Key: WICKET-4879 URL: https://issues.apache.org/jira/browse/WICKET-4879 Project: Wicket Issue Type: New Feature Components: wicket-atmosphere Affects Versions: 6.3.0 Environment: Tomcat / Jetty Reporter: Zala Goupil Assignee: Emond Papegaaij Fix For: 6.4.0 Attachments: wicket-atmosphere-quickstart.zip Good evening, Now that both Tomcat Jetty support native WebSockets, it would be a killer-feature to implement Comet / WebSockets channels. i.e. being able to have a channel id and to post a message to one client only or to all the clients who subscribed to a certain channel. For the moment, it is possible to do it, but to the (expensive) price of having a PerRequestBroadcastFilter and tweaking it if we manage to do it. But it would be great to have a link to the Broadcaster API from Atmosphere, which I think, supports this kind of things.That would probably be way more efficient than PerRequestBroadcastFilter tweaking. As of today, when posting a message to the event bus, all pages who have the @Subscribed-decorated method suitable to process this message will do it, which is not always desirable. I'm looking forward to hear from you. Regards -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: WICKET-4889: added a constructor that takes Serializable
Updated Branches:
refs/heads/master bef99f313 - 3d5fba8ca
WICKET-4889: added a constructor that takes Serializable
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/3d5fba8c
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/3d5fba8c
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/3d5fba8c
Branch: refs/heads/master
Commit: 3d5fba8cada3fa8aae6ea60cd55af084e1c76fcc
Parents: bef99f3
Author: Emond Papegaaij papega...@apache.org
Authored: Mon Nov 26 22:41:20 2012 +0100
Committer: Emond Papegaaij papega...@apache.org
Committed: Mon Nov 26 22:41:20 2012 +0100
--
.../org/apache/wicket/markup/html/basic/Label.java | 19 ++-
1 files changed, 18 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/3d5fba8c/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/Label.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/Label.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/Label.java
index 43a7556..b88f44e 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/Label.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/Label.java
@@ -16,6 +16,8 @@
*/
package org.apache.wicket.markup.html.basic;
+import java.io.Serializable;
+
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.markup.MarkupStream;
import org.apache.wicket.markup.html.WebComponent;
@@ -95,6 +97,21 @@ public class Label extends WebComponent
}
/**
+* Convenience constructor. Same as Label(String,
Model.of(Serializable))
+*
+* @param id
+*See Component
+* @param label
+*The label text or object, converted to a string via the
{@link IConverter}.
+*
+* @see org.apache.wicket.Component#Component(String, IModel)
+*/
+ public Label(final String id, Serializable label)
+ {
+ this(id, Model.of(label));
+ }
+
+ /**
* @param id
* @param model
* @see org.apache.wicket.Component#Component(String, IModel)
@@ -127,4 +144,4 @@ public class Label extends WebComponent
tag.setType(TagType.OPEN);
}
}
-}
\ No newline at end of file
+}
[jira] [Resolved] (WICKET-4889) Label constructor should accept Serializable as label
[ https://issues.apache.org/jira/browse/WICKET-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emond Papegaaij resolved WICKET-4889. - Resolution: Fixed Fix Version/s: 6.4.0 A new constructor is added. Label constructor should accept Serializable as label - Key: WICKET-4889 URL: https://issues.apache.org/jira/browse/WICKET-4889 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.3.0 Reporter: Emond Papegaaij Assignee: Emond Papegaaij Fix For: 6.4.0 The fixed-label constructor of Label current only accepts strings, which is very limited. Label has no problems in rendering other serializable fixed values through the use of converters. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: WICKET-4889: added a constructor that takes Serializable
Updated Branches:
refs/heads/master 3d5fba8ca - e9d8e33ff
WICKET-4889: added a constructor that takes Serializable
Fix a javadoc link.
Add a TODO to remove the constructor that accepts String in Wicket 7.
Deprecating it now will lead to ugly warnings in the user apps.
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e9d8e33f
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e9d8e33f
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e9d8e33f
Branch: refs/heads/master
Commit: e9d8e33ffc51651a7862c7213d71058ab2a3c6f2
Parents: 3d5fba8
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Mon Nov 26 22:52:18 2012 +0100
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Mon Nov 26 22:52:18 2012 +0100
--
.../org/apache/wicket/markup/html/basic/Label.java |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/e9d8e33f/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/Label.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/Label.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/Label.java
index b88f44e..1423dd5 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/Label.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/basic/Label.java
@@ -91,6 +91,7 @@ public class Label extends WebComponent
*
* @see org.apache.wicket.Component#Component(String, IModel)
*/
+ // TODO Wicket 7 remove this constructor. The one with Serializable is
the replacement
public Label(final String id, String label)
{
this(id, new ModelString(label));
@@ -102,7 +103,7 @@ public class Label extends WebComponent
* @param id
*See Component
* @param label
-*The label text or object, converted to a string via the
{@link IConverter}.
+*The label text or object, converted to a string via the
{@link org.apache.wicket.util.convert.IConverter}.
*
* @see org.apache.wicket.Component#Component(String, IModel)
*/
[jira] [Commented] (WICKET-4879) Implementing channels in wicket-atmosphere
[ https://issues.apache.org/jira/browse/WICKET-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504218#comment-13504218 ] Zala Goupil commented on WICKET-4879: - Thanks again! I've tried this new code, but unfortunately the situation is the same: all the connected resources are refreshed when issuing: Application.get().getEventBus().post(MyObject, pageUuid), not just the one that I'm expecting. Sorry about that, I don't know what could be wrong. Implementing channels in wicket-atmosphere -- Key: WICKET-4879 URL: https://issues.apache.org/jira/browse/WICKET-4879 Project: Wicket Issue Type: New Feature Components: wicket-atmosphere Affects Versions: 6.3.0 Environment: Tomcat / Jetty Reporter: Zala Goupil Assignee: Emond Papegaaij Fix For: 6.4.0 Attachments: wicket-atmosphere-quickstart.zip Good evening, Now that both Tomcat Jetty support native WebSockets, it would be a killer-feature to implement Comet / WebSockets channels. i.e. being able to have a channel id and to post a message to one client only or to all the clients who subscribed to a certain channel. For the moment, it is possible to do it, but to the (expensive) price of having a PerRequestBroadcastFilter and tweaking it if we manage to do it. But it would be great to have a link to the Broadcaster API from Atmosphere, which I think, supports this kind of things.That would probably be way more efficient than PerRequestBroadcastFilter tweaking. As of today, when posting a message to the event bus, all pages who have the @Subscribed-decorated method suitable to process this message will do it, which is not always desirable. I'm looking forward to hear from you. Regards -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[CONF] Apache Wicket Migration to Wicket 6.0
Migration to Wicket 6.0
Page edited by Daniel Huang
Changes (1)
...
AjaxRequestTarget target = requestCycle.find(AjaxRequestTarget.class); {code}
RequestCycle.get().find(Class? extends IRequestHandler) can be used to find the currently running or a scheduled IRequestHandler for other types too.
h3. IHeaderResponse, including decorators and filters
...
Full Content
Migrating to Wicket 6.0
Environment
Repeaters
Form Processing
Validation
Feedback Storage Refactoring
Feedback messages now use ${label} instead of ${input}
added onAfterSubmit to Buttons and SubmitLinks
Ajax
Use JQuery as a backing library for Wicket Ajax functionality
AjaxRequestTarget is an interface
IHeaderResponse, including decorators and filters
Order of Header contributions and wicket:head
package.properties renamed to wicket-package.properties
List of renamed classes and methods
Refactorings
o.a.w.IComponentSource and o.a.w.ComponentSourceEntry are removed
o.a.w.Component#onMarkupAttached() has been dropped in favour of o.a.w.Component#onInitialize().
IInitializers are initialized before Application#init()
PackageResourceReference can load a minified version of a package resource
ResourceStreamLocator and ResourceFinder have been cleaned up
Minor changes
Environment
Wicket 6.0 requires at least Java 6
Repeaters
`IDataProvider` was converted to using `long` instead of `int` to better line up with JPA and other persistence frameworks. This has caused a rather large cascade of `int` to `long` changes all over the repeater packages (WICKET-1175).
All classes in wicket-extensions which are related to repeaters with sorting behavior have improved generics
related to the sorting property (WICKET-4535). In most cases you just have to add ', String' to the previous parameterized type. For example: IColumnEntity becomes IColumnEntity, String. But now it is possible to use other type for the sort property than java.lang.String too.
Form Processing
Validation
`StringValidator` will add the `maxlength` attribute if added to a component attached to an input tag
MinimumValidator and MaximumValidator are replaced by RangeValidator.minimum and RangeValidator.maximum respectively
`AbstractValidator` has been removed
`ValidationError` now makes creating standard error keys (classname and classname.subtype) easier. Before one had to do: new ValidationError().addMessageKey(validator.getClass().getSimpleName()) to construct the default key, now you can simply say new ValidationError(validator) and it will do the above for you. Also, for more specific keys one had to do new ValidationError().addMessageKey(validator.getClass().getSimpleName()+".variant"), now you can do new ValidationError(validator, "variant").
Most validators provide a `decorate(ValidationError, Validatable)` method for overriding how they report errors. For example, to add an extra resource key for the error message to StringValidator one can do
class MyStringValidator extends StringValidator {
ValidationError decorate(ValidationError error, IValidatable validatable) {
error.addKey("mystringerror");
return error;
}
}
org.apache.wicket.validation.RawValidationError is introduced. It can be used to bring a raw Serializable object which is registered as FeedbackMessage with org.apache.wicket.Component#error(Serializable).
IFormValidator can have its own resource bundle as other IValidator implementations. WICKET-3879
Feedback Storage Refactoring
Feedback messages reported against components are now stored in component's metadata rather then in session. This will allow them to survive across requests, see WICKET-2705.
Previously the cleanup of messages was controlled by RequestCycle#cleanupFeedbackMessages(), now it is controlled by an IFeedbackMessageFilter set via IApplicationSettings#setFeedbackMessageCleanupFilter(). When session and components are detached they will run this filter on any stored messages, all messages accepted by the filter are removed. The default filter will accept any rendered message, so by default feedback messages are removed once rendered.
Form components will clear any stored messages when validate() is called. This will remove any unredered, but now stale, messages.
Since messages are now stored in session and in component tree retrieving them is not as simple as Session.getFeedbackMessages(). To assist with this common usecase please see FeedbackCollector.
In test land cleanup of feedback messages was controlled by RequestCycle#set/isCleanupFeedbackMessagesOnDetach(), but this method is now deprecated. Instead, in testland you can now call
[jira] [Commented] (WICKET-4879) Implementing channels in wicket-atmosphere
[ https://issues.apache.org/jira/browse/WICKET-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504401#comment-13504401 ] Emond Papegaaij commented on WICKET-4879: - Do you think you can make a quickstart for that? If so, please create a new ticket. However, I suspect the problem lies somewhere else, because the code in EventBus does not write anything to the other resources. Implementing channels in wicket-atmosphere -- Key: WICKET-4879 URL: https://issues.apache.org/jira/browse/WICKET-4879 Project: Wicket Issue Type: New Feature Components: wicket-atmosphere Affects Versions: 6.3.0 Environment: Tomcat / Jetty Reporter: Zala Goupil Assignee: Emond Papegaaij Fix For: 6.4.0 Attachments: wicket-atmosphere-quickstart.zip Good evening, Now that both Tomcat Jetty support native WebSockets, it would be a killer-feature to implement Comet / WebSockets channels. i.e. being able to have a channel id and to post a message to one client only or to all the clients who subscribed to a certain channel. For the moment, it is possible to do it, but to the (expensive) price of having a PerRequestBroadcastFilter and tweaking it if we manage to do it. But it would be great to have a link to the Broadcaster API from Atmosphere, which I think, supports this kind of things.That would probably be way more efficient than PerRequestBroadcastFilter tweaking. As of today, when posting a message to the event bus, all pages who have the @Subscribed-decorated method suitable to process this message will do it, which is not always desirable. I'm looking forward to hear from you. Regards -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: WICKET-4884 keep locale untouched but do custom conversion instead
Updated Branches:
refs/heads/master e9d8e33ff - 9de66fbf5
WICKET-4884 keep locale untouched but do custom conversion instead
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/9de66fbf
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/9de66fbf
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/9de66fbf
Branch: refs/heads/master
Commit: 9de66fbf5701de16d28cf6ea78a1c2a62065a987
Parents: e9d8e33
Author: svenmeier svenme...@apache.org
Authored: Tue Nov 27 08:38:27 2012 +0100
Committer: svenmeier svenme...@apache.org
Committed: Tue Nov 27 08:38:27 2012 +0100
--
.../wicket/markup/html/form/NumberTextField.java | 69
.../markup/html/form/NumberTextFieldTest.java | 144 +++
2 files changed, 177 insertions(+), 36 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/9de66fbf/wicket-core/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java
index ae3706b..0e88c7b 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java
@@ -16,14 +16,14 @@
*/
package org.apache.wicket.markup.html.form;
-import java.text.NumberFormat;
import java.util.Locale;
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.model.IModel;
+import org.apache.wicket.util.convert.ConversionException;
import org.apache.wicket.util.convert.IConverter;
-import org.apache.wicket.util.convert.converter.AbstractDecimalConverter;
import org.apache.wicket.util.lang.Numbers;
+import org.apache.wicket.util.lang.Objects;
import org.apache.wicket.util.value.IValueMap;
import org.apache.wicket.validation.validator.RangeValidator;
@@ -33,8 +33,8 @@ import org.apache.wicket.validation.validator.RangeValidator;
* p
* Automatically validates the input against the configured {@link
#setMinimum(N) min} and
* {@link #setMaximum(N) max} attributes. If any of them is codenull/code
then respective
- * MIN_VALUE or MAX_VALUE for the number type is used. If the number type has
no minimum and/or maximum
- * value then {@link Double#MIN_VALUE} and {@link Double#MAX_VALUE} are used
respectfully.
+ * MIN_VALUE or MAX_VALUE for the number type is used. If the number type has
no minimum and/or
+ * maximum value then {@link Double#MIN_VALUE} and {@link Double#MAX_VALUE}
are used respectfully.
*
* @param N
*the type of the number
@@ -43,13 +43,6 @@ public class NumberTextFieldN extends Number
ComparableN extends TextField
{
private static final long serialVersionUID = 1L;
- /**
-* A special locale which is used to render decimal number formats that
are HTML5 compliant.
-*
-* See a
href=http://dev.w3.org/html5/markup/datatypes.html#common.data.float;HTML5
number format/a
-*/
- private static final Locale HTML5_LOCALE = new Locale(en, ,
wicket-html5);
-
private RangeValidatorN validator;
private N minimum;
@@ -149,7 +142,7 @@ public class NumberTextFieldN extends Number
ComparableN extends TextField
else
{
ClassN numberType = getNumberType();
- result = (N) Numbers.getMinValue(numberType);
+ result = (N)Numbers.getMinValue(numberType);
}
return result;
}
@@ -164,7 +157,7 @@ public class NumberTextFieldN extends Number
ComparableN extends TextField
else
{
ClassN numberType = getNumberType();
- result = (N) Numbers.getMaxValue(numberType);
+ result = (N)Numbers.getMaxValue(numberType);
}
return result;
}
@@ -174,7 +167,7 @@ public class NumberTextFieldN extends Number
ComparableN extends TextField
ClassN numberType = getType();
if (numberType == null getModelObject() != null)
{
- numberType = (ClassN) getModelObject().getClass();
+ numberType = (ClassN)getModelObject().getClass();
}
return numberType;
}
@@ -188,8 +181,7 @@ public class NumberTextFieldN extends Number
ComparableN extends TextField
if (minimum != null)
{
- IConverterN converter = getConverter(getNumberType());
- attributes.put(min,
git commit: WICKET-4884 keep locale untouched but do custom conversion instead
Updated Branches:
refs/heads/wicket-1.5.x 4d6b76dee - 121f2e2a1
WICKET-4884 keep locale untouched but do custom conversion instead
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/121f2e2a
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/121f2e2a
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/121f2e2a
Branch: refs/heads/wicket-1.5.x
Commit: 121f2e2a1139105a3ae21b3a9a74ae392b454ec3
Parents: 4d6b76d
Author: svenmeier svenme...@apache.org
Authored: Tue Nov 27 08:38:37 2012 +0100
Committer: svenmeier svenme...@apache.org
Committed: Tue Nov 27 08:38:37 2012 +0100
--
.../wicket/markup/html/form/NumberTextField.java | 94 +++---
.../markup/html/form/NumberTextFieldTest.java | 143 +++
2 files changed, 206 insertions(+), 31 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/121f2e2a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java
index ae3706b..4f0adbb 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/NumberTextField.java
@@ -16,15 +16,18 @@
*/
package org.apache.wicket.markup.html.form;
-import java.text.NumberFormat;
import java.util.Locale;
+import java.util.Map;
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.model.IModel;
+import org.apache.wicket.util.convert.ConversionException;
import org.apache.wicket.util.convert.IConverter;
-import org.apache.wicket.util.convert.converter.AbstractDecimalConverter;
+import org.apache.wicket.util.lang.Classes;
import org.apache.wicket.util.lang.Numbers;
+import org.apache.wicket.util.lang.Objects;
import org.apache.wicket.util.value.IValueMap;
+import org.apache.wicket.validation.ValidationError;
import org.apache.wicket.validation.validator.RangeValidator;
/**
@@ -33,8 +36,8 @@ import org.apache.wicket.validation.validator.RangeValidator;
* p
* Automatically validates the input against the configured {@link
#setMinimum(N) min} and
* {@link #setMaximum(N) max} attributes. If any of them is codenull/code
then respective
- * MIN_VALUE or MAX_VALUE for the number type is used. If the number type has
no minimum and/or maximum
- * value then {@link Double#MIN_VALUE} and {@link Double#MAX_VALUE} are used
respectfully.
+ * MIN_VALUE or MAX_VALUE for the number type is used. If the number type has
no minimum and/or
+ * maximum value then {@link Double#MIN_VALUE} and {@link Double#MAX_VALUE}
are used respectfully.
*
* @param N
*the type of the number
@@ -44,9 +47,10 @@ public class NumberTextFieldN extends Number
ComparableN extends TextField
private static final long serialVersionUID = 1L;
/**
-* A special locale which is used to render decimal number formats that
are HTML5 compliant.
-*
-* See a
href=http://dev.w3.org/html5/markup/datatypes.html#common.data.float;HTML5
number format/a
+* A special locale which is used to parse decimal number formats that
are HTML5 compliant.
+*
+* See a
href=http://dev.w3.org/html5/markup/datatypes.html#common.data.float;HTML5
number
+* format/a
*/
private static final Locale HTML5_LOCALE = new Locale(en, ,
wicket-html5);
@@ -149,7 +153,7 @@ public class NumberTextFieldN extends Number
ComparableN extends TextField
else
{
ClassN numberType = getNumberType();
- result = (N) Numbers.getMinValue(numberType);
+ result = (N)Numbers.getMinValue(numberType);
}
return result;
}
@@ -164,7 +168,7 @@ public class NumberTextFieldN extends Number
ComparableN extends TextField
else
{
ClassN numberType = getNumberType();
- result = (N) Numbers.getMaxValue(numberType);
+ result = (N)Numbers.getMaxValue(numberType);
}
return result;
}
@@ -174,7 +178,7 @@ public class NumberTextFieldN extends Number
ComparableN extends TextField
ClassN numberType = getType();
if (numberType == null getModelObject() != null)
{
- numberType = (ClassN) getModelObject().getClass();
+ numberType = (ClassN)getModelObject().getClass();
}
return
[jira] [Closed] (WICKET-4884) ValidationError messages for NumberTextFields with minimum/maximum are always English
[ https://issues.apache.org/jira/browse/WICKET-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sven Meier closed WICKET-4884. -- Resolution: Fixed Fix Version/s: 1.5.10 6.4.0 Assignee: Sven Meier The locale is now kept untouched. ValidationError messages for NumberTextFields with minimum/maximum are always English - Key: WICKET-4884 URL: https://issues.apache.org/jira/browse/WICKET-4884 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.1.1, 6.3.0 Environment: Ubuntu 12.04 Reporter: Dirk Bachmann Assignee: Sven Meier Priority: Minor Fix For: 6.4.0, 1.5.10 Attachments: myproject.zip Although my Form's Locale is, e.g., de_DE, the error message generated from AbstractRangeValidator#validate(IValidatable) is always English. My German custom message for resource key RangeValidator.range in the Page's resource bundle gets ignored too - the default custom message from the resource bundle is used instead. Reason might be that Component#getLocale() invoked from Localizer#getStringIgnoreSettings(String, Component, IModel, Locale, String, String) always returns NumberTextField#HTML5_LOCALE (fix for WICKET-3591). Pls. see attached quickstart. I'm a Wicket newbie, so could very well be that I'm missing something. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
buildbot failure in ASF Buildbot on wicket-master
The Buildbot has detected a new failure on builder wicket-master while building wicket. Full details are available at: http://ci.apache.org/builders/wicket-master/builds/889 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: scheduler Build Source Stamp: [branch master] 9de66fbf5701de16d28cf6ea78a1c2a62065a987 Blamelist: svenmeier svenme...@apache.org BUILD FAILED: failed compile sincerely, -The Buildbot
buildbot failure in ASF Buildbot on wicket-branch-1.5.x
The Buildbot has detected a new failure on builder wicket-branch-1.5.x while building wicket. Full details are available at: http://ci.apache.org/builders/wicket-branch-1.5.x/builds/368 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: scheduler Build Source Stamp: [branch wicket-1.5.x] 121f2e2a1139105a3ae21b3a9a74ae392b454ec3 Blamelist: svenmeier svenme...@apache.org BUILD FAILED: failed compile sincerely, -The Buildbot
buildbot success in ASF Buildbot on wicket-master
The Buildbot has detected a restored build on builder wicket-master while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/wicket-master/builds/890 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: forced: by IRC user martin-g on channel ##wicket: None Build Source Stamp: HEAD Blamelist: Build succeeded! sincerely, -The Buildbot
