[jira] [Commented] (WICKET-5550) MetaDataKey/MetaDataEntry redundancy.

2014-04-17 Thread Emond Papegaaij (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972368#comment-13972368
 ] 

Emond Papegaaij commented on WICKET-5550:
-

The reason for this code is not that standard JDK classes do not perform well 
or were not available during development of Wicket 1. The code was written this 
way to save memory. Every component stores meta data. Changing the 
implementation from an array to an ArrayList would increase the in-memory size 
of every component by one object, an int and some spare space in the array, 
which does sum up to at least 12 to 20 bytes per component, depending on your 
vm. Also, component optimizes this further by replacing the array with a single 
object reference if only one entry is set. A HashMap is even less 
memory-friendly. It contains several fields, the hash table always contains 
empty spaces and entries require an additional int and reference. 

When it comes to serialization, required for persisting pages to disk and for 
clustering, these JDK classes do quite a good job, but still are not as compact 
as a simple array. Every byte has to be written to disk or sent over a network 
connection, so every byte counts.

 MetaDataKey/MetaDataEntry redundancy.
 -

 Key: WICKET-5550
 URL: https://issues.apache.org/jira/browse/WICKET-5550
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Reporter: Mattias Eliasson
Priority: Trivial
   Original Estimate: 24h
  Remaining Estimate: 24h

 Let me start with the fact that I am ready to create a full patch for this, 
 but I want feedback from other developers first.
 My first reflection when reading the MetaDataKey source where that the array 
 should be replaced by an ArrayList which would decrease code complexity and 
 increase HotSpot optimization, as the array logic does practically the same 
 thing as ArrayList.
 However after more consideration why are these two classes (MetaDataKey) not 
 based on the java.util.Map class. The only thing MetaDataKey would actually 
 need are the hashCode (and possibly equals) functions. Using for instance 
 HashMap, the result would be identical. 
 The MetaDataEntry should be dropped and replaced with Map.Entry. The only 
 difference between them are that MetaDataEntry are IClusterable.
 I suggests creating a ClusterableHashMap class that extends HashMap and 
 implements IClusterable. Then I would use a MetaDataKey which contains 
 nothing but hashCode and possibly equals. That are clean, slim and reusable. 
 In fact it would feel better to have a @Clusterable attribute that can just 
 be attached to a HashMap instance variable, creating a new class just to add 
 IClusterable to a build feels excessive.
 Also this will allow for some code cleanup where MetaDataKey/Entry are used, 
 which are why I estimate this to one day instead of an hour.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (WICKET-5550) MetaDataKey/MetaDataEntry redundancy.

2014-04-17 Thread Martin Grigorov (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5550.
-

Resolution: Won't Fix

 MetaDataKey/MetaDataEntry redundancy.
 -

 Key: WICKET-5550
 URL: https://issues.apache.org/jira/browse/WICKET-5550
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Reporter: Mattias Eliasson
Priority: Trivial
   Original Estimate: 24h
  Remaining Estimate: 24h

 Let me start with the fact that I am ready to create a full patch for this, 
 but I want feedback from other developers first.
 My first reflection when reading the MetaDataKey source where that the array 
 should be replaced by an ArrayList which would decrease code complexity and 
 increase HotSpot optimization, as the array logic does practically the same 
 thing as ArrayList.
 However after more consideration why are these two classes (MetaDataKey) not 
 based on the java.util.Map class. The only thing MetaDataKey would actually 
 need are the hashCode (and possibly equals) functions. Using for instance 
 HashMap, the result would be identical. 
 The MetaDataEntry should be dropped and replaced with Map.Entry. The only 
 difference between them are that MetaDataEntry are IClusterable.
 I suggests creating a ClusterableHashMap class that extends HashMap and 
 implements IClusterable. Then I would use a MetaDataKey which contains 
 nothing but hashCode and possibly equals. That are clean, slim and reusable. 
 In fact it would feel better to have a @Clusterable attribute that can just 
 be attached to a HashMap instance variable, creating a new class just to add 
 IClusterable to a build feels excessive.
 Also this will allow for some code cleanup where MetaDataKey/Entry are used, 
 which are why I estimate this to one day instead of an hour.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (WICKET-5560) Click on any link leads to a 404 error

2014-04-17 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972371#comment-13972371
 ] 

Martin Grigorov commented on WICKET-5560:
-

Please provide a quickstart application that shows the issue 
(http://wicket.apache.org/start/quickstart.html).
Please try to create it without @MountPath because this is not part of Wicket 
distro and thus is not officially supported by us.
Thanks!

 Click on any link leads to a 404 error
 --

 Key: WICKET-5560
 URL: https://issues.apache.org/jira/browse/WICKET-5560
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.14.0
Reporter: Dirk Reichelt

 Under certain prerequisites a click on any link in an instance of SomePage 
 leads to a 404 error.
 The prerequisites are:
 - Class SomePage is not annotated with @MountPath
 - SecuritySettings.enforceMounts is set to true
 - A CryptoMapper is used as RequestMapper
 Reason:
 In BookmarkableMapper.parseRequest (called indirectly by 
 CryptoMapper.mapRequest) the method matches returns false,
 as reverseUrl is the encrypted URL (rootRequestMapper is a CryptoMapper) but 
 BookmarkableMapper.matches expects a decrypted URL.
 BookmarkableMapper - lines 132 ff.:
 {code}
 Url reverseUrl = application.getRootRequestMapper().mapHandler(
   new RenderPageRequestHandler(new PageProvider(pageClass)));
 if (!matches(request.cloneWithUrl(reverseUrl)))
 {
   return null;
 }
 {code}
   
 As a result BookmarkableMapper.mapRequest and hence CryptoMapper.mapRequest 
 returns null resulting in a 404 error.
   
 The Problem came up with the change in the if-clause in 
 Component.urlFor(Behavior, RequestListenerInterface, PageParameters) [lines 
 3341 ff.].
 Now BookmarkableListenerInterfaceRequestHandler is used instead of 
 ListenerInterfaceRequestHandler.
 (Page isBookmarkable and wasCreatedBookmarkable, but is not stateless.) 
 So BookmarkableMapper became responsible.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (WICKET-5561) Derived page without own markup leads to MarkupNotFoundException when BasePage has wicket:head in its markup

2014-04-17 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972372#comment-13972372
 ] 

Martin Grigorov commented on WICKET-5561:
-

Please provide a quickstart app 
(http://wicket.apache.org/start/quickstart.html).
Thanks!

 Derived page without own markup leads to MarkupNotFoundException when 
 BasePage has wicket:head in its markup
 --

 Key: WICKET-5561
 URL: https://issues.apache.org/jira/browse/WICKET-5561
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.14.0
Reporter: Dirk Reichelt

 Both Page1 and Page2 extend BasePage (which extends WebPage).
 BasePage.html:
 {code}
 html
 wicket:head
 ...
 /wicket:head
 body
 ...
 wicket:child/   
 ...
 /body
 /html
 {code}
 Page1.html:
 {code}
 wicket:extend
 ...
 /wicket:extend
 {code}
 Page2 hat no own markup (there is no Page2.html).
 Calling Page1 and then Page2 leads to the following MarkupNotFoundException:
 {code}
 org.apache.wicket.markup.MarkupNotFoundException
 'Markup not found for Component: [HtmlHeaderContainer [Component id = 
 _header_0]]'
 org.apache.wicket.Component.internalRender(Component.java:2349)
 org.apache.wicket.Component.render(Component.java:2309)
 org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1390)
 org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1555)
 org.apache.wicket.Page.onRender(Page.java:887)
 org.apache.wicket.markup.html.WebPage.onRender(WebPage.java:142)
 org.apache.wicket.Component.internalRender(Component.java:2381)
 org.apache.wicket.Component.render(Component.java:2309)
 org.apache.wicket.Page.renderPage(Page.java:1024)
 org.apache.wicket.request.handler.render.WebPageRenderer.renderPage(WebPageRenderer.java:121)
 org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:274)
 org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:175)
 org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:862)
 org.apache.wicket.request.RequestHandlerStack.execute(RequestHandlerStack.java:64)
 org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:261)
 org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:218)
 org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:289)
 org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:259)
 org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:201)
 org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:282)
 org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
 org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:581)
 org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
 java.lang.Thread.run(Thread.java:662)
 {code}
 (Calling Page2 without having called Page1 does not lead to a 
 MarkupNotFoundException.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (WICKET-5560) A 404 error occurs when using a CryptoManager

2014-04-17 Thread Dirk Reichelt (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dirk Reichelt updated WICKET-5560:
--

Description: 
Under certain prerequisites a 404 error occurs.

The prerequisites are:
- A CryptoMapper is used as RequestMapper
- SecuritySettings.enforceMounts is set to true
- Class SomePage is *not* annotated with @MountPath

Reason:
In _BookmarkableMapper.parseRequest_ (called indirectly by 
_CryptoMapper.mapRequest_) the method _matches_ returns _false_,
as _reverseUrl_ is the *encrypted URL* (_rootRequestMapper_ is a 
_CryptoMapper_) but _BookmarkableMapper.matches_ expects a *decrypted URL*.

_BookmarkableMapper_ - lines 132 ff.:
{code}
Url reverseUrl = application.getRootRequestMapper().mapHandler(
new RenderPageRequestHandler(new PageProvider(pageClass)));
if (!matches(request.cloneWithUrl(reverseUrl)))
{
return null;
}
{code}

As a result _BookmarkableMapper.mapRequest_ and hence _CryptoMapper.mapRequest_ 
returns _null_ resulting in a 404 error.


  was:
Under certain prerequisites a click on any link in an instance of SomePage 
leads to a 404 error.

The prerequisites are:
- Class SomePage is not annotated with @MountPath
- SecuritySettings.enforceMounts is set to true
- A CryptoMapper is used as RequestMapper

Reason:
In BookmarkableMapper.parseRequest (called indirectly by 
CryptoMapper.mapRequest) the method matches returns false,
as reverseUrl is the encrypted URL (rootRequestMapper is a CryptoMapper) but 
BookmarkableMapper.matches expects a decrypted URL.

BookmarkableMapper - lines 132 ff.:
{code}
Url reverseUrl = application.getRootRequestMapper().mapHandler(
new RenderPageRequestHandler(new PageProvider(pageClass)));
if (!matches(request.cloneWithUrl(reverseUrl)))
{
return null;
}
{code}

As a result BookmarkableMapper.mapRequest and hence CryptoMapper.mapRequest 
returns null resulting in a 404 error.


The Problem came up with the change in the if-clause in 
Component.urlFor(Behavior, RequestListenerInterface, PageParameters) [lines 
3341 ff.].
Now BookmarkableListenerInterfaceRequestHandler is used instead of 
ListenerInterfaceRequestHandler.
(Page isBookmarkable and wasCreatedBookmarkable, but is not stateless.) 
So BookmarkableMapper became responsible.


Summary: A 404 error occurs when using a CryptoManager  (was: Click on 
any link leads to a 404 error)

 A 404 error occurs when using a CryptoManager
 -

 Key: WICKET-5560
 URL: https://issues.apache.org/jira/browse/WICKET-5560
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.14.0
Reporter: Dirk Reichelt

 Under certain prerequisites a 404 error occurs.
 The prerequisites are:
 - A CryptoMapper is used as RequestMapper
 - SecuritySettings.enforceMounts is set to true
 - Class SomePage is *not* annotated with @MountPath
 Reason:
 In _BookmarkableMapper.parseRequest_ (called indirectly by 
 _CryptoMapper.mapRequest_) the method _matches_ returns _false_,
 as _reverseUrl_ is the *encrypted URL* (_rootRequestMapper_ is a 
 _CryptoMapper_) but _BookmarkableMapper.matches_ expects a *decrypted URL*.
 _BookmarkableMapper_ - lines 132 ff.:
 {code}
 Url reverseUrl = application.getRootRequestMapper().mapHandler(
   new RenderPageRequestHandler(new PageProvider(pageClass)));
 if (!matches(request.cloneWithUrl(reverseUrl)))
 {
   return null;
 }
 {code}
   
 As a result _BookmarkableMapper.mapRequest_ and hence 
 _CryptoMapper.mapRequest_ returns _null_ resulting in a 404 error.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (WICKET-5560) A 404 error occurs when using a CryptoManager

2014-04-17 Thread Martin Grigorov (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov updated WICKET-5560:


Assignee: Emond Papegaaij

 A 404 error occurs when using a CryptoManager
 -

 Key: WICKET-5560
 URL: https://issues.apache.org/jira/browse/WICKET-5560
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.14.0
Reporter: Dirk Reichelt
Assignee: Emond Papegaaij

 Under certain prerequisites a 404 error occurs.
 The prerequisites are:
 - A CryptoMapper is used as RequestMapper
 - SecuritySettings.enforceMounts is set to true
 - Class SomePage is *not* annotated with @MountPath
 Reason:
 In _BookmarkableMapper.parseRequest_ (called indirectly by 
 _CryptoMapper.mapRequest_) the method _matches_ returns _false_,
 as _reverseUrl_ is the *encrypted URL* (_rootRequestMapper_ is a 
 _CryptoMapper_) but _BookmarkableMapper.matches_ expects a *decrypted URL*.
 _BookmarkableMapper_ - lines 132 ff.:
 {code}
 Url reverseUrl = application.getRootRequestMapper().mapHandler(
   new RenderPageRequestHandler(new PageProvider(pageClass)));
 if (!matches(request.cloneWithUrl(reverseUrl)))
 {
   return null;
 }
 {code}
   
 As a result _BookmarkableMapper.mapRequest_ and hence 
 _CryptoMapper.mapRequest_ returns _null_ resulting in a 404 error.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (WICKET-5560) A 404 error occurs when using a CryptoManager

2014-04-17 Thread Dirk Reichelt (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dirk Reichelt updated WICKET-5560:
--

Attachment: wicket5560.zip

 A 404 error occurs when using a CryptoManager
 -

 Key: WICKET-5560
 URL: https://issues.apache.org/jira/browse/WICKET-5560
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.14.0
Reporter: Dirk Reichelt
Assignee: Emond Papegaaij
 Attachments: wicket5560.zip


 Under certain prerequisites a 404 error occurs.
 The prerequisites are:
 - A CryptoMapper is used as RequestMapper
 - SecuritySettings.enforceMounts is set to true
 - Class SomePage is *not* annotated with @MountPath
 Reason:
 In _BookmarkableMapper.parseRequest_ (called indirectly by 
 _CryptoMapper.mapRequest_) the method _matches_ returns _false_,
 as _reverseUrl_ is the *encrypted URL* (_rootRequestMapper_ is a 
 _CryptoMapper_) but _BookmarkableMapper.matches_ expects a *decrypted URL*.
 _BookmarkableMapper_ - lines 132 ff.:
 {code}
 Url reverseUrl = application.getRootRequestMapper().mapHandler(
   new RenderPageRequestHandler(new PageProvider(pageClass)));
 if (!matches(request.cloneWithUrl(reverseUrl)))
 {
   return null;
 }
 {code}
   
 As a result _BookmarkableMapper.mapRequest_ and hence 
 _CryptoMapper.mapRequest_ returns _null_ resulting in a 404 error.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (WICKET-5560) A 404 error occurs when using a CryptoManager

2014-04-17 Thread Dirk Reichelt (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972860#comment-13972860
 ] 

Dirk Reichelt commented on WICKET-5560:
---

Attachment wicket5560.zip contains a quickstart app showing the bug.
(click on Click here in the HomePage to trigger the 404 error)
TestHomePage contains a test that fails due to the bug.

 A 404 error occurs when using a CryptoManager
 -

 Key: WICKET-5560
 URL: https://issues.apache.org/jira/browse/WICKET-5560
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.14.0
Reporter: Dirk Reichelt
Assignee: Emond Papegaaij
 Attachments: wicket5560.zip


 Under certain prerequisites a 404 error occurs.
 The prerequisites are:
 - A CryptoMapper is used as RequestMapper
 - SecuritySettings.enforceMounts is set to true
 - Class SomePage is *not* annotated with @MountPath
 Reason:
 In _BookmarkableMapper.parseRequest_ (called indirectly by 
 _CryptoMapper.mapRequest_) the method _matches_ returns _false_,
 as _reverseUrl_ is the *encrypted URL* (_rootRequestMapper_ is a 
 _CryptoMapper_) but _BookmarkableMapper.matches_ expects a *decrypted URL*.
 _BookmarkableMapper_ - lines 132 ff.:
 {code}
 Url reverseUrl = application.getRootRequestMapper().mapHandler(
   new RenderPageRequestHandler(new PageProvider(pageClass)));
 if (!matches(request.cloneWithUrl(reverseUrl)))
 {
   return null;
 }
 {code}
   
 As a result _BookmarkableMapper.mapRequest_ and hence 
 _CryptoMapper.mapRequest_ returns _null_ resulting in a 404 error.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (WICKET-5562) Make it possible to start wicket-examples with 'mvn jetty:run' again

2014-04-17 Thread Martin Grigorov (JIRA)
Martin Grigorov created WICKET-5562:
---

 Summary: Make it possible to start wicket-examples with 'mvn 
jetty:run' again
 Key: WICKET-5562
 URL: https://issues.apache.org/jira/browse/WICKET-5562
 Project: Wicket
  Issue Type: Bug
  Components: wicket-examples
Affects Versions: 6.14.0
Reporter: Martin Grigorov
Assignee: Emond Papegaaij


Since some months it is not possible to run the examples with 'mvn jetty:run' 
because of some CDI related issues.

I'd be thankful if this can be fixed because it really slows me down when 
validating a release.

The exception is:

2014-04-17 15:11:54.481:WARN:oejuc.AbstractLifeCycle:FAILED 
org.mortbay.jetty.plugin.JettyServer@7cc8e407: java.lang.LinkageError: loader 
constraint violation: when resolving overridden method 
org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
 the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
the current class, org/jboss/weld/Weld, and its superclass loader (instance of 
org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class objects 
for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used in the 
signature
java.lang.LinkageError: loader constraint violation: when resolving overridden 
method 
org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
 the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
the current class, org/jboss/weld/Weld, and its superclass loader (instance of 
org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class objects 
for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used in the 
signature
at 
org.jboss.weld.servlet.StaticWeldProvider$WeldSingleton.clinit(StaticWeldProvider.java:29)
at 
org.jboss.weld.servlet.StaticWeldProvider.getCDI(StaticWeldProvider.java:49)
at javax.enterprise.inject.spi.CDI.current(CDI.java:60)
at 
org.jboss.weld.servlet.WeldInitialListener.contextInitialized(WeldInitialListener.java:85)
at 
org.jboss.weld.servlet.api.helpers.ForwardingServletListener.contextInitialized(ForwardingServletListener.java:34)
at 
org.jboss.weld.environment.servlet.Listener.contextInitialized(Listener.java:171)
at 
org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:733)
...



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (WICKET-5561) Derived page without own markup leads to MarkupNotFoundException when BasePage has wicket:head in its markup

2014-04-17 Thread Dirk Reichelt (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dirk Reichelt updated WICKET-5561:
--

Attachment: wicket5561.zip

 Derived page without own markup leads to MarkupNotFoundException when 
 BasePage has wicket:head in its markup
 --

 Key: WICKET-5561
 URL: https://issues.apache.org/jira/browse/WICKET-5561
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.14.0
Reporter: Dirk Reichelt
 Attachments: wicket5561.zip


 Both Page1 and Page2 extend BasePage (which extends WebPage).
 BasePage.html:
 {code}
 html
 wicket:head
 ...
 /wicket:head
 body
 ...
 wicket:child/   
 ...
 /body
 /html
 {code}
 Page1.html:
 {code}
 wicket:extend
 ...
 /wicket:extend
 {code}
 Page2 hat no own markup (there is no Page2.html).
 Calling Page1 and then Page2 leads to the following MarkupNotFoundException:
 {code}
 org.apache.wicket.markup.MarkupNotFoundException
 'Markup not found for Component: [HtmlHeaderContainer [Component id = 
 _header_0]]'
 org.apache.wicket.Component.internalRender(Component.java:2349)
 org.apache.wicket.Component.render(Component.java:2309)
 org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1390)
 org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1555)
 org.apache.wicket.Page.onRender(Page.java:887)
 org.apache.wicket.markup.html.WebPage.onRender(WebPage.java:142)
 org.apache.wicket.Component.internalRender(Component.java:2381)
 org.apache.wicket.Component.render(Component.java:2309)
 org.apache.wicket.Page.renderPage(Page.java:1024)
 org.apache.wicket.request.handler.render.WebPageRenderer.renderPage(WebPageRenderer.java:121)
 org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:274)
 org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:175)
 org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:862)
 org.apache.wicket.request.RequestHandlerStack.execute(RequestHandlerStack.java:64)
 org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:261)
 org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:218)
 org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:289)
 org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:259)
 org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:201)
 org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:282)
 org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
 org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:581)
 org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
 java.lang.Thread.run(Thread.java:662)
 {code}
 (Calling Page2 without having called Page1 does not lead to a 
 MarkupNotFoundException.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (WICKET-5561) Derived page without own markup leads to MarkupNotFoundException when BasePage has wicket:head in its markup

2014-04-17 Thread Dirk Reichelt (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972879#comment-13972879
 ] 

Dirk Reichelt commented on WICKET-5561:
---

Attachment wicket5561.zip contains a quickstart app showing the bug.
(Click on Page1 in the HomePage, then go back to the HomePage (Browser back), 
then click on Page2 to trigger the MarkupNotFoundException)

TestHomePage contains the test _test1_ that fails due to the bug, as Page 1 is 
called before Page2.
The Test _test2_ does not fail, as Page1 ist not called before Page2.

 Derived page without own markup leads to MarkupNotFoundException when 
 BasePage has wicket:head in its markup
 --

 Key: WICKET-5561
 URL: https://issues.apache.org/jira/browse/WICKET-5561
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.14.0
Reporter: Dirk Reichelt
 Attachments: wicket5561.zip


 Both Page1 and Page2 extend BasePage (which extends WebPage).
 BasePage.html:
 {code}
 html
 wicket:head
 ...
 /wicket:head
 body
 ...
 wicket:child/   
 ...
 /body
 /html
 {code}
 Page1.html:
 {code}
 wicket:extend
 ...
 /wicket:extend
 {code}
 Page2 hat no own markup (there is no Page2.html).
 Calling Page1 and then Page2 leads to the following MarkupNotFoundException:
 {code}
 org.apache.wicket.markup.MarkupNotFoundException
 'Markup not found for Component: [HtmlHeaderContainer [Component id = 
 _header_0]]'
 org.apache.wicket.Component.internalRender(Component.java:2349)
 org.apache.wicket.Component.render(Component.java:2309)
 org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1390)
 org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1555)
 org.apache.wicket.Page.onRender(Page.java:887)
 org.apache.wicket.markup.html.WebPage.onRender(WebPage.java:142)
 org.apache.wicket.Component.internalRender(Component.java:2381)
 org.apache.wicket.Component.render(Component.java:2309)
 org.apache.wicket.Page.renderPage(Page.java:1024)
 org.apache.wicket.request.handler.render.WebPageRenderer.renderPage(WebPageRenderer.java:121)
 org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:274)
 org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:175)
 org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:862)
 org.apache.wicket.request.RequestHandlerStack.execute(RequestHandlerStack.java:64)
 org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:261)
 org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:218)
 org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:289)
 org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:259)
 org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:201)
 org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:282)
 org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
 org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:581)
 org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
 java.lang.Thread.run(Thread.java:662)
 {code}
 (Calling Page2 without having called Page1 does not lead to a 
 MarkupNotFoundException.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


git commit: Minor improvements in the javadoc

2014-04-17 Thread mgrigorov
Repository: wicket
Updated Branches:
  refs/heads/wicket-6.x 347301f7e - fe0686f6e


Minor improvements in the javadoc


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/fe0686f6
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/fe0686f6
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/fe0686f6

Branch: refs/heads/wicket-6.x
Commit: fe0686f6ec38b5016a5ed96722e7acd2443f5f12
Parents: 347301f
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Apr 17 15:41:49 2014 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Apr 17 15:41:49 2014 +0300

--
 wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java   | 2 +-
 wicket-core/src/main/java/org/apache/wicket/ThreadContext.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/fe0686f6/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java 
b/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java
index 64bb616..33bc181 100644
--- a/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java
+++ b/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java
@@ -29,7 +29,7 @@ import org.apache.wicket.util.io.IClusterable;
  * 
  * pre
  * code
- * public static MetaDataKeylt;Rolegt; ROLE = new MetaDataKeylt;Rolegt;() 
{ };
+ * public static final MetaDataKeylt;Rolegt; ROLE = new 
MetaDataKeylt;Rolegt;() { };
  * /code
  * /pre
  * 

http://git-wip-us.apache.org/repos/asf/wicket/blob/fe0686f6/wicket-core/src/main/java/org/apache/wicket/ThreadContext.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/ThreadContext.java 
b/wicket-core/src/main/java/org/apache/wicket/ThreadContext.java
index a4f3f7f..15facd3 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ThreadContext.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ThreadContext.java
@@ -53,7 +53,7 @@ public class ThreadContext
{
/*
 * There is no ThreadContext set, but the 
threadLocal.get() operation has registered
-* registered the threadLocal in this Thread's 
ThreadLocal map. We must now remove it.
+* the threadLocal in this Thread's ThreadLocal 
map. We must now remove it.
 */
threadLocal.remove();
}



git commit: Minor improvements in the javadoc

2014-04-17 Thread mgrigorov
Repository: wicket
Updated Branches:
  refs/heads/master d7a75a046 - ce3b837e8


Minor improvements in the javadoc

(cherry picked from commit fe0686f6ec38b5016a5ed96722e7acd2443f5f12)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/ce3b837e
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/ce3b837e
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ce3b837e

Branch: refs/heads/master
Commit: ce3b837e8c185ce5926e0adfe3f5e314ca1acaa2
Parents: d7a75a0
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Apr 17 15:41:49 2014 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Apr 17 15:43:22 2014 +0300

--
 wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java   | 2 +-
 wicket-core/src/main/java/org/apache/wicket/ThreadContext.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/ce3b837e/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java 
b/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java
index 64bb616..33bc181 100644
--- a/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java
+++ b/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java
@@ -29,7 +29,7 @@ import org.apache.wicket.util.io.IClusterable;
  * 
  * pre
  * code
- * public static MetaDataKeylt;Rolegt; ROLE = new MetaDataKeylt;Rolegt;() 
{ };
+ * public static final MetaDataKeylt;Rolegt; ROLE = new 
MetaDataKeylt;Rolegt;() { };
  * /code
  * /pre
  * 

http://git-wip-us.apache.org/repos/asf/wicket/blob/ce3b837e/wicket-core/src/main/java/org/apache/wicket/ThreadContext.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/ThreadContext.java 
b/wicket-core/src/main/java/org/apache/wicket/ThreadContext.java
index a4f3f7f..15facd3 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ThreadContext.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ThreadContext.java
@@ -53,7 +53,7 @@ public class ThreadContext
{
/*
 * There is no ThreadContext set, but the 
threadLocal.get() operation has registered
-* registered the threadLocal in this Thread's 
ThreadLocal map. We must now remove it.
+* the threadLocal in this Thread's ThreadLocal 
map. We must now remove it.
 */
threadLocal.remove();
}



[jira] [Updated] (WICKET-5562) Make it possible to start wicket-examples with 'mvn jetty:run' again

2014-04-17 Thread Emond Papegaaij (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emond Papegaaij updated WICKET-5562:


Assignee: Martin Grigorov  (was: Emond Papegaaij)

I'm unable to reproduce your exception. I do get an exception during startup, 
but this does not prevent the server from starting and everything works fine. 
This seems to be caused by a classloading problem in the maven classloader. I'm 
on maven 3.0.4.

 Make it possible to start wicket-examples with 'mvn jetty:run' again
 

 Key: WICKET-5562
 URL: https://issues.apache.org/jira/browse/WICKET-5562
 Project: Wicket
  Issue Type: Bug
  Components: wicket-examples
Affects Versions: 6.14.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov

 Since some months it is not possible to run the examples with 'mvn jetty:run' 
 because of some CDI related issues.
 I'd be thankful if this can be fixed because it really slows me down when 
 validating a release.
 The exception is:
 2014-04-17 15:11:54.481:WARN:oejuc.AbstractLifeCycle:FAILED 
 org.mortbay.jetty.plugin.JettyServer@7cc8e407: java.lang.LinkageError: loader 
 constraint violation: when resolving overridden method 
 org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
  the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
 the current class, org/jboss/weld/Weld, and its superclass loader (instance 
 of org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class 
 objects for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used 
 in the signature
 java.lang.LinkageError: loader constraint violation: when resolving 
 overridden method 
 org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
  the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
 the current class, org/jboss/weld/Weld, and its superclass loader (instance 
 of org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class 
 objects for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used 
 in the signature
   at 
 org.jboss.weld.servlet.StaticWeldProvider$WeldSingleton.clinit(StaticWeldProvider.java:29)
   at 
 org.jboss.weld.servlet.StaticWeldProvider.getCDI(StaticWeldProvider.java:49)
   at javax.enterprise.inject.spi.CDI.current(CDI.java:60)
   at 
 org.jboss.weld.servlet.WeldInitialListener.contextInitialized(WeldInitialListener.java:85)
   at 
 org.jboss.weld.servlet.api.helpers.ForwardingServletListener.contextInitialized(ForwardingServletListener.java:34)
   at 
 org.jboss.weld.environment.servlet.Listener.contextInitialized(Listener.java:171)
   at 
 org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:733)
 ...



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (WICKET-5562) Make it possible to start wicket-examples with 'mvn jetty:run' again

2014-04-17 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972898#comment-13972898
 ] 

Martin Grigorov commented on WICKET-5562:
-

Please try with a newer Maven. I use 3.2.1 here.

 Make it possible to start wicket-examples with 'mvn jetty:run' again
 

 Key: WICKET-5562
 URL: https://issues.apache.org/jira/browse/WICKET-5562
 Project: Wicket
  Issue Type: Bug
  Components: wicket-examples
Affects Versions: 6.14.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov

 Since some months it is not possible to run the examples with 'mvn jetty:run' 
 because of some CDI related issues.
 I'd be thankful if this can be fixed because it really slows me down when 
 validating a release.
 The exception is:
 2014-04-17 15:11:54.481:WARN:oejuc.AbstractLifeCycle:FAILED 
 org.mortbay.jetty.plugin.JettyServer@7cc8e407: java.lang.LinkageError: loader 
 constraint violation: when resolving overridden method 
 org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
  the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
 the current class, org/jboss/weld/Weld, and its superclass loader (instance 
 of org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class 
 objects for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used 
 in the signature
 java.lang.LinkageError: loader constraint violation: when resolving 
 overridden method 
 org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
  the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
 the current class, org/jboss/weld/Weld, and its superclass loader (instance 
 of org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class 
 objects for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used 
 in the signature
   at 
 org.jboss.weld.servlet.StaticWeldProvider$WeldSingleton.clinit(StaticWeldProvider.java:29)
   at 
 org.jboss.weld.servlet.StaticWeldProvider.getCDI(StaticWeldProvider.java:49)
   at javax.enterprise.inject.spi.CDI.current(CDI.java:60)
   at 
 org.jboss.weld.servlet.WeldInitialListener.contextInitialized(WeldInitialListener.java:85)
   at 
 org.jboss.weld.servlet.api.helpers.ForwardingServletListener.contextInitialized(ForwardingServletListener.java:34)
   at 
 org.jboss.weld.environment.servlet.Listener.contextInitialized(Listener.java:171)
   at 
 org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:733)
 ...



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (WICKET-5562) Make it possible to start wicket-examples with 'mvn jetty:run' again

2014-04-17 Thread Emond Papegaaij (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972912#comment-13972912
 ] 

Emond Papegaaij commented on WICKET-5562:
-

I'm using the stock ubuntu maven packages, which is 3.0.4 on saucy. Trusty 
comes with 3.0.5.

 Make it possible to start wicket-examples with 'mvn jetty:run' again
 

 Key: WICKET-5562
 URL: https://issues.apache.org/jira/browse/WICKET-5562
 Project: Wicket
  Issue Type: Bug
  Components: wicket-examples
Affects Versions: 6.14.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov

 Since some months it is not possible to run the examples with 'mvn jetty:run' 
 because of some CDI related issues.
 I'd be thankful if this can be fixed because it really slows me down when 
 validating a release.
 The exception is:
 2014-04-17 15:11:54.481:WARN:oejuc.AbstractLifeCycle:FAILED 
 org.mortbay.jetty.plugin.JettyServer@7cc8e407: java.lang.LinkageError: loader 
 constraint violation: when resolving overridden method 
 org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
  the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
 the current class, org/jboss/weld/Weld, and its superclass loader (instance 
 of org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class 
 objects for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used 
 in the signature
 java.lang.LinkageError: loader constraint violation: when resolving 
 overridden method 
 org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
  the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
 the current class, org/jboss/weld/Weld, and its superclass loader (instance 
 of org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class 
 objects for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used 
 in the signature
   at 
 org.jboss.weld.servlet.StaticWeldProvider$WeldSingleton.clinit(StaticWeldProvider.java:29)
   at 
 org.jboss.weld.servlet.StaticWeldProvider.getCDI(StaticWeldProvider.java:49)
   at javax.enterprise.inject.spi.CDI.current(CDI.java:60)
   at 
 org.jboss.weld.servlet.WeldInitialListener.contextInitialized(WeldInitialListener.java:85)
   at 
 org.jboss.weld.servlet.api.helpers.ForwardingServletListener.contextInitialized(ForwardingServletListener.java:34)
   at 
 org.jboss.weld.environment.servlet.Listener.contextInitialized(Listener.java:171)
   at 
 org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:733)
 ...



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (WICKET-5562) Make it possible to start wicket-examples with 'mvn jetty:run' again

2014-04-17 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972917#comment-13972917
 ] 

Martin Grigorov commented on WICKET-5562:
-

Let me know if you want me to explain you how to download a .tar.gz file from a 
site, how to extract it for example in /tmp, and how to use 
/tmp/apache-maven-3.2.1/bin/mvn for a single build to verify something !

 Make it possible to start wicket-examples with 'mvn jetty:run' again
 

 Key: WICKET-5562
 URL: https://issues.apache.org/jira/browse/WICKET-5562
 Project: Wicket
  Issue Type: Bug
  Components: wicket-examples
Affects Versions: 6.14.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov

 Since some months it is not possible to run the examples with 'mvn jetty:run' 
 because of some CDI related issues.
 I'd be thankful if this can be fixed because it really slows me down when 
 validating a release.
 The exception is:
 2014-04-17 15:11:54.481:WARN:oejuc.AbstractLifeCycle:FAILED 
 org.mortbay.jetty.plugin.JettyServer@7cc8e407: java.lang.LinkageError: loader 
 constraint violation: when resolving overridden method 
 org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
  the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
 the current class, org/jboss/weld/Weld, and its superclass loader (instance 
 of org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class 
 objects for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used 
 in the signature
 java.lang.LinkageError: loader constraint violation: when resolving 
 overridden method 
 org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
  the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
 the current class, org/jboss/weld/Weld, and its superclass loader (instance 
 of org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class 
 objects for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used 
 in the signature
   at 
 org.jboss.weld.servlet.StaticWeldProvider$WeldSingleton.clinit(StaticWeldProvider.java:29)
   at 
 org.jboss.weld.servlet.StaticWeldProvider.getCDI(StaticWeldProvider.java:49)
   at javax.enterprise.inject.spi.CDI.current(CDI.java:60)
   at 
 org.jboss.weld.servlet.WeldInitialListener.contextInitialized(WeldInitialListener.java:85)
   at 
 org.jboss.weld.servlet.api.helpers.ForwardingServletListener.contextInitialized(ForwardingServletListener.java:34)
   at 
 org.jboss.weld.environment.servlet.Listener.contextInitialized(Listener.java:171)
   at 
 org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:733)
 ...



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (WICKET-5562) Make it possible to start wicket-examples with 'mvn jetty:run' again

2014-04-17 Thread Martin Grigorov (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5562.
-

Resolution: Won't Fix

 Make it possible to start wicket-examples with 'mvn jetty:run' again
 

 Key: WICKET-5562
 URL: https://issues.apache.org/jira/browse/WICKET-5562
 Project: Wicket
  Issue Type: Bug
  Components: wicket-examples
Affects Versions: 6.14.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov

 Since some months it is not possible to run the examples with 'mvn jetty:run' 
 because of some CDI related issues.
 I'd be thankful if this can be fixed because it really slows me down when 
 validating a release.
 The exception is:
 2014-04-17 15:11:54.481:WARN:oejuc.AbstractLifeCycle:FAILED 
 org.mortbay.jetty.plugin.JettyServer@7cc8e407: java.lang.LinkageError: loader 
 constraint violation: when resolving overridden method 
 org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
  the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
 the current class, org/jboss/weld/Weld, and its superclass loader (instance 
 of org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class 
 objects for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used 
 in the signature
 java.lang.LinkageError: loader constraint violation: when resolving 
 overridden method 
 org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
  the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
 the current class, org/jboss/weld/Weld, and its superclass loader (instance 
 of org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class 
 objects for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used 
 in the signature
   at 
 org.jboss.weld.servlet.StaticWeldProvider$WeldSingleton.clinit(StaticWeldProvider.java:29)
   at 
 org.jboss.weld.servlet.StaticWeldProvider.getCDI(StaticWeldProvider.java:49)
   at javax.enterprise.inject.spi.CDI.current(CDI.java:60)
   at 
 org.jboss.weld.servlet.WeldInitialListener.contextInitialized(WeldInitialListener.java:85)
   at 
 org.jboss.weld.servlet.api.helpers.ForwardingServletListener.contextInitialized(ForwardingServletListener.java:34)
   at 
 org.jboss.weld.environment.servlet.Listener.contextInitialized(Listener.java:171)
   at 
 org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:733)
 ...



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (WICKET-5562) Make it possible to start wicket-examples with 'mvn jetty:run' again

2014-04-17 Thread Emond Papegaaij (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972930#comment-13972930
 ] 

Emond Papegaaij commented on WICKET-5562:
-

As I expected, this issue is caused by classes leaking through the maven 
classloaders. I've verified that the examples run fine on maven 3.0.5, but are 
broken since 3.1.0-alpha-1. I do not think this is something we can fix. It 
should probably be reported upstream, either to the jetty maintainers or the 
maven maintainers.

 Make it possible to start wicket-examples with 'mvn jetty:run' again
 

 Key: WICKET-5562
 URL: https://issues.apache.org/jira/browse/WICKET-5562
 Project: Wicket
  Issue Type: Bug
  Components: wicket-examples
Affects Versions: 6.14.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov

 Since some months it is not possible to run the examples with 'mvn jetty:run' 
 because of some CDI related issues.
 I'd be thankful if this can be fixed because it really slows me down when 
 validating a release.
 The exception is:
 2014-04-17 15:11:54.481:WARN:oejuc.AbstractLifeCycle:FAILED 
 org.mortbay.jetty.plugin.JettyServer@7cc8e407: java.lang.LinkageError: loader 
 constraint violation: when resolving overridden method 
 org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
  the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
 the current class, org/jboss/weld/Weld, and its superclass loader (instance 
 of org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class 
 objects for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used 
 in the signature
 java.lang.LinkageError: loader constraint violation: when resolving 
 overridden method 
 org.jboss.weld.Weld.select(Ljavax/enterprise/util/TypeLiteral;[Ljava/lang/annotation/Annotation;)Ljavax/enterprise/inject/Instance;
  the class loader (instance of org/eclipse/jetty/webapp/WebAppClassLoader) of 
 the current class, org/jboss/weld/Weld, and its superclass loader (instance 
 of org/codehaus/plexus/classworlds/realm/ClassRealm), have different Class 
 objects for the type tion/Annotation;)Ljavax/enterprise/inject/Instance; used 
 in the signature
   at 
 org.jboss.weld.servlet.StaticWeldProvider$WeldSingleton.clinit(StaticWeldProvider.java:29)
   at 
 org.jboss.weld.servlet.StaticWeldProvider.getCDI(StaticWeldProvider.java:49)
   at javax.enterprise.inject.spi.CDI.current(CDI.java:60)
   at 
 org.jboss.weld.servlet.WeldInitialListener.contextInitialized(WeldInitialListener.java:85)
   at 
 org.jboss.weld.servlet.api.helpers.ForwardingServletListener.contextInitialized(ForwardingServletListener.java:34)
   at 
 org.jboss.weld.environment.servlet.Listener.contextInitialized(Listener.java:171)
   at 
 org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:733)
 ...



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (WICKET-5560) A 404 error occurs when using a CryptoMapper

2014-04-17 Thread Dirk Reichelt (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dirk Reichelt updated WICKET-5560:
--

Description: 
Under certain prerequisites a 404 error occurs.

The prerequisites are:
- A _CryptoMapper_ is used as _RequestMapper_
- _SecuritySettings.enforceMounts_ is set to true
- Class _SomePage_ is *not* annotated with _@MountPath_

Reason:
In _BookmarkableMapper.parseRequest_ (called indirectly by 
_CryptoMapper.mapRequest_) the method _matches_ returns _false_,
as _reverseUrl_ is the *encrypted URL* (_rootRequestMapper_ is a 
_CryptoMapper_) but _BookmarkableMapper.matches_ expects a *decrypted URL*.

_BookmarkableMapper_ - lines 132 ff.:
{code}
Url reverseUrl = application.getRootRequestMapper().mapHandler(
new RenderPageRequestHandler(new PageProvider(pageClass)));
if (!matches(request.cloneWithUrl(reverseUrl)))
{
return null;
}
{code}

As a result _BookmarkableMapper.mapRequest_ and hence _CryptoMapper.mapRequest_ 
returns _null_ resulting in a 404 error.


  was:
Under certain prerequisites a 404 error occurs.

The prerequisites are:
- A CryptoMapper is used as RequestMapper
- SecuritySettings.enforceMounts is set to true
- Class SomePage is *not* annotated with @MountPath

Reason:
In _BookmarkableMapper.parseRequest_ (called indirectly by 
_CryptoMapper.mapRequest_) the method _matches_ returns _false_,
as _reverseUrl_ is the *encrypted URL* (_rootRequestMapper_ is a 
_CryptoMapper_) but _BookmarkableMapper.matches_ expects a *decrypted URL*.

_BookmarkableMapper_ - lines 132 ff.:
{code}
Url reverseUrl = application.getRootRequestMapper().mapHandler(
new RenderPageRequestHandler(new PageProvider(pageClass)));
if (!matches(request.cloneWithUrl(reverseUrl)))
{
return null;
}
{code}

As a result _BookmarkableMapper.mapRequest_ and hence _CryptoMapper.mapRequest_ 
returns _null_ resulting in a 404 error.


Summary: A 404 error occurs when using a CryptoMapper  (was: A 404 
error occurs when using a CryptoManager)

 A 404 error occurs when using a CryptoMapper
 

 Key: WICKET-5560
 URL: https://issues.apache.org/jira/browse/WICKET-5560
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.14.0
Reporter: Dirk Reichelt
Assignee: Emond Papegaaij
 Attachments: wicket5560.zip


 Under certain prerequisites a 404 error occurs.
 The prerequisites are:
 - A _CryptoMapper_ is used as _RequestMapper_
 - _SecuritySettings.enforceMounts_ is set to true
 - Class _SomePage_ is *not* annotated with _@MountPath_
 Reason:
 In _BookmarkableMapper.parseRequest_ (called indirectly by 
 _CryptoMapper.mapRequest_) the method _matches_ returns _false_,
 as _reverseUrl_ is the *encrypted URL* (_rootRequestMapper_ is a 
 _CryptoMapper_) but _BookmarkableMapper.matches_ expects a *decrypted URL*.
 _BookmarkableMapper_ - lines 132 ff.:
 {code}
 Url reverseUrl = application.getRootRequestMapper().mapHandler(
   new RenderPageRequestHandler(new PageProvider(pageClass)));
 if (!matches(request.cloneWithUrl(reverseUrl)))
 {
   return null;
 }
 {code}
   
 As a result _BookmarkableMapper.mapRequest_ and hence 
 _CryptoMapper.mapRequest_ returns _null_ resulting in a 404 error.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[CONF] Apache Wicket Migration to Wicket 6.0

2014-04-17 Thread Sven Meier (Confluence)














  


Sven Meier bearbeitete die Seite:
 


Migration to Wicket 6.0   






Migrating to Wicket 6.0
 



 Inhalt








minLevel
3


 




Environment

Wicket 6.0 requires at least Java 6

...

`StringValidator` will add the `maxlength` attribute if added to a component attached to an input tag
 MinimumValidator and MaximumValidator are replaced by RangeValidator.minimum and RangeValidator.maximum respectively
`AbstractValidator` has been removed
`ValidationError` now makes creating standard error keys (classname and classname.subtype) easier. Before one had to do: new ValidationError().addMessageKey(validator.getClass().getSimpleName()) to construct the default key, now you can simply say new ValidationError(validator) and it will do the above for you. Also, for more specific keys one had to do new ValidationError().addMessageKey(validator.getClass().getSimpleName()+.variant), now you can do new ValidationError(validator, variant).
  Most validators provide a `decorate(ValidationError, Validatable)` method for overriding how they report errors. For example, to add an extra resource key for the error message to StringValidator one can do 



 Codeblock




 

class MyStringValidator extends StringValidator {
ValidationError decorate(ValidationError error, IValidatable validatable) {
   

[8/8] git commit: Make experimental modules releasable in 6.x and 7.x

2014-04-17 Thread dashorst
Make experimental modules releasable in 6.x and 7.x

Having the experimental modules in one and the same groupid makes it
impossible to maintain the experimental modules in both 6.x and 7.x
branches--they will be unreleasable due to conflicting version numbers
and users will be confused which release is compatible with which
version of Wicket.

By moving the experimental modules into their own wicket version specific
group id, we can release both experimental modules with wicket releases
for the corresponding major branches.


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/f591343b
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/f591343b
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/f591343b

Branch: refs/heads/master
Commit: f591343b2ef42fda0518c7eaeecffb76f56845d5
Parents: 989c17a
Author: Martijn Dashorst dasho...@apache.org
Authored: Fri Apr 18 00:06:49 2014 +0200
Committer: Martijn Dashorst dasho...@apache.org
Committed: Fri Apr 18 00:06:49 2014 +0200

--
 pom.xml   | 2 +-
 testing/wicket-common-tests/pom.xml   | 2 +-
 wicket-examples/pom.xml   | 2 +-
 wicket-experimental/pom.xml   | 1 +
 wicket-experimental/wicket-atmosphere/pom.xml | 2 +-
 5 files changed, 5 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/f591343b/pom.xml
--
diff --git a/pom.xml b/pom.xml
index 4fd24a5..addd72b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -365,7 +365,7 @@
typejar/type
/dependency
dependency
-   groupIdorg.apache.wicket/groupId
+   
groupIdorg.apache.wicket.experimental.wicket-7.x/groupId
artifactIdwicket-atmosphere/artifactId
version0.10-SNAPSHOT/version
typejar/type

http://git-wip-us.apache.org/repos/asf/wicket/blob/f591343b/testing/wicket-common-tests/pom.xml
--
diff --git a/testing/wicket-common-tests/pom.xml 
b/testing/wicket-common-tests/pom.xml
index 6f594df..02d631f 100644
--- a/testing/wicket-common-tests/pom.xml
+++ b/testing/wicket-common-tests/pom.xml
@@ -104,7 +104,7 @@
scopetest/scope
/dependency
dependency
-   groupIdorg.apache.wicket/groupId
+   
groupIdorg.apache.wicket.experimental.wicket-7.x/groupId
artifactIdwicket-atmosphere/artifactId
scopetest/scope
/dependency

http://git-wip-us.apache.org/repos/asf/wicket/blob/f591343b/wicket-examples/pom.xml
--
diff --git a/wicket-examples/pom.xml b/wicket-examples/pom.xml
index 3d927e2..eecb7a2 100644
--- a/wicket-examples/pom.xml
+++ b/wicket-examples/pom.xml
@@ -44,7 +44,7 @@
artifactIdwicket-extensions/artifactId
/dependency
dependency
-   groupIdorg.apache.wicket/groupId
+   
groupIdorg.apache.wicket.experimental.wicket-7.x/groupId
artifactIdwicket-atmosphere/artifactId
/dependency
dependency

http://git-wip-us.apache.org/repos/asf/wicket/blob/f591343b/wicket-experimental/pom.xml
--
diff --git a/wicket-experimental/pom.xml b/wicket-experimental/pom.xml
index 8534744..15d79c3 100644
--- a/wicket-experimental/pom.xml
+++ b/wicket-experimental/pom.xml
@@ -23,6 +23,7 @@
version7.0.0-SNAPSHOT/version
relativePath../pom.xml/relativePath
/parent
+   groupIdorg.apache.wicket.experimental.wicket-7.x/groupId
artifactIdwicket-experimental/artifactId
packagingpom/packaging
nameWicket-Experimental/name

http://git-wip-us.apache.org/repos/asf/wicket/blob/f591343b/wicket-experimental/wicket-atmosphere/pom.xml
--
diff --git a/wicket-experimental/wicket-atmosphere/pom.xml 
b/wicket-experimental/wicket-atmosphere/pom.xml
index c375b42..ce1c272 100644
--- a/wicket-experimental/wicket-atmosphere/pom.xml
+++ b/wicket-experimental/wicket-atmosphere/pom.xml
@@ -18,7 +18,7 @@
 project xmlns=http://maven.apache.org/POM/4.0.0; 
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;

[1/8] Remove obsolete experimental modules

2014-04-17 Thread dashorst
Repository: wicket
Updated Branches:
  refs/heads/master ce3b837e8 - f591343b2


http://git-wip-us.apache.org/repos/asf/wicket/blob/989c17ad/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Labels.md
--
diff --git 
a/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Labels.md
 
b/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Labels.md
deleted file mode 100644
index b25ed28..000
--- 
a/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Labels.md
+++ /dev/null
@@ -1,99 +0,0 @@
-div class=page-header
-   h2Labels smallDisplaying text using labels, MultiLineLabels and 
escaping markup/small/h2
-/div
-
-With 
[Label](http://ci.apache.org/projects/wicket/apidocs/6.0.x/org/apache/wicket/markup/html/basic/Label.html)
-components you can display dynamic text in your pages and components.
-
-{% highlight java %}
-add(new LabelString(text, Hello, World!));
-{% endhighlight %}
-
-Like all Wicket components, the label needs a counterpart in the
-markup with the same wicket:id:
-
-{% highlight html %}
-span wicket:id=textgets replaced/span
-{% endhighlight %}
-
-Using models you can display fields from your entities in your pages:
-
-{% highlight java %}
-Person person = ...;
-add(new LabelString(text, new PropertyModelString(person, name)));
-{% endhighlight %}
-
-### Multi-line text
-
-HTML notoriously strips newlines from your text and renders
-everything like it is just one line of text. With MultiLineLabel you
-can render text like it is supposed to look with paragraphs and
-line-breaks.
-
-{% highlight java %}
-add(new Label(txt, Hello,\nWorld!));
-add(new MultiLineLabel(multi, Hello,\nWorld!));
-{% endhighlight %}
-
-Will render the following markup:
-
-{% highlight html %}
-pHello,
-World!/p
-pHello,br /World!/p
-{% endhighlight %}
-
-And that will result in text like:
-
-{% highlight html %}
-Hello, World!
-Hello,
-World!
-{% endhighlight %}
-
-Notice that the first label is displayed on a single line, while the
-`MultiLineLabel` correctly renders the text across multiple lines.
-
-### Label tags
-
-The associated markup tag can be anything: a `span`, `a`nchor,
-`p`aragraph, or even if you don't want a surrounding tag in the
-final markup a `wicket:container`. So for example:
-
-{% highlight html %}
-span wicket:id=t1/span
-p wicket:id=t2/p
-wicket:container wicket:id=t3/wicket:container
-{% endhighlight %}
-
-Will render as:
-
-{% highlight html %}
-spanHello, World!/span
-pHello, World!/p
-Hello, World!
-{% endhighlight %}
-
-You can also use `label.setRenderBodyOnly(true)` to instruct Wicket
-to just render the body.
-
-### Escaping markup
-
-By default, Wicket escapes all rendered text, preventing JavaScript
-injection attacks:
-
-{% highlight java %}
-add(new Label(bad,  lt;a onclick=\alert('Booh')\gt;Click 
melt;/agt;));
-{% endhighlight %}
-   
-Will render safely as the following markup:
-
-{% highlight html %}
-lt;a onclick=\quot;alert(#x27;Booh#x27;)\quot;gt;Click melt;/agt;
-{% endhighlight %}
-
-Which displays in the browser as:
-
-{% highlight html %}
-a onclick=\alert('Booh')\Click me/a
-{% endhighlight %}

http://git-wip-us.apache.org/repos/asf/wicket/blob/989c17ad/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Layout.md
--
diff --git 
a/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Layout.md
 
b/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Layout.md
deleted file mode 100644
index 26079ac..000
--- 
a/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Layout.md
+++ /dev/null
@@ -1,4 +0,0 @@
-div class=page-header
-   h2Layout smallPanels, borders, fragments, tabs and markup 
inheritance/small/h2
-/div
-

http://git-wip-us.apache.org/repos/asf/wicket/blob/989c17ad/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Links.md
--
diff --git 
a/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Links.md
 
b/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Links.md
deleted file mode 100644
index d10fd0d..000
--- 

[1/8] Remove obsolete experimental modules

2014-04-17 Thread dashorst
Repository: wicket
Updated Branches:
  refs/heads/wicket-6.x fe0686f6e - 1d32311db


http://git-wip-us.apache.org/repos/asf/wicket/blob/669e595a/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Labels.md
--
diff --git 
a/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Labels.md
 
b/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Labels.md
deleted file mode 100644
index b25ed28..000
--- 
a/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Labels.md
+++ /dev/null
@@ -1,99 +0,0 @@
-div class=page-header
-   h2Labels smallDisplaying text using labels, MultiLineLabels and 
escaping markup/small/h2
-/div
-
-With 
[Label](http://ci.apache.org/projects/wicket/apidocs/6.0.x/org/apache/wicket/markup/html/basic/Label.html)
-components you can display dynamic text in your pages and components.
-
-{% highlight java %}
-add(new LabelString(text, Hello, World!));
-{% endhighlight %}
-
-Like all Wicket components, the label needs a counterpart in the
-markup with the same wicket:id:
-
-{% highlight html %}
-span wicket:id=textgets replaced/span
-{% endhighlight %}
-
-Using models you can display fields from your entities in your pages:
-
-{% highlight java %}
-Person person = ...;
-add(new LabelString(text, new PropertyModelString(person, name)));
-{% endhighlight %}
-
-### Multi-line text
-
-HTML notoriously strips newlines from your text and renders
-everything like it is just one line of text. With MultiLineLabel you
-can render text like it is supposed to look with paragraphs and
-line-breaks.
-
-{% highlight java %}
-add(new Label(txt, Hello,\nWorld!));
-add(new MultiLineLabel(multi, Hello,\nWorld!));
-{% endhighlight %}
-
-Will render the following markup:
-
-{% highlight html %}
-pHello,
-World!/p
-pHello,br /World!/p
-{% endhighlight %}
-
-And that will result in text like:
-
-{% highlight html %}
-Hello, World!
-Hello,
-World!
-{% endhighlight %}
-
-Notice that the first label is displayed on a single line, while the
-`MultiLineLabel` correctly renders the text across multiple lines.
-
-### Label tags
-
-The associated markup tag can be anything: a `span`, `a`nchor,
-`p`aragraph, or even if you don't want a surrounding tag in the
-final markup a `wicket:container`. So for example:
-
-{% highlight html %}
-span wicket:id=t1/span
-p wicket:id=t2/p
-wicket:container wicket:id=t3/wicket:container
-{% endhighlight %}
-
-Will render as:
-
-{% highlight html %}
-spanHello, World!/span
-pHello, World!/p
-Hello, World!
-{% endhighlight %}
-
-You can also use `label.setRenderBodyOnly(true)` to instruct Wicket
-to just render the body.
-
-### Escaping markup
-
-By default, Wicket escapes all rendered text, preventing JavaScript
-injection attacks:
-
-{% highlight java %}
-add(new Label(bad,  lt;a onclick=\alert('Booh')\gt;Click 
melt;/agt;));
-{% endhighlight %}
-   
-Will render safely as the following markup:
-
-{% highlight html %}
-lt;a onclick=\quot;alert(#x27;Booh#x27;)\quot;gt;Click melt;/agt;
-{% endhighlight %}
-
-Which displays in the browser as:
-
-{% highlight html %}
-a onclick=\alert('Booh')\Click me/a
-{% endhighlight %}

http://git-wip-us.apache.org/repos/asf/wicket/blob/669e595a/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Layout.md
--
diff --git 
a/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Layout.md
 
b/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Layout.md
deleted file mode 100644
index 26079ac..000
--- 
a/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Layout.md
+++ /dev/null
@@ -1,4 +0,0 @@
-div class=page-header
-   h2Layout smallPanels, borders, fragments, tabs and markup 
inheritance/small/h2
-/div
-

http://git-wip-us.apache.org/repos/asf/wicket/blob/669e595a/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Links.md
--
diff --git 
a/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Links.md
 
b/wicket-experimental/wicket-examples-parent/wicket-examples-jar/src/main/java/org/apache/wicket/examples/components/Links.md
deleted file mode 100644
index d10fd0d..000
--- 

[8/8] git commit: Make experimental modules releasable in 6.x and 7.x

2014-04-17 Thread dashorst
Make experimental modules releasable in 6.x and 7.x

Having the experimental modules in one and the same groupid makes it
impossible to maintain the experimental modules in both 6.x and 7.x
branches--they will be unreleasable due to conflicting version numbers
and users will be confused which release is compatible with which
version of Wicket.

By moving the experimental modules into their own wicket version specific
group id, we can release both experimental modules with wicket releases
for the corresponding major branches.

Conflicts:
pom.xml
testing/wicket-common-tests/pom.xml


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/1d32311d
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/1d32311d
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/1d32311d

Branch: refs/heads/wicket-6.x
Commit: 1d32311dba362e7f4221d15b3b77df5e12628afa
Parents: 669e595
Author: Martijn Dashorst dasho...@apache.org
Authored: Fri Apr 18 00:06:49 2014 +0200
Committer: Martijn Dashorst dasho...@apache.org
Committed: Fri Apr 18 00:50:44 2014 +0200

--
 pom.xml   | 2 +-
 testing/wicket-common-tests/pom.xml   | 2 +-
 wicket-examples/pom.xml   | 2 +-
 wicket-experimental/pom.xml   | 1 +
 wicket-experimental/wicket-atmosphere/pom.xml | 2 +-
 5 files changed, 5 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/1d32311d/pom.xml
--
diff --git a/pom.xml b/pom.xml
index 1af1c42..0a809da 100644
--- a/pom.xml
+++ b/pom.xml
@@ -316,7 +316,7 @@
typejar/type
/dependency
dependency
-   groupIdorg.apache.wicket/groupId
+   
groupIdorg.apache.wicket.experimental.wicket-6.x/groupId
artifactIdwicket-atmosphere/artifactId
version0.18-SNAPSHOT/version
typejar/type

http://git-wip-us.apache.org/repos/asf/wicket/blob/1d32311d/testing/wicket-common-tests/pom.xml
--
diff --git a/testing/wicket-common-tests/pom.xml 
b/testing/wicket-common-tests/pom.xml
index 0362c1a..cfbcf9a 100644
--- a/testing/wicket-common-tests/pom.xml
+++ b/testing/wicket-common-tests/pom.xml
@@ -100,7 +100,7 @@
scopetest/scope
/dependency
dependency
-   groupIdorg.apache.wicket/groupId
+   
groupIdorg.apache.wicket.experimental.wicket-6.x/groupId
artifactIdwicket-atmosphere/artifactId
scopetest/scope
/dependency

http://git-wip-us.apache.org/repos/asf/wicket/blob/1d32311d/wicket-examples/pom.xml
--
diff --git a/wicket-examples/pom.xml b/wicket-examples/pom.xml
index 09b5b73..f3f7e97 100644
--- a/wicket-examples/pom.xml
+++ b/wicket-examples/pom.xml
@@ -40,7 +40,7 @@
artifactIdwicket-extensions/artifactId
/dependency
dependency
-   groupIdorg.apache.wicket/groupId
+   
groupIdorg.apache.wicket.experimental.wicket-6.x/groupId
artifactIdwicket-atmosphere/artifactId
/dependency
dependency

http://git-wip-us.apache.org/repos/asf/wicket/blob/1d32311d/wicket-experimental/pom.xml
--
diff --git a/wicket-experimental/pom.xml b/wicket-experimental/pom.xml
index 74b3192..b42d5d7 100644
--- a/wicket-experimental/pom.xml
+++ b/wicket-experimental/pom.xml
@@ -23,6 +23,7 @@
version6.15.0-SNAPSHOT/version
relativePath../pom.xml/relativePath
/parent
+   groupIdorg.apache.wicket.experimental.wicket-6.x/groupId
artifactIdwicket-experimental/artifactId
packagingpom/packaging
nameWicket-Experimental/name

http://git-wip-us.apache.org/repos/asf/wicket/blob/1d32311d/wicket-experimental/wicket-atmosphere/pom.xml
--
diff --git a/wicket-experimental/wicket-atmosphere/pom.xml 
b/wicket-experimental/wicket-atmosphere/pom.xml
index 1e3e9ff..058ef63 100644
--- a/wicket-experimental/wicket-atmosphere/pom.xml
+++ b/wicket-experimental/wicket-atmosphere/pom.xml
@@ -18,7 +18,7 @@
 project xmlns=http://maven.apache.org/POM/4.0.0; 
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation=http://maven.apache.org/POM/4.0.0