[jira] [Commented] (WICKET-6438) 8.x reference guide needs a few minor improvements
[ https://issues.apache.org/jira/browse/WICKET-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124594#comment-16124594 ] ASF GitHub Bot commented on WICKET-6438: Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/229 hi @ozeray , please close this issue as i don't have the rights to do it > 8.x reference guide needs a few minor improvements > -- > > Key: WICKET-6438 > URL: https://issues.apache.org/jira/browse/WICKET-6438 > Project: Wicket > Issue Type: Improvement > Components: guide >Affects Versions: 8.0.0 >Reporter: Ahmet Yaşar Özer >Assignee: Andrea Del Bene >Priority: Minor > Labels: documentation > > Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during > maven packaging phase: > WARNING: image to embed not found or not readable: > F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg > Minor fix in contributing.adoc: Revised the generated document target > directory for the user guide documentation. > Cropped top and bottom blank parts in comsysto-logo.png to have the > Introduction page fit in one page in PDF. Made minor changes in > helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6438) 8.x reference guide needs a few minor improvements
[ https://issues.apache.org/jira/browse/WICKET-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124592#comment-16124592 ] Andrea Del Bene commented on WICKET-6438: - Hi [~ahmetozer10], please create a new issue and pr for additional changes. Thank you! > 8.x reference guide needs a few minor improvements > -- > > Key: WICKET-6438 > URL: https://issues.apache.org/jira/browse/WICKET-6438 > Project: Wicket > Issue Type: Improvement > Components: guide >Affects Versions: 8.0.0 >Reporter: Ahmet Yaşar Özer >Assignee: Andrea Del Bene >Priority: Minor > Labels: documentation > > Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during > maven packaging phase: > WARNING: image to embed not found or not readable: > F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg > Minor fix in contributing.adoc: Revised the generated document target > directory for the user guide documentation. > Cropped top and bottom blank parts in comsysto-logo.png to have the > Introduction page fit in one page in PDF. Made minor changes in > helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (WICKET-6438) 8.x reference guide needs a few minor improvements
[ https://issues.apache.org/jira/browse/WICKET-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene resolved WICKET-6438. - Resolution: Fixed > 8.x reference guide needs a few minor improvements > -- > > Key: WICKET-6438 > URL: https://issues.apache.org/jira/browse/WICKET-6438 > Project: Wicket > Issue Type: Improvement > Components: guide >Affects Versions: 8.0.0 >Reporter: Ahmet Yaşar Özer >Assignee: Andrea Del Bene >Priority: Minor > Labels: documentation > > Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during > maven packaging phase: > WARNING: image to embed not found or not readable: > F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg > Minor fix in contributing.adoc: Revised the generated document target > directory for the user guide documentation. > Cropped top and bottom blank parts in comsysto-logo.png to have the > Introduction page fit in one page in PDF. Made minor changes in > helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6438) 8.x reference guide needs a few minor improvements
[ https://issues.apache.org/jira/browse/WICKET-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124591#comment-16124591 ] ASF subversion and git services commented on WICKET-6438: - Commit 075d8371ef3eb2e5f3bdadf008ae904cafd222b3 in wicket's branch refs/heads/master from ozeray [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=075d837 ] WICKET-6438 8.x reference guide needs a few minor improvements > 8.x reference guide needs a few minor improvements > -- > > Key: WICKET-6438 > URL: https://issues.apache.org/jira/browse/WICKET-6438 > Project: Wicket > Issue Type: Improvement > Components: guide >Affects Versions: 8.0.0 >Reporter: Ahmet Yaşar Özer >Assignee: Andrea Del Bene >Priority: Minor > Labels: documentation > > Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during > maven packaging phase: > WARNING: image to embed not found or not readable: > F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg > Minor fix in contributing.adoc: Revised the generated document target > directory for the user guide documentation. > Cropped top and bottom blank parts in comsysto-logo.png to have the > Introduction page fit in one page in PDF. Made minor changes in > helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
wicket git commit: WICKET-6438 8.x reference guide needs a few minor improvements
Repository: wicket Updated Branches: refs/heads/master 2cb93c323 -> 075d8371e WICKET-6438 8.x reference guide needs a few minor improvements Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/075d8371 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/075d8371 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/075d8371 Branch: refs/heads/master Commit: 075d8371ef3eb2e5f3bdadf008ae904cafd222b3 Parents: 2cb93c3 Author: ozerayAuthored: Sun Aug 6 03:12:03 2017 +0300 Committer: Andrea Del Bene Committed: Sat Aug 12 17:13:05 2017 +0200 -- .../src/main/asciidoc/contributing.adoc | 16 ++- .../src/main/asciidoc/helloWorld.adoc | 1 - .../main/asciidoc/helloWorld/helloWorld_2.adoc | 2 +- .../main/asciidoc/helloWorld/helloWorld_3.adoc | 2 +- .../src/main/asciidoc/img/comsysto-logo.png | Bin 9926 -> 12166 bytes .../main/asciidoc/img/page-panel-hierarchy.png | Bin 161128 -> 75309 bytes .../src/main/asciidoc/introduction.adoc | 6 ++-- .../asciidoc/keepControl/keepControl_1.adoc | 2 +- .../asciidoc/keepControl/keepControl_2.adoc | 4 +-- .../asciidoc/keepControl/keepControl_4.adoc | 10 --- .../asciidoc/keepControl/keepControl_5.adoc | 23 --- .../src/main/asciidoc/layout/layout_2.adoc | 4 +-- .../src/main/asciidoc/layout/layout_4.adoc | 20 ++--- .../asciidoc/wicketstuff/wicketstuff_1.adoc | 28 +-- 14 files changed, 79 insertions(+), 39 deletions(-) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/075d8371/wicket-user-guide/src/main/asciidoc/contributing.adoc -- diff --git a/wicket-user-guide/src/main/asciidoc/contributing.adoc b/wicket-user-guide/src/main/asciidoc/contributing.adoc index fab207f..e338e23 100644 --- a/wicket-user-guide/src/main/asciidoc/contributing.adoc +++ b/wicket-user-guide/src/main/asciidoc/contributing.adoc @@ -3,23 +3,25 @@ You can contribute to this guide by following these steps: * The guide uses AsciiDoctor to generate the final HTML/PDF so you should consult with its http://asciidoctor.org[syntax] -* Clone Apache Wicket's GIT repository https://github.com/apache/wicket.git[site] +* Fork Apache Wicket's GIT https://github.com/apache/wicket.git[repository] to your own github account. + +* Clone your forked copy of Apache Wicket's repository into your machine [source,java] -git clone https://github.com/apache/wicket.git +git clone https://github.com/<>/wicket.git * Edit the _.adoc_ files in `wicket/wicket-user-guide/src/main/asciidoctor` folder -* To preview your changes run _mvn clean package -P guide_ in the `wicket/wicket-user-guide` folder (in eclipse use a run configuration) +* To preview your changes run _mvn clean package -P guide_ in the `wicket/wicket-user-guide` folder (You may use a run configuration in your IDE) -* Navigate to _wicket/wicket-user-guide/target/guide/8.x_ and open one of the following files in a browser / pdf viewer: -** _guide/single.html_ (single page version) -** _guide/single.pdf_ (single page pdf version) +* Navigate to _wicket/wicket-user-guide/target/generated-docs_ and open one of the following files in a browser / pdf viewer: +** _single.html_ (single page version) +** _single.pdf_ (single page pdf version) * Create a ticket in Apache Wicket's https://issues.apache.org/jira/browse/WICKET[JIRA] -* *Commit and push the changes* to your forked Apache Wicket's GIT repository and *create a pull request* on github +* *Commit and push the changes* to your forked Apache Wicket's GIT repository and *create a pull request* on github (Enter the created JIRA ticket id into your pull request's title) *Thank you!* http://git-wip-us.apache.org/repos/asf/wicket/blob/075d8371/wicket-user-guide/src/main/asciidoc/helloWorld.adoc -- diff --git a/wicket-user-guide/src/main/asciidoc/helloWorld.adoc b/wicket-user-guide/src/main/asciidoc/helloWorld.adoc index b50e96c..52bec1b 100644 --- a/wicket-user-guide/src/main/asciidoc/helloWorld.adoc +++ b/wicket-user-guide/src/main/asciidoc/helloWorld.adoc @@ -4,7 +4,6 @@ Both frameworks share the same component-based architecture: in AWT we have a _W image::../img/uml-component.png[] -["plantuml", "uml-component", "svg"] @startuml package java.awt { http://git-wip-us.apache.org/repos/asf/wicket/blob/075d8371/wicket-user-guide/src/main/asciidoc/helloWorld/helloWorld_2.adoc -- diff --git a/wicket-user-guide/src/main/asciidoc/helloWorld/helloWorld_2.adoc
[2/3] wicket git commit: Added a note about the Marckdown version of the new release's announce
Added a note about the Marckdown version of the new release's announce Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/d851788a Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d851788a Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d851788a Branch: refs/heads/master Commit: d851788ab5fcbf648eec33eb479a608823c01409 Parents: dc1e9f8 Author: Andrea Del BeneAuthored: Mon Aug 7 12:00:33 2017 +0200 Committer: Andrea Del Bene Committed: Mon Aug 7 12:03:36 2017 +0200 -- release.sh | 3 +++ 1 file changed, 3 insertions(+) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/d851788a/release.sh -- diff --git a/release.sh b/release.sh index 242e11d..2eb352a 100755 --- a/release.sh +++ b/release.sh @@ -612,6 +612,9 @@ Use the release-announce.txt as a starter for the release announcement: cat release-announce.txt | pbcopy +A Markdown file called wicket-$version-released.md has been also generated. +You can use it to update the site with the release announcement. + To promote the release after a successful vote, run: $ ./promote-$version.sh
[1/3] wicket git commit: Added CHANGELOG for release 8.0.0-M7
Repository: wicket Updated Branches: refs/heads/master 2f23607e1 -> 2cb93c323 Added CHANGELOG for release 8.0.0-M7 Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/dc1e9f81 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/dc1e9f81 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/dc1e9f81 Branch: refs/heads/master Commit: dc1e9f816d2318470ccba11b76ec7618b826b10a Parents: 2f23607 Author: Andrea Del BeneAuthored: Mon Aug 7 11:50:01 2017 +0200 Committer: Andrea Del Bene Committed: Mon Aug 7 11:50:01 2017 +0200 -- CHANGELOG-8.x | 43 +++ 1 file changed, 43 insertions(+) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/dc1e9f81/CHANGELOG-8.x -- diff --git a/CHANGELOG-8.x b/CHANGELOG-8.x index e297fbf..5fd4d1c 100644 --- a/CHANGELOG-8.x +++ b/CHANGELOG-8.x @@ -2,6 +2,49 @@ This file contains all changes done in releases for Apache Wicket 8.x. === +Release Notes - Wicket - Version 8.0.0-M7 + +** Bug + +* [WICKET-4324] - [wicket-ioc] LazyInitProxyFactory CGLIB proxies naming strategy may cause java.lang.IllegalAccessError +* [WICKET-6366] - Autocomplete race condition makes page unresponsive +* [WICKET-6373] - Edge not recognized in UserAgent +* [WICKET-6374] - Exception caused by border extending another border with +* [WICKET-6376] - Ajax redirects to non http(s)-urls are interpreted as relative +* [WICKET-6377] - Autolinking breaks hierarchy for nested elements +* [WICKET-6379] - IModel's default models should detach the target model +* [WICKET-6386] - Simplification of the code in WICKET-3347 is not consistent with previous behavior +* [WICKET-6387] - ModalWindow PageReference broken +* [WICKET-6393] - NestedStringResourceLoader ignores hard-coded default values and throws MissingResourceException +* [WICKET-6398] - WICKET-6204 breaks jQuery.noConflict() +* [WICKET-6399] - Dequeuing of Border component with nested body fails +* [WICKET-6400] - Object with array property fails on NPE when construction JSON object +* [WICKET-6402] - OSGi-Manifest: wicket does not declare BSN +* [WICKET-6406] - Each path has to be pushed directly +* [WICKET-6419] - Localization of PageParameters +* [WICKET-6428] - PageProvider#getPageInstance() may return null +* [WICKET-6429] - AbstractRequestLogger should not create new Sessions +* [WICKET-6434] - Fixed WicketTester to detect components in enclosure when doing isComponentOnAjaxResponse. + +** Improvement + +* [WICKET-6372] - Consider to switch to a sans-serif typeface in the Wicket guide +* [WICKET-6385] - Allow using custom port for web socket connections +* [WICKET-6388] - MockServletContext should define non-null session tracking modes +* [WICKET-6389] - Introduce CsrfPreventionRequestCycleListener that is aware of Web Socket requests +* [WICKET-6401] - OSGi-Manifest: wicket-util should decalre its dependency to 'commons-io' and 'commons-fileupload' +* [WICKET-6412] - Model#orElse behavior is inconsistent! +* [WICKET-6421] - WicketTester should provide assertBehavior method +* [WICKET-6433] - Allow to set the rel attribute with CssHeaderItem +* [WICKET-6436] - Please add CompoundPropertyModel.of(T object) method +* [WICKET-6437] - Libraries should be updated to most recent versions + +** Task + +* [WICKET-6390] - Update Tomcat to 8.5.15 to get the latest HTTP2 features and APIs + +=== + Release Notes - Wicket - Version 8.0.0-M6 ** Bug
[3/3] wicket git commit: Start next development version
Start next development version Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/2cb93c32 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/2cb93c32 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/2cb93c32 Branch: refs/heads/master Commit: 2cb93c3233e269b1647f17a56eaf08a66f71443c Parents: d851788 Author: Andrea Del BeneAuthored: Sat Aug 12 17:05:55 2017 +0200 Committer: Andrea Del Bene Committed: Sat Aug 12 17:05:55 2017 +0200 -- pom.xml | 10 +- wicket-experimental/wicket-http2/pom.xml | 2 +- .../wicket-http2/wicket-http2-core/pom.xml| 2 +- .../wicket-http2/wicket-http2-jetty/pom.xml | 2 +- .../wicket-http2/wicket-http2-tomcat/pom.xml | 2 +- .../wicket-http2/wicket-http2-undertow/pom.xml| 2 +- wicket-experimental/wicket-metrics/pom.xml| 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/2cb93c32/pom.xml -- diff --git a/pom.xml b/pom.xml index ac0df56..a415b0a 100644 --- a/pom.xml +++ b/pom.xml @@ -398,31 +398,31 @@ org.apache.wicket.experimental.wicket8 wicket-metrics - 0.3-SNAPSHOT + 0.4-SNAPSHOT jar org.apache.wicket.experimental.wicket8 wicket-http2-core - 0.2-SNAPSHOT + 0.3-SNAPSHOT jar org.apache.wicket.experimental.wicket8 wicket-http2-jetty - 0.2-SNAPSHOT + 0.3-SNAPSHOT jar org.apache.wicket.experimental.wicket8 wicket-http2-tomcat - 0.2-SNAPSHOT + 0.3-SNAPSHOT jar org.apache.wicket.experimental.wicket8 wicket-http2-undertow - 0.2-SNAPSHOT + 0.3-SNAPSHOT jar http://git-wip-us.apache.org/repos/asf/wicket/blob/2cb93c32/wicket-experimental/wicket-http2/pom.xml -- diff --git a/wicket-experimental/wicket-http2/pom.xml b/wicket-experimental/wicket-http2/pom.xml index 72a30c2..e287d66 100644 --- a/wicket-experimental/wicket-http2/pom.xml +++ b/wicket-experimental/wicket-http2/pom.xml @@ -24,7 +24,7 @@ ../pom.xml wicket-http2 - 0.2-SNAPSHOT + 0.3-SNAPSHOT pom Wicket Http/2 http://git-wip-us.apache.org/repos/asf/wicket/blob/2cb93c32/wicket-experimental/wicket-http2/wicket-http2-core/pom.xml -- diff --git a/wicket-experimental/wicket-http2/wicket-http2-core/pom.xml b/wicket-experimental/wicket-http2/wicket-http2-core/pom.xml index f5c50cd..d8f4f45 100644 --- a/wicket-experimental/wicket-http2/wicket-http2-core/pom.xml +++ b/wicket-experimental/wicket-http2/wicket-http2-core/pom.xml @@ -20,7 +20,7 @@ org.apache.wicket.experimental.wicket8 wicket-http2 - 0.2-SNAPSHOT + 0.3-SNAPSHOT ../pom.xml wicket-http2-core http://git-wip-us.apache.org/repos/asf/wicket/blob/2cb93c32/wicket-experimental/wicket-http2/wicket-http2-jetty/pom.xml -- diff --git a/wicket-experimental/wicket-http2/wicket-http2-jetty/pom.xml b/wicket-experimental/wicket-http2/wicket-http2-jetty/pom.xml index 00e313e..792ebe4 100644 --- a/wicket-experimental/wicket-http2/wicket-http2-jetty/pom.xml +++ b/wicket-experimental/wicket-http2/wicket-http2-jetty/pom.xml @@ -20,7 +20,7 @@ org.apache.wicket.experimental.wicket8 wicket-http2 - 0.2-SNAPSHOT + 0.3-SNAPSHOT ../pom.xml
svn commit: r21033 - /release/wicket/8.0.0-M6/
Author: adelbene Date: Sat Aug 12 15:02:56 2017 New Revision: 21033 Log: Remove previous version from mirrors Removed: release/wicket/8.0.0-M6/
svn commit: r21032 - /dev/wicket/8.0.0-M7/ /release/wicket/8.0.0-M7/
Author: adelbene Date: Sat Aug 12 15:02:07 2017 New Revision: 21032 Log: Upload release to the mirrors Added: release/wicket/8.0.0-M7/ - copied from r21031, dev/wicket/8.0.0-M7/ Removed: dev/wicket/8.0.0-M7/
[wicket] Git Push Summary
Repository: wicket Updated Tags: refs/tags/rel/wicket-8.0.0-M7 [created] ac2c91ae0
[jira] [Commented] (WICKET-6438) 8.x reference guide needs a few minor improvements
[ https://issues.apache.org/jira/browse/WICKET-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124578#comment-16124578 ] Ahmet Yaşar Özer commented on WICKET-6438: -- Hello. Could anybody let me know, should I push my new local commits into this pull request, or wait for this PR to complete? I guess pushing too many commits into one PR may complicate the process. What to do? > 8.x reference guide needs a few minor improvements > -- > > Key: WICKET-6438 > URL: https://issues.apache.org/jira/browse/WICKET-6438 > Project: Wicket > Issue Type: Improvement > Components: guide >Affects Versions: 8.0.0 >Reporter: Ahmet Yaşar Özer >Assignee: Andrea Del Bene >Priority: Minor > Labels: documentation > > Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during > maven packaging phase: > WARNING: image to embed not found or not readable: > F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg > Minor fix in contributing.adoc: Revised the generated document target > directory for the user guide documentation. > Cropped top and bottom blank parts in comsysto-logo.png to have the > Introduction page fit in one page in PDF. Made minor changes in > helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (WICKET-6444) OnDomReadyHeaderItem is not being called by WicketTester
[ https://issues.apache.org/jira/browse/WICKET-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sven Meier resolved WICKET-6444. Resolution: Invalid Assignee: Sven Meier WicketTester does not execute JavaScript, you'll have to trigger your behavior explicitly by yourself. > OnDomReadyHeaderItem is not being called by WicketTester > > > Key: WICKET-6444 > URL: https://issues.apache.org/jira/browse/WICKET-6444 > Project: Wicket > Issue Type: Bug >Reporter: Kamil >Assignee: Sven Meier > > I have a Panel: > {code} > public class MyPanel extends Panel { >private AbstractDefaultAjaxBehavior onPageLoadEvent; >public MyPanel(final String id, final IModel model) { > super(id, model); >} > >@Override >protected void onInitialize() { > super.onInitialize(); > onPageLoadEvent = new AbstractDefaultAjaxBehavior() { > @Override > protected void respond(AjaxRequestTarget target) { > > ((IModel)getDefaultModel()).setObject("Invoked"); > } > }; > add(onPageLoadEvent); >} > >@Override >public void renderHead(IHeaderResponse response) { > super.renderHead(response); > > response.render(OnDomReadyHeaderItem.forScript(onPageLoadEvent.getCallbackScript())); >} > } > {code} > and when I open the webpage, where this Panel is placed, model object is > being set to "Invoked", but Wicket tester: > {code} > @Test > public void shouldInvokeAjaxBehavior() throws Exception { > // given > Model model = Model.of(""); > // when > wicketTester.startComponentInPage(new MyPanel("test", model)); > // then > assertThat(model.getObject()).isEqualTo("Invoked"); > } > {code} > doesn't invoke this Ajax call (I checked in debug mode) -- This message was sent by Atlassian JIRA (v6.4.14#64029)