svn commit: r21474 - in /dev/wicket/7.8.1: ./ binaries/
Author: adelbene Date: Tue Sep 5 20:06:13 2017 New Revision: 21474 Log: Upload wicket-7.8.1 to staging area Added: dev/wicket/7.8.1/CHANGELOG-7.x dev/wicket/7.8.1/apache-wicket-7.8.1.tar.gz (with props) dev/wicket/7.8.1/apache-wicket-7.8.1.tar.gz.asc dev/wicket/7.8.1/apache-wicket-7.8.1.tar.gz.md5 dev/wicket/7.8.1/apache-wicket-7.8.1.tar.gz.sha dev/wicket/7.8.1/apache-wicket-7.8.1.zip (with props) dev/wicket/7.8.1/apache-wicket-7.8.1.zip.asc dev/wicket/7.8.1/apache-wicket-7.8.1.zip.md5 dev/wicket/7.8.1/apache-wicket-7.8.1.zip.sha dev/wicket/7.8.1/binaries/ dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.tar.gz (with props) dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.tar.gz.asc dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.tar.gz.md5 dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.tar.gz.sha dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.zip (with props) dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.zip.asc dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.zip.md5 dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.zip.sha Added: dev/wicket/7.8.1/CHANGELOG-7.x == --- dev/wicket/7.8.1/CHANGELOG-7.x (added) +++ dev/wicket/7.8.1/CHANGELOG-7.x Tue Sep 5 20:06:13 2017 @@ -0,0 +1,766 @@ +This file contains all changes done in releases for Apache Wicket 7.x. + +=== + +Release Notes - Wicket - Version 7.8.1 + +** Bug + +* [WICKET-6457] - PageStore not cleared at session end + +Release Notes - Wicket - Version 7.8.0 + +** Bug + +* [WICKET-4324] - [wicket-ioc] LazyInitProxyFactory CGLIB proxies naming strategy may cause java.lang.IllegalAccessError +* [WICKET-6362] - HeaderItems with different PageParameters are treated as identical +* [WICKET-6366] - Autocomplete race condition makes page unresponsive +* [WICKET-6373] - Edge not recognized in UserAgent +* [WICKET-6374] - Exception caused by border extending another border with +* [WICKET-6376] - Ajax redirects to non http(s)-urls are interpreted as relative +* [WICKET-6377] - Autolinking breaks hierarchy for nested elements +* [WICKET-6386] - Simplification of the code in WICKET-3347 is not consistent with previous behavior +* [WICKET-6387] - ModalWindow PageReference broken +* [WICKET-6393] - NestedStringResourceLoader ignores hard-coded default values and throws MissingResourceException +* [WICKET-6398] - WICKET-6204 breaks jQuery.noConflict() +* [WICKET-6399] - Dequeuing of Border component with nested body fails +* [WICKET-6400] - Object with array property fails on NPE when construction JSON object + +** Improvement + +* [WICKET-6372] - Consider to switch to a sans-serif typeface in the Wicket guide +* [WICKET-6385] - Allow using custom port for web socket connections +* [WICKET-6389] - Introduce CsrfPreventionRequestCycleListener that is aware of Web Socket requests +* [WICKET-6401] - OSGi-Manifest: wicket-util should decalre its dependency to 'commons-io' and 'commons-fileupload' + +** Task + +* [WICKET-6391] - Deprecate the classes and methods which now throw runtime exception after the switch to OpenJson + +=== + +Release Notes - Wicket - Version 7.7.0 + +** Bug + +* [WICKET-6165] - Inconsistent behavior of Markupstream.hasMore vs. MarkupStream.next. +* [WICKET-6303] - renderHead method of a Behavior added to a Border body is not called +* [WICKET-6306] - Changing model object of Panel added to a Border not allowed +* [WICKET-6311] - SignOutPage_ru.html is missing +* [WICKET-6314] - 7.6 release references 7.5-SNAPSHOT poms +* [WICKET-6316] - Wicket tester encodes page id for stateless links in stateless pages +* [WICKET-6317] - AuthenticatedWebSession#signOut() calls twice after session invalidation +* [WICKET-6319] - AutoCompleteTextField: popup is hidden when clicking on scrollbar in IE +* [WICKET-6332] - NullPointerException in PageParameters#equals() +* [WICKET-6339] - Wrong implementation of MarkupFragment.iterator() +* [WICKET-6340] - The Ajax reponse of an AjaxSubmitButton creates invalid XHTML markup for multipart forms +* [WICKET-6342] - Wrong baseUrl in BaseWebSocketBehavior +* [WICKET-6349] - Stateless form does not work when RecreateBookmarkablePagesAfterExpiry is false +* [WICKET-6353] - Proxy deserialization fails due to classloading issues +* [WICKET-6356] - Clustering failover not working on Tomcat +* [WICKET-6361] - MarkupContainer#queue doesn't work in table column +* [WICKET-6365] - Links on "Contribute to the User Guide" are broken + +** Improvement + +* [WICKET-6212] - CheckChoice / add a getAdditionalAttributes() also for -tag +* [WICKET-6265] - Make it po
svn commit: r21473 - /dev/wicket/7.8.1/
Author: adelbene Date: Tue Sep 5 20:03:56 2017 New Revision: 21473 Log: Create 7.8.1 release staging area Added: dev/wicket/7.8.1/
svn commit: r21470 - /dev/wicket/7.8.1/
Author: adelbene Date: Tue Sep 5 19:15:07 2017 New Revision: 21470 Log: Release vote has failed Removed: dev/wicket/7.8.1/
svn commit: r21469 - in /dev/wicket/7.8.1: ./ binaries/
Author: adelbene Date: Tue Sep 5 19:04:14 2017 New Revision: 21469 Log: Upload wicket-7.8.1 to staging area Added: dev/wicket/7.8.1/CHANGELOG-7.x dev/wicket/7.8.1/apache-wicket-7.8.1.tar.gz (with props) dev/wicket/7.8.1/apache-wicket-7.8.1.tar.gz.asc dev/wicket/7.8.1/apache-wicket-7.8.1.tar.gz.md5 dev/wicket/7.8.1/apache-wicket-7.8.1.tar.gz.sha dev/wicket/7.8.1/apache-wicket-7.8.1.zip (with props) dev/wicket/7.8.1/apache-wicket-7.8.1.zip.asc dev/wicket/7.8.1/apache-wicket-7.8.1.zip.md5 dev/wicket/7.8.1/apache-wicket-7.8.1.zip.sha dev/wicket/7.8.1/binaries/ dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.tar.gz (with props) dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.tar.gz.asc dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.tar.gz.md5 dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.tar.gz.sha dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.zip (with props) dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.zip.asc dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.zip.md5 dev/wicket/7.8.1/binaries/apache-wicket-7.8.1-bin.zip.sha Added: dev/wicket/7.8.1/CHANGELOG-7.x == --- dev/wicket/7.8.1/CHANGELOG-7.x (added) +++ dev/wicket/7.8.1/CHANGELOG-7.x Tue Sep 5 19:04:14 2017 @@ -0,0 +1,760 @@ +This file contains all changes done in releases for Apache Wicket 7.x. + +=== + +Release Notes - Wicket - Version 7.8.0 + +** Bug + +* [WICKET-4324] - [wicket-ioc] LazyInitProxyFactory CGLIB proxies naming strategy may cause java.lang.IllegalAccessError +* [WICKET-6362] - HeaderItems with different PageParameters are treated as identical +* [WICKET-6366] - Autocomplete race condition makes page unresponsive +* [WICKET-6373] - Edge not recognized in UserAgent +* [WICKET-6374] - Exception caused by border extending another border with +* [WICKET-6376] - Ajax redirects to non http(s)-urls are interpreted as relative +* [WICKET-6377] - Autolinking breaks hierarchy for nested elements +* [WICKET-6386] - Simplification of the code in WICKET-3347 is not consistent with previous behavior +* [WICKET-6387] - ModalWindow PageReference broken +* [WICKET-6393] - NestedStringResourceLoader ignores hard-coded default values and throws MissingResourceException +* [WICKET-6398] - WICKET-6204 breaks jQuery.noConflict() +* [WICKET-6399] - Dequeuing of Border component with nested body fails +* [WICKET-6400] - Object with array property fails on NPE when construction JSON object + +** Improvement + +* [WICKET-6372] - Consider to switch to a sans-serif typeface in the Wicket guide +* [WICKET-6385] - Allow using custom port for web socket connections +* [WICKET-6389] - Introduce CsrfPreventionRequestCycleListener that is aware of Web Socket requests +* [WICKET-6401] - OSGi-Manifest: wicket-util should decalre its dependency to 'commons-io' and 'commons-fileupload' + +** Task + +* [WICKET-6391] - Deprecate the classes and methods which now throw runtime exception after the switch to OpenJson + +=== + +Release Notes - Wicket - Version 7.7.0 + +** Bug + +* [WICKET-6165] - Inconsistent behavior of Markupstream.hasMore vs. MarkupStream.next. +* [WICKET-6303] - renderHead method of a Behavior added to a Border body is not called +* [WICKET-6306] - Changing model object of Panel added to a Border not allowed +* [WICKET-6311] - SignOutPage_ru.html is missing +* [WICKET-6314] - 7.6 release references 7.5-SNAPSHOT poms +* [WICKET-6316] - Wicket tester encodes page id for stateless links in stateless pages +* [WICKET-6317] - AuthenticatedWebSession#signOut() calls twice after session invalidation +* [WICKET-6319] - AutoCompleteTextField: popup is hidden when clicking on scrollbar in IE +* [WICKET-6332] - NullPointerException in PageParameters#equals() +* [WICKET-6339] - Wrong implementation of MarkupFragment.iterator() +* [WICKET-6340] - The Ajax reponse of an AjaxSubmitButton creates invalid XHTML markup for multipart forms +* [WICKET-6342] - Wrong baseUrl in BaseWebSocketBehavior +* [WICKET-6349] - Stateless form does not work when RecreateBookmarkablePagesAfterExpiry is false +* [WICKET-6353] - Proxy deserialization fails due to classloading issues +* [WICKET-6356] - Clustering failover not working on Tomcat +* [WICKET-6361] - MarkupContainer#queue doesn't work in table column +* [WICKET-6365] - Links on "Contribute to the User Guide" are broken + +** Improvement + +* [WICKET-6212] - CheckChoice / add a getAdditionalAttributes() also for -tag +* [WICKET-6265] - Make it possible to authorize component instantiations both with OR and AND rules +* [WICKET-6307] - SubmitLink does no
svn commit: r21467 - /dev/wicket/7.8.1/
Author: adelbene Date: Tue Sep 5 19:02:00 2017 New Revision: 21467 Log: Create 7.8.1 release staging area Added: dev/wicket/7.8.1/
wicket git commit: Added CHANGELOG for release 6.28.0
Repository: wicket Updated Branches: refs/heads/wicket-6.x 45227b059 -> 98fbb6853 Added CHANGELOG for release 6.28.0 Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/98fbb685 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/98fbb685 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/98fbb685 Branch: refs/heads/wicket-6.x Commit: 98fbb68530ace0c702a0600568dd63f078d222a4 Parents: 45227b0 Author: Andrea Del Bene Authored: Wed Aug 30 21:42:07 2017 +0200 Committer: Andrea Del Bene Committed: Wed Aug 30 21:43:10 2017 +0200 -- CHANGELOG-6.x | 8 1 file changed, 8 insertions(+) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/98fbb685/CHANGELOG-6.x -- diff --git a/CHANGELOG-6.x b/CHANGELOG-6.x index 29639ad..4096da5 100644 --- a/CHANGELOG-6.x +++ b/CHANGELOG-6.x @@ -2,6 +2,14 @@ This file contains all changes done in releases for Apache Wicket 6.x. === +Release Notes - Wicket - Version 6.27.1 + +** Bug + +* [WICKET-6457] - PageStore not cleared at session end + +=== + Release Notes - Wicket - Version 6.27.0 ** Bug
Oakley Sunglass Warehouse
From: Oakley Sunglass Warehouse Email: wicket-comm...@apache.org -- Hi It's our birthday and we are celebrating 2 years of our outlet. We'd like to offer you only 19.95 USD for all styles of Oakley and Ray Ban Sunglasses. Please visit our online store for more details: http://tinyurl.com/y7dlgcrv YOU WON'T WANT TO MISS THESE OFFERS To your success! Regards, Mila Oakley Sunglass Warehouse --
[jira] [Updated] (WICKET-6461) Default constructor is incorrectly called if optional param is not provided in parameter placeholder URL with additional required parameter
[
https://issues.apache.org/jira/browse/WICKET-6461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Melissa Beldman updated WICKET-6461:
Attachment: quickstartPP.zip
Quickstart Added.
> Default constructor is incorrectly called if optional param is not provided
> in parameter placeholder URL with additional required parameter
> ---
>
> Key: WICKET-6461
> URL: https://issues.apache.org/jira/browse/WICKET-6461
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 6.22.0
>Reporter: Melissa Beldman
> Attachments: quickstartPP.zip
>
>
> From the documentation here:
> https://ci.apache.org/projects/wicket/guide/6.x/guide/urls.html
> I'm following the section titled, "Using parameter placeholders with mounted
> pages".
> In the documentation from here:
> https://cwiki.apache.org/confluence/display/WICKET/Request+mapping
> {code}
> Named parameters - /page/${named1}/${named2}
> mountPage("/page/${named1}/${named2}", MyPage.class);
> Now a request to "/page/a/b" will be handled by MyPage and the parameters can
> be get with PageParameters.get(String) (e.g. parameters.get("named1") will
> return "a")
> Optional named parameters - /page/${named1}/#{named2\
> mountPage("/page/${named1}/#{named2}", MyPage.class);
> This means the second parameter is optional. Requests to "/page/a/b" ,
> "/page/a/b/" and "/page/a/" will be handled by MyPage and the parameters can
> be get with PageParameters.get(String) (e.g. parameters.get("named2") will
> return "b" for the first case and null for the second).
> The mapper is smart enough to handle optional named parameters in any
> segment, not just the last one.
> {code}
> it states: "The mapper is smart enough to handle optional named parameters in
> any segment, not just the last one."
> I've found it does matter IF other segments in the url are also parameter
> placeholders. The resulting behaviour is that if the optional parameter
> placeholder isn't provided in the URL, the page's default constructor gets
> called instead of the PageParameter constructor as expected (since there are
> still additional PageParameter data that may need to be processed by the
> page).
> Here is my example:
> From child class of AdtAuthenticatedWebApplication
> {code}
> @Override
> protected void init()
> {
> super.init();
> mountPage("/foo/#{optParam}/${otherParam}", MyPage.class);
> //mountPage("/foo/${otherParam}/#{optParam}", MyPage.class); <--- NOTE:
> This works as expected
> }
> {code}
> In child class of WebPage
> {code}
> public class MyPage extends WebPage
> {
> public MyPage(PageParameters parameters)
> {
> super(parameters);
> StringValue optParam = parameters.get("optParam");
> StringValue otherParam = parameters.get("otherParam");
>//do something...
> }
> private MyPage()
> {
> throw new IllegalAccessError("The default constructor should not be
> instantiated");
> }
> {code}
> And in a different class:
> {code}
> public static BookmarkablePageLink getBookmarkableLink(String id, String
> optParam, String otherParam)
> {
> PageParameters pageParam = new PageParameters();
>
> pageParam.add("otherParam", otherParam);
> if (optParam != null && !optParam.isEmpty())
> {
> pageParam.add("optParam", optParam);
> }
>
> return new BookmarkablePageLink(id, MyPage.class, pageParam);
>
> }
> {code}
> Here are the result of clicking on the BookmarkablePageLinks created:
> {code}
> /foo/baz/bar -- calls MyPage(PageParameters parameters) constructor
> /foo/bar -- attempts to call MyPage default constructor (exception thrown)
> {code}
> Exception thrown is:
> {code}
> Last cause: Class org.apache.wicket.session.DefaultPageFactory can not access
> a member of class ca.example.for.testing.MyPage with modifiers "private"
> WicketMessage: Can't instantiate page using constructor 'private
> ca.example.for.testing.MyPage()'. This constructor is private!
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
buildbot success in on wicket-branch-7.x
The Buildbot has detected a restored build on builder wicket-branch-7.x while building wicket. Full details are available at: https://ci.apache.org/builders/wicket-branch-7.x/builds/439 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The SingleBranchScheduler scheduler named 'on-wicket-branch-7.x-commit' triggered this build Build Source Stamp: [branch wicket-7.x] dc6d948790733bc99c0d9d750b6c8f27c15d5910 Blamelist: Andrea Del Bene Build succeeded! Sincerely, -The Buildbot
[jira] [Commented] (WICKET-6462) When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called twice
[ https://issues.apache.org/jira/browse/WICKET-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153886#comment-16153886 ] ASF subversion and git services commented on WICKET-6462: - Commit dc6d948790733bc99c0d9d750b6c8f27c15d5910 in wicket's branch refs/heads/wicket-7.x from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=dc6d948 ] WICKET-6462 fixed syntax for Java 7 > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > --- > > Key: WICKET-6462 > URL: https://issues.apache.org/jira/browse/WICKET-6462 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M7, 8.0.0-M8 > Environment: 8.0.0-SNAPSHOT - 2017 08 31 >Reporter: francois >Assignee: Andrea Del Bene >Priority: Critical > Attachments: wicket_quickstart.zip > > > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > The appears after WICKET-6455. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
wicket git commit: WICKET-6462 fixed syntax for Java 7
Repository: wicket
Updated Branches:
refs/heads/wicket-7.x 08be805e1 -> dc6d94879
WICKET-6462 fixed syntax for Java 7
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/dc6d9487
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/dc6d9487
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/dc6d9487
Branch: refs/heads/wicket-7.x
Commit: dc6d948790733bc99c0d9d750b6c8f27c15d5910
Parents: 08be805
Author: Andrea Del Bene
Authored: Tue Sep 5 17:59:12 2017 +0200
Committer: Andrea Del Bene
Committed: Tue Sep 5 17:59:12 2017 +0200
--
.../src/main/java/org/apache/wicket/markup/html/form/Form.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/dc6d9487/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
index da0e1e4..2f12c7a 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
@@ -1019,7 +1019,7 @@ public class Form extends WebMarkupContainer
private void markFormsSubmitted(IFormSubmitter submitter)
{
setFlag(FLAG_SUBMITTED, true);
- Form formToProcess = findFormToProcess(submitter);
+ final Form formToProcess = findFormToProcess(submitter);
visitChildren(Form.class, new IVisitor()
{
buildbot failure in on wicket-branch-7.x
The Buildbot has detected a new failure on builder wicket-branch-7.x while building wicket. Full details are available at: https://ci.apache.org/builders/wicket-branch-7.x/builds/438 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The SingleBranchScheduler scheduler named 'on-wicket-branch-7.x-commit' triggered this build Build Source Stamp: [branch wicket-7.x] 08be805e120a08e5acd659b8c94f10702cbc5c49 Blamelist: Andrea Del Bene BUILD FAILED: failed compile Sincerely, -The Buildbot
[jira] [Commented] (WICKET-6462) When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called twice
[ https://issues.apache.org/jira/browse/WICKET-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153881#comment-16153881 ] ASF subversion and git services commented on WICKET-6462: - Commit 08be805e120a08e5acd659b8c94f10702cbc5c49 in wicket's branch refs/heads/wicket-7.x from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=08be805 ] WICKET-6462 added regression test > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > --- > > Key: WICKET-6462 > URL: https://issues.apache.org/jira/browse/WICKET-6462 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M7, 8.0.0-M8 > Environment: 8.0.0-SNAPSHOT - 2017 08 31 >Reporter: francois >Assignee: Andrea Del Bene >Priority: Critical > Attachments: wicket_quickstart.zip > > > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > The appears after WICKET-6455. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6462) When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called twice
[ https://issues.apache.org/jira/browse/WICKET-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153880#comment-16153880 ] ASF subversion and git services commented on WICKET-6462: - Commit bedf3fdcd4e7ac12c6dac9694e4029e50a289f77 in wicket's branch refs/heads/wicket-7.x from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=bedf3fd ] WICKET-6462 When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called twice > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > --- > > Key: WICKET-6462 > URL: https://issues.apache.org/jira/browse/WICKET-6462 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M7, 8.0.0-M8 > Environment: 8.0.0-SNAPSHOT - 2017 08 31 >Reporter: francois >Assignee: Andrea Del Bene >Priority: Critical > Attachments: wicket_quickstart.zip > > > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > The appears after WICKET-6455. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[1/2] wicket git commit: WICKET-6462 When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called twice
Repository: wicket
Updated Branches:
refs/heads/wicket-7.x 18a1c2f9e -> 08be805e1
WICKET-6462 When an Ajax Button is submitted, AjaxFormSubmitBehavior #
onSubmit is called twice
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/bedf3fdc
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/bedf3fdc
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/bedf3fdc
Branch: refs/heads/wicket-7.x
Commit: bedf3fdcd4e7ac12c6dac9694e4029e50a289f77
Parents: 18a1c2f
Author: Andrea Del Bene
Authored: Mon Sep 4 21:48:41 2017 +0200
Committer: Andrea Del Bene
Committed: Tue Sep 5 17:53:53 2017 +0200
--
.../apache/wicket/ajax/form/AjaxFormSubmitBehavior.java | 7 ---
.../java/org/apache/wicket/markup/html/form/Form.java| 11 +++
2 files changed, 7 insertions(+), 11 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/bedf3fdc/wicket-core/src/main/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehavior.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehavior.java
b/wicket-core/src/main/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehavior.java
index 2d2f07f..b281be4 100644
---
a/wicket-core/src/main/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehavior.java
+++
b/wicket-core/src/main/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehavior.java
@@ -172,13 +172,6 @@ public abstract class AjaxFormSubmitBehavior extends
AjaxEventBehavior
Form form = getForm();
form.getRootForm().onFormSubmitted(submitter);
-
- //the target form might have wantSubmitOnParentFormSubmit
returning "false"
- //so it must be explicitly submitted.
- if (!form.isSubmitted())
- {
- form.onFormSubmitted(submitter);
- }
}
/**
http://git-wip-us.apache.org/repos/asf/wicket/blob/bedf3fdc/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
index 75e06cb..da0e1e4 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
@@ -734,7 +734,7 @@ public class Form extends WebMarkupContainer
*/
public final void onFormSubmitted(IFormSubmitter submitter)
{
- markFormsSubmitted();
+ markFormsSubmitted(submitter);
if (handleMultiPart())
{
@@ -1014,18 +1014,21 @@ public class Form extends WebMarkupContainer
/**
* Sets FLAG_SUBMITTED to true on this form and every enabled nested
form.
+* @param submitter
*/
- private void markFormsSubmitted()
+ private void markFormsSubmitted(IFormSubmitter submitter)
{
setFlag(FLAG_SUBMITTED, true);
-
+ Form formToProcess = findFormToProcess(submitter);
+
visitChildren(Form.class, new IVisitor()
{
@Override
public void component(final Component component, final
IVisit visit)
{
Form form = (Form)component;
- if (form.wantSubmitOnParentFormSubmit() &&
form.isEnabledInHierarchy() && form.isVisibleInHierarchy())
+ if ((form.wantSubmitOnParentFormSubmit() ||
form == formToProcess)
+ && form.isEnabledInHierarchy() &&
form.isVisibleInHierarchy())
{
form.setFlag(FLAG_SUBMITTED, true);
return;
[2/2] wicket git commit: WICKET-6462 added regression test
WICKET-6462 added regression test
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/08be805e
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/08be805e
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/08be805e
Branch: refs/heads/wicket-7.x
Commit: 08be805e120a08e5acd659b8c94f10702cbc5c49
Parents: bedf3fd
Author: Andrea Del Bene
Authored: Tue Sep 5 12:53:08 2017 +0200
Committer: Andrea Del Bene
Committed: Tue Sep 5 17:54:08 2017 +0200
--
.../ajax/form/AjaxFormSubmitBehaviorTest.java | 44 +-
.../org/apache/wicket/ajax/form/PanelEdit.html | 47 +++
.../org/apache/wicket/ajax/form/PanelEdit.java | 60
3 files changed, 136 insertions(+), 15 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/08be805e/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
--
diff --git
a/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
b/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
index 48f55a9..a0cab5d 100644
---
a/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
+++
b/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
@@ -16,6 +16,8 @@
*/
package org.apache.wicket.ajax.form;
+import org.apache.wicket.Component;
+import org.apache.wicket.ajax.AjaxRequestTarget;
import org.apache.wicket.ajax.markup.html.form.AjaxButton;
import org.apache.wicket.markup.html.form.Form;
import org.apache.wicket.util.tester.FormTester;
@@ -53,43 +55,55 @@ public class AjaxFormSubmitBehaviorTest extends
WicketTestCase
tester.startPage(NestedFormTestPage.class);
NestedFormTestPage homePage =
(NestedFormTestPage)tester.getLastRenderedPage();
- assertFalse(homePage.innerFormSubmitted);
+ assertFalse(homePage.innerSubmitted);
FormTester formTester = tester.newFormTester("outer:inner");
formTester.submit("submit");
- assertTrue(homePage.innerFormSubmitted);
+ assertTrue(homePage.innerSubmitted);
}
+ /**
+* https://issues.apache.org/jira/browse/WICKET-6462
+*
+* onSubmit must be called once.
+*/
+ @Test
+ public void formReplacement()
+ {
+ PanelEdit panelEdit =
tester.startComponentInPage(PanelEdit.class);
+ FormTester formTester = tester.newFormTester(panelEdit.getId()
+ ":form");
+ //AjaxFormSubmitBehavior onSubmit must not be called when form
is removed
+ formTester.submit("submit");
+ }
+
public static class NestedFormTestPage extends NestedFormPage
{
- public boolean innerFormSubmitted = false;
+ /**
+*
+*/
+ private static final long serialVersionUID =
-515262294201762225L;
+
public NestedFormTestPage()
{
- Form outer = new Form("outer");
- replace(outer);
-
- Form inner = new Form("inner")
- {
+ Form inner = new Form("inner") {
@Override
- protected boolean
wantSubmitOnParentFormSubmit()
- {
+ protected boolean
wantSubmitOnParentFormSubmit() {
return false;
}
@Override
- protected void onSubmit()
- {
+ protected void onSubmit() {
super.onSubmit();
- innerFormSubmitted = true;
+ innerSubmitted = true;
}
};
- outer.add(inner);
-
inner.add(new AjaxButton("submit", inner) {});
+
+ get("outer:inner").replaceWith(inner);
}
}
}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/wicket/blob/08be805e/wicket-core/src/test/java/org/apache/wicket/ajax/form/PanelEdit.html
--
[jira] [Commented] (WICKET-6435) WicketTester should provide assertExists and assertNotExists methods
[
https://issues.apache.org/jira/browse/WICKET-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153623#comment-16153623
]
Kamil commented on WICKET-6435:
---
Another use case of notExist is when I have a ListView which, depending on
conditions, will have on or two buttons.
Having notExist I could do:
{code}
wicketTester.assertComponent("test:linkContainer:0:button",
AjaxLink.class);
wicketTester.assertVisible("test:linkContainer:0:button");
wicketTester.assertNotExist("test:linkContainer:1:button");
{code}
> WicketTester should provide assertExists and assertNotExists methods
>
>
> Key: WICKET-6435
> URL: https://issues.apache.org/jira/browse/WICKET-6435
> Project: Wicket
> Issue Type: Improvement
>Reporter: Kamil
>
> BaseWicketTester has:
> {code}
> private Component assertExists(final String path)
> {code}
> which is unfortunately private and doesn't provide contrary method.
> These methods are very important if you want to properly test code which is
> using Fragments: one Fragment is being added at time (exist) while another is
> not added (notExist)
> Could you please make assertExists public and add assertNotExists method?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (WICKET-6452) Problem while multiple opening same page in WICkET 8.0.0-M6
[
https://issues.apache.org/jira/browse/WICKET-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153547#comment-16153547
]
KAHA commented on WICKET-6452:
--
Now we are using wicket 7.8.0
yes you are right it is similar as WICKET-4733. But 4733 was about
StalePageExceptions. Here is no exception. Here is problem with serialization
and deserialization page ..
Store Page 107 on session node01afimri2ixqlb14azexfgs28gg0//PAGE IS
SERIALIZED
Store Page 108 on session node01afimri2ixqlb14azexfgs28gg0
Get Page 107 for session node01afimri2ixqlb14azexfgs28gg0 result null
//DESERIALIZATION RETURN NULL and this is reason to create new page instance
> Problem while multiple opening same page in WICkET 8.0.0-M6
> ---
>
> Key: WICKET-6452
> URL: https://issues.apache.org/jira/browse/WICKET-6452
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 8.0.0-M6
> Environment: Windows 10 64bit CZ Java(TM) SE Runtime Environment
> (build 1.8.0_131-b11)
>Reporter: KAHA
> Attachments: ABRA BI - Google Chrome 15.08.2017 13_33_45.mp4, ABRA BI
> - Google Chrome 15.08.2017 13_33_45_x264.mov, test.zip
>
>
> As you can see on the video, there is a problem when I multiple open same
> page. Each one page is rendered again and again and again (you can see it on
> rapidly increasing page number). There were no problem with same excercise on
> Wicket 7.
> I think that problem is in method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance(). In
> Wicket 7 there was
> if (pageInstance == null)
> {
> resolvePageInstance(pageId, pageClass, pageParameters, renderCount);
> if (pageInstance == null)
> {
> throw new PageExpiredException("Page with id '" + pageId + "'
> has expired.");
> }
> }
> return pageInstance;
> If pageInstance is null, method resolvePageInstance is called and
> resolvePageInstance first trying to load page stored on disk (stored thanks
> Serialization) and it will success. If there is no page stored on disk with
> this pageID, than getPageSource().newPageInstance( ... is called to create
> new page instance.
> On other hand on the new wicket 8 same method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance() looks
> like this
> return getProvision().getPage();
> and In Provision class method getPage looks like this
> if (page == null && doesProvideNewPage())
> {
> page = getPageSource().newPageInstance(pageClass,
> pageParameters);
> }
> return page;
> if the page is null, method does not try to load page stored on the disk, but
> imediatly creates a new instance and this is why same page is created many
> times repeatly.
> But it is only my guess.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (WICKET-6452) Problem while multiple opening same page in WICkET 8.0.0-M6
[
https://issues.apache.org/jira/browse/WICKET-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153545#comment-16153545
]
Martin Grigorov commented on WICKET-6452:
-
The video looks to me like WICKET-4733.
But this doesn't work since a long time (it is known since 1.5.8).
Which version of Wicket 7 did you use before trying 8.x ?
> Problem while multiple opening same page in WICkET 8.0.0-M6
> ---
>
> Key: WICKET-6452
> URL: https://issues.apache.org/jira/browse/WICKET-6452
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 8.0.0-M6
> Environment: Windows 10 64bit CZ Java(TM) SE Runtime Environment
> (build 1.8.0_131-b11)
>Reporter: KAHA
> Attachments: ABRA BI - Google Chrome 15.08.2017 13_33_45.mp4, ABRA BI
> - Google Chrome 15.08.2017 13_33_45_x264.mov, test.zip
>
>
> As you can see on the video, there is a problem when I multiple open same
> page. Each one page is rendered again and again and again (you can see it on
> rapidly increasing page number). There were no problem with same excercise on
> Wicket 7.
> I think that problem is in method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance(). In
> Wicket 7 there was
> if (pageInstance == null)
> {
> resolvePageInstance(pageId, pageClass, pageParameters, renderCount);
> if (pageInstance == null)
> {
> throw new PageExpiredException("Page with id '" + pageId + "'
> has expired.");
> }
> }
> return pageInstance;
> If pageInstance is null, method resolvePageInstance is called and
> resolvePageInstance first trying to load page stored on disk (stored thanks
> Serialization) and it will success. If there is no page stored on disk with
> this pageID, than getPageSource().newPageInstance( ... is called to create
> new page instance.
> On other hand on the new wicket 8 same method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance() looks
> like this
> return getProvision().getPage();
> and In Provision class method getPage looks like this
> if (page == null && doesProvideNewPage())
> {
> page = getPageSource().newPageInstance(pageClass,
> pageParameters);
> }
> return page;
> if the page is null, method does not try to load page stored on the disk, but
> imediatly creates a new instance and this is why same page is created many
> times repeatly.
> But it is only my guess.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (WICKET-6452) Problem while multiple opening same page in WICkET 8.0.0-M6
[
https://issues.apache.org/jira/browse/WICKET-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
KAHA updated WICKET-6452:
-
Attachment: (was: test.zip)
> Problem while multiple opening same page in WICkET 8.0.0-M6
> ---
>
> Key: WICKET-6452
> URL: https://issues.apache.org/jira/browse/WICKET-6452
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 8.0.0-M6
> Environment: Windows 10 64bit CZ Java(TM) SE Runtime Environment
> (build 1.8.0_131-b11)
>Reporter: KAHA
> Attachments: ABRA BI - Google Chrome 15.08.2017 13_33_45.mp4, ABRA BI
> - Google Chrome 15.08.2017 13_33_45_x264.mov, test.zip
>
>
> As you can see on the video, there is a problem when I multiple open same
> page. Each one page is rendered again and again and again (you can see it on
> rapidly increasing page number). There were no problem with same excercise on
> Wicket 7.
> I think that problem is in method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance(). In
> Wicket 7 there was
> if (pageInstance == null)
> {
> resolvePageInstance(pageId, pageClass, pageParameters, renderCount);
> if (pageInstance == null)
> {
> throw new PageExpiredException("Page with id '" + pageId + "'
> has expired.");
> }
> }
> return pageInstance;
> If pageInstance is null, method resolvePageInstance is called and
> resolvePageInstance first trying to load page stored on disk (stored thanks
> Serialization) and it will success. If there is no page stored on disk with
> this pageID, than getPageSource().newPageInstance( ... is called to create
> new page instance.
> On other hand on the new wicket 8 same method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance() looks
> like this
> return getProvision().getPage();
> and In Provision class method getPage looks like this
> if (page == null && doesProvideNewPage())
> {
> page = getPageSource().newPageInstance(pageClass,
> pageParameters);
> }
> return page;
> if the page is null, method does not try to load page stored on the disk, but
> imediatly creates a new instance and this is why same page is created many
> times repeatly.
> But it is only my guess.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (WICKET-6452) Problem while multiple opening same page in WICkET 8.0.0-M6
[
https://issues.apache.org/jira/browse/WICKET-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
KAHA updated WICKET-6452:
-
Attachment: test.zip
> Problem while multiple opening same page in WICkET 8.0.0-M6
> ---
>
> Key: WICKET-6452
> URL: https://issues.apache.org/jira/browse/WICKET-6452
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 8.0.0-M6
> Environment: Windows 10 64bit CZ Java(TM) SE Runtime Environment
> (build 1.8.0_131-b11)
>Reporter: KAHA
> Attachments: ABRA BI - Google Chrome 15.08.2017 13_33_45.mp4, ABRA BI
> - Google Chrome 15.08.2017 13_33_45_x264.mov, test.zip, test.zip
>
>
> As you can see on the video, there is a problem when I multiple open same
> page. Each one page is rendered again and again and again (you can see it on
> rapidly increasing page number). There were no problem with same excercise on
> Wicket 7.
> I think that problem is in method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance(). In
> Wicket 7 there was
> if (pageInstance == null)
> {
> resolvePageInstance(pageId, pageClass, pageParameters, renderCount);
> if (pageInstance == null)
> {
> throw new PageExpiredException("Page with id '" + pageId + "'
> has expired.");
> }
> }
> return pageInstance;
> If pageInstance is null, method resolvePageInstance is called and
> resolvePageInstance first trying to load page stored on disk (stored thanks
> Serialization) and it will success. If there is no page stored on disk with
> this pageID, than getPageSource().newPageInstance( ... is called to create
> new page instance.
> On other hand on the new wicket 8 same method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance() looks
> like this
> return getProvision().getPage();
> and In Provision class method getPage looks like this
> if (page == null && doesProvideNewPage())
> {
> page = getPageSource().newPageInstance(pageClass,
> pageParameters);
> }
> return page;
> if the page is null, method does not try to load page stored on the disk, but
> imediatly creates a new instance and this is why same page is created many
> times repeatly.
> But it is only my guess.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (WICKET-6452) Problem while multiple opening same page in WICkET 8.0.0-M6
[
https://issues.apache.org/jira/browse/WICKET-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
KAHA updated WICKET-6452:
-
Attachment: test.zip
Simple test project
> Problem while multiple opening same page in WICkET 8.0.0-M6
> ---
>
> Key: WICKET-6452
> URL: https://issues.apache.org/jira/browse/WICKET-6452
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 8.0.0-M6
> Environment: Windows 10 64bit CZ Java(TM) SE Runtime Environment
> (build 1.8.0_131-b11)
>Reporter: KAHA
> Attachments: ABRA BI - Google Chrome 15.08.2017 13_33_45.mp4, ABRA BI
> - Google Chrome 15.08.2017 13_33_45_x264.mov, test.zip
>
>
> As you can see on the video, there is a problem when I multiple open same
> page. Each one page is rendered again and again and again (you can see it on
> rapidly increasing page number). There were no problem with same excercise on
> Wicket 7.
> I think that problem is in method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance(). In
> Wicket 7 there was
> if (pageInstance == null)
> {
> resolvePageInstance(pageId, pageClass, pageParameters, renderCount);
> if (pageInstance == null)
> {
> throw new PageExpiredException("Page with id '" + pageId + "'
> has expired.");
> }
> }
> return pageInstance;
> If pageInstance is null, method resolvePageInstance is called and
> resolvePageInstance first trying to load page stored on disk (stored thanks
> Serialization) and it will success. If there is no page stored on disk with
> this pageID, than getPageSource().newPageInstance( ... is called to create
> new page instance.
> On other hand on the new wicket 8 same method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance() looks
> like this
> return getProvision().getPage();
> and In Provision class method getPage looks like this
> if (page == null && doesProvideNewPage())
> {
> page = getPageSource().newPageInstance(pageClass,
> pageParameters);
> }
> return page;
> if the page is null, method does not try to load page stored on the disk, but
> imediatly creates a new instance and this is why same page is created many
> times repeatly.
> But it is only my guess.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (WICKET-6452) Problem while multiple opening same page in WICkET 8.0.0-M6
[
https://issues.apache.org/jira/browse/WICKET-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153538#comment-16153538
]
KAHA commented on WICKET-6452:
--
Ok, i have made new demo project (in zip file) . I have tested it on version
8.0.0-M6. here is log file where you can see that page 107 was stored, but
loading page 107 from store return null and new page is created and rendered
again ...
Store Page 107 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 108 on session node01afimri2ixqlb14azexfgs28gg0
Get Page 107 for session node01afimri2ixqlb14azexfgs28gg0 result null
Store Page 109 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 109 on session node01afimri2ixqlb14azexfgs28gg0
Get Page 108 for session node01afimri2ixqlb14azexfgs28gg0 result null
Store Page 110 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 110 on session node01afimri2ixqlb14azexfgs28gg0
Get Page 109 for session node01afimri2ixqlb14azexfgs28gg0 result null
Store Page 111 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 111 on session node01afimri2ixqlb14azexfgs28gg0
Get Page 110 for session node01afimri2ixqlb14azexfgs28gg0 result null
Store Page 112 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 112 on session node01afimri2ixqlb14azexfgs28gg0
Get Page 111 for session node01afimri2ixqlb14azexfgs28gg0 result null
Store Page 113 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 113 on session node01afimri2ixqlb14azexfgs28gg0
Get Page 112 for session node01afimri2ixqlb14azexfgs28gg0 result null
Store Page 114 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 114 on session node01afimri2ixqlb14azexfgs28gg0
Get Page 113 for session node01afimri2ixqlb14azexfgs28gg0 result null
Store Page 115 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 115 on session node01afimri2ixqlb14azexfgs28gg0
Get Page 114 for session node01afimri2ixqlb14azexfgs28gg0 result null
Store Page 116 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 116 on session node01afimri2ixqlb14azexfgs28gg0
Get Page 115 for session node01afimri2ixqlb14azexfgs28gg0 result null
Store Page 117 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 117 on session node01afimri2ixqlb14azexfgs28gg0
Get Page 116 for session node01afimri2ixqlb14azexfgs28gg0 result null
Store Page 118 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 118 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 118 on session node01afimri2ixqlb14azexfgs28gg0
Get Page 117 for session node01afimri2ixqlb14azexfgs28gg0 result null
Store Page 119 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 119 on session node01afimri2ixqlb14azexfgs28gg0
Store Page 119 on session node01afimri2ixqlb14azexfgs28gg0
It looks that this behavior is better on version 8.0.0-M7. But still on version
8.0.0-M7 I am able to reproduce this error on our project. But our project is
much much complicated that this simple example.
> Problem while multiple opening same page in WICkET 8.0.0-M6
> ---
>
> Key: WICKET-6452
> URL: https://issues.apache.org/jira/browse/WICKET-6452
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 8.0.0-M6
> Environment: Windows 10 64bit CZ Java(TM) SE Runtime Environment
> (build 1.8.0_131-b11)
>Reporter: KAHA
> Attachments: ABRA BI - Google Chrome 15.08.2017 13_33_45.mp4, ABRA BI
> - Google Chrome 15.08.2017 13_33_45_x264.mov, test.zip
>
>
> As you can see on the video, there is a problem when I multiple open same
> page. Each one page is rendered again and again and again (you can see it on
> rapidly increasing page number). There were no problem with same excercise on
> Wicket 7.
> I think that problem is in method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance(). In
> Wicket 7 there was
> if (pageInstance == null)
> {
> resolvePageInstance(pageId, pageClass, pageParameters, renderCount);
> if (pageInstance == null)
> {
> throw new PageExpiredException("Page with id '" + pageId + "'
> has expired.");
> }
> }
> return pageInstance;
> If pageInstance is null, method resolvePageInstance is called and
> resolvePageInstance first trying to load page stored on disk (stored thanks
> Serialization) and it will success. If there is no page stored on disk with
> this pageID, than getPageSource().newPageInstance( ... is called to create
> new page instance.
> On other hand on the new wicket 8 same method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance() looks
> like this
> return getProvision().getPage();
> and In Provision class method getPage looks like this
> if (page == null && doesProvideNewPage())
> {
> page = getPageSource().newPageInstance(pageClass,
> pageParameters);
> }
> return
svn commit: r21458 - /release/wicket/6.27.0/
Author: adelbene Date: Tue Sep 5 11:58:24 2017 New Revision: 21458 Log: Remove previous version from mirrors Removed: release/wicket/6.27.0/
svn commit: r21457 - /dev/wicket/6.27.1/ /release/wicket/6.27.1/
Author: adelbene Date: Tue Sep 5 11:57:16 2017 New Revision: 21457 Log: Upload release to the mirrors Added: release/wicket/6.27.1/ - copied from r21456, dev/wicket/6.27.1/ Removed: dev/wicket/6.27.1/
[wicket] Git Push Summary
Repository: wicket Updated Tags: refs/tags/rel/wicket-6.27.1 [created] ae14a76f2
[jira] [Updated] (WICKET-6458) Websocket replacing a panel which uses websockets
[ https://issues.apache.org/jira/browse/WICKET-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Henderson updated WICKET-6458: Attachment: wicket-websocket-replace.tar.gz Thanks for having a look Martin. I've condensed the Scala version into a quick start. (which was a lot easier than I anticipated) > Websocket replacing a panel which uses websockets > - > > Key: WICKET-6458 > URL: https://issues.apache.org/jira/browse/WICKET-6458 > Project: Wicket > Issue Type: Bug > Components: wicket-native-websocket >Affects Versions: 7.8.0 > Environment: Ubuntu 16.04 > Tomcat 8.5.20 >Reporter: Peter Henderson >Assignee: Martin Grigorov >Priority: Minor > Attachments: wicket-websocket-replace.tar.gz > > > I've a page which initially shows a loading panel. > This panel uses web sockets to trigger background loading when the connected > message is received. > When the background loading has completed > (onEvent => event.getPayload => WebSocketPushPayload => ???) > I replace the loading place holder panel with the real data panel. > The real data panel may also want to use web sockets, and show a loading > animation. > (Turtles all the way down) > The problem I'm seeing, is that the WebSocketBehavior::onConnected method is > not being called on the replaced panel. > A scala sample which shows this problem. > https://github.com/bollinger/WebSocketPanelReplace -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6462) When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called twice
[ https://issues.apache.org/jira/browse/WICKET-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153464#comment-16153464 ] ASF subversion and git services commented on WICKET-6462: - Commit 72a5d312a1dfe63349a8ab963d9126cab5525a20 in wicket's branch refs/heads/master from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=72a5d31 ] WICKET-6462 added regression test > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > --- > > Key: WICKET-6462 > URL: https://issues.apache.org/jira/browse/WICKET-6462 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M7, 8.0.0-M8 > Environment: 8.0.0-SNAPSHOT - 2017 08 31 >Reporter: francois >Assignee: Andrea Del Bene >Priority: Critical > Attachments: wicket_quickstart.zip > > > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > The appears after WICKET-6455. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
wicket git commit: WICKET-6462 added regression test
Repository: wicket
Updated Branches:
refs/heads/master 48f458091 -> 72a5d312a
WICKET-6462 added regression test
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/72a5d312
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/72a5d312
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/72a5d312
Branch: refs/heads/master
Commit: 72a5d312a1dfe63349a8ab963d9126cab5525a20
Parents: 48f4580
Author: Andrea Del Bene
Authored: Tue Sep 5 12:53:08 2017 +0200
Committer: Andrea Del Bene
Committed: Tue Sep 5 12:53:08 2017 +0200
--
.../ajax/form/AjaxFormSubmitBehaviorTest.java | 44 +-
.../org/apache/wicket/ajax/form/PanelEdit.html | 47 +++
.../org/apache/wicket/ajax/form/PanelEdit.java | 60
3 files changed, 136 insertions(+), 15 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/72a5d312/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
--
diff --git
a/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
b/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
index 48f55a9..a0cab5d 100644
---
a/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
+++
b/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
@@ -16,6 +16,8 @@
*/
package org.apache.wicket.ajax.form;
+import org.apache.wicket.Component;
+import org.apache.wicket.ajax.AjaxRequestTarget;
import org.apache.wicket.ajax.markup.html.form.AjaxButton;
import org.apache.wicket.markup.html.form.Form;
import org.apache.wicket.util.tester.FormTester;
@@ -53,43 +55,55 @@ public class AjaxFormSubmitBehaviorTest extends
WicketTestCase
tester.startPage(NestedFormTestPage.class);
NestedFormTestPage homePage =
(NestedFormTestPage)tester.getLastRenderedPage();
- assertFalse(homePage.innerFormSubmitted);
+ assertFalse(homePage.innerSubmitted);
FormTester formTester = tester.newFormTester("outer:inner");
formTester.submit("submit");
- assertTrue(homePage.innerFormSubmitted);
+ assertTrue(homePage.innerSubmitted);
}
+ /**
+* https://issues.apache.org/jira/browse/WICKET-6462
+*
+* onSubmit must be called once.
+*/
+ @Test
+ public void formReplacement()
+ {
+ PanelEdit panelEdit =
tester.startComponentInPage(PanelEdit.class);
+ FormTester formTester = tester.newFormTester(panelEdit.getId()
+ ":form");
+ //AjaxFormSubmitBehavior onSubmit must not be called when form
is removed
+ formTester.submit("submit");
+ }
+
public static class NestedFormTestPage extends NestedFormPage
{
- public boolean innerFormSubmitted = false;
+ /**
+*
+*/
+ private static final long serialVersionUID =
-515262294201762225L;
+
public NestedFormTestPage()
{
- Form outer = new Form("outer");
- replace(outer);
-
- Form inner = new Form("inner")
- {
+ Form inner = new Form("inner") {
@Override
- protected boolean
wantSubmitOnParentFormSubmit()
- {
+ protected boolean
wantSubmitOnParentFormSubmit() {
return false;
}
@Override
- protected void onSubmit()
- {
+ protected void onSubmit() {
super.onSubmit();
- innerFormSubmitted = true;
+ innerSubmitted = true;
}
};
- outer.add(inner);
-
inner.add(new AjaxButton("submit", inner) {});
+
+ get("outer:inner").replaceWith(inner);
}
}
}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/wicket/blob/72a5d312/wicket-core/src/test/java/org/apa
svn commit: r21455 - /dev/wicket/7.8.1/
Author: adelbene Date: Tue Sep 5 09:46:03 2017 New Revision: 21455 Log: Release vote has failed Removed: dev/wicket/7.8.1/
[jira] [Commented] (WICKET-6438) 8.x reference guide needs a few minor improvements
[ https://issues.apache.org/jira/browse/WICKET-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153378#comment-16153378 ] ASF GitHub Bot commented on WICKET-6438: Github user ozeray closed the pull request at: https://github.com/apache/wicket/pull/229 > 8.x reference guide needs a few minor improvements > -- > > Key: WICKET-6438 > URL: https://issues.apache.org/jira/browse/WICKET-6438 > Project: Wicket > Issue Type: Improvement > Components: guide >Affects Versions: 8.0.0 >Reporter: Ahmet Yaşar Özer >Assignee: Andrea Del Bene >Priority: Minor > Labels: documentation > > Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during > maven packaging phase: > WARNING: image to embed not found or not readable: > F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg > Minor fix in contributing.adoc: Revised the generated document target > directory for the user guide documentation. > Cropped top and bottom blank parts in comsysto-logo.png to have the > Introduction page fit in one page in PDF. Made minor changes in > helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (WICKET-6462) When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called twice
[ https://issues.apache.org/jira/browse/WICKET-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153368#comment-16153368 ] francois edited comment on WICKET-6462 at 9/5/17 9:33 AM: -- Hi Andrea, I have tested the new 8-SNAPSHOT and tt works perfectly for me Thanks a lot ! was (Author: francois): Hi Andrea, I have tested the new 8-SNAPSHOT and tt works perfectly for me Thanks a lot ! François > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > --- > > Key: WICKET-6462 > URL: https://issues.apache.org/jira/browse/WICKET-6462 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M7, 8.0.0-M8 > Environment: 8.0.0-SNAPSHOT - 2017 08 31 >Reporter: francois >Assignee: Andrea Del Bene >Priority: Critical > Attachments: wicket_quickstart.zip > > > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > The appears after WICKET-6455. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6462) When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called twice
[ https://issues.apache.org/jira/browse/WICKET-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153368#comment-16153368 ] francois commented on WICKET-6462: -- Hi Andrea, I have tested the new 8-SNAPSHOT and tt works perfectly for me Thanks a lot ! François > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > --- > > Key: WICKET-6462 > URL: https://issues.apache.org/jira/browse/WICKET-6462 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M7, 8.0.0-M8 > Environment: 8.0.0-SNAPSHOT - 2017 08 31 >Reporter: francois >Assignee: Andrea Del Bene >Priority: Critical > Attachments: wicket_quickstart.zip > > > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > The appears after WICKET-6455. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6438) 8.x reference guide needs a few minor improvements
[ https://issues.apache.org/jira/browse/WICKET-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153336#comment-16153336 ] ASF GitHub Bot commented on WICKET-6438: Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/229 @ozeray , could you please close this PR? Thank you! > 8.x reference guide needs a few minor improvements > -- > > Key: WICKET-6438 > URL: https://issues.apache.org/jira/browse/WICKET-6438 > Project: Wicket > Issue Type: Improvement > Components: guide >Affects Versions: 8.0.0 >Reporter: Ahmet Yaşar Özer >Assignee: Andrea Del Bene >Priority: Minor > Labels: documentation > > Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during > maven packaging phase: > WARNING: image to embed not found or not readable: > F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg > Minor fix in contributing.adoc: Revised the generated document target > directory for the user guide documentation. > Cropped top and bottom blank parts in comsysto-logo.png to have the > Introduction page fit in one page in PDF. Made minor changes in > helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6462) When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called twice
[ https://issues.apache.org/jira/browse/WICKET-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153285#comment-16153285 ] Andrea Del Bene commented on WICKET-6462: - Hi [~francois], the 8-SNAPSHOT should be ok now. Could you try it with your application? > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > --- > > Key: WICKET-6462 > URL: https://issues.apache.org/jira/browse/WICKET-6462 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M7, 8.0.0-M8 > Environment: 8.0.0-SNAPSHOT - 2017 08 31 >Reporter: francois >Assignee: Andrea Del Bene >Priority: Critical > Attachments: wicket_quickstart.zip > > > When an Ajax Button is submitted, AjaxFormSubmitBehavior # onSubmit is called > twice > The appears after WICKET-6455. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6452) Problem while multiple opening same page in WICkET 8.0.0-M6
[
https://issues.apache.org/jira/browse/WICKET-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153278#comment-16153278
]
Martin Grigorov commented on WICKET-6452:
-
Which command do you execute when this error happens in the console ?
"mvn archetype:generate ..." ?
Please paste it here.
Also please use 8.0.0-M7. There was a but in the generator few versions back.
Don't remember whether it affects M6.
> Problem while multiple opening same page in WICkET 8.0.0-M6
> ---
>
> Key: WICKET-6452
> URL: https://issues.apache.org/jira/browse/WICKET-6452
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 8.0.0-M6
> Environment: Windows 10 64bit CZ Java(TM) SE Runtime Environment
> (build 1.8.0_131-b11)
>Reporter: KAHA
> Attachments: ABRA BI - Google Chrome 15.08.2017 13_33_45.mp4, ABRA BI
> - Google Chrome 15.08.2017 13_33_45_x264.mov
>
>
> As you can see on the video, there is a problem when I multiple open same
> page. Each one page is rendered again and again and again (you can see it on
> rapidly increasing page number). There were no problem with same excercise on
> Wicket 7.
> I think that problem is in method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance(). In
> Wicket 7 there was
> if (pageInstance == null)
> {
> resolvePageInstance(pageId, pageClass, pageParameters, renderCount);
> if (pageInstance == null)
> {
> throw new PageExpiredException("Page with id '" + pageId + "'
> has expired.");
> }
> }
> return pageInstance;
> If pageInstance is null, method resolvePageInstance is called and
> resolvePageInstance first trying to load page stored on disk (stored thanks
> Serialization) and it will success. If there is no page stored on disk with
> this pageID, than getPageSource().newPageInstance( ... is called to create
> new page instance.
> On other hand on the new wicket 8 same method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance() looks
> like this
> return getProvision().getPage();
> and In Provision class method getPage looks like this
> if (page == null && doesProvideNewPage())
> {
> page = getPageSource().newPageInstance(pageClass,
> pageParameters);
> }
> return page;
> if the page is null, method does not try to load page stored on the disk, but
> imediatly creates a new instance and this is why same page is created many
> times repeatly.
> But it is only my guess.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (WICKET-6452) Problem while multiple opening same page in WICkET 8.0.0-M6
[
https://issues.apache.org/jira/browse/WICKET-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153258#comment-16153258
]
KAHA commented on WICKET-6452:
--
I am not sure, that I understand you.
I have made a new directory "D:\WicketTest". I have opened power shell in
Windows ..
I have moved into new directory
D:
cd WicketTest
and now I ran command which has been generated by the Quick Start Wizard and I
got this error
I am sure that I followed instruction from 1 to 5 on Quick Start Wizard page
I have also tried to register new archetype in eclipse and make new project
form eclipse, but i got other error
"Can't resolve Archetype org.apache.wicket:wicket-archetype-quickstart:8.0.0-M6
org.eclipse.core.runtime.CoreException: Could not resolve artifact
org.apache.wicket:wicket-archetype-quickstart:pom:8.0.0-M6"
> Problem while multiple opening same page in WICkET 8.0.0-M6
> ---
>
> Key: WICKET-6452
> URL: https://issues.apache.org/jira/browse/WICKET-6452
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 8.0.0-M6
> Environment: Windows 10 64bit CZ Java(TM) SE Runtime Environment
> (build 1.8.0_131-b11)
>Reporter: KAHA
> Attachments: ABRA BI - Google Chrome 15.08.2017 13_33_45.mp4, ABRA BI
> - Google Chrome 15.08.2017 13_33_45_x264.mov
>
>
> As you can see on the video, there is a problem when I multiple open same
> page. Each one page is rendered again and again and again (you can see it on
> rapidly increasing page number). There were no problem with same excercise on
> Wicket 7.
> I think that problem is in method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance(). In
> Wicket 7 there was
> if (pageInstance == null)
> {
> resolvePageInstance(pageId, pageClass, pageParameters, renderCount);
> if (pageInstance == null)
> {
> throw new PageExpiredException("Page with id '" + pageId + "'
> has expired.");
> }
> }
> return pageInstance;
> If pageInstance is null, method resolvePageInstance is called and
> resolvePageInstance first trying to load page stored on disk (stored thanks
> Serialization) and it will success. If there is no page stored on disk with
> this pageID, than getPageSource().newPageInstance( ... is called to create
> new page instance.
> On other hand on the new wicket 8 same method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance() looks
> like this
> return getProvision().getPage();
> and In Provision class method getPage looks like this
> if (page == null && doesProvideNewPage())
> {
> page = getPageSource().newPageInstance(pageClass,
> pageParameters);
> }
> return page;
> if the page is null, method does not try to load page stored on the disk, but
> imediatly creates a new instance and this is why same page is created many
> times repeatly.
> But it is only my guess.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (WICKET-6452) Problem while multiple opening same page in WICkET 8.0.0-M6
[
https://issues.apache.org/jira/browse/WICKET-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153251#comment-16153251
]
Maxim Solodovnik commented on WICKET-6452:
--
It seems you need to `cd your_artifact_id` after quick start was generated
> Problem while multiple opening same page in WICkET 8.0.0-M6
> ---
>
> Key: WICKET-6452
> URL: https://issues.apache.org/jira/browse/WICKET-6452
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 8.0.0-M6
> Environment: Windows 10 64bit CZ Java(TM) SE Runtime Environment
> (build 1.8.0_131-b11)
>Reporter: KAHA
> Attachments: ABRA BI - Google Chrome 15.08.2017 13_33_45.mp4, ABRA BI
> - Google Chrome 15.08.2017 13_33_45_x264.mov
>
>
> As you can see on the video, there is a problem when I multiple open same
> page. Each one page is rendered again and again and again (you can see it on
> rapidly increasing page number). There were no problem with same excercise on
> Wicket 7.
> I think that problem is in method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance(). In
> Wicket 7 there was
> if (pageInstance == null)
> {
> resolvePageInstance(pageId, pageClass, pageParameters, renderCount);
> if (pageInstance == null)
> {
> throw new PageExpiredException("Page with id '" + pageId + "'
> has expired.");
> }
> }
> return pageInstance;
> If pageInstance is null, method resolvePageInstance is called and
> resolvePageInstance first trying to load page stored on disk (stored thanks
> Serialization) and it will success. If there is no page stored on disk with
> this pageID, than getPageSource().newPageInstance( ... is called to create
> new page instance.
> On other hand on the new wicket 8 same method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance() looks
> like this
> return getProvision().getPage();
> and In Provision class method getPage looks like this
> if (page == null && doesProvideNewPage())
> {
> page = getPageSource().newPageInstance(pageClass,
> pageParameters);
> }
> return page;
> if the page is null, method does not try to load page stored on the disk, but
> imediatly creates a new instance and this is why same page is created many
> times repeatly.
> But it is only my guess.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (WICKET-6452) Problem while multiple opening same page in WICkET 8.0.0-M6
[
https://issues.apache.org/jira/browse/WICKET-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153238#comment-16153238
]
KAHA commented on WICKET-6452:
--
Yours DEMO generator (http://wicket.apache.org/start/quickstart.html) doesnot
works with maven 3.3.9
[INFO] Scanning for projects...
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 0.064 s
[INFO] Finished at: 2017-09-05T09:35:45+02:00
[INFO] Final Memory: 13M/368M
[INFO]
[ERROR] The goal you specified requires a project to execute but there is no
POM in this directory (D:\WicketTest). Please verify you invoked Maven from the
correct directory. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException
I will try to make demo "by foot" ..
> Problem while multiple opening same page in WICkET 8.0.0-M6
> ---
>
> Key: WICKET-6452
> URL: https://issues.apache.org/jira/browse/WICKET-6452
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 8.0.0-M6
> Environment: Windows 10 64bit CZ Java(TM) SE Runtime Environment
> (build 1.8.0_131-b11)
>Reporter: KAHA
> Attachments: ABRA BI - Google Chrome 15.08.2017 13_33_45.mp4, ABRA BI
> - Google Chrome 15.08.2017 13_33_45_x264.mov
>
>
> As you can see on the video, there is a problem when I multiple open same
> page. Each one page is rendered again and again and again (you can see it on
> rapidly increasing page number). There were no problem with same excercise on
> Wicket 7.
> I think that problem is in method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance(). In
> Wicket 7 there was
> if (pageInstance == null)
> {
> resolvePageInstance(pageId, pageClass, pageParameters, renderCount);
> if (pageInstance == null)
> {
> throw new PageExpiredException("Page with id '" + pageId + "'
> has expired.");
> }
> }
> return pageInstance;
> If pageInstance is null, method resolvePageInstance is called and
> resolvePageInstance first trying to load page stored on disk (stored thanks
> Serialization) and it will success. If there is no page stored on disk with
> this pageID, than getPageSource().newPageInstance( ... is called to create
> new page instance.
> On other hand on the new wicket 8 same method
> org.apache.wicket.core.request.handler.PageProvider.getPageInstance() looks
> like this
> return getProvision().getPage();
> and In Provision class method getPage looks like this
> if (page == null && doesProvideNewPage())
> {
> page = getPageSource().newPageInstance(pageClass,
> pageParameters);
> }
> return page;
> if the page is null, method does not try to load page stored on the disk, but
> imediatly creates a new instance and this is why same page is created many
> times repeatly.
> But it is only my guess.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
