[jira] [Commented] (WICKET-6959) Form#setDefaultButton does not work under Safari
[ https://issues.apache.org/jira/browse/WICKET-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500742#comment-17500742 ] Sven Meier commented on WICKET-6959: [~papegaaij] valid point > Form#setDefaultButton does not work under Safari > > > Key: WICKET-6959 > URL: https://issues.apache.org/jira/browse/WICKET-6959 > Project: Wicket > Issue Type: Bug >Affects Versions: 9.7.0, 9.8.0 > Environment: Safari 15.3 > macOS 12.2 >Reporter: felix.rill...@cryptshare.com >Priority: Minor > Attachments: PoC Safari and setDefaultButton.zip > > > setDefaultButton uses a hidden submit component. In most major browsers, this > works well and allows one to submit a form by pressing 'Enter' while in a > e.g. TextField. > Safari seems to ignore the hidden submit component, which makes it impossible > to submit the form by using 'Enter' if the submit button is outside the form > (attached is a Proof of Concept). > If instead of using the HTML 'hidden' attribute, the hidden submit component > is made invisible by other means (e.g. moving it outside the viewport), it > works. > > As the JavaDoc of setDefaultButton already state "note that this is a best > effort only", this probably not a priority. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (WICKET-6959) Form#setDefaultButton does not work under Safari
[ https://issues.apache.org/jira/browse/WICKET-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500740#comment-17500740 ] Emond Papegaaij commented on WICKET-6959: - Actually, I think Safari has it wrong. This is from the HTML 5 specification https://html.spec.whatwg.org/#the-hidden-attribute {quote}Elements in a section hidden by the hidden attribute are still active, e.g. scripts and form controls in such sections still execute and submit respectively. Only their presentation to the user changes.{quote} > Form#setDefaultButton does not work under Safari > > > Key: WICKET-6959 > URL: https://issues.apache.org/jira/browse/WICKET-6959 > Project: Wicket > Issue Type: Bug >Affects Versions: 9.7.0, 9.8.0 > Environment: Safari 15.3 > macOS 12.2 >Reporter: felix.rill...@cryptshare.com >Priority: Minor > Attachments: PoC Safari and setDefaultButton.zip > > > setDefaultButton uses a hidden submit component. In most major browsers, this > works well and allows one to submit a form by pressing 'Enter' while in a > e.g. TextField. > Safari seems to ignore the hidden submit component, which makes it impossible > to submit the form by using 'Enter' if the submit button is outside the form > (attached is a Proof of Concept). > If instead of using the HTML 'hidden' attribute, the hidden submit component > is made invisible by other means (e.g. moving it outside the viewport), it > works. > > As the JavaDoc of setDefaultButton already state "note that this is a best > effort only", this probably not a priority. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[wicket] branch master updated: Fix to the ajax request attributes table
This is an automated email from the ASF dual-hosted git repository. adelbene pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/wicket.git The following commit(s) were added to refs/heads/master by this push: new 3fe4864 Fix to the ajax request attributes table 3fe4864 is described below commit 3fe4864125da3cb0d7951960566427edcb98db94 Author: Andrea Del Bene AuthorDate: Thu Mar 3 13:18:15 2022 +0100 Fix to the ajax request attributes table --- wicket-user-guide/src/main/asciidoc/ajax/ajax_5.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/wicket-user-guide/src/main/asciidoc/ajax/ajax_5.adoc b/wicket-user-guide/src/main/asciidoc/ajax/ajax_5.adoc index 901c475..a2de03f 100644 --- a/wicket-user-guide/src/main/asciidoc/ajax/ajax_5.adoc +++ b/wicket-user-guide/src/main/asciidoc/ajax/ajax_5.adoc @@ -15,7 +15,8 @@ AjaxRequestAttributes exposes the attributes used to generate the JavaScript cal |mp | If the AJAX call involves the submission of a form, this flag indicates whether the data must be encoded using the encoding mode “multipart/form-data”. | false |sc | The input name of the submitting component of the form | |async | A boolean parameter that indicates if the AJAX call is asynchronous (true) or not. | true -|wr | Specifies the type of data returned by the AJAX call (XML, HTML, JSON, etc...). | XML +|dt | Specifies the type of data returned by the AJAX call (XML, HTML, JSON, etc...). | XML +|wr | Boolean flag which indicates whether the response is which is handled by wicket-ajax.js or custom response type which can be handled by application's code (e.g. in IAjaxCallListener's success handler). | true |ih, bh, pre, bsh, ah, sh, fh, coh, dh | This is a list of the listeners that are executed on client side (they are JavaScript scripts) during the lifecycle of an AJAX request. Each short name is the abbreviation of one of the methods defined in the interface IAjaxCallListener (see below). | An empty list |===
[wicket] branch wicket-9.x updated: Fix to the ajax request attributes table
This is an automated email from the ASF dual-hosted git repository. adelbene pushed a commit to branch wicket-9.x in repository https://gitbox.apache.org/repos/asf/wicket.git The following commit(s) were added to refs/heads/wicket-9.x by this push: new 191bb10 Fix to the ajax request attributes table 191bb10 is described below commit 191bb10a3be23ef40319db68ac98b340357aa383 Author: Andrea Del Bene AuthorDate: Thu Mar 3 13:18:15 2022 +0100 Fix to the ajax request attributes table --- wicket-user-guide/src/main/asciidoc/ajax/ajax_5.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/wicket-user-guide/src/main/asciidoc/ajax/ajax_5.adoc b/wicket-user-guide/src/main/asciidoc/ajax/ajax_5.adoc index 901c475..a2de03f 100644 --- a/wicket-user-guide/src/main/asciidoc/ajax/ajax_5.adoc +++ b/wicket-user-guide/src/main/asciidoc/ajax/ajax_5.adoc @@ -15,7 +15,8 @@ AjaxRequestAttributes exposes the attributes used to generate the JavaScript cal |mp | If the AJAX call involves the submission of a form, this flag indicates whether the data must be encoded using the encoding mode “multipart/form-data”. | false |sc | The input name of the submitting component of the form | |async | A boolean parameter that indicates if the AJAX call is asynchronous (true) or not. | true -|wr | Specifies the type of data returned by the AJAX call (XML, HTML, JSON, etc...). | XML +|dt | Specifies the type of data returned by the AJAX call (XML, HTML, JSON, etc...). | XML +|wr | Boolean flag which indicates whether the response is which is handled by wicket-ajax.js or custom response type which can be handled by application's code (e.g. in IAjaxCallListener's success handler). | true |ih, bh, pre, bsh, ah, sh, fh, coh, dh | This is a list of the listeners that are executed on client side (they are JavaScript scripts) during the lifecycle of an AJAX request. Each short name is the abbreviation of one of the methods defined in the interface IAjaxCallListener (see below). | An empty list |===
[jira] [Comment Edited] (WICKET-6959) Form#setDefaultButton does not work under Safari
[ https://issues.apache.org/jira/browse/WICKET-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500632#comment-17500632 ] Sven Meier edited comment on WICKET-6959 at 3/3/22, 10:15 AM: -- Too bad, actually we removed all Safari-specific workarounds. But in this case, Safari might actually have the correct interpretation of the *hidden* element. Can you try styling class "hidden-fields" in your CSS? Does that make any difference? {code:java} .hidden-fields { display:block; width:0px; height:0px; position:absolute; left:-100px; top:-100px; overflow:hidden; } {code} was (Author: svenmeier): Too bad, actually we removed all Safari-specific workarounds. But in this case, Safari might actually have the correct interpretation of the *hidden* element. Can you try styling class "hidden-fields" in your CSS? Does that make any difference? .hidden-fields { display:block; width:0px; height:0px; position:absolute; left:-100px; top:-100px; overflow:hidden; } > Form#setDefaultButton does not work under Safari > > > Key: WICKET-6959 > URL: https://issues.apache.org/jira/browse/WICKET-6959 > Project: Wicket > Issue Type: Bug >Affects Versions: 9.7.0, 9.8.0 > Environment: Safari 15.3 > macOS 12.2 >Reporter: felix.rill...@cryptshare.com >Priority: Minor > Attachments: PoC Safari and setDefaultButton.zip > > > setDefaultButton uses a hidden submit component. In most major browsers, this > works well and allows one to submit a form by pressing 'Enter' while in a > e.g. TextField. > Safari seems to ignore the hidden submit component, which makes it impossible > to submit the form by using 'Enter' if the submit button is outside the form > (attached is a Proof of Concept). > If instead of using the HTML 'hidden' attribute, the hidden submit component > is made invisible by other means (e.g. moving it outside the viewport), it > works. > > As the JavaDoc of setDefaultButton already state "note that this is a best > effort only", this probably not a priority. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (WICKET-6959) Form#setDefaultButton does not work under Safari
[ https://issues.apache.org/jira/browse/WICKET-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500632#comment-17500632 ] Sven Meier commented on WICKET-6959: Too bad, actually we removed all Safari-specific workarounds. But in this case, Safari might actually have the correct interpretation of the *hidden* element. Can you try styling class "hidden-fields" in your CSS? Does that make any difference? .hidden-fields { display:block; width:0px; height:0px; position:absolute; left:-100px; top:-100px; overflow:hidden; } > Form#setDefaultButton does not work under Safari > > > Key: WICKET-6959 > URL: https://issues.apache.org/jira/browse/WICKET-6959 > Project: Wicket > Issue Type: Bug >Affects Versions: 9.7.0, 9.8.0 > Environment: Safari 15.3 > macOS 12.2 >Reporter: felix.rill...@cryptshare.com >Priority: Minor > Attachments: PoC Safari and setDefaultButton.zip > > > setDefaultButton uses a hidden submit component. In most major browsers, this > works well and allows one to submit a form by pressing 'Enter' while in a > e.g. TextField. > Safari seems to ignore the hidden submit component, which makes it impossible > to submit the form by using 'Enter' if the submit button is outside the form > (attached is a Proof of Concept). > If instead of using the HTML 'hidden' attribute, the hidden submit component > is made invisible by other means (e.g. moving it outside the viewport), it > works. > > As the JavaDoc of setDefaultButton already state "note that this is a best > effort only", this probably not a priority. -- This message was sent by Atlassian Jira (v8.20.1#820001)