WICKET-6242 Weak concurrency management in AuthenticatedWebSession#signedIn
Unset signedIn to 'false' only if the authenticated has failed. Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/d1fc5d2c Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d1fc5d2c Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d1fc5d2c Branch: refs/heads/master Commit: d1fc5d2cc3c1ef5da9d8569328fa96a8de4abbad Parents: 4fdc817 Author: Martin Tzvetanov Grigorov <mgrigo...@apache.org> Authored: Sat Sep 10 13:24:00 2016 +0200 Committer: Martin Tzvetanov Grigorov <mgrigo...@apache.org> Committed: Mon Sep 19 21:38:34 2016 +0200 ---------------------------------------------------------------------- .../authroles/authentication/AuthenticatedWebSession.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/d1fc5d2c/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authentication/AuthenticatedWebSession.java ---------------------------------------------------------------------- diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authentication/AuthenticatedWebSession.java b/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authentication/AuthenticatedWebSession.java index 744811b..4e3851e 100644 --- a/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authentication/AuthenticatedWebSession.java +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authentication/AuthenticatedWebSession.java @@ -70,7 +70,10 @@ public abstract class AuthenticatedWebSession extends AbstractAuthenticatedWebSe { bind(); } - signedIn.set(authenticated); + else + { + signedIn.set(false); + } } return signedIn.get(); }
