[jira] [Commented] (WICKET-5411) Improve AutoLabels by updating their CSS classes automatically during Ajax requests

2013-11-26 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832469#comment-13832469
 ] 

Martin Grigorov commented on WICKET-5411:
-

tag.put(id, getLabelIdFor(component)); at 
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/markup/html/form/AutoLabelResolver.java?source=cc#L302
 
causes a lot of 
  WARN  - ComponentTag   - Please use component.setMarkupId(String) 
to change the tag's 'id' attribute.
when executing the JS UI tests (start wicket examples and go to 
http://localhost:8080/js-test/all.html)

 Improve AutoLabels by updating their CSS classes automatically during Ajax 
 requests
 ---

 Key: WICKET-5411
 URL: https://issues.apache.org/jira/browse/WICKET-5411
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Reporter: Igor Vaynberg
Assignee: Igor Vaynberg
 Fix For: 6.13.0, 7.0.0


 The problem with auto labels is that once they are rendered the only way to 
 update their `error`/`required` css classes during ajax requests is to update 
 some parent since auto components cannot be targeted directly. however, when 
 dealing with forms we may not necessarily want to repaint components because 
 we may lose state.
 This issue solves the problem by tracking state changes in form components 
 that have auto labels and updating their css classes on all ajax requests.
 disabled by default in 6.13 (to enable override 
 WebApplication#getUpdateAutoLabelsOnAjaxRequests() ), always enabled in 7.0



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (WICKET-5411) Improve AutoLabels by updating their CSS classes automatically during Ajax requests

2013-11-12 Thread Igor Vaynberg (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820226#comment-13820226
 ] 

Igor Vaynberg commented on WICKET-5411:
---

i wasnt going to close it until i tested it in our app to make sure it works 
for complex usecases...

 Improve AutoLabels by updating their CSS classes automatically during Ajax 
 requests
 ---

 Key: WICKET-5411
 URL: https://issues.apache.org/jira/browse/WICKET-5411
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Reporter: Igor Vaynberg
Assignee: Igor Vaynberg
 Fix For: 6.13.0, 7.0.0


 The problem with auto labels is that once they are rendered the only way to 
 update their `error`/`required` css classes during ajax requests is to update 
 some parent since auto components cannot be targeted directly. however, when 
 dealing with forms we may not necessarily want to repaint components because 
 we may lose state.
 This issue solves the problem by tracking state changes in form components 
 that have auto labels and updating their css classes on all ajax requests.
 disabled by default in 6.13 (to enable override 
 WebApplication#getUpdateAutoLabelsOnAjaxRequests() ), always enabled in 7.0



--
This message was sent by Atlassian JIRA
(v6.1#6144)