git commit: WICKET-5273 Tabindex overwritten in modal window for IE - Works in FF, Chrome
Updated Branches: refs/heads/master b02409742 - bcee5140a WICKET-5273 Tabindex overwritten in modal window for IE - Works in FF, Chrome Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/bcee5140 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/bcee5140 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/bcee5140 Branch: refs/heads/master Commit: bcee5140a20c8c0921d8efdc48e21d048151d968 Parents: b024097 Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Authored: Wed Jul 24 13:07:57 2013 +0300 Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org Committed: Wed Jul 24 13:08:27 2013 +0300 -- .../wicket/extensions/ajax/markup/html/modal/res/modal.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/bcee5140/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js -- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js index bf039a9..13fb6d0 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js @@ -1553,9 +1553,9 @@ for (var j = 0; j this.tabbableTags.length; j++) { var tagElements = doc.getElementsByTagName(this.tabbableTags[j]); for (var k = 0 ; k tagElements.length; k++) { - // if this is not an iframe window and the element is child of window content, + // if this is not an iframe window and the element is child of modal window, // don't disable tab on it - if (win.isIframe() === true || this.isParent(tagElements[k], win.content) === false) { + if (win.isIframe() === true || this.isParent(tagElements[k], win.window) === false) { var element = tagElements[k]; element.hiddenTabIndex = element.tabIndex; element.tabIndex=-1; @@ -1679,4 +1679,4 @@ } }; -})(); \ No newline at end of file +})();
git commit: WICKET-5273 Tabindex overwritten in modal window for IE - Works in FF, Chrome
Updated Branches: refs/heads/wicket-6.x 0b61b074b - 1929f7b1d WICKET-5273 Tabindex overwritten in modal window for IE - Works in FF, Chrome Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/1929f7b1 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/1929f7b1 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/1929f7b1 Branch: refs/heads/wicket-6.x Commit: 1929f7b1db6f6b7d24fb1ec842be22a63506bcd1 Parents: 0b61b07 Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Authored: Wed Jul 24 13:07:57 2013 +0300 Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org Committed: Wed Jul 24 13:07:57 2013 +0300 -- .../wicket/extensions/ajax/markup/html/modal/res/modal.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/1929f7b1/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js -- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js index 9e3e85a..52279d7 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js @@ -1559,9 +1559,9 @@ for (var j = 0; j this.tabbableTags.length; j++) { var tagElements = doc.getElementsByTagName(this.tabbableTags[j]); for (var k = 0 ; k tagElements.length; k++) { - // if this is not an iframe window and the element is child of window content, + // if this is not an iframe window and the element is child of modal window, // don't disable tab on it - if (win.isIframe() === true || this.isParent(tagElements[k], win.content) === false) { + if (win.isIframe() === true || this.isParent(tagElements[k], win.window) === false) { var element = tagElements[k]; element.hiddenTabIndex = element.tabIndex; element.tabIndex=-1; @@ -1685,4 +1685,4 @@ } }; -})(); \ No newline at end of file +})();